[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698235#comment-17698235 ] Angela Schreiber commented on SLING-10110: -- [~SonglessHill], i don't know but since [~joerghoh] stated above: {quote} I will take care of the merge and also trigger a release. {quote} maybe a gentle nudge will do the trick ;-). [~joerghoh], wdty? > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Assignee: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698232#comment-17698232 ] Andreas Bannasch commented on SLING-10110: -- [~angela] Thank you for the clarification. I was wondering why it didn't work with 3.3.0 when i tested it on a local server and then i noticed that my changes weren't part of the release when i downloaded the source-code linked to the 3.3.0 Release. Can you tell me when the next release is planned? > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Assignee: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698229#comment-17698229 ] Angela Schreiber commented on SLING-10110: -- [~SonglessHill], what i meant was: I added you to 'contributors' group and you should be able to assign tickets to yourself not that the ticket is fixed yet. sorry for the confusion. but i quickly checked: your PR https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/26 has been merged. i am resolving this ticket as fixed. feel free to verify again once the release is out. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Assignee: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698209#comment-17698209 ] Andreas Bannasch commented on SLING-10110: -- [~angela] Thank you. I will take a look at the new release and then close the ticket. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Assignee: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646580#comment-17646580 ] Angela Schreiber commented on SLING-10110: -- [~SonglessHill], should be ok now. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Assignee: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646459#comment-17646459 ] Andreas Bannasch commented on SLING-10110: -- [~joerghoh], as [~rombert] mentioned it is not possible for me to assign it to myself at the moment. Could someone please add me to the group? > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646149#comment-17646149 ] Robert Munteanu commented on SLING-10110: - [~joerghoh] - you can't assign this to Andreas as-is, but you can do so once you add him to a special 'contributors' group in Jira. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646144#comment-17646144 ] Joerg Hoh commented on SLING-10110: --- [~SonglessHill] can you please assign this ticket to yourself (if possible)? I will take care of the merge and also trigger a release. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634922#comment-17634922 ] Andreas Bannasch commented on SLING-10110: -- [~rombert] I just created the pull-request. I'll wait for someone to review it and if needed I'll make some adjustments based on feedback. > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > Time Spent: 10m > Remaining Estimate: 0h > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634915#comment-17634915 ] Robert Munteanu commented on SLING-10110: - [~SonglessHill] - sounds good! > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-10110) Sling Dynamic Include: ignoreUrlParams with Wildcards do not work
[ https://issues.apache.org/jira/browse/SLING-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17634899#comment-17634899 ] Andreas Bannasch commented on SLING-10110: -- I tried to add the functionality myself and wrote Unit-Tests to make sure the existing and new logic work properly. [~rombert] Should i push my local branch and create a Pull-Request? > Sling Dynamic Include: ignoreUrlParams with Wildcards do not work > - > > Key: SLING-10110 > URL: https://issues.apache.org/jira/browse/SLING-10110 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.2.0 > Environment: AEM 6.3 - AEM 6.5 >Reporter: Andreas Bannasch >Priority: Major > Fix For: Dynamic Include 3.3.2 > > > Hello > i have the following problem in my AEM instance but i think it might be a > general problem. > The issue i am facing is that in my dispatcher configuration there are > several parameters defined with a * as wildcard. > This is configured for our tracking engine where users might get a link to a > page with one of these parameters. > For example: > {code:html} > https//www.mypage.com/latest-news?testengine-usergroup=10 > {code} > In this case my dispatcher is configured to ignore the paramers that match > the following: > {code:html} > testengine-* > {code} > When i configured this in my SlingDynamicInclude config on the server under > the ignoreUrlParams it does not see the above parameter from the url as > matching for ignoreUrlParams. > > {code:config} > include-filter.config.extension="" > include-filter.config.enabled=B"true" > include-filter.config.path="/content" > include-filter.config.required_header="Server-Agent\=Communique-Dispatcher" > include-filter.config.include-type="SSI" > include-filter.config.selector="nocache" > include-filter.config.add_comment=B"true" > include-filter.config.appendSuffix=B"true" > include-filter.config.rewrite=B"false" > include-filter.config.ttl="" > # These are the urlParams from the dispatcher that are ignored by as such and > will load from cache (for tracking etc.) > # If you do not ignore them then a page with rendered SDI will be cached if > the call contains these parameters > include-filter.config.ignoreUrlParams=[ > "gclid", > "testengine-*" > ] > include-filter.config.resource-types=[ > "mypage/components/slingdynamic/dynamicbanner" > ] > {code} > Instead the SDI component will completely render and since my dispatcher was > configured to ignore this parameter, the response will be cached with an > already rendered SDI-Component instead of the SDI-Tag. > I hope this information is enough to understand what my problem is. > If there are some more informations that you need or if something is not > clear enough please tell me and i will try to update everything that is needed -- This message was sent by Atlassian Jira (v8.20.10#820010)