[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320503#comment-17320503
]
Eric Norman commented on SLING-10186:
-
Below would be my preference to maintain compatibility with the 1.1.16 and
earlier for:
{quote}Could you mark the following options with
[*]must
[?]could
[!]not
{quote}
[*] -D a=1
[*] -D a=1 -D b=2
[!] -D a=1,b=2
[!] -D a=1,b=2 -D c=3
[!] -Da=1
[!] -Da=1 -D b=2
[!] -Da=1,b=2
[!] -Da=1,b=2 -Dc=3
[!] -Da=1 -D c=3
I'm not sure what the use case was to allow a csv of name=value pairs within
the same argument. Was this to facilitate using env vars to supply the
configuration? I saw some mention of using env vars for running
sling-feature-launcher as an container, but I didn't see where those env vars
were being read and used. Specifically, is the FRAMEWORK_PROPERTIES env var
supposed to be a list of properties?
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315449#comment-17315449
]
Stefan Bischof commented on SLING-10186:
Could you mark the following options with
[*]must
[?]could
[!]not
that i know what is expected
-D a=1
-D a=1 -D b=2
-D a=1,b=2
-D a=1,b=2 -D c=3
-Da=1
-Da=1 -D b=2
-Da=1,b=2
-Da=1,b=2 -Dc=3
-Da=1 -D c=3
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315354#comment-17315354
]
Robert Munteanu commented on SLING-10186:
-
We can't change the syntax 'behind the scenes' in a minor release, and only
change it if we have a good reason. We should revert to the old handling.
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314012#comment-17314012
]
Eric Norman commented on SLING-10186:
-
[~bisch...@jena.de] Thanks for working on this.
I would probably lean toward keeping the whitespace between "-D" and
"=" as it was in 1.1.16 to avoid any backward compatibility
troubles.
Or it you want to keep supporting the "-D=" style and make that
the new preferred style then perhaps add some new code to also support the
older "-D =" style and log a deprecation warning for any usage of
that older syntax.
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313966#comment-17313966
]
Stefan Bischof commented on SLING-10186:
Hi,
Im starting to fix this, and the logleves is the easier part.
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/24
because there was no tests on the cli behavier i am not sure what rules i
should follow.
must or could there be an white-space between the option an its values?
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10186) Enhance cli parsing on sling-feature-launcher
[
https://issues.apache.org/jira/browse/SLING-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313403#comment-17313403
]
Eric Norman commented on SLING-10186:
-
These changes seem to contain a regression that now defaults to "debug" log
level instead of "info" which results in a significant amount of additional
debug logging that should only be present when the verbose "-v" flag is
supplied on the command line.
In other words, this command should log at info level instead of debug level.
{code:java}
java -jar target/dependency/org.apache.sling.feature.launcher.jar -f
target/org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far{code}
> Enhance cli parsing on sling-feature-launcher
> -
>
> Key: SLING-10186
> URL: https://issues.apache.org/jira/browse/SLING-10186
> Project: Sling
> Issue Type: Improvement
>Reporter: Stefan Bischof
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Launcher 1.1.18
>
>
> extract opts as Constants
> add longOpt to Options
> fix plural in description
> use Builder-pattern to build Options
> set numberOfArgs , valueSeparator(',')
> accept (but ignore) empty options without ParsingExceptions
> using .optionalArg(true) and Optionals
> option to set loglevel on verbose Option
> update common-cli version
> use DefaultParser not deprecated BasicParser
> https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
