[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386184#comment-17386184 ] Bertrand Delacretaz commented on SLING-10229: - {quote}there is just one build for each release... {quote} For Sling yes but if Docker Hub counts all builds from the [https://github.com/apache/] that might be a lot. I have no idea how many similar builds there are under [https://github.com/apache/] and what the limits are but if we rely on this build someone needs to find out. Alternatively, if a "manual" way of publishing the image to Docker Hub is available and documented that might be fine, as a last resource in case we (the ASF, collectively) hit build resource limitations. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384972#comment-17384972 ] Stefan Bischof commented on SLING-10229: Since there is just one build for each release i do not thing that there will by any problem mit resource limitations. The main limitation is that docker-hub runs on ubuntu 16.04 . See more: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27 > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384900#comment-17384900 ] Bertrand Delacretaz commented on SLING-10229: - IIUC the goal of this is to build the Docker image using the [https://docs.docker.com/docker-hub/builds/advanced/] mechanism, and I suppose this happens on the hub.docker.com infrastructure. If that's correct, do we know if there are limitations in terms of resource usage? There might be limitations on how many build requests hub.docker.com accepts from a single GitHub organization (which https://github.com/apache/ is) in a given time frame. RTFM links to existing documentation are welcome! > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17332987#comment-17332987 ] Robert Munteanu commented on SLING-10229: - [~bisch...@jena.de] - thanks for the PR, I added a few comments. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325059#comment-17325059 ] Stefan Bischof commented on SLING-10229: here is a pr that usex the dockerhub hooks to build and create an image with 3 tags - latest - project-version - commit hash https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27 > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320143#comment-17320143 ] Stefan Bischof commented on SLING-10229: They have the version number fixes in the Dockerfile Line 9: {code:java} RUN ./mvnw clean package && cp target/publish-docker-image-to-docker-hub-1.0-SNAPSHOT.jar publish-docker-image-to-docker-hub-1.0-SNAPSHOT.jar {code} while i handle it using th docherhub builder hooks > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320067#comment-17320067 ] Robert Munteanu commented on SLING-10229: - Hi [~bisch...@jena.de]. Sorry for the delay, I hope to be able to look into this by the end of the week. In the meantime, I have also found an approach to build Java applications on Docker Hub - https://springframework.guru/docker-hub-for-spring-boot/ . Not sure how this compares to your proposal, just wanted to leave it here. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315770#comment-17315770 ] Stefan Bischof commented on SLING-10229: [~rombert] i added an [PR|https://github.com/rombert/sling-org-apache-sling-feature-launcher/pull/1] to your repo. this let be build and push an container via dockerhub automades build using a build-hook and an empty dockerfile. DockerHub overview https://hub.docker.com/repository/docker/stbischof/default DockerHub Log https://hub.docker.com/repository/registry-1.docker.io/stbischof/default/builds/d2028360-026d-4f36-b76f-1ffaff253de9 > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315632#comment-17315632 ] Stefan Bischof commented on SLING-10229: [~rombert] with this hooks we can use bash and docker commands st controle build tagging and push https://docs.docker.com/docker-hub/builds/advanced/#override-build-test-or-push-commands > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315613#comment-17315613 ] Robert Munteanu commented on SLING-10229: - [~bisch...@jena.de] - I think that automated builds from Docker Hub expect us to just build the image locally, and they take care of the tagging. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315609#comment-17315609 ] Stefan Bischof commented on SLING-10229: I have seen your work. Just to have all options together - The docker-maven-plugin we using for building also has an `push` goal https://github.com/fabric8io/docker-maven-plugin#goals > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315430#comment-17315430 ] Robert Munteanu commented on SLING-10229: - Unless this is urgent, I'd prefer to explore building the docker image from the same repo. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10229) [LauncherContainer]Set up automated builds for this Docker image
[ https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312341#comment-17312341 ] Stefan Bischof commented on SLING-10229: The other option would be to create an github repositoy like the one from [sling-org-apache-sling-starter-docker|https://github.com/apache/sling-org-apache-sling-starter-docker] Then we have to manually upgrade the version. If this would be a way to go, please let me know. then i will create it. > [LauncherContainer]Set up automated builds for this Docker image > - > > Key: SLING-10229 > URL: https://issues.apache.org/jira/browse/SLING-10229 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Stefan Bischof >Priority: Minor > > This is an leftover from an other PR: > [~rombert]: in > [PR|https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18] > "I think it would be good to set up automated builds for this Docker image > eventually ( not in scope of this PR ). Looking at > https://stackoverflow.com/questions/36853002/writing-dockerfile-for-dockerhub-automated-builds, > it looks like the Docker build is basically invoking a top-level Dockerfile. > Maybe we should move the 'launch' Dockerfile where the plug-in expects it and > leave the top-level Dockerfile as an entry point for Dockerhub automated > builds?" > --- > I am not sure what you mean with `launch`Dockerfile. And that would mean that > we have 2 files? > The Docker Hub automated build uses a file, that could be specified in > Docker-hub. They use the Tag/Branch as the version tag of the image. But we > are holding the version just inside maven. So I am not sure that this > automated build from the Dockerhub-side is the best way. And we are back at > the point where we have to find a way to copy the launcher-${version].jar > without changing the Dockerfile in every version just because of the > different names. > I would really like to have this official container automated in the docker > hub. > But I do not know how to solve this with your CI-Tooling / Access rights on > DockerHub. > Having an jenkins that builds every commit with the -P container option and > pushes the images would be the easiest way. > regards > Stefan -- This message was sent by Atlassian Jira (v8.3.4#803005)