[jira] [Commented] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492739#comment-17492739 ] Joerg Hoh commented on SLING-10625: --- PR merged > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Assignee: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > Time Spent: 1h > Remaining Estimate: 0h > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490941#comment-17490941 ] Joerg Hoh commented on SLING-10625: --- created https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/21 > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386186#comment-17386186 ] Bertrand Delacretaz commented on SLING-10625: - bq. do you recall why the code wraps all exceptions into RuntimeExceptions.. I don't, but it's probably a way to avoid the hassle of checked exceptions? If you have a backwards compatible suggestion I'm open to that. > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10625) Repoinit Visitors should not throw RuntimeExceptions
[ https://issues.apache.org/jira/browse/SLING-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17383037#comment-17383037 ] Joerg Hoh commented on SLING-10625: --- [~bdelacretaz]: do you recall why the code wraps all exceptions into RuntimeExceptions in [1]? [1] https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/11e17c0991fef2536454470d7f9b91a94917f224/src/main/java/org/apache/sling/jcr/repoinit/impl/DoNothingVisitor.java#L63 > Repoinit Visitors should not throw RuntimeExceptions > > > Key: SLING-10625 > URL: https://issues.apache.org/jira/browse/SLING-10625 > Project: Sling > Issue Type: Improvement > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.36 >Reporter: Joerg Hoh >Priority: Major > Fix For: Repoinit JCR 1.1.38 > > > When a repoinit visitor catches an exception it wraps this exception into a > RuntimeException. In case the original exception is an > InvalidItemStateException, the retry mechanism introduced in SLING-10418 is > not able to retry. > This should be changed, instead of wrapping the Exception the exception > should just be thrown, the special handling of report should not be required > at all. -- This message was sent by Atlassian Jira (v8.3.4#803005)