[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560889#comment-17560889
]
Georg Henzler commented on SLING-11141:
---
Let's move forward, we can deprecate this ScriptedHealthCheck in the next
release and for this release, it will work side by side with the Felix 3.x one.
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17560592#comment-17560592
]
Eric Norman commented on SLING-11141:
-
[~henzlerg] Thanks for your feedback. I had also considered marking the
ScriptedHealthCheck in this bundle as deprecated and just forward all the calls
to the Felix equivalent, but getting the forwarding logic to work was somewhat
complicated. Also, I did see that the ScriptedHealthCheck in this bundle is
not 100% compatible with the felix impl due to the reason I described in my
comment to Oliver above. But since I don't have much insight as to how people
are using this, I decided to take the safe approach and leave this
ScriptedHealthCheck in place but I do not have a firm opinion on that.
Do you see any of your deprecation concerns as blockers for the release of the
1.0.8 version that is already underway? Or can these be addressed in the next
release?
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557146#comment-17557146
]
Eric Norman commented on SLING-11141:
-
[~olli]
{quote}There is a bug in {{{}ScriptedHealthCheck{}}}, language and extension
are mixed up
{quote}
Well, I left it that way to preserve backward compatibility. If you look at
the history of that file, it was always looking up by extension first and then
fallback to the language if no match of the extension. It may break existing
usages in the wild if I changed that to only match by the language name. If
you look closely at the PR diffs, I did not change that line.
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557134#comment-17557134
]
Oliver Lietz commented on SLING-11141:
--
[~enorman], There is a bug in {{ScriptedHealthCheck}}, language and extension
are mixed up:
{noformat}
private ScriptEngine getScriptEngine(String language) {
ScriptEngine scriptEngine =
scriptEngineManager.getEngineByExtension(language);
{noformat}
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556461#comment-17556461
]
Eric Norman commented on SLING-11141:
-
FYI: I've updated PR #1 to remove the dependency on
org.apache.felix.healthcheck.generalchecks and solve the problem in a different
way.
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SLING-11141) Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
[
https://issues.apache.org/jira/browse/SLING-11141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491469#comment-17491469
]
Eric Norman commented on SLING-11141:
-
After updating the dependency to the 3.0.0 version, I discovered that the
org.apache.felix.healthcheck.generalchecks version 3.0.0 no longer exports the
org.apache.felix.hc.generalchecks.util package anymore.
Also, after the changes from [~henzlerg] for SLING-9859 it looks like we now
have an inlined copy of the org.apache.felix.hc.generalchecks.util package in
the o.a..sling.hc.support bundle. But that inlined package isn't exported
anymore either.
So I suppose, we just exclude the package from the Import-Package instruction
since we have a local copy of that package within our bundle? That seems kind
of messy, so if anyone has a better idea then speak up.
> Make compatible with org.apache.felix.healthcheck.generalchecks version 3.x
> ---
>
> Key: SLING-11141
> URL: https://issues.apache.org/jira/browse/SLING-11141
> Project: Sling
> Issue Type: Bug
>Reporter: Eric Norman
>Priority: Major
> Fix For: Health Check Support 1.0.8
>
>
> After updating to the org.apache.felix.healthcheck.generalchecks version
> 3.0.0 release, the org.apache.sling.hc.support bundle fails during the
> feature analyzer with this error:
> {noformat}
> [ERROR] [bundle-packages] org.apache.sling:org.apache.sling.hc.support:1.0.6:
> is importing package(s) org.apache.felix.hc.generalchecks.util in start
> level 20 but no bundle is exporting these for that start level.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
