[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[
https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741515#comment-17741515
]
Stefan Seifert commented on SLING-11843:
bq. The second most issue I saw is related to Checkstyle – I've no clue why
suppressions are ignored during CI build
i had a look at this while looking at
https://github.com/apache/sling-org-apache-sling-testing-paxexam
the problem is the syntax of the project-specific
{{checkstyle-suppressions.xml}} - it seems the checkstyle plugin is using
platform-dependent paths when checking against the "files" regex - that means
checking only for
{noformat}
.*\/TestSupport\.java
{noformat}
for supressions will work on linux, but fail to match any file on windows.
you should switch either to
{noformat}
.*(/|\\)TestSupport\.java
{noformat}
or just to
{noformat}
TestSupport\.java
{noformat}
> Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
> -
>
> Key: SLING-11843
> URL: https://issues.apache.org/jira/browse/SLING-11843
> Project: Sling
> Issue Type: Improvement
> Components: CI
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Attachments: java11-install-build.log,
> sling-org-apache-sling-scripting-groovy-#183.txt
>
>
> Currently our Jenkins jobs by default only run on JDK8 with Linux.
> I would propose to change the default (mentioned in
> https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues)
> to
> * Build with JDK 11 and 17 on
> * Windows and Linux
> Although this might break some builds, I think it is time now to make all
> modules compatible with it once we touch it for whatever reason.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741503#comment-17741503 ] Robert Munteanu commented on SLING-11843: - [~olli] - the Windows nodes should have a functioning Docker installation now - see INFRA-24682 . I am not sure about the other topics > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741491#comment-17741491 ] Oliver Lietz commented on SLING-11843: -- [~rombert], I guess we have to limit builds using Docker ([Testcontainers|https://testcontainers.com/]) to Linux (Docker seems to be not available on our Windows nodes). The second most issue I saw is related to Checkstyle – I've no clue why suppressions are ignored during CI build. Network connection issues seem to be random. I will go through more builds and report found issues here. > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741480#comment-17741480 ] Robert Munteanu commented on SLING-11843: - [~olli] - are the issues that we should report to the ASF infra team or something that we can address from our side? From my side there is no rush to fix things now, just want to understand the root cause > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11843) Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows
[ https://issues.apache.org/jira/browse/SLING-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741353#comment-17741353 ] Oliver Lietz commented on SLING-11843: -- Several build issues happen on Windows only and I will therefore limit builds of some modules to Linux. Example: [^sling-org-apache-sling-scripting-groovy-#183.txt] > Change Default JDK/OS for Jenkins Builds to JDK11/17 on Linux/Windows > - > > Key: SLING-11843 > URL: https://issues.apache.org/jira/browse/SLING-11843 > Project: Sling > Issue Type: Improvement > Components: CI >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Attachments: java11-install-build.log, > sling-org-apache-sling-scripting-groovy-#183.txt > > > Currently our Jenkins jobs by default only run on JDK8 with Linux. > I would propose to change the default (mentioned in > https://cwiki.apache.org/confluence/display/SLING/Sling+module+descriptor#Slingmoduledescriptor-DefaultValues) > to > * Build with JDK 11 and 17 on > * Windows and Linux > Although this might break some builds, I think it is time now to make all > modules compatible with it once we touch it for whatever reason. -- This message was sent by Atlassian Jira (v8.20.10#820010)
