[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722287#comment-17722287 ] Dan Klco commented on SLING-11871: -- Correct [~cziegeler], this would only apply for modification requests. [~kwin] Good question. Reviewing the issue, I think SLING-9061 makes more sense than this change with an addition of a service factory for ReferrerFilter configuration amendments. The reason being conflicts between vendor provided base configurations and end-users need to customize the allowed hosts. Since this configuration is a singleton, it's not possible for an end user to customize this component without overriding the default configuration. Here's another PR with this: https://github.com/apache/sling-org-apache-sling-security/pull/9 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1773#comment-1773 ] Konrad Windszus commented on SLING-11871: - Why not implementing a real validation instead of just skipping as proposed in SLING-9061? > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17722210#comment-17722210 ] Carsten Ziegeler commented on SLING-11871: -- I might be misreading the code in the filter, but doesn't the filter only block if it a modification request? > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-11871) Referrer Filter - Enable Bypass for Requests with Origin Header
[ https://issues.apache.org/jira/browse/SLING-11871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721970#comment-17721970 ] Dan Klco commented on SLING-11871: -- PR: https://github.com/apache/sling-org-apache-sling-security/pull/8 > Referrer Filter - Enable Bypass for Requests with Origin Header > --- > > Key: SLING-11871 > URL: https://issues.apache.org/jira/browse/SLING-11871 > Project: Sling > Issue Type: Improvement > Components: Sling Security >Affects Versions: Security 1.1.24 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: Security 1.1.26 > > > The Referrer Filter in Apache Sling Security blocks requests without a > Referrer or a non-allow listed Referrer. Therefore Referrer filter will also > block external CORS requests which rather than using the Referrer, like > standard browser requests, use the Origin header. > We should therefore enable bypassing the ReferrerFilter for requests > containing an Origin header. These requests would need to be separately > validated by something else to ensure the Origin is valid. -- This message was sent by Atlassian Jira (v8.20.10#820010)