[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations
[ https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797148#comment-17797148 ] Carsten Ziegeler commented on SLING-12181: -- Very often you have a combination of provider type and consumer type implementations in your bundle - in which case you can't use the plugin without any further information. I'm not against implementing this, but I wonder how useful it is in the end. > Evaluate provider type information also directly from annotations > - > > Key: SLING-12181 > URL: https://issues.apache.org/jira/browse/SLING-12181 > Project: Sling > Issue Type: Improvement >Affects Versions: Provider Type Checker Bnd Plugin 1.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Provider Type Checker Bnd Plugin 1.1.0 > > > Currently the check implemented in SLING-12026 only retrieves the provider > type information from the META-INF/api-info.json (being generated by > SLING-12135). > As fallback there should be direct evaluation of the annotations. > The logic needs to be the same as in > https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991, > i.e. the annotation provider type needs to be evaluated both on package as > well as on type level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SLING-12181) Evaluate provider type information also directly from annotations
[ https://issues.apache.org/jira/browse/SLING-12181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797129#comment-17797129 ] Carsten Ziegeler commented on SLING-12181: -- How do you distinguish between allowed implementations of a ProviderType and forbidden ones? > Evaluate provider type information also directly from annotations > - > > Key: SLING-12181 > URL: https://issues.apache.org/jira/browse/SLING-12181 > Project: Sling > Issue Type: Improvement >Affects Versions: Provider Type Checker Bnd Plugin 1.0.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Provider Type Checker Bnd Plugin 1.1.0 > > > Currently the check implemented in SLING-12026 only retrieves the provider > type information from the META-INF/api-info.json (being generated by > SLING-12135). > As fallback there should be direct evaluation of the annotations. > The logic needs to be the same as in > https://github.com/bndtools/bnd/blob/d06df066f402f1433b70c51f568c40a444b4518d/biz.aQute.bndlib/src/aQute/bnd/osgi/Analyzer.java#L1991, > i.e. the annotation provider type needs to be evaluated both on package as > well as on type level. -- This message was sent by Atlassian Jira (v8.20.10#820010)
