[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486691#comment-13486691 ] Ian Boston commented on SLING-2240: --- I guess they should be made available. Thanks for reminding me. move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486722#comment-13486722 ] Carsten Ziegeler commented on SLING-2240: - Yes, the exported version needs to be changed move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston Attachments: SLING-2240.patch DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486725#comment-13486725 ] Felix Meschberger commented on SLING-2240: -- I am weary of this change: * Why is RequestProperty exported ? * Export version must be increased but this will break implementors of extension interfaces Particularly the second issue makes me nervous. I would prefer another solution. move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston Attachments: SLING-2240.patch DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13486732#comment-13486732 ] Carsten Ziegeler commented on SLING-2240: - I haven't looked at the classes so far, having done so I think RequestProperty should not be exported, it really seems more like an internal class. JSONResponse is already exported. So we're back to DateParser - if we increase the package version (which we have to if we add something to the package) then like Felix explained this breaks implementor bundles. If we start with this fact, it means we shouldn't increase the package version which means we shouldn't add DateParser to that package. We have three options then: 1) leave everything as is 2) Create a new public package in the post servlet bundle and move the class there 3) Add the class to another common bundle - whatever this is I don't think we have a good place for 3) atm, so we either go with 2) or 1) move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston Attachments: SLING-2240.patch DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485905#comment-13485905 ] Felix Meschberger commented on SLING-2240: -- [~ianeboston] IIRC the jackrabbit-usermanager embeds that stuff because at that time, the POST servlet was not extensible enough to accommodate the needs of the user manager bundle (the access control bundle has the same issue) move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484747#comment-13484747 ] Carsten Ziegeler commented on SLING-2240: - I think moving it into a public package in the post servlet is the better option move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484758#comment-13484758 ] Ian Boston commented on SLING-2240: --- Hmm, jcr/jackrabbit-usermanager/src/main/java/org/apache/sling/jackrabbit/usermanager/impl/post/AbstractAuthorizablePostServlet.java It inlines org.apache.sling.servlets.post:2.1.0 in the pom.xml It also inlines RequestProperty and JSONResponse Perhaps they should also be made available ? move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter Assignee: Ian Boston DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2240) move org.apache.sling.servlets.post.impl.helper.DateParser to commons
[ https://issues.apache.org/jira/browse/SLING-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484647#comment-13484647 ] Ian Boston commented on SLING-2240: --- The class in itself is relatively free of bindings and does not depend on anything private to the Servlets Post bundle. Being private, nothing depends on it outside the bundle (as you point out) I am not certain where it would go into commons as there is no suitable bundle at present (classloader, json, log, logservice, mime, osgi, scheduler, testing, threads) One lower impact alternative would be to move it to o.a.s.servlets.post which is exported from the Servlets Post Bundle. WDYT? move org.apache.sling.servlets.post.impl.helper.DateParser to commons - Key: SLING-2240 URL: https://issues.apache.org/jira/browse/SLING-2240 Project: Sling Issue Type: Wish Components: Commons Affects Versions: Servlets Post 2.1.0 Reporter: Ben Peter DateParser is a nice utility and comes in handy in a lot of cases. As such, it would be great to have it in a place where it is part of an exported package instead of being locked in in the private org.apache.sling.servlets.post.impl.helper -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
