[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186943#comment-13186943 ] David Gonzalez commented on SLING-2350: --- Our s great, until then I'll go about happily using my snapshot revision. Thanks again. Sent from my iPad On Jan 16, 2012, at 2:15 AM, "Carsten Ziegeler (Resolved) (JIRA)" > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Fix For: Maven JSPC Plugin 2.0.6 > > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185920#comment-13185920 ] David Gonzalez commented on SLING-2350: --- Carsten, The following build (I believe the lastest as jan 13, 2012) of the maven JSPC plugin is working for me! Many, many thanks for all your help and counsel in resolving this. org.apache.sling maven-jspc-plugin 2.0.5-20120113.190459-520 > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184816#comment-13184816 ] Carsten Ziegeler commented on SLING-2350: - For your taglib problem, you have to add the used taglib (and dependencies) to your project, like this: com.day.cq.wcm cq-wcm-api 5.4.0 com.day.cq.wcm cq-wcm-taglib 5.4.2 com.day.cq.wcm cq-wcm-commons 5.4.2 com.day.cq cq-commons 5.4.2 I just used some arbitrary versions, please adjust to your versions. If you have further questions related to Adobe, please contact Adobe. With these changes it seems to work for me. > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184811#comment-13184811 ] Carsten Ziegeler commented on SLING-2350: - I'Ve also fixed the NPE and deployed a new snapshot of the maven plugin with revision 1230439 > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184801#comment-13184801 ] Carsten Ziegeler commented on SLING-2350: - It's ok - this is not a valid url. It's just used for registering the taglib In the meantime I committed a fix to the pom of the plugin in revision 1230434. This solves the slf4j issue, so no need to add those dependencies to your pom anymore. I'll take a look at the NPE next. > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184726#comment-13184726 ] David Gonzalez commented on SLING-2350: --- Carsten, Im making some headway but and not getting errors resolving the uri for: <%@taglib prefix="cq" uri="http://www.day.com/taglibs/cq/1.0"; %> The absolute uri: http://www.day.com/taglibs/cq/1.0 cannot be resolved in either web.xml or the jar files deployed with this application file:/Users/david/Code/github/jspc-test/src/main/scripts/apps/jspc-test/global/global.jsp(1,1) The absolute uri: http://www.day.com/taglibs/cq/1.0 cannot be resolved in either web.xml or the jar files deployed with this application file:/Users/david/Code/github/jspc-test/src/main/scripts/apps/jspc-test/components/templates/page.jsp(1,1) file:/Users/david/Code/github/jspc-test/src/main/scripts/apps/jspc-test/global/global.jsp(1,1) The absolute uri: http://www.day.com/taglibs/cq/1.0 cannot be resolved in either web.xml or the jar files deployed with this application Is this OK? or should i contact adobe about a valid uri? I've set failOnError to false so the jar is being created and installed in sling. i still have to validate that everything is being compiled properly and sling is picking it up but i think were on the right track. Ill make patches for all this after ive validated the builds work. > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184354#comment-13184354 ] David Gonzalez commented on SLING-2350: --- ill take a look at this tonight (EST) -- i was unable to mvn build the jsp scripting bundle locally after syncing from trunk so hopefully I can get that figured out and try commenting out the isOutDated check. Thanks for the counsel - ill keep you posted :) On Wed, Jan 11, 2012 at 11:04 AM, Carsten Ziegeler (Commented) (JIRA) > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184162#comment-13184162 ] Carsten Ziegeler commented on SLING-2350: - The JspCompilationContext is initialized without a jsw some lines above the isOutDated check. I think as a workaround, we could remove the isOutDated check and always compile - makes a rerun slower but shouldn't really hurt > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183862#comment-13183862 ] David Gonzalez commented on SLING-2350: --- I was able to resolve: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory by adding slf4j-api and slf4j-log4j12 as plugin depdencies in my pom.xml org.apache.sling maven-jspc-plugin 2.0.6-SNAPSHOT ... org.slf4j slf4j-api 1.5.2 org.slf4j slf4j-log4j12 1.5.2 I also needed to add a log4j.properties file to the maven-jspc-plugin under /src/main/resources else i received a numbe of warnings about log4j not being properly initialized (I couldnt put them in my proj's /src/main/resources, it had to be in the maven-jspc-plugin project's). I am now running into a NullPointerException: ava.lang.NullPointerException at org.apache.sling.scripting.jsp.jasper.compiler.Compiler.isOutDated(Compiler.java:361) at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:359) at org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:315) at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:227) I've included the entire maven build output here: https://gist.github.com/1592959 It looks like in Compiler.java its throwing the exception because jsw is null: final long lastModifiedTest = jsw.getLastModificationTest(); In JspMojo,processFile the Compiler object is created, however i *think* the only way to set the JspServletWrapper in the Compiler is by calling its: public void init(JspCompilationContext ctxt, JspServletWrapper jsw) And it's not, thus its null. I looked through code and im not sure I understand what would be needed to create a JspServletWrapper obj properly, or if its even needed (is jsw.getLastModificationTest even truly needed?) Any thoughts around this? > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181845#comment-13181845 ] David Gonzalez commented on SLING-2350: --- Hi Carsten, Unfortunately Im still having problems with the slf4j include..it looks like the problem originates in the JspcMojo class. Caused by: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory at org.apache.juli.logging.Slf4jLog.(Slf4jLog.java:29) at org.apache.juli.logging.LogFactory.getLog(LogFactory.java:54) at org.apache.juli.logging.LogFactory.getLog(LogFactory.java:35) at org.apache.sling.scripting.jsp.jasper.compiler.OriginalTldLocationsCache.(OriginalTldLocationsCache.java:81) at org.apache.sling.maven.jspc.JspcMojo.initServletContext(JspcMojo.java:426) I dug into the source and the juli.logging.Slf4jLog class does import org.slf4j.LoggerFactory, thought strangely the pom for it does not list any dependencies. I've tried adding a variety of versions of org.slf4j.api to my pom as dependencies but no luck. Let me know if there is anything else I can help out with. Thanks again for all the help. > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: jspc-test.zip, pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181244#comment-13181244 ] Carsten Ziegeler commented on SLING-2350: - I guess the plugin itself requires slf4j - I've added a dependency to it in revision 1228133 and deployed a new snapshot If this doesn't solve the problem, maybe you could attach a simple test project so I could test myself? Thanks Carsten > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180932#comment-13180932 ] David Gonzalez commented on SLING-2350: --- When building my project I and getting the build error identified below. My project includes dependencies for org.slf4j > slf4j-api and slf4j.simple (1.6.4) Im not sure where to go from here (the maven-jspc-plugin itself builds and installs just fine for me locally). Failed to execute goal org.apache.sling:maven-jspc-plugin:2.0.5-SNAPSHOT:jspc (compile-jsp) on project activecq: Execution compile-jsp of goal org.apache.sling:maven-jspc-plugin:2.0.5-SNAPSHOT:jspc failed: A required class was missing while executing org.apache.sling:maven-jspc-plugin:2.0.5-SNAPSHOT:jspc: org/slf4j/LoggerFactory - realm =plugin>org.apache.sling:maven-jspc-plugin:2.0.5-SNAPSHOT strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy urls[0] = file:/Users/david/.m2/org/apache/sling/maven-jspc-plugin/2.0.5-SNAPSHOT/maven-jspc-plugin-2.0.5-SNAPSHOT.jar urls[1] = file:/Users/david/.m2/org/apache/sling/org.apache.sling.scripting.jsp/2.0.18/org.apache.sling.scripting.jsp-2.0.18.jar urls[2] = file:/Users/david/.m2/org/apache/tomcat/jsp-api/6.0.14/jsp-api-6.0.14.jar urls[3] = file:/Users/david/.m2/org/apache/tomcat/servlet-api/6.0.14/servlet-api-6.0.14.jar urls[4] = file:/Users/david/.m2/org/apache/tomcat/jasper-el/6.0.14/jasper-el-6.0.14.jar urls[5] = file:/Users/david/.m2/org/apache/tomcat/jasper-jdt/6.0.14/jasper-jdt-6.0.14.jar urls[6] = file:/Users/david/.m2/org/apache/tomcat/el-api/6.0.14/el-api-6.0.14.jar urls[7] = file:/Users/david/.m2/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar urls[8] = file:/Users/david/.m2/javax/servlet/jsp/jsp-api/2.1/jsp-api-2.1.jar urls[9] = file:/Users/david/.m2/commons-io/commons-io/1.4/commons-io-1.4.jar urls[10] = file:/Users/david/.m2/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar urls[11] = file:/Users/david/.m2/org/apache/maven/maven-archiver/2.0/maven-archiver-2.0.jar urls[12] = file:/Users/david/.m2/org/codehaus/plexus/plexus-utils/1.0.4/plexus-utils-1.0.4.jar urls[13] = file:/Users/david/.m2/org/codehaus/plexus/plexus-archiver/1.0-alpha-3/plexus-archiver-1.0-alpha-3.jar Number of foreign imports: 1 import: Entry[import from realm ClassRealm[project>com.activecq:activecq:1.0-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]] -: org.slf4j.LoggerFactory -- David Gonzalez Sent with Sparrow (http://www.sparrowmailapp.com/?sig) > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180242#comment-13180242 ] Carsten Ziegeler commented on SLING-2350: - Hi David, I just deployed the snapshot version to the apache snapshots repository. So the version you mention above should now be updated. If that doesn't work you can just check out the code from trunk, invoke mvn install which will deploy the latest snapshot into your local repository and then you can directly use it. Carsten > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179771#comment-13179771 ] David Gonzalez commented on SLING-2350: --- Hi Carsten, thanks! Appreciate your patience - in more of a ruby/git person :) Will this change immediately propagate to the main maven repos? I'm alittle fuzzy on how to force my maven project to use the committed changes. I'm using the default repos exposed on netbeans and archiva servlet under Felix to turn my jcr into a maven repo. Thanks again On Jan 4, 2012, at 12:39 PM, "Carsten Ziegeler (Commented) (JIRA)" > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179671#comment-13179671 ] Carsten Ziegeler commented on SLING-2350: - Many thanks for your patch David. I've committed a slightly modified version in revision 1227233 which updates the plugin to the latest Sling API and Scripting JSP. Could you please test if that works for you? Thanks! > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez >Assignee: Carsten Ziegeler > Labels: maven-bundle-plugin > Attachments: pom.xml, pom.xml.diff > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects
[ https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179340#comment-13179340 ] Carsten Ziegeler commented on SLING-2350: - Thanks David for the issue - could you please create patch against current trunk? > Sling Maven JSPC Plugin depends on legacy Sling API lib which does not > support adaptable SlingHttpServletRequest objects > > > Key: SLING-2350 > URL: https://issues.apache.org/jira/browse/SLING-2350 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Affects Versions: Maven JSPC Plugin 2.0.4 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) > Maven home: /usr/share/maven > Java version: 1.6.0_29, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac" >Reporter: David Gonzalez > Labels: maven-bundle-plugin > Attachments: pom.xml > > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > Buiding Sling-based project using the Maven JSPC Plugin but am getting > compilation errors because SlingHttpServletRequest object doesn't have > .adaptTo(...) defined. > Latest Sling API docs state: > Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface > also extends the Adaptable interface. > Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on "Sling > Scripting 2.0.2-incubator" [2] which in turn depends on "Sling API > 2.0.2-incubator" which is older than 2.0.6 thus no Adaptable support. > [1] > http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml > [2] > http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
