[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[ https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184988#comment-13184988 ] Justin Edelson commented on SLING-2355: --- One more point of clarification... I want to be able to do this without changing the AdapterFactory's source code. For the purposes of this issue, let's say I don't have access to the source code or the ability to change it and I want to be able to provide this metadata separately from the original bundle. > An Adapter annotation should be able to declare that it replaces the service > properties metadata > > > Key: SLING-2355 > URL: https://issues.apache.org/jira/browse/SLING-2355 > Project: Sling > Issue Type: Improvement > Components: Extensions, Maven Plugins and Archetypes >Reporter: Justin Edelson >Assignee: Justin Edelson > > Currently, the Adapters web console plugin merges metadata from the JSON > files with the metadata extracted from the OSGi service properties for > AdapterFactory services. It should be possible for the JSON metadata to > declare that it overrides the metadata from the AdapterFactory service (just > for the purposes of the web console plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[ https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184864#comment-13184864 ] Felix Meschberger commented on SLING-2355: -- Ok, thanks for the clarification. How about doing this as an extension to the existing AdapterFactory annotations (are there any?) Or could these annotations be used to generate the DS service properties for AdapterFactories ? I just want to prevent duplicate definitions which are hard to maintain. > An Adapter annotation should be able to declare that it replaces the service > properties metadata > > > Key: SLING-2355 > URL: https://issues.apache.org/jira/browse/SLING-2355 > Project: Sling > Issue Type: Improvement > Components: Extensions, Maven Plugins and Archetypes >Reporter: Justin Edelson >Assignee: Justin Edelson > > Currently, the Adapters web console plugin merges metadata from the JSON > files with the metadata extracted from the OSGi service properties for > AdapterFactory services. It should be possible for the JSON metadata to > declare that it overrides the metadata from the AdapterFactory service (just > for the purposes of the web console plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[ https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184742#comment-13184742 ] Justin Edelson commented on SLING-2355: --- proposed patch here: http://codereview.appspot.com/5534076 > An Adapter annotation should be able to declare that it replaces the service > properties metadata > > > Key: SLING-2355 > URL: https://issues.apache.org/jira/browse/SLING-2355 > Project: Sling > Issue Type: Improvement > Components: Extensions, Maven Plugins and Archetypes >Reporter: Justin Edelson >Assignee: Justin Edelson > > Currently, the Adapters web console plugin merges metadata from the JSON > files with the metadata extracted from the OSGi service properties for > AdapterFactory services. It should be possible for the JSON metadata to > declare that it overrides the metadata from the AdapterFactory service (just > for the purposes of the web console plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[ https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184743#comment-13184743 ] Justin Edelson commented on SLING-2355: --- Felix - I know it's a rush, but if you have an objection to this, please let me know as soon as possible. I'd like to get this committed and start the release train for the adapter annotations and the plugin so that it doesn't hold up Carsten's releases. Thx. > An Adapter annotation should be able to declare that it replaces the service > properties metadata > > > Key: SLING-2355 > URL: https://issues.apache.org/jira/browse/SLING-2355 > Project: Sling > Issue Type: Improvement > Components: Extensions, Maven Plugins and Archetypes >Reporter: Justin Edelson >Assignee: Justin Edelson > > Currently, the Adapters web console plugin merges metadata from the JSON > files with the metadata extracted from the OSGi service properties for > AdapterFactory services. It should be possible for the JSON metadata to > declare that it overrides the metadata from the AdapterFactory service (just > for the purposes of the web console plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[
https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184193#comment-13184193
]
Justin Edelson commented on SLING-2355:
---
The situation which prompted this is where an AdapterFactory declares 2 adapter
classes and 2 adaptable classes (could be more than 2, but let's keep it
simple), i.e.
adapterClasses = Resource, ResourceResolver
adaptableClasses = MyDomainClass, MyDomainClassManager
This AdapterFactory adapts Resource objects into instances of MyDomainClass and
ResourceResolver objects into instances of MyDomainClassManager. It does not
adapt Resource objects into MyDomainClassManager instances nor does it adapt
ResourceResolver objects into MyDomainClass instances. Attempts to do so simply
return null (which is perfectly legal).
The intent of this issue is to enable the use of the web console metadata to
make the options here explicit:
@Adaptables({
@Adaptable(adaptableClass=ResourceResolver.class,
adapters=@Adapter(MyDomainClassManager.class),
servicePid="com.myco.MyDomainAdapterFactory"),
@Adaptable(adaptableClass=Resource.class,
adapters=@Adapter(value=MyDomainClass.class,
servicePid="com.myco.MyDomainAdapterFactory")
})
> An Adapter annotation should be able to declare that it replaces the service
> properties metadata
>
>
> Key: SLING-2355
> URL: https://issues.apache.org/jira/browse/SLING-2355
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Justin Edelson
>Assignee: Justin Edelson
>
> Currently, the Adapters web console plugin merges metadata from the JSON
> files with the metadata extracted from the OSGi service properties for
> AdapterFactory services. It should be possible for the JSON metadata to
> declare that it overrides the metadata from the AdapterFactory service (just
> for the purposes of the web console plugin).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata
[ https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183912#comment-13183912 ] Felix Meschberger commented on SLING-2355: -- I wonder about the use case here ? An AdpaterFactory service must be fully described by its two service registration properties for it to be used by the AdapterManager. I do not see how the web console metadata would usefully extend this information Maybe I am just missing a point ? > An Adapter annotation should be able to declare that it replaces the service > properties metadata > > > Key: SLING-2355 > URL: https://issues.apache.org/jira/browse/SLING-2355 > Project: Sling > Issue Type: Improvement > Components: Extensions >Reporter: Justin Edelson >Assignee: Justin Edelson > > Currently, the Adapters web console plugin merges metadata from the JSON > files with the metadata extracted from the OSGi service properties for > AdapterFactory services. It should be possible for the JSON metadata to > declare that it overrides the metadata from the AdapterFactory service (just > for the purposes of the web console plugin). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
