[jira] [Commented] (SLING-2631) [Tooling] Slingclipse should only try to sync files

2012-10-30 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486988#comment-13486988
 ] 

Robert Munteanu commented on SLING-2631:


The problem is that non-file resources are sync'ed. I'll attach a patch which 
fixes this for me. I'll supply the rest of the patches ( when done ) on 
SLING-2635 .

> [Tooling] Slingclipse should only try to sync files
> ---
>
> Key: SLING-2631
> URL: https://issues.apache.org/jira/browse/SLING-2631
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Attachments: SLING-2631.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I get lots of such exceptions when I start Eclipse. I disabled sync after 
> every save for now.
> !ENTRY org.eclipse.core.resources 4 2 2012-10-25 23:30:31.945
> !MESSAGE Problems occurred when invoking code from plug-in: 
> "org.eclipse.core.resources".
> !STACK 0
> java.lang.IllegalArgumentException: Invalid uri 
> 'http://localhost:8080metrixx-commons-core/target/classes/META-INF': 
> invalid port number
>   at 
> org.apache.commons.httpclient.HttpMethodBase.(HttpMethodBase.java:222)
>   at 
> org.apache.commons.httpclient.methods.ExpectContinueMethod.(ExpectContinueMethod.java:93)
>   at 
> org.apache.commons.httpclient.methods.EntityEnclosingMethod.(EntityEnclosingMethod.java:119)
>   at 
> org.apache.commons.httpclient.methods.PostMethod.(PostMethod.java:106)
>   at 
> org.apache.sling.slingclipse.http.impl.RepositoryImpl.addNode(RepositoryImpl.java:37)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener$1.visit(SlingclipseListener.java:91)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:69)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:49)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener.resourceChanged(SlingclipseListener.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
>   at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
>   at 
> org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
>   at 
> org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:395)
>   at 
> org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1530)
>   at 
> org.eclipse.core.internal.resources.Resource.refreshLocal(Resource.java:1712)
>   at 
> org.eclipse.core.internal.refresh.RefreshJob.runInWorkspace(RefreshJob.java:167)
>   at 
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>   at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (SLING-2631) [Tooling] Slingclipse should only try to sync files

2012-10-30 Thread Antonio Sanso (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487038#comment-13487038
 ] 

Antonio Sanso commented on SLING-2631:
--

thanks for your patch Robert. It would be nice to handle folder as well though.
It does handle them quite well I think. I know there is an issue with empty 
file and folder though.
Are you sure that the issue above is not isolated to jcr_root folder though? if 
yes this could be handled differentely

> [Tooling] Slingclipse should only try to sync files
> ---
>
> Key: SLING-2631
> URL: https://issues.apache.org/jira/browse/SLING-2631
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Attachments: SLING-2631.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I get lots of such exceptions when I start Eclipse. I disabled sync after 
> every save for now.
> !ENTRY org.eclipse.core.resources 4 2 2012-10-25 23:30:31.945
> !MESSAGE Problems occurred when invoking code from plug-in: 
> "org.eclipse.core.resources".
> !STACK 0
> java.lang.IllegalArgumentException: Invalid uri 
> 'http://localhost:8080metrixx-commons-core/target/classes/META-INF': 
> invalid port number
>   at 
> org.apache.commons.httpclient.HttpMethodBase.(HttpMethodBase.java:222)
>   at 
> org.apache.commons.httpclient.methods.ExpectContinueMethod.(ExpectContinueMethod.java:93)
>   at 
> org.apache.commons.httpclient.methods.EntityEnclosingMethod.(EntityEnclosingMethod.java:119)
>   at 
> org.apache.commons.httpclient.methods.PostMethod.(PostMethod.java:106)
>   at 
> org.apache.sling.slingclipse.http.impl.RepositoryImpl.addNode(RepositoryImpl.java:37)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener$1.visit(SlingclipseListener.java:91)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:69)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:49)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener.resourceChanged(SlingclipseListener.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
>   at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
>   at 
> org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
>   at 
> org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:395)
>   at 
> org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1530)
>   at 
> org.eclipse.core.internal.resources.Resource.refreshLocal(Resource.java:1712)
>   at 
> org.eclipse.core.internal.refresh.RefreshJob.runInWorkspace(RefreshJob.java:167)
>   at 
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>   at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (SLING-2631) [Tooling] Slingclipse should only try to sync files

2012-10-31 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487645#comment-13487645
 ] 

Robert Munteanu commented on SLING-2631:


You're right, I missed that case and I also missed the fact that there are some 
files also missing. I think that the logic for determining whether the resource 
is part of Sling project is incorrect, since I get errors similar to

Failed visiting resource based on delta 
ResourceDelta(/$PROJECT/target/classes/META-INF/MANIFEST.MF)
Failed visiting resource based on delta ResourceDelta(/$PROJECT/pom.xml)

I'll test some more and resubmit the patch.

> [Tooling] Slingclipse should only try to sync files
> ---
>
> Key: SLING-2631
> URL: https://issues.apache.org/jira/browse/SLING-2631
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Attachments: SLING-2631.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> I get lots of such exceptions when I start Eclipse. I disabled sync after 
> every save for now.
> !ENTRY org.eclipse.core.resources 4 2 2012-10-25 23:30:31.945
> !MESSAGE Problems occurred when invoking code from plug-in: 
> "org.eclipse.core.resources".
> !STACK 0
> java.lang.IllegalArgumentException: Invalid uri 
> 'http://localhost:8080metrixx-commons-core/target/classes/META-INF': 
> invalid port number
>   at 
> org.apache.commons.httpclient.HttpMethodBase.(HttpMethodBase.java:222)
>   at 
> org.apache.commons.httpclient.methods.ExpectContinueMethod.(ExpectContinueMethod.java:93)
>   at 
> org.apache.commons.httpclient.methods.EntityEnclosingMethod.(EntityEnclosingMethod.java:119)
>   at 
> org.apache.commons.httpclient.methods.PostMethod.(PostMethod.java:106)
>   at 
> org.apache.sling.slingclipse.http.impl.RepositoryImpl.addNode(RepositoryImpl.java:37)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener$1.visit(SlingclipseListener.java:91)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:69)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:80)
>   at 
> org.eclipse.core.internal.events.ResourceDelta.accept(ResourceDelta.java:49)
>   at 
> org.apache.sling.slingclipse.SlingclipseListener.resourceChanged(SlingclipseListener.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
>   at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
>   at 
> org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
>   at 
> org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
>   at 
> org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:395)
>   at 
> org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:1530)
>   at 
> org.eclipse.core.internal.resources.Resource.refreshLocal(Resource.java:1712)
>   at 
> org.eclipse.core.internal.refresh.RefreshJob.runInWorkspace(RefreshJob.java:167)
>   at 
> org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>   at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira