[jira] [Commented] (SLING-5433) WritePipe should remove a property when value is evaluated as null

2016-01-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101885#comment-15101885
 ] 

Nicolas Peltier commented on SLING-5433:


thx [~rombert], can you (quickly check) SLING-5431, as now i guess pipes tests 
are broken :-/

> WritePipe should remove a property when value is evaluated as null
> --
>
> Key: SLING-5433
> URL: https://issues.apache.org/jira/browse/SLING-5433
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5433.patch
>
>
> it's not documented (will do), but a value evaluated as null in a write pipe 
> conf should remove the property. It doesn't work right now as the target 
> resource used for removal is the wrong one. 
> failing test & fix patch attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5433) WritePipe should remove a property when value is evaluated as null

2016-01-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101807#comment-15101807
 ] 

Nicolas Peltier commented on SLING-5433:


without SLING-5431, this patch will throw a NPE during test

> WritePipe should remove a property when value is evaluated as null
> --
>
> Key: SLING-5433
> URL: https://issues.apache.org/jira/browse/SLING-5433
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
> Attachments: SLING-5433.patch
>
>
> it's not documented (will do), but a value evaluated as null in a write pipe 
> conf should remove the property. It doesn't work right now as the target 
> resource used for removal is the wrong one. 
> failing test & fix patch attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5433) WritePipe should remove a property when value is evaluated as null

2016-01-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101940#comment-15101940
 ] 

Nicolas Peltier commented on SLING-5433:


thx [~rombert]! should have i done differently?

> WritePipe should remove a property when value is evaluated as null
> --
>
> Key: SLING-5433
> URL: https://issues.apache.org/jira/browse/SLING-5433
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5433.patch
>
>
> it's not documented (will do), but a value evaluated as null in a write pipe 
> conf should remove the property. It doesn't work right now as the target 
> resource used for removal is the wrong one. 
> failing test & fix patch attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5433) WritePipe should remove a property when value is evaluated as null

2016-01-15 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101924#comment-15101924
 ] 

Robert Munteanu commented on SLING-5433:


Oops, I thought the tests were already fixed by this patch. Applied patch from 
SLING-5431 just now.

> WritePipe should remove a property when value is evaluated as null
> --
>
> Key: SLING-5433
> URL: https://issues.apache.org/jira/browse/SLING-5433
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5433.patch
>
>
> it's not documented (will do), but a value evaluated as null in a write pipe 
> conf should remove the property. It doesn't work right now as the target 
> resource used for removal is the wrong one. 
> failing test & fix patch attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5433) WritePipe should remove a property when value is evaluated as null

2016-01-15 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101976#comment-15101976
 ] 

Robert Munteanu commented on SLING-5433:


Nothing really, I just misread the comments :-)

> WritePipe should remove a property when value is evaluated as null
> --
>
> Key: SLING-5433
> URL: https://issues.apache.org/jira/browse/SLING-5433
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5433.patch
>
>
> it's not documented (will do), but a value evaluated as null in a write pipe 
> conf should remove the property. It doesn't work right now as the target 
> resource used for removal is the wrong one. 
> failing test & fix patch attached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)