[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[ https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700378#comment-16700378 ] Robert Munteanu commented on SLING-5648: [~kwin] - sorry, I haven't tried this recently. I will try to set up a fresh installation and import. > Make Non-Eclipse Module regular Maven Packages > -- > > Key: SLING-5648 > URL: https://issues.apache.org/jira/browse/SLING-5648 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.10 >Reporter: Andreas Schaefer >Assignee: Konrad Windszus >Priority: Major > Fix For: Sling Eclipse IDE 1.2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be > regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to > support development of it by other IDEs like IntelliJ IDEA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[ https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699242#comment-16699242 ] Konrad Windszus commented on SLING-5648: The problem is most probably a visibility issue: bnd-maven-plugin does not notify the plugin about changes: https://github.com/bndtools/bnd/issues/2746. > Make Non-Eclipse Module regular Maven Packages > -- > > Key: SLING-5648 > URL: https://issues.apache.org/jira/browse/SLING-5648 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.10 >Reporter: Andreas Schaefer >Assignee: Robert Munteanu >Priority: Major > Fix For: Sling Eclipse IDE 1.2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be > regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to > support development of it by other IDEs like IntelliJ IDEA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[ https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699218#comment-16699218 ] Konrad Windszus commented on SLING-5648: For me with Eclipse 2018-09 (4.9.0) the copy mechanism for Manifest and Component descriptors does not work reliably. Very often those folders in the project's root are just plain empty. Could not find any related log entry though. Sometimes it works, other times it doesn't. [~rombert] Did you notice a similar thing? E.g. when freshly importing those projects in Eclipse? > Make Non-Eclipse Module regular Maven Packages > -- > > Key: SLING-5648 > URL: https://issues.apache.org/jira/browse/SLING-5648 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.10 >Reporter: Andreas Schaefer >Assignee: Robert Munteanu >Priority: Major > Fix For: Sling Eclipse IDE 1.2.4 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be > regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to > support development of it by other IDEs like IntelliJ IDEA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[ https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427116#comment-16427116 ] Robert Munteanu commented on SLING-5648: The test execution is due to the extended OSGi metadata added by bnd, (or maybe by the older DS implementation). Rather than work around that, I'd upgrade to the latest Eclipse release (Oxygen) as a baseline for compilation and testing and also to Java 8 ( SLING-7151, SLING-7152 ) > Make Non-Eclipse Module regular Maven Packages > -- > > Key: SLING-5648 > URL: https://issues.apache.org/jira/browse/SLING-5648 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.10 >Reporter: Andreas Schaefer >Assignee: Robert Munteanu >Priority: Major > Fix For: Sling Eclipse IDE 1.2.4 > > > Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be > regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to > support development of it by other IDEs like IntelliJ IDEA. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427054#comment-16427054
]
Robert Munteanu commented on SLING-5648:
The PDE issue can be worked around by configuring the
{{maven-resources-plugin}} to copy the MANIFEST.MF file under
META-INF/MANIFEST.MF, so that PDE considers the project a bundle and uses it
for dependency resolution. A patch for a single project is below
{noformat}diff --git a/shared/modules/api/.gitignore
b/shared/modules/api/.gitignore
new file mode 100644
index ..219f4178
--- /dev/null
+++ b/shared/modules/api/.gitignore
@@ -0,0 +1 @@
+/META-INF/MANIFEST.MF
diff --git a/shared/modules/api/pom.xml b/shared/modules/api/pom.xml
index 2f6a2c1c..05a80f59 100644
--- a/shared/modules/api/pom.xml
+++ b/shared/modules/api/pom.xml
@@ -93,4 +93,44 @@
provided
+
+
+
+m2e
+
+
+
+m2e.version
+
+
+
+
+
+maven-resources-plugin
+
+
+copy-manifest-for-pde
+process-classes
+
+copy-resources
+
+
+META-INF
+
+
+
${project.build.outputDirectory}/META-INF
+
+MANIFEST.MF
+
+
+
+
+
+
+
+
+
+
+
{noformat}
> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
> Issue Type: Improvement
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to
> support development of it by other IDEs like IntelliJ IDEA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426782#comment-16426782
]
Robert Munteanu commented on SLING-5648:
I've started working on this topic at
https://github.com/apache/sling-ide-tooling/tree/feature/intellij . Currently I
have a shared folder which holds the common parts
- maven modules
- tycho build
and an eclipse folder which holds the eclipse-specific plug-ins.
The CLI build works and the built features seems to run succesfully in a new
Eclipse instance. There are 2 major issues to address:
- The tests no longer run with Tycho ; the build errors out with
{{java.lang.RuntimeException: Bundle org.apache.sling.ide.eclipse-test is not
found}}
- Eclipse PDE no longer recognizes the 'shared' modules as OSGi bundles and
therefore does not add them to the plug-in classpath, leading to errors.
> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
> Issue Type: Improvement
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to
> support development of it by other IDEs like IntelliJ IDEA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages
[ https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235095#comment-15235095 ] Robert Munteanu commented on SLING-5648: I'm all for it, given that nothing breaks in the existing Eclipse setup. > Make Non-Eclipse Module regular Maven Packages > -- > > Key: SLING-5648 > URL: https://issues.apache.org/jira/browse/SLING-5648 > Project: Sling > Issue Type: Improvement > Components: IDE >Affects Versions: Sling Eclipse IDE 1.0.10 >Reporter: Andreas Schaefer > Fix For: Sling Eclipse IDE 1.1.2 > > > Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be > regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to > support development of it by other IDEs like IntelliJ IDEA. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
