[jira] [Commented] (SLING-5718) Pipes size parameter is ignored

2016-05-10 Thread Jordan Shurmer (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278618#comment-15278618
 ] 

Jordan Shurmer commented on SLING-5718:
---

Hi [~npeltier]. Thanks for taking a look.

I was wanting to see all the results in the project I was working on, without 
knowing for sure how many would be affected ahead of time. That's why I added 
the <0 check. If you give size=-1 then all the results will be returned.


> Pipes size parameter is ignored
> ---
>
> Key: SLING-5718
> URL: https://issues.apache.org/jira/browse/SLING-5718
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Jordan Shurmer
> Attachments: SLING-5718.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The "size" parameter which can be passed in when executing a Pipe is ignored.
> line 92 of PlumbServlet.Java gets it
> {code}int size = request.getParameter(PARAM_SIZE) != null ? 
> Integer.parseInt(request.getParameter(PARAM_SIZE)) : NB_MAX;{code}
> but it is never used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-5718) Pipes size parameter is ignored

2016-05-10 Thread Nicolas Peltier (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278525#comment-15278525
 ] 

Nicolas Peltier commented on SLING-5718:


Hi [~jshurmer] looks good to me, just maybe the <0 checks seems overkill to me.
(i don't have commit rights by the way, so you'll have to wait for a commiter 
to see this)

> Pipes size parameter is ignored
> ---
>
> Key: SLING-5718
> URL: https://issues.apache.org/jira/browse/SLING-5718
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Jordan Shurmer
> Attachments: SLING-5718.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The "size" parameter which can be passed in when executing a Pipe is ignored.
> line 92 of PlumbServlet.Java gets it
> {code}int size = request.getParameter(PARAM_SIZE) != null ? 
> Integer.parseInt(request.getParameter(PARAM_SIZE)) : NB_MAX;{code}
> but it is never used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)