[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724935#comment-15724935
]
Robert Munteanu commented on SLING-6368:
[~kwin] - a failing test would be a great way to get closer to a fix :-)
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15738219#comment-15738219
]
Konrad Windszus commented on SLING-6368:
I am not really familiar with the vlt code which is used in the Sling IDE to
publish the files. [~rombert] Can you give me a hint on where the according
test should most probably be added in the code and point me to similar tests.
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15739740#comment-15739740
]
Konrad Windszus commented on SLING-6368:
The {{DocViewProperty.parse(...)}} resolves all escaped characters (escape
character is "\"}
(https://github.com/apache/jackrabbit-filevault/blob/trunk/vault-core/src/main/java/org/apache/jackrabbit/vault/util/DocViewProperty.java#L201).
That is not being done correctly in the
{{o.a.s.ide.impl.vlt.serialization.ContentXmlHandler}}. The whole class
ContentXmlHandler should be rewritten to internally rely on {{DocViewProperty}}
instead of implementing the parse method a 2nd time.
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6368-testv01.patch, content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741351#comment-15741351
]
Robert Munteanu commented on SLING-6368:
If the problem starts as early as the XML parsing, then that's the perfect
place to write the unit test for.
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6368-testv02.patch, content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741361#comment-15741361
]
Robert Munteanu commented on SLING-6368:
{quote}Probably it would be good to come up with a patch for FileVault to
decouple parsing from persisting enhanced doc view format.{quote}
Indeed, it would be to better to rely more on FileVault to ensure a more
consistent behaviour. Separate implementation with a lot of tests is the next
best thing :-)
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Attachments: SLING-6368-testv02.patch, content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15807842#comment-15807842
]
Konrad Windszus commented on SLING-6368:
Attached is a patch leveraging DocViewNode and DocViewProperty from FileVault
for the deserialization. That makes the previously failing test succeed.
[~rombert] Could you have a look?
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811179#comment-15811179
]
Robert Munteanu commented on SLING-6368:
Patch looks good to me, thanks!
A couple of questions:
- do you see any significant performance with this change?
- I see some changes in the manifest and build.properties and it seems jar
files are now tracked without version. What's the reason for that?
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811904#comment-15811904
]
Konrad Windszus commented on SLING-6368:
bq. do you see any significant performance with this change?
I have not tested that extensively yet. But I had a closer look at
{{DocViewNode}} and {{DocViewProperty}} and both seem rather lean to me, so I
don't expect any major differences here to the previous version from a
performance point of view.
bq. I see some changes in the manifest and build.properties and it seems jar
files are now tracked without version. What's the reason for that?
This change requires a newer version of FileVault (because older version 3.0.0
did not contain the DocViewProperty) and some of the transitive dependencies of
it (e.g. Jackrabbit API, Guava). I therefore just upgraded to the latest
release of FileVault.
I stripped the version numbers from the filename just to make upgrades in the
future easier to handle (i.e. in the best case with only a change of the
version in the pom.xml). If you are not fine with stripping the version, I can
again revert that change (that way it may be more obvious what the actual
vlt-wrapper bundle contains).
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814366#comment-15814366
]
Robert Munteanu commented on SLING-6368:
{quote}I have not tested that extensively yet. But I had a closer look at
DocViewNode and DocViewProperty and both seem rather lean to me, so I don't
expect any major differences here to the previous version from a performance
point of view.{quote}
That's good enough for me, thanks.
{quote}I stripped the version numbers from the filename just to make upgrades
in the future easier to handle (i.e. in the best case with only a change of the
version in the pom.xml). If you are not fine with stripping the version, I can
again revert that change (that way it may be more obvious what the actual
vlt-wrapper bundle contains).{quote}
I would prefer it that way for the exact reason you mentioned - we know the
versions without the need to look into the pom file.
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-6368) Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR attribute values
[
https://issues.apache.org/jira/browse/SLING-6368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816460#comment-15816460
]
Konrad Windszus commented on SLING-6368:
Fixed in [r1778218|https://svn.apache.org/r1778218] by applying the slightly
modified patch (without stripping the version number from the generated
filenames).
> Eclipse IDE Publishing: Double backslashes are not correctly resolved in JCR
> attribute values
> -
>
> Key: SLING-6368
> URL: https://issues.apache.org/jira/browse/SLING-6368
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.0
>
> Attachments: SLING-6368-testv02.patch, SLING-6368-v01.patch,
> content.xml
>
>
> If a .content.xml file contains a attribute like this
> {code}
> configjson="\{
"title": "Resolved
> Segments",
"icon":
> "coral-Icon--targeted",
"storeMapping":
> {
"s": "segmentation"
> },
"template": " class=\\"contexthub-module-line1\\">Resolved Segments
class=\\"contexthub-module-line2\\">{{s.summary}}
",
> "clickable": true,
"listReference":
> "/store/segmentation/segments",
"listType":
> "custom",
"listItemTemplate":
> "{{label}}",
> "itemOnClickNoop": true
}"
> {code}
> the double "\" is not resolved correclty.
> In the JCR its value is shown as
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved
> Segments{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. it contains double backslashes).
> When being deployed through the content-package-maven-plugin the same
> attribute is being stored in the JCR with value
> {code}
> {
> "title": "Resolved Segments",
>"icon": "coral-Icon--targeted",
> "storeMapping": {
> "s": "segmentation"
> },
> "template": "Resolved Segments class=\"contexthub-module-line2\">{{s.summary}}",
> "clickable": true,
> "listReference": "/store/segmentation/segments",
> "listType": "custom",
> "listItemTemplate": "{{label}}",
> "itemOnClickNoop": true
> }
> {code}
> (i.e. only with single backslashes).
> Attached is the full problematic {{.content.xml}} renamed to {{content.xml}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
