[jira] [Commented] (SLING-6428) DateFormat is printed when date-value is empty

2017-01-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814540#comment-15814540
 ] 

ASF GitHub Bot commented on SLING-6428:
---

Github user vladbailescu closed the pull request at:

https://github.com/apache/sling/pull/197


> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6428) DateFormat is printed when date-value is empty

2017-01-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811994#comment-15811994
 ] 

ASF GitHub Bot commented on SLING-6428:
---

GitHub user vladbailescu opened a pull request:

https://github.com/apache/sling/pull/197

SLING-6428 - DateFormat is printed when date-value is empty

* Updated TCK to include tests for empty/undefined formatting input values
* Updated implementation to return empty when formatting input is 
null/undefined
* Added missing javadocs

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vladbailescu/sling issue/SLING-6428

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #197


commit 8295230ff8472366f07e938ec81fe75f05ab8ca3
Author: vladbailescu 
Date:   2017-01-09T15:07:19Z

SLING-6428 - DateFormat is printed when date-value is empty
* Updated TCK to include tests for empty/undefined formatting input values
* Updated implementation to return empty when formatting input is 
null/undefined
* Added missing javadocs




> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-6428) DateFormat is printed when date-value is empty

2016-12-22 Thread Feike Visser (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15769774#comment-15769774
 ] 

Feike Visser commented on SLING-6428:
-

FYI: [~vladb] [~gwalt]

> DateFormat is printed when date-value is empty
> --
>
> Key: SLING-6428
> URL: https://issues.apache.org/jira/browse/SLING-6428
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Feike Visser
>
> When the format-value emtpy, the date-format is printed.
> Example
> {code}
> 
> ${'-MM-dd' @ format=date1}
> 
> {code}
> In my view the date-format should not be printed, never.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)