[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130401#comment-16130401 ] Robert Munteanu commented on SLING-6519: Ignored test JSON file from rat checks in [r1805283|https://svn.apache.org/r1805283] > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Assignee: Konrad Windszus >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > Attachments: SLING-6519-v01.patch > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932809#comment-15932809 ] Robert Munteanu commented on SLING-6519: [~kwin] - looks good to me, thanks! > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Assignee: Konrad Windszus >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > Attachments: SLING-6519-v01.patch > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927761#comment-15927761 ] Robert Munteanu commented on SLING-6519: GSON would work for me. I think there's also Jackson in there, but I have no strong preference either way. > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927759#comment-15927759 ] Konrad Windszus commented on SLING-6519: What about replacing it with Google GSON (https://github.com/google/gson) then? Its license is Apache 2.0 and it is part of Eclipse Orbit as well (http://download.eclipse.org/tools/orbit/downloads/drops/R20160520211859/). > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927754#comment-15927754 ] Robert Munteanu commented on SLING-6519: We include it in the p2 repo as part of the main repo. Since it's part of Orbit and not of the the p2 update sites from the release train we need to provide it ourselves. > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927752#comment-15927752 ] Konrad Windszus commented on SLING-6519: Since we only consume a dependency being approved by Eclipse and being provided from orbit (not part of our releases) I think this is not a blocker for the 1.2.0 release, right? > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865911#comment-15865911 ] Robert Munteanu commented on SLING-6519: AFAIR there are old releases of the org.json artifact whose license do not contain the 'evil' provision. But I might be wrong > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[ https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865838#comment-15865838 ] Carsten Ziegeler commented on SLING-6519: - Interesting, I'm wondering if this license snippet is correct, the original contains that sentence > Remove dependency to org.json > - > > Key: SLING-6519 > URL: https://issues.apache.org/jira/browse/SLING-6519 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Carsten Ziegeler >Priority: Blocker > Fix For: Sling Eclipse IDE 1.2.0 > > > Some IDE code is using org.json. We have to replace this. This is the list of > files using that code: > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONArray; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONException; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONObject; > ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import > org.json.JSONTokener; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONArray; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONObject; > ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import > org.json.JSONTokener; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONArray; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import > org.json.JSONObject; > ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import > org.json.JSONObject; -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6519) Remove dependency to org.json
[
https://issues.apache.org/jira/browse/SLING-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865570#comment-15865570
]
Robert Munteanu commented on SLING-6519:
I will look into this. Note however that we pick up org.json from Eclipse
Orbit. The latest version of Orbit (
http://download.eclipse.org/tools/orbit/downloads/drops/R20160520211859/ )
contains org.json_1.0.0.v201011060100.jar . Inside the jar,
{{about_files/LICENSE}} I see the following text:
{noformat}JSON.org License
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.{noformat}
This license does not contain 'can not be used for evil' clause, so I don't
think we are technically in the wrong here.
For simplicity though I'll replace this with another JSON parsing bundle from
Orbit.
> Remove dependency to org.json
> -
>
> Key: SLING-6519
> URL: https://issues.apache.org/jira/browse/SLING-6519
> Project: Sling
> Issue Type: Improvement
> Components: IDE
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: Sling Eclipse IDE 1.2.0
>
>
> Some IDE code is using org.json. We have to replace this. This is the list of
> files using that code:
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONArray;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONException;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONObject;
> ./tooling/ide/api/src/org/apache/sling/ide/osgi/impl/HttpOsgiClient.java:import
> org.json.JSONTokener;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONArray;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONObject;
> ./tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/helpers/ExternalSlingLaunchpad.java:import
> org.json.JSONTokener;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
> org.json.JSONArray;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/GetNodeContentCommand.java:import
> org.json.JSONObject;
> ./tooling/ide/impl-resource/src/org/apache/sling/ide/impl/resource/transport/ListChildrenCommand.java:import
> org.json.JSONObject;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
