[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing
[
https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336259#comment-16336259
]
Carsten Ziegeler commented on SLING-7428:
-
[~kwin] No, it might be a timing issue, when everything is ready and the readme
is written later on. But I'm not sure about that
> StartupFilter not reliably stopped (and still returning 503) when executing
> org.apache.sling.scripting.sightly.testing
> --
>
> Key: SLING-7428
> URL: https://issues.apache.org/jira/browse/SLING-7428
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Testing Content 1.0.8-1.3.1
>
>
> For me the IT
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content
> fails every second time stating that client received status code 503. This
> is due to the fact that the condition in
> https://github.com/apache/sling-org-apache-sling-starter-startup/blob/dbe9746f945312a05f99648357ed4c88b01d325a/src/main/java/org/apache/sling/starter/startup/impl/Activator.java#L107
> to stop the StartupFilter (which returns the 503) is never fulfilled.
> There is always the untransformed resource at
> {{/apps/sightly/install/README}}
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/blob/master/src/main/resources/SLING-INF/apps/sightly/install/README).
> We should either remove this resource from the install folder (so that this
> is no longer being picked up by the JCR installer) or we should no longer
> check for untransformed resources (not sure about the implications).
> I am not sure why I am not running into this every time I execute the IT but
> only about half of the time. Seems to be related to some unfortunate timings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing
[
https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335803#comment-16335803
]
Radu Cotescu commented on SLING-7428:
-
ACK: I'll move the README file. :)
> StartupFilter not reliably stopped (and still returning 503) when executing
> org.apache.sling.scripting.sightly.testing
> --
>
> Key: SLING-7428
> URL: https://issues.apache.org/jira/browse/SLING-7428
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> For me the IT
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content
> fails every second time stating that client received status code 503. This
> is due to the fact that the condition in
> https://github.com/apache/sling-org-apache-sling-starter-startup/blob/dbe9746f945312a05f99648357ed4c88b01d325a/src/main/java/org/apache/sling/starter/startup/impl/Activator.java#L107
> to stop the StartupFilter (which returns the 503) is never fulfilled.
> There is always the untransformed resource at
> {{/apps/sightly/install/README}}
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/blob/master/src/main/resources/SLING-INF/apps/sightly/install/README).
> We should either remove this resource from the install folder (so that this
> is no longer being picked up by the JCR installer) or we should no longer
> check for untransformed resources (not sure about the implications).
> I am not sure why I am not running into this every time I execute the IT but
> only about half of the time. Seems to be related to some unfortunate timings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7428) StartupFilter not reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing
[
https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335806#comment-16335806
]
Konrad Windszus commented on SLING-7428:
Any idea why this issue did not occur with every execution?
> StartupFilter not reliably stopped (and still returning 503) when executing
> org.apache.sling.scripting.sightly.testing
> --
>
> Key: SLING-7428
> URL: https://issues.apache.org/jira/browse/SLING-7428
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> For me the IT
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content
> fails every second time stating that client received status code 503. This
> is due to the fact that the condition in
> https://github.com/apache/sling-org-apache-sling-starter-startup/blob/dbe9746f945312a05f99648357ed4c88b01d325a/src/main/java/org/apache/sling/starter/startup/impl/Activator.java#L107
> to stop the StartupFilter (which returns the 503) is never fulfilled.
> There is always the untransformed resource at
> {{/apps/sightly/install/README}}
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/blob/master/src/main/resources/SLING-INF/apps/sightly/install/README).
> We should either remove this resource from the install folder (so that this
> is no longer being picked up by the JCR installer) or we should no longer
> check for untransformed resources (not sure about the implications).
> I am not sure why I am not running into this every time I execute the IT but
> only about half of the time. Seems to be related to some unfortunate timings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7428) StartupFilter nor reliably stopped (and still returning 503) when executing org.apache.sling.scripting.sightly.testing
[
https://issues.apache.org/jira/browse/SLING-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335711#comment-16335711
]
Carsten Ziegeler commented on SLING-7428:
-
I think waiting for untransformed resources makes sense, at least in our setup.
It means that the installer has resources that can't be processed. Clearly, the
README can't.
I don't want to create special cases like excluding the README from the check
or something along those lines. So I guess moving that README to somewhere else
is the better option
> StartupFilter nor reliably stopped (and still returning 503) when executing
> org.apache.sling.scripting.sightly.testing
> --
>
> Key: SLING-7428
> URL: https://issues.apache.org/jira/browse/SLING-7428
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> For me the IT
> https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content
> fails every second time stating that client received status code 503. This
> is due to the fact that the condition in
> https://github.com/apache/sling-org-apache-sling-starter-startup/blob/dbe9746f945312a05f99648357ed4c88b01d325a/src/main/java/org/apache/sling/starter/startup/impl/Activator.java#L107
> to stop the StartupFilter (which returns the 503) is never fulfilled.
> There is always the untransformed resource at
> {{/apps/sightly/install/README}}
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing-content/blob/master/src/main/resources/SLING-INF/apps/sightly/install/README).
> We should either remove this resource from the install folder (so that this
> is no longer being picked up by the JCR installer) or we should no longer
> check for untransformed resources (not sure about the implications).
> I am not sure why I am not running into this every time I execute the IT but
> only about half of the time. Seems to be related to some unfortunate timings.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
