[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17451890#comment-17451890
]
Konrad Windszus commented on SLING-7504:
Adjusted documentation in
https://github.com/apache/sling-site/commit/427a4cb122d0a6838ff0a29ae716db787a9318f4.
> Sling File Installer Provider inactive in Sling Starter and directory not
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.4
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450915#comment-17450915
]
Konrad Windszus commented on SLING-7504:
Adjusted Starter configuration in
https://github.com/apache/sling-org-apache-sling-starter/commit/49ee27afdb25ad6961dc5c9bfcc520095bb5396c.
> Sling File Installer Provider inactive in Sling Starter and directory not
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.4
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447493#comment-17447493
]
Stefan Seifert commented on SLING-7504:
---
thanks!
> Sling File Installer Provider inactive in Sling Starter and directory not
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.4
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447488#comment-17447488
]
Konrad Windszus commented on SLING-7504:
Improved robustness to create directory (and parent directories) only in case
they don't exist yet:
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/6bbc945bb543de07245b78c983214148ef43c212
> Sling File Installer Provider inactive in Sling Starter and directory not
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.2
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter and directory not auto-created
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447444#comment-17447444
]
Stefan Seifert commented on SLING-7504:
---
i've posted a question on the (merged) PR:
https://github.com/apache/sling-org-apache-sling-installer-provider-file/pull/4#discussion_r754298684
> Sling File Installer Provider inactive in Sling Starter and directory not
> auto-created
> --
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347326#comment-17347326
]
Konrad Windszus commented on SLING-7504:
In
https://github.com/apache/sling-org-apache-sling-installer-provider-file/commit/6afa50396eb826df16b75d610ebd07315ced988b
added additional option to create directories to monitor in case they don't
exist yet.
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Starter 12, File Installer 1.3.2
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169826#comment-17169826
]
Carsten Ziegeler commented on SLING-7504:
-
Sorry, but I'm still not understanding the use case fully.
I understand that it makes sense to set sling.fileinstall.dir ootb - we can
just do this. The directory can be created later on by the user.
Now, if we want to be more user friendly and create that directory for the
user, then this can be done in two places: either in launchpad base or in the
fileinstall bundle; but in both cases I think it needs an option telling that
this is the wanted desire.
It this is added to launchpad base, then launchpad base (probably the Loader
class) will inspect that new property together with sling.fileinstall.dir and
create the directory if it doesn't exist
Similar, if this code is added to the fileinstall bundle, the activator will
inspect the new property and create the dirs if they do not exist.
>From that, it seems the fileinstall bundle is the better location as this
>works regardless of which launcher is used and it does not add special logic
>to handle this property where it doesn't belong. But again, it needs an opt-in
>property
If your use case is different and you want to have that directory even before
the user starts the starter jar, then the question is, what is the user using?
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169741#comment-17169741
]
Konrad Windszus commented on SLING-7504:
I am not that familiar with the different Maven plugins involved here. But I
would say in the best case the empty directory is already part of the
starter.jar. Can you pinpoint me to the source code location where you think
this should be added?
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169730#comment-17169730
]
Carsten Ziegeler commented on SLING-7504:
-
I don't think that this belongs in the feature model itself. Not sure if the
feature launcher plugin is a good place for this?
At this point it is unclear to me what the use case is? Someone downloading the
starter jar will not run a maven plugin - on the other end if a maven build is
invoked there are plenty ways of letting maven create the directory
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169318#comment-17169318
]
Konrad Windszus commented on SLING-7504:
Is there any option with the feature model/the maven plugins now for creating a
folder [~cziegeler]?
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 12
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612636#comment-16612636
]
Carsten Ziegeler commented on SLING-7504:
-
I think there is no good place in the maven plugin to do so and I'm not sure
if the provisioning model is the right place to do. The folder can be created
even after startup of the instance, but that's maybe not that user friendly.
We could add a configuration to the file installer bundle which will simply
create the folder if it doesn't exist
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612007#comment-16612007
]
Konrad Windszus commented on SLING-7504:
[~cziegeler] Do you have any good idea how to create the according folder with
the provisioning model/the maven plugin?
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611991#comment-16611991
]
Robert Munteanu commented on SLING-7504:
[~kwin] - do you still plan to do this for Sling 11?
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368874#comment-16368874
]
Konrad Windszus commented on SLING-7504:
That change is easy to do, but the slingstart-maven-plugin will not create the
according folder by default. Any pointer where that is done in the code already
for {{sling/installer}} would be helpful.
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.home}/install}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter
[
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368872#comment-16368872
]
Robert Munteanu commented on SLING-7504:
+1
> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
> Issue Type: Improvement
> Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File
> Installer is not set by default. This should be fixed. The relevant framework
> property is {{sling.fileinstall.dir}}. I propose to set this to
> {{${sling.launchpad}/install}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
