subject:"\[jira\] \[Commented\] \(SLING\-7890\) JSON\-related IT failures when upgrading sling.servlets to 2.1.34"

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-19 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620300#comment-16620300
 ] 

Robert Munteanu commented on SLING-7890:


Confirmed, thanks a lot [~jebailey]!

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.han

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619481#comment-16619481
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] You should be able to update the tests and have it pass now

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.in

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619174#comment-16619174
 ] 

Jason E Bailey commented on SLING-7890:
---

looking into it

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619159#comment-16619159
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - I still get test failures with:

* locally installed latest servlets.get bundle
* switching the starter to user servlets.get 2.1.35-SNAPSHOT
* running launchpad-testing with {{mvn -U clean verify)}

{noformat}[ERROR] Failures: 
[ERROR]   VersionInfoServletTest.testStandardVersionsList:77 Expecting true 
baseVersion expected: but was:
[INFO] 
[ERROR] Tests run: 655, Failures: 1, Errors: 0, Skipped: 1
{noformat}

Are there changes at your end that are not pushed? Also there are still some 
TODOs in the servlets.get bundle added by Bertrand that we should probably 
address.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doP

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618960#comment-16618960
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - I'll release the IT bundle anyway for the Sling 11 release so you 
can skip on that. If for any reason you can't make the release let me know and 
I'll do it.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogSer

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618899#comment-16618899
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] Yes it's ready to be released. I was hoping to do a release of both 
bundles last night but I'm running into some time constraints. I'll be able to 
get to it by tonight if someone else doens't pick up that task.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-18 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618687#comment-16618687
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - so should we be safe to release the new Servlets GET bundle now 
and the bug should be fixed?

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-17 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617816#comment-16617816
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] 2.1.34, as it stands, has a bug and should not be part of Sling 11.

I have made the necessary changes to correct the problem and made the commits 
to the 2.1.36-SNAPSHOT master branch. I have also had to make a change to the  
Launchpad integration tests. Both will need to be released.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.inte

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-17 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16617787#comment-16617787
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - are you still looking into this? It's ok if you're not, but I 
wanted to double-check as we still have a failing IT and getting ready for the 
Sling 11 release.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogS

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Bertrand Delacretaz (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611273#comment-16611273
 ] 

Bertrand Delacretaz commented on SLING-7890:


Ok got it, so I agree with changing the {{VersionInfoServletTest}}

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.b

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610943#comment-16610943
 ] 

Jason E Bailey commented on SLING-7890:
---

[~bdelacretaz] You got the tests right, it's that I had inadvertently fixed the 
boolean to String issue as part of my refactoring work. The current master 
branch is "correct" in the way it handles booleans and the problem was that the 
integration test was failing because it was expecting a String which it 
shouldn't have.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Bertrand Delacretaz (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610869#comment-16610869
 ] 

Bertrand Delacretaz commented on SLING-7890:


I have added some tests for the {{JsonRenderer}} in 
[https://github.com/apache/sling-org-apache-sling-servlets-get/commit/79e861f1e2e19a2dca71fbab55e9c1c01d01c5ee]

{{testBooleansNoTidy}} is as expected for me, b1 and b2 are booleans as 
expected and s1 and s2 are strings.

{{testBooleansWithTidy}} however does not expose the conversion to String that 
[~jebailey] is describing, did I miss something in those tests? I think it's 
good to nail the problem down with tests before fixing it, as it looks like 
it's only the (much further away) integration test that exposed the issue.

But maybe I'm totally confused at this point ;)

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apa

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610724#comment-16610724
 ] 

Robert Munteanu commented on SLING-7890:


Then I guess that the correct behaviour is to have the older one - boolean 
rendered as it is and change the tests rather than the impl. What do you think 
about this [~bdelacretaz]?

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610720#comment-16610720
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] Correct.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.j

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610718#comment-16610718
 ] 

Robert Munteanu commented on SLING-7890:


Nice investigation [~jebailey]! So, IIUC, the "native" boolean rendering was 
there up to 2.1.26, switched to "String" rendering in 2.1.30 and then it was 
changed back with your recent refactorings?

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.ju

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610625#comment-16610625
 ] 

Jason E Bailey commented on SLING-7890:
---

Additional information

The issue that is occurring is happening in two use cases, in the VersionInfo 
servlet and in the Default JSON Renderer when the selector of "tidy" is used. 
In these cases all values are being returned as Strings. This was introduced in 
release 2.1.26 as part of the change to apache johnzon json implementation. The 
class org.apache.sling.servlets.get.impl.util.JsonRenderer was added and the 
method valueToString(Object value)  incorrectly handled numbers and booleans.

Here is a version request prior to 2.1.26
{code:java}
{
    "versions": {
        "jcr:rootVersion": {
            "created": "Mon Sep 10 2018 08:50:23 GMT-0400",
            "successors": ["1.0"],
            "predecessors": [],
            "labels": [],
            "baseVersion": false
        },
        "1.0": {
            "created": "Tue Sep 11 2018 09:26:52 GMT-0400",
            "successors": [],
            "predecessors": ["jcr:rootVersion"],
            "labels": [],
            "baseVersion": true
        }
    }
}{code}
 

The same request via 2.1.30
{code:java}
{
    "versions": {
        "jcr:rootVersion": {
            "created": "Mon Sep 10 2018 08:50:23 GMT-0400",
            "successors": ["1.0"],
            "predecessors": [],
            "labels": [],
            "baseVersion": "false"
        },
        "1.0": {
            "created": "Tue Sep 11 2018 09:26:52 GMT-0400",
            "successors": [],
            "predecessors": ["jcr:rootVersion"],
            "labels": [],
            "baseVersion": "true"
        }
    }
}{code}
Notice that the booleans are being returned as boolean. I suspect the issue 
came about with how JsonObject.getString is being implemented. In the old 
library it would convert a value to String, where as in Johnzon it's expecting 
a JsonString. So when the change was made to Johnzon and the results were 
changed to return a String rather than a boolean, no errors were detected.

 

Here is the same issue in 2.1.30 appearing with the default JSON Renderer: 
http://localhost:8080/content/apache/sling-apache-org/index.json
{code:java}
{
    "jcr:primaryType": "nt:unstructured",
    "jcr:title": "Apache Sling - Bringing Back the Fun!",
    "sling:template": "/conf/global/site/templates/base-page",
    "sling:taxonomy": "/etc/taxonomy/reference/community",
    "sling:resourceType": "reference/components/pages/base",
    "published": true,
    "hideInSitemap": false
}{code}
 

and with tidy: 
http://localhost:8080/content/apache/sling-apache-org/index.tidy.json
{
  "jcr:primaryType": "nt:unstructured",
  "jcr:title": "Apache Sling - Bringing Back the Fun!",
  "sling:template": "/conf/global/site/templates/base-page",
  "sling:taxonomy": "/etc/taxonomy/reference/community",
  "sling:resourceType": "reference/components/pages/base",
  "published": "true",
  "hideInSitemap": "false"
  }
 

I would say that if this hasn't shown up as a bug yet, that it will, because 
the boolean as a String is a fairly recent development.

 

 

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-11 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610242#comment-16610242
 ] 

Robert Munteanu commented on SLING-7890:


{quote}Personally I would prefer that we keep the old, imperfect behavior - 
what do others think?{quote}

I also am a fan of keeping backwards compatibility. At this point we have many 
systems depending on the current behaviour and should avoid and such changes.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.do

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-10 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609975#comment-16609975
 ] 

Jason E Bailey commented on SLING-7890:
---

[~bdelacretaz] So something is odd here. The reason this is being returned as a 
String is that in 2.1.30 all boolean values are being returned as Strings when 
you add the tidy selector to the URL. This is effecting the default json as 
well. I don't think this was always the case. I'm researching.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.in

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-10 Thread Bertrand Delacretaz (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609770#comment-16609770
 ] 

Bertrand Delacretaz commented on SLING-7890:


Ok, got it - sorry that I didn't figure it out earlier.

I think it's similar to the ECMA dates thing then, fixing this means the output 
is not fully backwards compatible anymore.

Personally I would prefer that we keep the old, imperfect behavior - what do 
others think?

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.I

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-10 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609761#comment-16609761
 ] 

Jason E Bailey commented on SLING-7890:
---

[~bdelacretaz] yes there is a difference in the output, "baseVersion" is now 
returning a boolean

{code:java}
"baseVersion": true{code}

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(Te

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-10 Thread Bertrand Delacretaz (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609733#comment-16609733
 ] 

Bertrand Delacretaz commented on SLING-7890:


The commit that you mention is 
https://github.com/apache/sling-org-apache-sling-launchpad-integration-tests/commit/7e70e9f8fa79ae27576ca73a6b48fd5107e19c7a
 , right?

Have there been any changes to the JSON output of the VersionInfoServlet? 

If the JSON output has changed, I think that's where we need to make a decision 
- even if the new output is more right, breaking backwards compatibility is not 
good in general.

Here's an example output from Sling 10, does the current trunk return something 
different?

{code}
{
  "versions": {
"jcr:rootVersion": {
  "created": "Mon Sep 10 2018 21:57:16 GMT+0200",
  "successors": [
"1.0"
  ],
  "predecessors": [],
  "labels": [],
  "baseVersion": "false"
},
"1.0": {
  "created": "Mon Sep 10 2018 21:57:16 GMT+0200",
  "successors": [],
  "predecessors": [
"jcr:rootVersion"
  ],
  "labels": [],
  "baseVersion": "true"
}
  }
}
{code}

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-07 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607251#comment-16607251
 ] 

Jason E Bailey commented on SLING-7890:
---

[~rombert] I've committed changes to both the default servlets and the 
integration tests. The last issue I'd like another opinion on. They current 
problem is that the json response for the VersionHistory was incorrectly 
returning a boolean property of true as "true" the integration test was set up 
to match on the String. It's now correctly responding with the boolean value. 
However this is a break if someone was expecting a String like the integration 
test.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Launchpad Integration Tests 1.0.8, Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMai

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-07 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607120#comment-16607120
 ] 

Jason E Bailey commented on SLING-7890:
---

There's a number of tests failing related to my changes beyond this specific 
error. So I'm running through all of them and fixing what I can. Some of these 
are fails because the test included a very explicit String check that failed. 
e.g. It was looking for "dumped by PlainTextRendererServlet" and I had changed 
the name of the class to PlainTextRenderer because it was no longer a Servlet, 
and I changed the wording as well.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Assignee: Jason E Bailey
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.ha

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-07 Thread Jason E Bailey (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607027#comment-16607027
 ] 

Jason E Bailey commented on SLING-7890:
---

I see the problem. I'll work on the fix and a unit test.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.TestLogServlet$TestNameLoggingFilter.doFilter(TestLogServlet.java:257)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:135)
>   at 
> org.apache.fe

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

2018-09-07 Thread Robert Munteanu (JIRA)



[ 
https://issues.apache.org/jira/browse/SLING-7890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606879#comment-16606879
 ] 

Robert Munteanu commented on SLING-7890:


[~jebailey] - since you did most of the changes between 2.1.30 and 2.1.34 would 
you have time to do a first assessment of the problem? To reproduce, update the 
{{servlets.get}} bundle to the latest version in the starter and run the 
integration tests.

> JSON-related IT failures when upgrading sling.servlets to 2.1.34
> 
>
> Key: SLING-7890
> URL: https://issues.apache.org/jira/browse/SLING-7890
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.34
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Servlets Get 2.1.36
>
>
> With the following change in the sling starter
> {noformat}diff --git a/src/main/provisioning/sling.txt 
> b/src/main/provisioning/sling.txt
> index 0f76c0b..4904fc3 100644
> --- a/src/main/provisioning/sling.txt
> +++ b/src/main/provisioning/sling.txt
> @@ -62,7 +62,7 @@
>  org.apache.sling/org.apache.sling.resourceresolver/1.6.6
>  org.apache.sling/org.apache.sling.serviceusermapper/1.4.0
>  org.apache.sling/org.apache.sling.serviceuser.webconsole/1.0.0
> -org.apache.sling/org.apache.sling.servlets.get/2.1.30
> +org.apache.sling/org.apache.sling.servlets.get/2.1.34
>  org.apache.sling/org.apache.sling.servlets.post/2.3.26
>  org.apache.sling/org.apache.sling.servlets.resolver/2.4.22
>  org.apache.sling/org.apache.sling.xss/2.0.12
> {noformat}
> I get multiple IT failures, and the root cause seems top be
> {noformat}java.lang.ClassCastException: 
> org.apache.johnzon.core.JsonObjectImpl cannot be cast to javax.json.JsonArray
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.valueToString(JsonToText.java:164)
>   at 
> org.apache.sling.servlets.get.impl.util.JsonToText.prettyPrint(JsonToText.java:209)
>   at 
> org.apache.sling.servlets.get.impl.VersionInfoServlet.doGet(VersionInfoServlet.java:124)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:266)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
>   at 
> org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
>   at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
>   at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
>   at 
> org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
>   at 
> org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter.doFilter(RequestProgressTrackerLogFilter.java:107)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.NoPropertyFilter.doFilter(NoPropertyFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47)
>   at 
> org.apache.sling.launchpad.testservices.filters.SlingFilter.doFilter(SlingFilter.java:25)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at org.apache.sling.i18n.impl.I18NFilter.doFilter(I18NFilter.java:131)
>   at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
>   at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.doProcessRequest(SlingRequestProcessorImpl.java:151)
>   at 
> org.apache.sling.engine.impl.SlingMainServlet.service(SlingMainServlet.java:234)
>   at 
> org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:120)
>   at 
> org.apache.felix.http.base.internal.dispatch.InvocationChain.doFilter(InvocationChain.java:86)
>   at 
> org.apache.sling.junit.impl.servlet.T

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

[jira] [Commented] (SLING-7890) JSON-related IT failures when upgrading sling.servlets to 2.1.34

25 matches

Site Navigation

Mail list logo

Footer information