[jira] [Commented] (SLING-8281) Exceptions in the ConfigInstallTasks should lead to log messages with category "WARN"
[
https://issues.apache.org/jira/browse/SLING-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772312#comment-16772312
]
Carsten Ziegeler commented on SLING-8281:
-
I guess there is a reason why its currently debug, and I think this was due to
getting a lot of exceptions in the log which later on where recovered from. I
would assume that IOExceptions thrown by configadmin fall into this category.
Not sure what else there is. Everything else should be regarded as an error,
properly logged in the audit log and the resource needs to be marked so its not
retried again
> Exceptions in the ConfigInstallTasks should lead to log messages with
> category "WARN"
> -
>
> Key: SLING-8281
> URL: https://issues.apache.org/jira/browse/SLING-8281
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently any exception being issued in {{ConfigInstallTask}} only leads to a
> debug level log entry
> (https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/fc2a63c8036843ba0db96686c33c10aeff99b74d/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java#L87).
> Instead those exceptions should be logged with level "WARN". Otherwise it
> will be quite hard to track issues like the one being outlined in SLING-8280.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8281) Exceptions in the ConfigInstallTasks should lead to log messages with category "WARN"
[
https://issues.apache.org/jira/browse/SLING-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772306#comment-16772306
]
Konrad Windszus commented on SLING-8281:
Which exceptions could we expect here which are recoverable? IMHO primarily the
non-recoverable ones should lead to exceptions.
> Exceptions in the ConfigInstallTasks should lead to log messages with
> category "WARN"
> -
>
> Key: SLING-8281
> URL: https://issues.apache.org/jira/browse/SLING-8281
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently any exception being issued in {{ConfigInstallTask}} only leads to a
> debug level log entry
> (https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/fc2a63c8036843ba0db96686c33c10aeff99b74d/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java#L87).
> Instead those exceptions should be logged with level "WARN". Otherwise it
> will be quite hard to track issues like the one being outlined in SLING-8280.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8281) Exceptions in the ConfigInstallTasks should lead to log messages with category "WARN"
[
https://issues.apache.org/jira/browse/SLING-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772294#comment-16772294
]
Carsten Ziegeler commented on SLING-8281:
-
There are recoverable errors and non recoverable ones, for the later ones it
makes sense to log them as error. For the first category debug is fine.
Or in other words, if the error is not logged as debug. the configuration
should not be retried. In this case this should go to the audit logger
> Exceptions in the ConfigInstallTasks should lead to log messages with
> category "WARN"
> -
>
> Key: SLING-8281
> URL: https://issues.apache.org/jira/browse/SLING-8281
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently any exception being issued in {{ConfigInstallTask}} only leads to a
> debug level log entry
> (https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/fc2a63c8036843ba0db96686c33c10aeff99b74d/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java#L87).
> Instead those exceptions should be logged with level "WARN". Otherwise it
> will be quite hard to track issues like the one being outlined in SLING-8280.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SLING-8281) Exceptions in the ConfigInstallTasks should lead to log messages with category "WARN"
[
https://issues.apache.org/jira/browse/SLING-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771859#comment-16771859
]
Konrad Windszus commented on SLING-8281:
[~cziegeler] WDYT about changing
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/fc2a63c8036843ba0db96686c33c10aeff99b74d/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java#L87
to log level warn?
> Exceptions in the ConfigInstallTasks should lead to log messages with
> category "WARN"
> -
>
> Key: SLING-8281
> URL: https://issues.apache.org/jira/browse/SLING-8281
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently any exception being issued in {{ConfigInstallTask}} only leads to a
> debug level log entry
> (https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/blob/fc2a63c8036843ba0db96686c33c10aeff99b74d/src/main/java/org/apache/sling/installer/factories/configuration/impl/ConfigInstallTask.java#L87).
> Instead those exceptions should be logged with level "WARN". Otherwise it
> will be quite hard to track issues like the one being outlined in SLING-8280.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
