[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161216#comment-17161216
 ] 

Robert Munteanu commented on SLING-9211:


That is good to hear.

> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: 
> startup-ServiceUnavailableFilter-2nd-startup-works-fine.log, 
> startup-ServiceUnavailableFilter-first-startup-feature-launcher.log, 
> startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Georg Henzler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161186#comment-17161186
 ] 

Georg Henzler commented on SLING-9211:
--

So I checked with 
{code}
java -jar org.apache.sling.feature.launcher-1.1.4.jar -f 
target/slingfeature-tmp/feature-oak_tar.json
{code}
that produced the log file  
[^startup-ServiceUnavailableFilter-first-startup-feature-launcher.log]. It 
works well and the ServiceUnavailableFilter is correctly activated at start 
level 5 on first start already. 

> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: 
> startup-ServiceUnavailableFilter-2nd-startup-works-fine.log, 
> startup-ServiceUnavailableFilter-first-startup-feature-launcher.log, 
> startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161126#comment-17161126
 ] 

Robert Munteanu commented on SLING-9211:


[~ghenzler] - the current plan is to ship Starter 12 based on the feature 
model. We are done with Phase 1 as defined in 
https://cwiki.apache.org/confluence/display/SLING/Migrating+the+Sling+Starter+to+the+Feature+Model
 and I will start defining tasks for Phase 2 this week.

> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: 
> startup-ServiceUnavailableFilter-2nd-startup-works-fine.log, 
> startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Georg Henzler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161122#comment-17161122
 ] 

Georg Henzler commented on SLING-9211:
--

[~rombert] I think at the moment the feature model variant is marked as 
experimental README.md - but if we swap over soon we obviously don't need to 
fix "the old world" (I think the problem described is more in project 
org.apache.sling.launchpad.installer than in OSGi installer, but also that will 
be deprecated soon I suppose). I'm testing now the experimental feature model 
variant

> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: 
> startup-ServiceUnavailableFilter-2nd-startup-works-fine.log, 
> startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161009#comment-17161009
 ] 

Robert Munteanu commented on SLING-9211:


I see the OSGi installer being mentioned. Perhaps with the migration to the 
feature model ( SLING-8350 ) this is no longer such an important an issue? This 
can be tested with the feature model aggregates generated locally by the 
started with {{mvn clean install}}.

{noformat}
...
[INFO] Installing 
/home/robert/sources/apache/sling/org-apache-sling-starter/target/slingfeature-tmp/feature-oak_tar.json
 to 
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/12-SNAPSHOT/org.apache.sling.starter-12-SNAPSHOT-oak_tar.slingosgifeature
...
{noformat}




> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-20 Thread Georg Henzler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160960#comment-17160960
 ] 

Georg Henzler commented on SLING-9211:
--

See attached [^startup-ServiceUnavailableFilter-too-late-registered.log] on 
what is happening (the result of {{cat sling/logs/error.log | grep -E 
"(ServiceUnavailable|health|Health)"}}). The only difference to the current 
committed version is that I added a bundle with 
org.apache.sling.starter.startup.impl.EventLogger that logs OSGi events 
together with current startlevel. 

[~cziegeler] So I'm pretty sure the expected behaviour is currently broken... 
maybe you can have a look? 

> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
> Attachments: startup-ServiceUnavailableFilter-too-late-registered.log
>
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-19 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160920#comment-17160920
 ] 

Carsten Ziegeler commented on SLING-9211:
-

Looking at the OSGi installer code - it should actually install the 
configurations before the bundles (all tasks are ordered, configuration tasks 
have a higher order than bundles). So we might want to look into why this is 
not working as expected
For the feature model: the feature launcher installs configurations as early as 
possible.


> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9211) Startup detection not working reliable anymore

2020-07-19 Thread Georg Henzler (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160917#comment-17160917
 ] 

Georg Henzler commented on SLING-9211:
--

I analysed the problem and I think the problem only exists on first startup 
(subsequent startups seem fine). The following is happening:

* the OSGi framework quickly "shoots up" to start level 30
* then the OSGi installer installs the bundles following the "conceptual start 
level order" as given by provisioning files but at actual start level 30 (also 
the start level is set to bundle for subsequent startups, but first startup 
installs everything on start level 30)
* only once all bundles are installed the configurations are installed (there 
is a significant delay between installing a bundle and configurations that are 
meant for the bundle). 
* While the configurations for ServiceUnvailableFilter and systemready health 
checks are not available yet (delay from point above), the Sling startup page 
is not shown yet

There are multiple options to fix the problem:
# Extend health check core with a bundle activator that "forces the relevant 
configurations" into the systems
** I have tested this approach (using "felix.health.ServiceUnavailableFilter.*" 
framework properties) and it works, however it feels like a workaround
# Change the launchpad to generally install configurations straight after the 
config admin is available (this seems conceptually the right thing to do for 
me, but there might be reasons for the current state that I'm not aware of)
# Change the launchpad to mark certain configurations as "bootstrap" (or 
similar naming), only those are installed immediately after the config admin 
becomes available

I also see that SLING-9498 introduced the possibility to run it with the 
feature model (maybe there configurations are respected as early as possible 
during startup? I haven't tried yet)

[~cziegeler] WDYT, what option from above would be best?



> Startup detection not working reliable anymore
> --
>
> Key: SLING-9211
> URL: https://issues.apache.org/jira/browse/SLING-9211
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Georg Henzler
>Assignee: Georg Henzler
>Priority: Major
>
> It seems with SLING-8418 the 503 responses are not as reliable as with the 
> previous custom solution. 
> To be checked with script in 
> https://issues.apache.org/jira/browse/FELIX-6097?focusedCommentId=16813130&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16813130



--
This message was sent by Atlassian Jira
(v8.3.4#803005)