[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307694#comment-17307694 ] Bertrand Delacretaz commented on SLING-9449: In principle I agree with Konrad that [commit 55aa500da6|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/55aa500da6805482d6972330e37125eacedaca8f] should be reverted, to be consistent with other repoinit operations throwing exceptions to prevent the repository from starting if something looks wrong in terms of access control and other important setup operations. However reverting it is not backwards compatible and might cause existing repoinit scripts to fail. [~andrei.dulvac] would that be a problem for your use-cases? > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Repoinit JCR 1.1.30 > > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302289#comment-17302289 ] Konrad Windszus commented on SLING-9449: [~andrei.dulvac] Sorry for the late response, but throwing an exception is in line with other ineffective repoinit statements. Also failure to set principal ACLs may lead to undesired side effects. What is the reason why an exception is a problem here, but not for all other illegal repoinit statements (e.g. like setting a resource based ACL on a non-existing path)? > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Repoinit JCR 1.1.30 > > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106383#comment-17106383 ] Andrei Dulvac commented on SLING-9449: -- resolved in https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/55aa500da6805482d6972330e37125eacedaca8f > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
