[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17559197#comment-17559197 ] Stefan Egli commented on SLING-9664: [~rombert], +1, I think downstream effort should be smaller these days for doing such a change now. > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > Fix For: Event 4.3.8 > > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558381#comment-17558381 ] Robert Munteanu commented on SLING-9664: [~stefanegli] - I think embedding the API in the bundle itself was a bit non-standard for how we do things, and lead to suprises down the road. What would you think about releasing a new version of the event bundle (minor version bump) that does not embed the API packages and require both to be deployed from now on? > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > Fix For: Event 4.3.8 > > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558098#comment-17558098 ] Stefan Egli commented on SLING-9664: PS: I'm currently releasing sling.event 4.3.6 and would prefer moving ahead with that, even without fixing this ticket - as I don't think it should block it and we can instead look at fixing it in the consuming (site) part > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558091#comment-17558091 ] Stefan Egli commented on SLING-9664: Right, the reason was SLING-6739 : the original sling.event bundle contained both API and implementation and the split was designed to be as smooth as possible, ie the after-split sling.event bundle would just embed the sling.event.api bundle. But apparently the javadoc got lost in this translation. I'm wondering if there's a way to re-include the javadocs (perhaps via the [bnd.bnd|https://github.com/apache/sling-org-apache-sling-event/blob/master/bnd.bnd] file).. > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555247#comment-17555247 ] Robert Munteanu commented on SLING-9664: I think [~stefanegli] knows what the reason was behind this move. > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555219#comment-17555219 ] Eric Norman commented on SLING-9664: [~joerghoh] I don't know all the history, but it looks to me that the event.api classes are currently embedded inside the o.a.sling.event bundle via the -includeresource instruction of the bnd.bnd file at: [https://github.com/apache/sling-org-apache-sling-event/blob/master/bnd.bnd] Maybe that was done for (upgrade?) convenience, but probably not ideal for modularity. > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555205#comment-17555205 ] Joerg Hoh commented on SLING-9664: -- indeed, it's missing in https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.starter/12/org.apache.sling.starter-12-oak_tar.slingosgifeature. I wonder if this model resolves at all, if the event API bundle is missing. At least the event bundle depends on it. > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555065#comment-17555065 ] Robert Munteanu commented on SLING-9664: [~joerghoh] - if the bundle is not included in the Sling Starter we need to add it manually to the javadoc release script at https://github.com/apache/sling-tooling-release/blob/master/generate_javadoc_for_release.sh ( see also SLING-6766 ) > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555050#comment-17555050 ] Joerg Hoh commented on SLING-9664: -- [~rombert] the event API is in the dedicated repository https://github.com/apache/sling-org-apache-sling-event-api, the split was done in 2017 and it seems that this new javadoc was never added to the site's build. Is there some documentation how the api-docs on the site can be updated/extended? > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Joerg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179689#comment-17179689 ] Stefan Egli commented on SLING-9664: Could be related to https://github.com/apache/sling-org-apache-sling-event/commit/e1b60efc22388d41906f47f6ef37ff2457574e1a > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Jörg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+
[ https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178839#comment-17178839 ] Robert Munteanu commented on SLING-9664: It seems that javadoc generation is broken for the event bundle. It's present for the 4.2.4 release ( https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.event/4.2.4/ ) but not for the 4.2.6 one ( https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.event/4.2.6/ ) . I see that between those changes the event.jobs package has been removed but it's still exported. [~karlpauls], [~stefanegli] - since you made changes for those releases can you help clear up what is going on? Thanks! > org.apache.sling.event.jobs package not present in javadoc for sling10+ > --- > > Key: SLING-9664 > URL: https://issues.apache.org/jira/browse/SLING-9664 > Project: Sling > Issue Type: Improvement > Components: Event >Reporter: Jörg Hoh >Priority: Major > > While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs > package(s), they went missing with the sling10 javadoc [2] and subsequent > versions. > [1] https://sling.apache.org/apidocs/sling9/index.html > [2] https://sling.apache.org/apidocs/sling10/index.html -- This message was sent by Atlassian Jira (v8.3.4#803005)
