[jira] [Resolved] (SLING-4753) Commit the Resource Resolver before passing it to Tenant Customizers for setting up their own customizations
[
https://issues.apache.org/jira/browse/SLING-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret resolved SLING-4753.
---
Resolution: Not A Bug
Fix Version/s: (was: Tenant 1.1.0)
Set status {{Not A Bug}}.
> Commit the Resource Resolver before passing it to Tenant Customizers for
> setting up their own customizations
>
>
> Key: SLING-4753
> URL: https://issues.apache.org/jira/browse/SLING-4753
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Tenant 1.1.0
>Reporter: Agraj Mangal
>Assignee: Timothee Maret
>
> We should commit the Resource Resolver after creating the Tenant Resource and
> before passing it on to the Tenant Customizers.
> One possible issue is that one of the Tenant Customizers calls some APIs like
> PageManager##createPage that does a session.refresh() and rollbacks all the
> un-committed changes on the resolver so far. That could also include the
> tenant resource itself.
> Ideally the TenantCustomizers should not call commit on the resolver and let
> TenantProvider commit the changes, but it would be a good protection against
> all such cases where we could prevent the tenant resource from getting
> modified if the TenantCustomizer failed and tried to refresh the session.
> We are experiencing this issue in
> https://jira.corp.adobe.com/browse/MAC-25410
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4753) Commit the Resource Resolver before passing it to Tenant Customizers for setting up their own customizations
[ https://issues.apache.org/jira/browse/SLING-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Gupta resolved SLING-4753. --- Resolution: Fixed Assignee: Amit Gupta > Commit the Resource Resolver before passing it to Tenant Customizers for > setting up their own customizations > > > Key: SLING-4753 > URL: https://issues.apache.org/jira/browse/SLING-4753 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Tenant 1.1.0 >Reporter: Agraj Mangal >Assignee: Amit Gupta > Fix For: Tenant 1.1.0 > > > We should commit the Resource Resolver after creating the Tenant Resource and > before passing it on to the Tenant Customizers. > One possible issue is that one of the Tenant Customizers calls some APIs like > PageManager##createPage that does a session.refresh() and rollbacks all the > un-committed changes on the resolver so far. That could also include the > tenant resource itself. > Ideally the TenantCustomizers should not call commit on the resolver and let > TenantProvider commit the changes, but it would be a good protection against > all such cases where we could prevent the tenant resource from getting > modified if the TenantCustomizer failed and tried to refresh the session. > We are experiencing this issue in > https://jira.corp.adobe.com/browse/MAC-25410 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
