[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3505: -- Attachment: MapEntry.java.rej Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: MapEntry.java.rej, SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt, SLING-3505-patch3.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3505: -- Attachment: SLING-3505-patch3-je.txt [~asanso] here's an updated version of your patch which fixes the formatting problems and does not remove the test cases. I found the NPE is that it was caused by failing to remove the /jcr:content path segment correctly. Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: MapEntry.java.rej, SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt, SLING-3505-patch3-je.txt, SLING-3505-patch3.txt, SLING-3505-patch3.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3505: - Attachment: SLING-3505-patch3.txt attaching patch that try to address the vanityOrder Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt, SLING-3505-patch3.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3505: - Attachment: (was: SLING-3505-patch3.txt) Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt, SLING-3505-patch3.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3505: - Attachment: SLING-3505-patch3.txt Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt, SLING-3505-patch3.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3505: -- Attachment: SLING-3505-patch2.txt Here's an updated patch which fixes a number of formatting issues and also the change problem with jcr:content mentioned above. Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson updated SLING-3505: -- Attachment: SLING-3505-patch2.txt Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt, SLING-3505-patch2.txt, SLING-3505-patch2.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3505) Improve handling of updates to mapping (alias, vanity path)
[ https://issues.apache.org/jira/browse/SLING-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated SLING-3505: - Attachment: SLING-3505-patch.txt attaching proposed patch. The patch will address all the concerns with the exception of the vanity:order. It does avoid the unnecessary searches for vanitypath and aliases after the updated (it rather does point-to-point update). It would be nice if somebody e.g. [~cziegeler] [~justinedelson] [~fmeschbe] could give a look to the patch. Should the approach look fine I will then finish it up including the vanity:order point to point update Improve handling of updates to mapping (alias, vanity path) --- Key: SLING-3505 URL: https://issues.apache.org/jira/browse/SLING-3505 Project: Sling Issue Type: Improvement Components: ResourceResolver Affects Versions: Resource Resolver 1.1.0 Reporter: Carsten Ziegeler Assignee: Antonio Sanso Attachments: SLING-3505-patch.txt The update handling for the mapping including aliases and vanity path is a simple algorithm which simply updates the whole mapping. Especially with large mapping info spread across the repository, a simple update of a single property results in the whole mapping info to be recreated. It would be great if this could be improved. Right now, only the active mapping is hold in memory - as a change of a single property might cause to activate a totally different mapping than the one which was changed (e.h. when the ordering is changed), the update needs to be more complex or more information needs to be hold in memory. In addition there is more to consider, like if the vanity path info is changed, only the new value is available - but the old is gone. -- This message was sent by Atlassian JIRA (v6.2#6252)
