[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892281#action_12892281 ] Ian Boston commented on SLING-1531: --- Unfortunately the upgrade to JR2.1 this did break Sakai Nakamura, not because of Sling but because of the changes internally to Jackrabbit. In Jackrabbit 2.1 ACLTemplate.Entry is now very private so its not possible to control the construction of an ACL list prior to compilation which makes it impossible to extend the Access control system that comes with Jackrabbit to cover use cases that are not covered (like ACE's that are active based on time or rules). At the moment I only have 2 solutions, fork Jackrabbit or take Sling snapshots before this change into production, neither are particularly attractive. No need to reopen this, just recording an upstream impact. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892287#action_12892287 ] Justin Edelson commented on SLING-1531: --- You have a third option - submit a patch to Jackrabbit. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892289#action_12892289 ] Ian Boston commented on SLING-1531: --- yes, however if the patch was accepted, it wouldn't be available till 2.2 and we have 4 institutions going live in about 6 weeks, code freeze should be in 2 weeks. although I will believe all of that when I see it. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892292#action_12892292 ] Justin Edelson commented on SLING-1531: --- well, it doesn't look like these bundles are going to be released in the next two weeks, so you're going to be using timestamped snapshots of something from Sling either way personally, I prefer timestamped snapshots to forks. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12892295#action_12892295 ] Ian Boston commented on SLING-1531: --- Good, point, I will try and work around the problem and if successful take a late snapshot if not take an early snapshot. (agreed snapshots are much better than forks) Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Launchpad Webapp 6, Launchpad Bundles 6, Launchpad App 6, JCR Webdav 2.0.10, JCR Jackrabbit Server 2.0.8 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
On 7/15/10 2:04 AM, Ian Boston wrote: On 15 Jul 2010, at 03:09, Justin Edelson wrote: I say yes. Ian has asked/suggested that we first do a JR 2 release of the impacted bundles, followed by a JR 2.1 release and then include the JR 2.1 bundles in Sling 6. So the sequence for jackrabbit.server is: 1) release 2.1.0 (JR 2.0.0) 2) release 2.1.2 (JR 2.1.0) 3) release Sling 6 including jackrabbit.server 2.1.2 The WebDAV bundle would be similar. In terms of davex, my inclination is to wait and do a 1.0.0 release of davex with JR 2.1, but I don't feel strongly about this. Ian - have you reconsidered your need for a released JR 2.0.0 server bundle? Yes, Speaking from a Sakai point of view, if the changes required are small then we wont need a release and will just move on. What is small ? the 1.6 to 2.0 upgrade caused us to pause for about 2 weeks while we made the change, we have several customised bundles including major modifications to the AccessManager. So small is 2 days work to upgrade. Do you have any feel for how much change there is between 2.0 and 2.1 ? From a code perspective? Basically none and the changes are isolated to the three bundles which embed Jackrabbit (go OSGi!) and the launchpad bundle list. See: http://codereview.appspot.com/1741051 The only code change is that the class I put in jackrabbit.server to load test content was obviated by JCR-2568. I'd like to pull that class entirely from the jackrabbit.server bundle, but haven't had a chance to test that yet. Justin The other way we can do this is I can capture a snapshot at a working revision of Sling and take that. Since almost every revision of Sling is working that should not be to hard. Ian Justin On Jul 14, 2010, at 8:48 PM, Mike Moulton (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888644#action_12888644 ] Mike Moulton commented on SLING-1531: - Is this scheduled for inclusion in Sling 6? I'm running into JCR-2576 that is fixed by Jackrabbit 2.1.0. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
On 15 Jul 2010, at 13:24, Justin Edelson wrote: On 7/15/10 2:04 AM, Ian Boston wrote: On 15 Jul 2010, at 03:09, Justin Edelson wrote: I say yes. Ian has asked/suggested that we first do a JR 2 release of the impacted bundles, followed by a JR 2.1 release and then include the JR 2.1 bundles in Sling 6. So the sequence for jackrabbit.server is: 1) release 2.1.0 (JR 2.0.0) 2) release 2.1.2 (JR 2.1.0) 3) release Sling 6 including jackrabbit.server 2.1.2 The WebDAV bundle would be similar. In terms of davex, my inclination is to wait and do a 1.0.0 release of davex with JR 2.1, but I don't feel strongly about this. Ian - have you reconsidered your need for a released JR 2.0.0 server bundle? Yes, Speaking from a Sakai point of view, if the changes required are small then we wont need a release and will just move on. What is small ? the 1.6 to 2.0 upgrade caused us to pause for about 2 weeks while we made the change, we have several customised bundles including major modifications to the AccessManager. So small is 2 days work to upgrade. Do you have any feel for how much change there is between 2.0 and 2.1 ? From a code perspective? Basically none and the changes are isolated to the three bundles which embed Jackrabbit (go OSGi!) and the launchpad bundle list. See: http://codereview.appspot.com/1741051 Cool, Looks really clean and simple No need to do a release for Sakai just press on with Sling 6 and Sakai will follow. I cant imagine that anyone else will have a problem with this. Thank you Ian The only code change is that the class I put in jackrabbit.server to load test content was obviated by JCR-2568. I'd like to pull that class entirely from the jackrabbit.server bundle, but haven't had a chance to test that yet. Justin The other way we can do this is I can capture a snapshot at a working revision of Sling and take that. Since almost every revision of Sling is working that should not be to hard. Ian Justin On Jul 14, 2010, at 8:48 PM, Mike Moulton (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888644#action_12888644 ] Mike Moulton commented on SLING-1531: - Is this scheduled for inclusion in Sling 6? I'm running into JCR-2576 that is fixed by Jackrabbit 2.1.0. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1531) Upgrade to Jackrabbit 2.1
[ https://issues.apache.org/jira/browse/SLING-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12888644#action_12888644 ] Mike Moulton commented on SLING-1531: - Is this scheduled for inclusion in Sling 6? I'm running into JCR-2576 that is fixed by Jackrabbit 2.1.0. Upgrade to Jackrabbit 2.1 - Key: SLING-1531 URL: https://issues.apache.org/jira/browse/SLING-1531 Project: Sling Issue Type: Task Components: JCR Reporter: Justin Edelson -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
