Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
Hi Olli, Sorry for getting back so late, but I was on holiday for the last 3 weeks and I really wanted to disconnect from work-related emails. > On 27 Sep 2019, at 19:37, Oliver Lietz wrote: > > On Friday, September 27, 2019 5:21:03 PM CEST Radu Cotescu wrote: >> Hi Olli, > > Hi Radu, > >>> On 27 Sep 2019, at 11:20, Oliver Lietz wrote: >>> >>> Please vote to approve this release: >>> [ ] +1 Approve the release >>> [ ] 0 Don't care >>> [ ] -1 Don't release, because … >> >> I would have loved to spend more time on [0] before cutting a release. It >> feels like the implementation was rushed, > > Why do you think so? Can you explain? > The current implementation is the minimal to start with and was carefully > added. The new feature doesn't change the existing behavior and doesn't > expose > a new public API. > The TODO mentioned by Stefan explains the design. More implementation - > taking > language version and engine into account - is still missing because I'm > investigating on a semantic version parser *and* there is most probably no > demand (I'm not aware of an engine supporting more than one language version > properly). > > As you might have noticed I improved the scripting documentation and I'm > still > in the process to consolidate the additional documentation from our wiki into > our site. Once done I will document the new feature coming with SLING-4330. > > Regards, > O. > >> Thanks, >> Radu >> >> [0] - https://issues.apache.org/jira/browse/SLING-4330 >> [1] - https://sling.apache.org/documentation/bundles/scripting.html > I was not against the release and the reason for my previous statement is that you mentioned on the JIRA issue [0] that we would talk on the dev list about the requirements of such an addition. However, I didn’t see any thread about it. Your code works as it should and is properly tested, so there’s absolutely nothing wrong with it. I guess I just wanted more eyes on the solution and a more open discussion. Regards, Radu
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
On Friday, September 27, 2019 11:20:23 AM CEST Oliver Lietz wrote: > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2135 +1 O.
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
On Friday, September 27, 2019 5:21:03 PM CEST Radu Cotescu wrote: > Hi Olli, Hi Radu, > > On 27 Sep 2019, at 11:20, Oliver Lietz wrote: > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because … > > I would have loved to spend more time on [0] before cutting a release. It > feels like the implementation was rushed, Why do you think so? Can you explain? > although the issue was open for > four years. There’s also no extra documentation added at [1] about how [0] > can be used by developers. > > Unfortunately I’m away for the next 3 weeks - do you think [0] could wait > until then? The current implementation is the minimal to start with and was carefully added. The new feature doesn't change the existing behavior and doesn't expose a new public API. The TODO mentioned by Stefan explains the design. More implementation - taking language version and engine into account - is still missing because I'm investigating on a semantic version parser *and* there is most probably no demand (I'm not aware of an engine supporting more than one language version properly). As you might have noticed I improved the scripting documentation and I'm still in the process to consolidate the additional documentation from our wiki into our site. Once done I will document the new feature coming with SLING-4330. Regards, O. > Thanks, > Radu > > [0] - https://issues.apache.org/jira/browse/SLING-4330 > [1] - https://sling.apache.org/documentation/bundles/scripting.html
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
Hi Olli, > On 27 Sep 2019, at 11:20, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because … > I would have loved to spend more time on [0] before cutting a release. It feels like the implementation was rushed, although the issue was open for four years. There’s also no extra documentation added at [1] about how [0] can be used by developers. Unfortunately I’m away for the next 3 weeks - do you think [0] could wait until then? Thanks, Radu [0] - https://issues.apache.org/jira/browse/SLING-4330 [1] - https://sling.apache.org/documentation/bundles/scripting.html
RE: [VOTE] Release Apache Sling Scripting Core 2.0.60
+1 - others more deeper into the sling script core (than myself) should have a look at it as well. stefan p.s. there is an open TODO in the code - is it still relevant? https://github.com/apache/sling-org-apache-sling-scripting-core/blob/master/src/main/java/org/apache/sling/scripting/core/impl/SlingScriptEnginePicker.java#L95 >-Original Message- >From: Oliver Lietz [mailto:apa...@oliverlietz.de] >Sent: Friday, September 27, 2019 11:20 AM >To: dev@sling.apache.org >Subject: [VOTE] Release Apache Sling Scripting Core 2.0.60 > >Hi, > >We solved 4 issues in this release: >https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 > >Staging repository: >https://repository.apache.org/content/repositories/orgapachesling-2135 > >You can use this UNIX script to download the release and verify the >signatures: >https://gitbox.apache.org/repos/asf?p=sling-tooling- >release.git;a=blob;f=check_staged_release.sh;hb=HEAD > >Usage: >sh check_staged_release.sh 2135 /tmp/sling-staging > >Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > >This majority vote is open for at least 72 hours. > >Regards, >O. > > >
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
+1 On Fri, Sep 27, 2019 at 5:20 AM Oliver Lietz wrote: > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2135 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2135 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > >
