RE: Jenkins test failure
Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
Re: Jenkins test failure
Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
RE: Jenkins test failure
Thanks, Justin. Was svn.apache.org really slow for you, or is it just my connection? Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:48 To: dev@sling.apache.org Subject: Re: Jenkins test failure Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
Re: Jenkins test failure
I didn't notice any particular slowness, but I'm multitasking :) On Mon, Dec 12, 2011 at 8:50 AM, Jeff Young j...@adobe.com wrote: Thanks, Justin. Was svn.apache.org really slow for you, or is it just my connection? Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:48 To: dev@sling.apache.org Subject: Re: Jenkins test failure Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
RE: Jenkins test failure
Hi Justin, In revision 1213304, I only see the change to ResourceTraversor.java. I think you might have applied the wrong patch (there was an earlier diff with just that file, and a later patch with that file and 4 or 5 test files and a POM or two). Or is there a further revision coming? Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 16:51 To: dev@sling.apache.org Subject: RE: Jenkins test failure Thanks, Justin. Was svn.apache.org really slow for you, or is it just my connection? Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:48 To: dev@sling.apache.org Subject: Re: Jenkins test failure Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
Re: Jenkins test failure
Yep. I did the tests in the next revision. Justin On Mon, Dec 12, 2011 at 8:55 AM, Jeff Young j...@adobe.com wrote: Hi Justin, In revision 1213304, I only see the change to ResourceTraversor.java. I think you might have applied the wrong patch (there was an earlier diff with just that file, and a later patch with that file and 4 or 5 test files and a POM or two). Or is there a further revision coming? Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 16:51 To: dev@sling.apache.org Subject: RE: Jenkins test failure Thanks, Justin. Was svn.apache.org really slow for you, or is it just my connection? Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:48 To: dev@sling.apache.org Subject: Re: Jenkins test failure Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
RE: Jenkins test failure
Yep, got it now. (I think I'm going to have to reboot. Something's decidedly fishy about my connection) Thanks, Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:57 To: dev@sling.apache.org Subject: Re: Jenkins test failure Yep. I did the tests in the next revision. Justin On Mon, Dec 12, 2011 at 8:55 AM, Jeff Young j...@adobe.com wrote: Hi Justin, In revision 1213304, I only see the change to ResourceTraversor.java. I think you might have applied the wrong patch (there was an earlier diff with just that file, and a later patch with that file and 4 or 5 test files and a POM or two). Or is there a further revision coming? Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 16:51 To: dev@sling.apache.org Subject: RE: Jenkins test failure Thanks, Justin. Was svn.apache.org really slow for you, or is it just my connection? Jeff. -Original Message- From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of Justin Edelson Sent: 12 December 2011 16:48 To: dev@sling.apache.org Subject: Re: Jenkins test failure Patch applied. On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young j...@adobe.com wrote: Well, the server is still pretty glacial for me (when it responds at all), but I've gotten enough out of it that I believe the test failure is a result of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch servlet_tests.patch (see comment 07/Dec/11 11:48). https://issues.apache.org/jira/browse/SLING-2320 Could I get a committer to apply that patch? (Carsten has looked over it.) I've also got a further patch developed to fix some of the other issues discovered: a) throwing two exceptions per node traversed b) serializing/de-serializing/re-serializing the JSON data but it'll be easier for me to post a clean patch if HEAD is updated first (otherwise I'm likely to get a diff including some of my changes twice). (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would just as soon not have my brain explode today.) Thanks, Jeff. -Original Message- From: Jeff Young [mailto:j...@adobe.com] Sent: 12 December 2011 10:50 To: dev@sling.apache.org Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 I was trying to look into the 4th test failure (the JsonRenderingTest), but I can't get to svn.apache.org. Is it down, or is it just my machine? Thanks, Jeff. -Original Message- From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] Sent: 12 December 2011 10:22 To: dev@sling.apache.org Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478 See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1478/
