RE: Sling Pipes Test Failing

[Shurmer, Jordan]

Great, thanks!

-Original Message-
From: Oliver Lietz [mailto:apa...@oliverlietz.de] 
Sent: Monday, May 09, 2016 6:28 AM
To: dev@sling.apache.org
Subject: Re: Sling Pipes Test Failing

On Monday 09 May 2016 09:09:49 Nicolas Peltier wrote:
> Hi Jordan,
> 
> yes, i guess that if the issue happens for at least two users, that 
> starts to smell like a bug and deserves a JIRA ticket. However pls 
> consider in your patch this does *not* happen for at least me and 
> Oliver :-) (the github issue was closed as the project got just merged 
> into sling community AND i couldn’t reproduce the issue).

It was a bug in the test, should be fixed by

https://github.com/apache/sling/commit/cafc10b946452ba3d67b5e311f6ea260aa44c2bf#diff-fcd011ee1e6dd8c84e60be39b836877d
 

Jordan, please report if test succeeds for you now also.

Regards,
O.

> Nicolas
[...]

Re: Sling Pipes Test Failing

[Oliver Lietz]

On Monday 09 May 2016 09:09:49 Nicolas Peltier wrote:
> Hi Jordan,
> 
> yes, i guess that if the issue happens for at least two users, that starts
> to smell like a bug and deserves a JIRA ticket. However pls consider in
> your patch this does *not* happen for at least me and Oliver :-) (the
> github issue was closed as the project got just merged into sling community
> AND i couldn’t reproduce the issue).

It was a bug in the test, should be fixed by

https://github.com/apache/sling/commit/cafc10b946452ba3d67b5e311f6ea260aa44c2bf#diff-fcd011ee1e6dd8c84e60be39b836877d
 

Jordan, please report if test succeeds for you now also.

Regards,
O.

> Nicolas
[...]

Re: Sling Pipes Test Failing

[Nicolas Peltier]

Hi Jordan,

yes, i guess that if the issue happens for at least two users, that starts to 
smell like a bug and deserves a JIRA ticket. However pls consider in your patch 
this does *not* happen for at least me and Oliver :-) (the github issue was 
closed as the project got just merged into sling community AND i couldn’t 
reproduce the issue).

Nicolas
> On 08 May 2016, at 10:11, Oliver Lietz  wrote:
> 
> On Saturday 07 May 2016 17:41:47 Shurmer, Jordan wrote:
>> Hello,
> 
> Hi Jordan,
> 
>> I've been using Sling Pipes for a few projects recently. In order to get the
>> code I checked out the apache sling svn repo [1] and went to build
>> contrib/extensions/sling-pipes. However, there was a failing unit test.
>> 
>> PipeBindingsTest#testInstantiateObject ends up creating a Date object with
>> the expression "${new Date(2012,04,12)}", and then asserting that the
>> day-of-month is 11 rather than 12.
>> 
>> This is the same issue that someone else had in the original github repo
>> [2].  The issue was closed, but the pull request was never merged.
>> 
>> I'm wondering if anyone else is encountering this problem. If not, what am I
>> doing wrong? If everyone is, I can gladly create my first Apache Jira
>> ticket and submit my first patch!
> 
> not a problem here (CEST). The test fails for some because timezone is not 
> considered propably.
> 
> Regards,
> O.
> 
>> [1]: http://svn.apache.org/repos/asf/sling/trunk
>> [2]: https://github.com/npeltier/sling-pipes/pull/12
>> 
>> Thanks,
>> Jordan Shurmer
> 

Re: Sling Pipes Test Failing

[Oliver Lietz]

On Saturday 07 May 2016 17:41:47 Shurmer, Jordan wrote:
> Hello,

Hi Jordan,

> I've been using Sling Pipes for a few projects recently. In order to get the
> code I checked out the apache sling svn repo [1] and went to build
> contrib/extensions/sling-pipes. However, there was a failing unit test.
> 
> PipeBindingsTest#testInstantiateObject ends up creating a Date object with
> the expression "${new Date(2012,04,12)}", and then asserting that the
> day-of-month is 11 rather than 12.
> 
> This is the same issue that someone else had in the original github repo
> [2].  The issue was closed, but the pull request was never merged.
> 
> I'm wondering if anyone else is encountering this problem. If not, what am I
> doing wrong? If everyone is, I can gladly create my first Apache Jira
> ticket and submit my first patch!

not a problem here (CEST). The test fails for some because timezone is not 
considered propably.

Regards,
O.

> [1]: http://svn.apache.org/repos/asf/sling/trunk
> [2]: https://github.com/npeltier/sling-pipes/pull/12
> 
> Thanks,
> Jordan Shurmer