Re: svn commit: r1062229 - /sling/trunk/launchpad/builder/src/main/bundles/list.xml

2011-01-25 Thread Felix Meschberger
Hi,

Am Samstag, den 22.01.2011, 19:13 + schrieb Justin Edelson: 
 I'm still uncertain that this is appropriate to include in the Sling 6
 release, but it has to stay in launchpad/builder/src/main/bundles/list.xml
 for the time being because there are integration tests which depend upon it.
 
 I guess the existence of integration tests is a good sign that this bundle
 should in fact be included in the release...

Maybe yes. Or the test exists there because it is convenient to add ;-)

But at the end of the day, I would welcome its inclusion in the release.

Regards
Felix

 
 Justin
 
 On Sat, Jan 22, 2011 at 1:56 PM, jus...@apache.org wrote:
 
  Author: justin
  Date: Sat Jan 22 18:56:37 2011
  New Revision: 1062229
 
  URL: http://svn.apache.org/viewvc?rev=1062229view=rev
  Log:
  restoring groovy extension to launchpad bundle list to fix failing tests
 
  Modified:
 sling/trunk/launchpad/builder/src/main/bundles/list.xml
 
  Modified: sling/trunk/launchpad/builder/src/main/bundles/list.xml
  URL:
  http://svn.apache.org/viewvc/sling/trunk/launchpad/builder/src/main/bundles/list.xml?rev=1062229r1=1062228r2=1062229view=diff
 
  ==
  --- sling/trunk/launchpad/builder/src/main/bundles/list.xml (original)
  +++ sling/trunk/launchpad/builder/src/main/bundles/list.xml Sat Jan 22
  18:56:37 2011
  @@ -258,6 +258,11 @@
  /bundle
  bundle
  groupIdorg.apache.sling/groupId
  +artifactIdorg.apache.sling.extensions.groovy/artifactId
  +version1.0.0-SNAPSHOT/version
  +/bundle
  +bundle
  +groupIdorg.apache.sling/groupId
  artifactIdorg.apache.sling.extensions.explorer/artifactId
  version1.0.0/version
  /bundle
 
 
 




Re: svn commit: r1062229 - /sling/trunk/launchpad/builder/src/main/bundles/list.xml

2011-01-22 Thread Justin Edelson
I'm still uncertain that this is appropriate to include in the Sling 6
release, but it has to stay in launchpad/builder/src/main/bundles/list.xml
for the time being because there are integration tests which depend upon it.

I guess the existence of integration tests is a good sign that this bundle
should in fact be included in the release...

Justin

On Sat, Jan 22, 2011 at 1:56 PM, jus...@apache.org wrote:

 Author: justin
 Date: Sat Jan 22 18:56:37 2011
 New Revision: 1062229

 URL: http://svn.apache.org/viewvc?rev=1062229view=rev
 Log:
 restoring groovy extension to launchpad bundle list to fix failing tests

 Modified:
sling/trunk/launchpad/builder/src/main/bundles/list.xml

 Modified: sling/trunk/launchpad/builder/src/main/bundles/list.xml
 URL:
 http://svn.apache.org/viewvc/sling/trunk/launchpad/builder/src/main/bundles/list.xml?rev=1062229r1=1062228r2=1062229view=diff

 ==
 --- sling/trunk/launchpad/builder/src/main/bundles/list.xml (original)
 +++ sling/trunk/launchpad/builder/src/main/bundles/list.xml Sat Jan 22
 18:56:37 2011
 @@ -258,6 +258,11 @@
 /bundle
 bundle
 groupIdorg.apache.sling/groupId
 +artifactIdorg.apache.sling.extensions.groovy/artifactId
 +version1.0.0-SNAPSHOT/version
 +/bundle
 +bundle
 +groupIdorg.apache.sling/groupId
 artifactIdorg.apache.sling.extensions.explorer/artifactId
 version1.0.0/version
 /bundle