[jira] [Updated] (SLING-7117) add jsonpath expression for jsonpipe

2017-09-09 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7117:
---
Fix Version/s: pipes 1.1.0

> add jsonpath expression for jsonpipe
> 
>
> Key: SLING-7117
> URL: https://issues.apache.org/jira/browse/SLING-7117
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
> Fix For: pipes 1.1.0
>
>
> it's not always that on the internet json streams are arrays of objects that 
> interest us. More often you find the array you want to use somewhere within 
> the json. 
> To adapt to this, JsonPipe configuration should mention where to fetch the 
> array it will use for generating its output.
> using JsonPath (http://goessner.net/articles/JsonPath/) seems good enough 
> {{$.results}} e.g.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7113) JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7113:
--

 Summary: JsonUtil.unbox generates a NPE with null values in object
 Key: SLING-7113
 URL: https://issues.apache.org/jira/browse/SLING-7113
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Affects Versions: Launchpad Integration Tests 1.0.2
Reporter: Nicolas Peltier


org.apache.sling.launchpad.webapp.integrationtest.util.JsonUtil.unbox fails in 
case of a null value in objects with a NPE

java.lang.NullPointerException
at java.util.HashMap.merge(HashMap.java:1224)
at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at 
java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at 
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at 
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7114) JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7114:
---
Component/s: (was: Launchpad)
 Content Distribution Integration Tests

> JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7114
> URL: https://issues.apache.org/jira/browse/SLING-7114
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution Integration Tests
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Nicolas Peltier
>
> org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7114) JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7114:
---
Affects Version/s: (was: Launchpad Integration Tests 1.0.2)
   Content Distribution Core 0.2.8

> JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7114
> URL: https://issues.apache.org/jira/browse/SLING-7114
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution Integration Tests
>Affects Versions: Content Distribution Core 0.2.8
>Reporter: Nicolas Peltier
>
> org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7115) CLONE - JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7115:
--

 Summary: CLONE - JsonUtil.unbox generates a NPE with null values 
in object
 Key: SLING-7115
 URL: https://issues.apache.org/jira/browse/SLING-7115
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution Integration Tests
Affects Versions: Content Distribution Core 0.2.8
Reporter: Nicolas Peltier


org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
in objects with a NPE

java.lang.NullPointerException
at java.util.HashMap.merge(HashMap.java:1224)
at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at 
java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at 
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at 
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7115) CLONE - JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7115:
---
Component/s: (was: Content Distribution Integration Tests)
 Extensions

> CLONE - JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7115
> URL: https://issues.apache.org/jira/browse/SLING-7115
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
>
> org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7115) CLONE - JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7115:
---
Affects Version/s: (was: Content Distribution Core 0.2.8)
   Pipes 1.0.4

> CLONE - JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7115
> URL: https://issues.apache.org/jira/browse/SLING-7115
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
>
> org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7115) JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7115:
---
Summary: JsonUtil.unbox generates a NPE with null values in object  (was: 
CLONE - JsonUtil.unbox generates a NPE with null values in object)

> JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7115
> URL: https://issues.apache.org/jira/browse/SLING-7115
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
>
> org.apache.sling.pipes.internal.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7115) CLONE - JsonUtil.unbox generates a NPE with null values in object

2017-09-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7115:
---
Description: 
org.apache.sling.pipes.internal.JsonUtil.unbox fails in case of a null value in 
objects with a NPE

java.lang.NullPointerException
at java.util.HashMap.merge(HashMap.java:1224)
at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at 
java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at 
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at 
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)

  was:
org.apache.sling.distribution.it.JsonUtil.unbox fails in case of a null value 
in objects with a NPE

java.lang.NullPointerException
at java.util.HashMap.merge(HashMap.java:1224)
at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at 
java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
at 
java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at 
java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at 
java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)


> CLONE - JsonUtil.unbox generates a NPE with null values in object
> -
>
> Key: SLING-7115
> URL: https://issues.apache.org/jira/browse/SLING-7115
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
>
> org.apache.sling.pipes.internal.JsonUtil.unbox fails in case of a null value 
> in objects with a NPE
> java.lang.NullPointerException
> at java.util.HashMap.merge(HashMap.java:1224)
> at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1320)
> at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
> at 
> java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet.lambda$entryConsumer$0(Collections.java:1575)
> at java.util.Iterator.forEachRemaining(Iterator.java:116)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.Collections$UnmodifiableMap$UnmodifiableEntrySet$UnmodifiableEntrySetSpliterator.forEachRemaining(Collections.java:1600)
> at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7099) add csv pipe

2017-09-12 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7099.

Resolution: Fixed

fixed in r1808090 and r1808091

> add csv pipe
> 
>
> Key: SLING-7099
> URL: https://issues.apache.org/jira/browse/SLING-7099
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 1.1.0
>
>
> would be cool to have a pipe able of ingesting csv à la jsonpipe, repeating 
> input to the output but outputing the line values in the bindings.
> they should share a same parent class. We could also add the possibility to 
> consume an input stream from the request if any.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7173) Add JMX data for pipes

2017-10-02 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7173:
--

 Summary: Add JMX data for pipes
 Key: SLING-7173
 URL: https://issues.apache.org/jira/browse/SLING-7173
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


some JMX data would be interesting to expose :
- pipe occurence calls #,
- mean time per pipe, 
- ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7170) Add PipeModel

2017-10-02 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7170:
--

 Summary: Add PipeModel
 Key: SLING-7170
 URL: https://issues.apache.org/jira/browse/SLING-7170
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


add a pipe model, allowing quick content aggregation with no java code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7170) Add PipeModel

2017-10-02 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16187986#comment-16187986
 ] 

Nicolas Peltier commented on SLING-7170:


cc [~bdelacretaz]

> Add PipeModel
> -
>
> Key: SLING-7170
> URL: https://issues.apache.org/jira/browse/SLING-7170
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>
> add a pipe model, allowing quick content aggregation with no java code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7171) Add Pipe Throttling capability

2017-10-02 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7171:
--

 Summary: Add Pipe Throttling capability
 Key: SLING-7171
 URL: https://issues.apache.org/jira/browse/SLING-7171
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


would be nice to be able to throttle pipe execution to limit CPU consumption



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7172) Change SlingQuery Pipe API

2017-10-02 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7172:
--

 Summary: Change SlingQuery Pipe API
 Key: SLING-7172
 URL: https://issues.apache.org/jira/browse/SLING-7172
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


currently SlingQuery Pipe expression is used for retrieving resources using 
getChildren. This should be calling "find" which is more natural for developers.

getChildren should still be optional (flag isDeep=false)? 

we should update to 4.0 version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7076) traversing pipe

2017-08-23 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7076:
--

 Summary: traversing pipe
 Key: SLING-7076
 URL: https://issues.apache.org/jira/browse/SLING-7076
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Pipes 0.0.10
Reporter: Nicolas Peltier


add a pipe traversing current resource tree, allowing to traverse node or node 
& properties. Adding traversal priority (depth or breadth first) 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7012) Pipes miss some integration tests

2017-08-24 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139854#comment-16139854
 ] 

Nicolas Peltier commented on SLING-7012:


[~olli] awesome, thanks! how did you get them to run at all? Is it the 
commons.lang dep you fixed?

> Pipes miss some integration tests
> -
>
> Key: SLING-7012
> URL: https://issues.apache.org/jira/browse/SLING-7012
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
> Fix For: Pipes 1.0.4
>
>
> As pipes depend so much on sling components that can't easily be tested in UT 
> (xpath, true repo operations, ...), some IT would be nice



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7089) MockNode should support getProperties(String[] nameGlob)

2017-08-29 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7089:
--

 Summary: MockNode should support getProperties(String[] nameGlob)
 Key: SLING-7089
 URL: https://issues.apache.org/jira/browse/SLING-7089
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Affects Versions: Testing JCR Mock 1.3.0
Reporter: Nicolas Peltier


add support for getNodes(final String[] nameGlobs) and getProperties(final 
String[] nameGlobs)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7100) dryRun parameter of a pipe execution should default to true

2017-09-04 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7100:
--

 Summary: dryRun parameter of a pipe execution should default to 
true
 Key: SLING-7100
 URL: https://issues.apache.org/jira/browse/SLING-7100
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Pipes 1.0.4
Reporter: Nicolas Peltier


in case dryRun is wrongly used like {Code}dryRun=True{Code} or 
{Code}dryRun=1{Code}, dryRun should be considered true,
*not* running with dryRun should only be no dryRun parameter, nor dryRyn=false




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7099) add csv pipe

2017-09-02 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7099:
--

 Summary: add csv pipe
 Key: SLING-7099
 URL: https://issues.apache.org/jira/browse/SLING-7099
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Pipes 1.0.4
Reporter: Nicolas Peltier


would be cool to have a pipe able of ingesting csv à la jsonpipe, repeating 
input to the output but outputing the line values in the bindings.
they should share a same parent class. We could also add the possibility to 
consume an input stream from the request if any.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7089) MockNode should support getProperties(String[] nameGlob)

2017-08-29 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7089:
--

Assignee: Nicolas Peltier

> MockNode should support getProperties(String[] nameGlob)
> 
>
> Key: SLING-7089
> URL: https://issues.apache.org/jira/browse/SLING-7089
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> add support for getNodes(final String[] nameGlobs) and getProperties(final 
> String[] nameGlobs)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7076) traversing pipe

2017-08-29 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7076.

   Resolution: Fixed
Fix Version/s: Pipes 1.0.4

fixed in r1806590

> traversing pipe
> ---
>
> Key: SLING-7076
> URL: https://issues.apache.org/jira/browse/SLING-7076
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: Pipes 1.0.4
>
>
> add a pipe traversing current resource tree, allowing to traverse node or 
> node & properties. Adding traversal priority (depth or breadth first) 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7089) MockNode should support getProperties(String[] nameGlob)

2017-08-29 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7089.

   Resolution: Fixed
Fix Version/s: Testing JCR Mock 1.3.2

fixed in r1806595

> MockNode should support getProperties(String[] nameGlob)
> 
>
> Key: SLING-7089
> URL: https://issues.apache.org/jira/browse/SLING-7089
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: Testing JCR Mock 1.3.2
>
>
> add support for getNodes(final String[] nameGlobs) and getProperties(final 
> String[] nameGlobs)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7013) PipesBuilder API is too rigid

2017-08-29 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7013:
--

Assignee: Nicolas Peltier

> PipesBuilder API is too rigid
> -
>
> Key: SLING-7013
> URL: https://issues.apache.org/jira/browse/SLING-7013
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> Some things are missing from Pipes API and there is no workaround:
> # additional bindings,
> # writers,
> # async
> # complicated structures (for write, filters, ...) 
> # any other parameter i forgot
> after trying it groovy + pipebuilder is rather cool UI to generate & test 
> pipes, so would be cool to have everything pipes can do
> as i don't want any of the above enhancement to trigger a major bump in the 
> version, i'd like to do that change for 1.0.x



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-6665) Provide a logging Option for Pax Exam

2017-10-05 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193693#comment-16193693
 ] 

Nicolas Peltier commented on SLING-6665:


[~olli] just added my vote as this would be a big enhancement!

> Provide a logging Option for Pax Exam
> -
>
> Key: SLING-6665
> URL: https://issues.apache.org/jira/browse/SLING-6665
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Affects Versions: Testing PaxExam 0.0.4
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> From {{ThymeleafTestSupport}}:
> {noformat}
> protected Option logging() {
> final String filename = 
> String.format("file:%s/src/test/resources/logback.xml", 
> PathUtils.getBaseDir());
> return composite(
> systemProperty("logback.configurationFile").value(filename),
> 
> mavenBundle().groupId("org.slf4j").artifactId("slf4j-api").version("1.7.21"),
> 
> mavenBundle().groupId("org.slf4j").artifactId("jcl-over-slf4j").version("1.7.21"),
> 
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-core").version("1.1.7"),
> 
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-classic").version("1.1.7")
> );
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7170) Add PipeModel

2017-10-18 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7170:
--

Assignee: Nicolas Peltier

> Add PipeModel
> -
>
> Key: SLING-7170
> URL: https://issues.apache.org/jira/browse/SLING-7170
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 1.2.0
>
>
> add a pipe model, allowing quick content aggregation with no java code



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7171) Add Pipe Throttling capability

2017-10-17 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7171.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 1.2.0

fixed in r1812428

> Add Pipe Throttling capability
> --
>
> Key: SLING-7171
> URL: https://issues.apache.org/jira/browse/SLING-7171
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 1.2.0
>
>
> would be nice to be able to throttle pipe execution to limit CPU consumption



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7206) add outputs to pipebuilder api

2017-10-19 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7206:
--

 Summary: add outputs to pipebuilder api
 Key: SLING-7206
 URL: https://issues.apache.org/jira/browse/SLING-7206
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


we should allow quick configuration of the output writer through the pipe 
builder like
{{newPipe(resolver).echo("/content").$("...").outputs("jcr:title","jcr:description").run()}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7250) allow non persisted configurations for pipe

2017-11-28 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7250:
---
Fix Version/s: pipes 2.0.0

> allow non persisted configurations for pipe
> ---
>
> Key: SLING-7250
> URL: https://issues.apache.org/jira/browse/SLING-7250
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> for some usage of the pipe builder, it might be useful not to persist pipes 
> before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7275) update sling pipes documentation

2017-11-28 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7275:
---
Fix Version/s: pipes 2.0.0

> update sling pipes documentation
> 
>
> Key: SLING-7275
> URL: https://issues.apache.org/jira/browse/SLING-7275
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> Documentation should be much clearer (in several pages, with nested details 
> only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7251) Fix pipes plumber servlet IT

2017-11-28 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7251:
---
Fix Version/s: pipes 2.0.0

> Fix pipes plumber servlet IT 
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> new Plumber servlet IT fail. This should be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7275) update sling pipes documentation

2017-11-28 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7275:
--

 Summary: update sling pipes documentation
 Key: SLING-7275
 URL: https://issues.apache.org/jira/browse/SLING-7275
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.0
Reporter: Nicolas Peltier


Documentation should be much clearer (in several pages, with nested details 
only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7173) Add JMX data for pipes

2017-11-28 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7173:
---
Fix Version/s: pipes 2.0.0

> Add JMX data for pipes
> --
>
> Key: SLING-7173
> URL: https://issues.apache.org/jira/browse/SLING-7173
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> some JMX data would be interesting to expose :
> - pipe occurence calls #,
> - mean time per pipe, 
> - ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7250) allow non persisted configurations for pipe

2017-11-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7250:
--

Assignee: Nicolas Peltier

> allow non persisted configurations for pipe
> ---
>
> Key: SLING-7250
> URL: https://issues.apache.org/jira/browse/SLING-7250
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> for some usage of the pipe builder, it might be useful not to persist pipes 
> before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7241.

   Resolution: Fixed
Fix Version/s: pipes 2.0.0

Thanks [~bcsott]! Did merge your commit (your commit author mail btw is not 
registered in github, hope it's ok)

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 2.0.0
>
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7241:
--

Assignee: Nicolas Peltier

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Assignee: Nicolas Peltier
>Priority: Minor
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-24 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265134#comment-16265134
 ] 

Nicolas Peltier commented on SLING-7241:


Hey [~bdelacretaz], 

"first" call is done with no parameter, which will take thread's class loader 
[0]. Second [1] with "null" parameter which takes root classloader, and fixes 
[~bcsott] issue. May be a method getScriptEngine with both calls in the same 
place would make things clearer.
agreed with the constant


[0] 
https://github.com/bcsott/sling-org-apache-sling-pipes/blob/bd15e86e7b3f37112fe06f26d86342a0832f969a/src/main/java/org/apache/sling/pipes/PipeBindings.java#L53
[1] 
https://github.com/bcsott/sling-org-apache-sling-pipes/blob/bd15e86e7b3f37112fe06f26d86342a0832f969a/src/main/java/org/apache/sling/pipes/PipeBindings.java#L80

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 2.0.0
>
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-27 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266534#comment-16266534
 ] 

Nicolas Peltier commented on SLING-7241:


thanks a lot [~bcsott]! as mentionned in the PR, pls next time provide one  fix 
per commit, as mixing them make review longer

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 2.0.0
>
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7314) Dry run not working

2017-12-15 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7314:
--

Assignee: Nicolas Peltier

> Dry run not working
> ---
>
> Key: SLING-7314
> URL: https://issues.apache.org/jira/browse/SLING-7314
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Honwai Wong
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> I worked with [~npeltier] to define a pipe to perform content migration, see 
> below for an example of this pipe:
> {code}
> def plumber = getService("org.apache.sling.pipes.Plumber");
> plumber.newPipe(resourceResolver)
> .echo('/content/foo/bar').name('startPath')
> .mv('${path.startPath.replace("/bar", "/xyz")}')
> .parent().name('parentContent')
> .mkdir('${path.parentContent}/bar').with('nodeType', 
> 'nt:unstructured').name('targetResource')
> .write('sling:resourceType', 'test/components/somecomponent')
> .echo('${path.parentContent}/xyz')
> .mv('${path.targetResource}/xyz')
> .runWith("dryRun", "true");
> {code}
> However, the {{dryRun}} argument is not taken into account, the changes are 
> actually persisted in the repository.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7249) allow csv output of a pipe execution

2017-11-18 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7249:
--

Assignee: Nicolas Peltier

> allow csv output of a pipe execution
> 
>
> Key: SLING-7249
> URL: https://issues.apache.org/jira/browse/SLING-7249
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> would be cool to have CSV outputs (with csv extension on a pipe)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7251) Fix pipes plumber servlet IT

2017-11-18 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7251:
--

 Summary: Fix pipes plumber servlet IT 
 Key: SLING-7251
 URL: https://issues.apache.org/jira/browse/SLING-7251
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: pipes 2.0.0
Reporter: Nicolas Peltier


new Plumber servlet IT fail. This should be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7249) allow csv output of a pipe execution

2017-11-18 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7249:
--

 Summary: allow csv output of a pipe execution
 Key: SLING-7249
 URL: https://issues.apache.org/jira/browse/SLING-7249
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


would be cool to have CSV outputs (with csv extension on a pipe)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7250) allow non persisted configurations for pipe

2017-11-18 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7250:
--

 Summary: allow non persisted configurations for pipe
 Key: SLING-7250
 URL: https://issues.apache.org/jira/browse/SLING-7250
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


for some usage of the pipe builder, it might be useful not to persist pipes 
before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7249) allow csv output of a pipe execution

2017-11-18 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7249.

   Resolution: Fixed
Fix Version/s: pipes 2.0.0

> allow csv output of a pipe execution
> 
>
> Key: SLING-7249
> URL: https://issues.apache.org/jira/browse/SLING-7249
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> would be cool to have CSV outputs (with csv extension on a pipe)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7206) add outputs to pipebuilder api

2017-11-11 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7206:
--

Assignee: Nicolas Peltier

> add outputs to pipebuilder api
> --
>
> Key: SLING-7206
> URL: https://issues.apache.org/jira/browse/SLING-7206
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> we should allow quick configuration of the output writer through the pipe 
> builder like
> {{newPipe(resolver).echo("/content").$("...").outputs("jcr:title","jcr:description").run()}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7206) add outputs to pipebuilder api

2017-11-11 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7206:
---
Description: 
we should allow quick configuration of the output writer through the pipe 
builder like
{{newPipe(resolver).echo("/content").$("...").outputs("title","jcr:title","desc","jcr:description").run()}}

  was:
we should allow quick configuration of the output writer through the pipe 
builder like
{{newPipe(resolver).echo("/content").$("...").outputs("jcr:title","jcr:description").run()}}


> add outputs to pipebuilder api
> --
>
> Key: SLING-7206
> URL: https://issues.apache.org/jira/browse/SLING-7206
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> we should allow quick configuration of the output writer through the pipe 
> builder like
> {{newPipe(resolver).echo("/content").$("...").outputs("title","jcr:title","desc","jcr:description").run()}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (SLING-7172) Change SlingQuery Pipe API

2017-11-11 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7172:
--

Assignee: Nicolas Peltier

> Change SlingQuery Pipe API
> --
>
> Key: SLING-7172
> URL: https://issues.apache.org/jira/browse/SLING-7172
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> currently SlingQuery Pipe expression is used for retrieving resources using 
> getChildren. This should be calling "find" which is more natural for 
> developers.
> getChildren should still be optional (flag isDeep=false)? 
> we should update to 4.0 version



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-16 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255107#comment-16255107
 ] 

Nicolas Peltier commented on SLING-7241:


[~karlpauls] that's not noise, it's fine enriching this ticket with your 
lights. 

[~bcsott] i'm fine merging in your change, but with some comment explaining 
that parameter as said (pls amend your commit and push --force so you have only 
one commit)
thanks!

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Priority: Minor
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Comment Edited] (SLING-7242) [Shiny] Sling Website Design

2017-11-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253221#comment-16253221
 ] 

Nicolas Peltier edited comment on SLING-7242 at 11/15/17 10:11 AM:
---

[~auniverseaway] i love it too! would be interesting to see how other pages 
would look like. I guess just one other template is enough?


was (Author: npeltier):
[~cmillar] i love it too! would be interesting to see how other pages would 
look like. I guess just one other template is enough?

> [Shiny] Sling Website Design
> 
>
> Key: SLING-7242
> URL: https://issues.apache.org/jira/browse/SLING-7242
> Project: Sling
>  Issue Type: Task
>Reporter: Chris Millar
>Priority: Minor
> Attachments: Web 1920 – 1.png
>
>
> As part of SLING-, it was mentioned the Sling website needs a re-design 
> to help attract new developers and make the site easier to use on mobile 
> devices.
> Now that the site is on JBake, it probably makes sense to start working on 
> this.
> The attached mockup is an initial take on the homepage. It's not meant to be 
> all-encompassing, but should provide a view into what the site could look 
> like and how it could match the new Sling Launchpad design.
> *Notes*
> * The image is pulled from Adobe Stock. Hopefully this can be donated, or we 
> can pull from the community to get an image we want to use. Was thinking 
> "greenfield" and not overly distracting.
> * I was looking for something punchy for the title text. "Effortlessly build 
> resource-driven web-applications." is what I came up with.
> * About text has been un-touched.
> * Easy build instructions are right on the homepage. Docker first, with Java 
> just a tab click away. This follows Docker now being the priority on the 
> getting started page.
> * News, Get Involved, and Additional Resource should be mostly 
> self-explanatory.
> * The navigation is designed around the common areas of the current left hand 
> rail, but with tutorials being broken out. This is a result of the many devs 
> I've on-boarded that prefer walk-throughs over raw docs.
> Overall the idea is to give a single page of the main topics, but kick out to 
> the pages already established.
> Let me know your thoughts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design

2017-11-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253221#comment-16253221
 ] 

Nicolas Peltier commented on SLING-7242:


[~cmillar] i love it too! would be interesting to see how other pages would 
look like. I guess just one other template is enough?

> [Shiny] Sling Website Design
> 
>
> Key: SLING-7242
> URL: https://issues.apache.org/jira/browse/SLING-7242
> Project: Sling
>  Issue Type: Task
>Reporter: Chris Millar
>Priority: Minor
> Attachments: Web 1920 – 1.png
>
>
> As part of SLING-, it was mentioned the Sling website needs a re-design 
> to help attract new developers and make the site easier to use on mobile 
> devices.
> Now that the site is on JBake, it probably makes sense to start working on 
> this.
> The attached mockup is an initial take on the homepage. It's not meant to be 
> all-encompassing, but should provide a view into what the site could look 
> like and how it could match the new Sling Launchpad design.
> *Notes*
> * The image is pulled from Adobe Stock. Hopefully this can be donated, or we 
> can pull from the community to get an image we want to use. Was thinking 
> "greenfield" and not overly distracting.
> * I was looking for something punchy for the title text. "Effortlessly build 
> resource-driven web-applications." is what I came up with.
> * About text has been un-touched.
> * Easy build instructions are right on the homepage. Docker first, with Java 
> just a tab click away. This follows Docker now being the priority on the 
> getting started page.
> * News, Get Involved, and Additional Resource should be mostly 
> self-explanatory.
> * The navigation is designed around the common areas of the current left hand 
> rail, but with tutorials being broken out. This is a result of the many devs 
> I've on-boarded that prefer walk-throughs over raw docs.
> Overall the idea is to give a single page of the main topics, but kick out to 
> the pages already established.
> Let me know your thoughts.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253239#comment-16253239
 ] 

Nicolas Peltier commented on SLING-7241:


thx [~bcsott] for the issue & PR!

i think [~kpauls] the issue is correlated with SLING-7134, but i'm not sure it 
would fix it. Anyway specifying system classloader might be a good idea to 
avoid future headaches about why nahshorn is not here in pipes case. 

[~bcsott] could you add some comment explaining the choice of the engine 
manager (something like "we take the system classloader's engine manager to 
ensure consistent execution of pipes across contexts")

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Priority: Minor
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7241) [pipes] Nashorn ScriptEngine in PipeBindings is null

2017-11-15 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16253260#comment-16253260
 ] 

Nicolas Peltier commented on SLING-7241:


ok [~kpauls] then i'll wait :-)

> [pipes] Nashorn ScriptEngine in PipeBindings is null
> 
>
> Key: SLING-7241
> URL: https://issues.apache.org/jira/browse/SLING-7241
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 1.0.4
> Environment: java.runtime.name = Java(TM) SE Runtime Environment
> java.runtime.version = 1.8.0_144-b01
>Reporter: Björn Csott
>Priority: Minor
> Attachments: error.log
>
>
> Under some unclear circumstances the ScriptEngine in PipeBindings does not 
> get initialized.
> There is a solution out there to attach Nashorn to the system bundle. Appart 
> from that I was able to fix it by using a different constructor: 
> ScriptEngineManager(null). 
> The issue can be reproduced by deploying 
> https://github.com/bcsott/migration-tool
> When it fails the following is written to stderror.log:
> ScriptEngineManager providers.next(): javax.script.ScriptEngineFactory:
> Provider jdk.nashorn.api.scripting.NashornScriptEngineFactory not found



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-7250) allow non persisted configurations for pipe

2017-12-12 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7250:
---
Fix Version/s: (was: pipes 2.0.0)

> allow non persisted configurations for pipe
> ---
>
> Key: SLING-7250
> URL: https://issues.apache.org/jira/browse/SLING-7250
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> for some usage of the pipe builder, it might be useful not to persist pipes 
> before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-7250) allow non persisted configurations for pipe

2017-12-12 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287629#comment-16287629
 ] 

Nicolas Peltier commented on SLING-7250:


removing this from pipes 2.0
this should be associated with decoupling of logic and state management (with 
something like boundable osgi components handling execution, and one class 
holding state passed as a parameter). This would be another version bump 
probably, but deserves bigger interest from community.

> allow non persisted configurations for pipe
> ---
>
> Key: SLING-7250
> URL: https://issues.apache.org/jira/browse/SLING-7250
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>
> for some usage of the pipe builder, it might be useful not to persist pipes 
> before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7217) Filter Pipe should handle property value regexp betters

2017-10-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7217.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 2.0.0

> Filter Pipe should handle property value regexp betters
> ---
>
> Key: SLING-7217
> URL: https://issues.apache.org/jira/browse/SLING-7217
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> currently filter pipe uses a match for property value regexp, which might be 
> complicated and confusing. It should use a find



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-7217) Filter Pipe should handle property value regexp betters

2017-10-24 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7217:
--

 Summary: Filter Pipe should handle property value regexp betters
 Key: SLING-7217
 URL: https://issues.apache.org/jira/browse/SLING-7217
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


currently filter pipe uses a match for property value regexp, which might be 
complicated and confusing. It should use a find



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-7638) Pipe binding expression instantiation failure should break the containing pipe

2018-05-14 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7638.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 2.1.0

> Pipe binding expression instantiation failure should break the containing pipe
> --
>
> Key: SLING-7638
> URL: https://issues.apache.org/jira/browse/SLING-7638
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.1.0
>
>
> now a failed expression instantation just take the source, which is always a 
> problem, the pipe should rather fail



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7614) write pipe should allow expression in node names

2018-05-05 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7614.

Resolution: Fixed

> write pipe should allow expression in node names
> 
>
> Key: SLING-7614
> URL: https://issues.apache.org/jira/browse/SLING-7614
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.1.0
>
>
> when writing a structure, configuration should allow expressions in node names



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7639) Enhance error message when additional script has errors

2018-05-05 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7639.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 2.1.0

> Enhance error message when additional script has errors
> ---
>
> Key: SLING-7639
> URL: https://issues.apache.org/jira/browse/SLING-7639
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: pipes 2.1.0
>
>
> {{org.apache.sling.pipes.PipeBindings unable to execute ..blah.js}} is pretty 
> useless...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7640) Package pipe

2018-05-05 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7640.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 2.1.0

only filter collection mode for now (most useful)

> Package pipe
> 
>
> Key: SLING-7640
> URL: https://issues.apache.org/jira/browse/SLING-7640
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.1.0
>
>
> à la Authorizable pipe, both reader & writer, ability to read apache 
> filevault package filters, or write some.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7639) Enhance error message when additional script has errors

2018-05-05 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7639:
---
Summary: Enhance error message when additional script has errors  (was: 
Enhance error message when additional script has erros)

> Enhance error message when additional script has errors
> ---
>
> Key: SLING-7639
> URL: https://issues.apache.org/jira/browse/SLING-7639
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Minor
>
> {{org.apache.sling.pipes.PipeBindings unable to execute ..blah.js}} is pretty 
> useless...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7614) write pipe should allow expression in node names

2018-05-05 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7614:
--

Assignee: Nicolas Peltier

> write pipe should allow expression in node names
> 
>
> Key: SLING-7614
> URL: https://issues.apache.org/jira/browse/SLING-7614
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.1.0
>
>
> when writing a structure, configuration should allow expressions in node names



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7632) Pipe Execution Result should show an error list

2018-05-15 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7632:
--

Assignee: Nicolas Peltier

> Pipe Execution Result should show an error list
> ---
>
> Key: SLING-7632
> URL: https://issues.apache.org/jira/browse/SLING-7632
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> While not breaking the pipe execution at the first issue encountered is 
> important in a production world when a content exception should/could be 
> handled separately. Errors happening are "only" happening on logs. 
> They should be tracked in the execution result as well, with path excerpt, 
> and total #, with same limit as for results. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7678) create gogo command provider for running & building pipe

2018-05-23 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7678:
--

 Summary: create gogo command provider for running & building pipe
 Key: SLING-7678
 URL: https://issues.apache.org/jira/browse/SLING-7678
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 3.0.0
Reporter: Nicolas Peltier


would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design

2018-05-23 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16486976#comment-16486976
 ] 

Nicolas Peltier commented on SLING-7242:


i'm really impatient to see that live, [~cmillar]! 

- line length seems a bit high to me though, counted ~130cpl. [Looks 
like|https://www.viget.com/articles/the-line-length-misconception/] there is no 
real standard, but i would "feel" better with less than that. Personal opinion 
may be.
- Have you looked into making 2nd level of TOC togglable? 
- do you need help on something?

> [Shiny] Sling Website Design
> 
>
> Key: SLING-7242
> URL: https://issues.apache.org/jira/browse/SLING-7242
> Project: Sling
>  Issue Type: Task
>Reporter: Chris Millar
>Priority: Minor
> Attachments: Sling - Page.png, Web 1920 – 1.png, 
> browser-comparison.jpg, screenshot-1.png
>
>
> As part of SLING-, it was mentioned the Sling website needs a re-design 
> to help attract new developers and make the site easier to use on mobile 
> devices.
> Now that the site is on JBake, it probably makes sense to start working on 
> this.
> The attached mockup is an initial take on the homepage. It's not meant to be 
> all-encompassing, but should provide a view into what the site could look 
> like and how it could match the new Sling Launchpad design.
> *Notes*
> * The image is pulled from Adobe Stock. Hopefully this can be donated, or we 
> can pull from the community to get an image we want to use. Was thinking 
> "greenfield" and not overly distracting.
> * I was looking for something punchy for the title text. "Effortlessly build 
> resource-driven web-applications." is what I came up with.
> * About text has been un-touched.
> * Easy build instructions are right on the homepage. Docker first, with Java 
> just a tab click away. This follows Docker now being the priority on the 
> getting started page.
> * News, Get Involved, and Additional Resource should be mostly 
> self-explanatory.
> * The navigation is designed around the common areas of the current left hand 
> rail, but with tutorials being broken out. This is a result of the many devs 
> I've on-boarded that prefer walk-throughs over raw docs.
> Overall the idea is to give a single page of the main topics, but kick out to 
> the pages already established.
> Let me know your thoughts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7632) Pipe Execution Result should show an error list

2018-05-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7632.

   Resolution: Fixed
Fix Version/s: pipes 3.0.0

> Pipe Execution Result should show an error list
> ---
>
> Key: SLING-7632
> URL: https://issues.apache.org/jira/browse/SLING-7632
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> While not breaking the pipe execution at the first issue encountered is 
> important in a production world when a content exception should/could be 
> handled separately. Errors happening are "only" happening on logs. 
> They should be tracked in the execution result as well, with path excerpt, 
> and total #, with same limit as for results. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7678:
---
Affects Version/s: (was: pipes 3.0.0)
   pipes 2.0.2

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7678:
---
Fix Version/s: pipes 3.0.0

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7678) create gogo command provider for running & building pipe

2018-05-24 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7678:
--

Assignee: Nicolas Peltier

> create gogo command provider for running & building pipe
> 
>
> Key: SLING-7678
> URL: https://issues.apache.org/jira/browse/SLING-7678
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> would be nice to have gogo command to run & build pipes quickly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7242) [Shiny] Sling Website Design

2018-05-21 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482291#comment-16482291
 ] 

Nicolas Peltier commented on SLING-7242:


[~cmillar] love it!
* will the top nav stay fluid? or do you plan to have some kind of stack at a 
given breakpoint?
* can you divide future work so we can help you?

> [Shiny] Sling Website Design
> 
>
> Key: SLING-7242
> URL: https://issues.apache.org/jira/browse/SLING-7242
> Project: Sling
>  Issue Type: Task
>Reporter: Chris Millar
>Priority: Minor
> Attachments: Sling - Page.png, Web 1920 – 1.png, 
> browser-comparison.jpg, screenshot-1.png
>
>
> As part of SLING-, it was mentioned the Sling website needs a re-design 
> to help attract new developers and make the site easier to use on mobile 
> devices.
> Now that the site is on JBake, it probably makes sense to start working on 
> this.
> The attached mockup is an initial take on the homepage. It's not meant to be 
> all-encompassing, but should provide a view into what the site could look 
> like and how it could match the new Sling Launchpad design.
> *Notes*
> * The image is pulled from Adobe Stock. Hopefully this can be donated, or we 
> can pull from the community to get an image we want to use. Was thinking 
> "greenfield" and not overly distracting.
> * I was looking for something punchy for the title text. "Effortlessly build 
> resource-driven web-applications." is what I came up with.
> * About text has been un-touched.
> * Easy build instructions are right on the homepage. Docker first, with Java 
> just a tab click away. This follows Docker now being the priority on the 
> getting started page.
> * News, Get Involved, and Additional Resource should be mostly 
> self-explanatory.
> * The navigation is designed around the common areas of the current left hand 
> rail, but with tutorials being broken out. This is a result of the many devs 
> I've on-boarded that prefer walk-throughs over raw docs.
> Overall the idea is to give a single page of the main topics, but kick out to 
> the pages already established.
> Let me know your thoughts.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7692) MockSession.revert(false) support should be clearer

2018-06-06 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7692.

Resolution: Fixed

> MockSession.revert(false) support should be clearer
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7722) Container pipe is not always cut when empty pipe in the middle

2018-06-11 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7722:
--

 Summary: Container pipe is not always cut when empty pipe in the 
middle
 Key: SLING-7722
 URL: https://issues.apache.org/jira/browse/SLING-7722
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


{Code}
.echo(PATH_FRUITS) //should return fruit root
.echo("nonexisting") // /content/fruits/nonexisting does not 
exist
.echo(PATH_APPLE) // existing apple
{Code}
does actually return PATH_APPLE's resource. 
wether nonexisting is a configuration mistake or some contextual problem, this 
pipe should be cut, and not remove anything.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7722) Container pipe is not always cut when empty pipe in the middle

2018-06-11 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7722.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 3.0.0

> Container pipe is not always cut when empty pipe in the middle
> --
>
> Key: SLING-7722
> URL: https://issues.apache.org/jira/browse/SLING-7722
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> {Code}
> .echo(PATH_FRUITS) //should return fruit root
> .echo("nonexisting") // /content/fruits/nonexisting does not 
> exist
> .echo(PATH_APPLE) // existing apple
> {Code}
> does actually return PATH_APPLE's resource. 
> wether nonexisting is a configuration mistake or some contextual problem, 
> this pipe should be cut, and not remove anything.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession.revert(false) support should be clearer

2018-06-11 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508119#comment-16508119
 ] 

Nicolas Peltier commented on SLING-7692:


[~sseif...@pro-vision.de] i guess #3 is a bad idea for other resource resolver 
types for which refresh(false) does mean something. Am happy implementing #2 or 
even #1

> MockSession.revert(false) support should be clearer
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (SLING-7640) Package pipe

2018-06-12 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reopened SLING-7640:


re-opening this issue to add:
- better handling of filters in case they are not existing,
- after hook to build the package if configured

> Package pipe
> 
>
> Key: SLING-7640
> URL: https://issues.apache.org/jira/browse/SLING-7640
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> à la Authorizable pipe, both reader & writer, ability to read apache 
> filevault package filters, or write some.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7704) create pipe execution hooks

2018-06-12 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7704.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 3.0.0

> create pipe execution hooks
> ---
>
> Key: SLING-7704
> URL: https://issues.apache.org/jira/browse/SLING-7704
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> There is a need for package pipe to build if configured. This ticket to add a 
> generic solution for a pipe implementation to do things when parent pipe is 
> over. Basically container pipe calls all its subpipe and call a ends() 
> method. May be a starts method would help as well.
> one other nice thing would be to create {{startsHook}} and {{endsHook}} 
> properties, that would be pipe references to execute before or after the 
> configured pipe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7707) Create Executor Pipe

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7707:
---
Summary: Create Executor Pipe  (was: Create Union Pipe)

> Create Executor Pipe
> 
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
>
> pipe that executes its subpipes in sequence or in parallel, with no relation 
> ship between them, and returns the union of the outputs, like a or / {{+}} 
> operator (as opposed to actual Container Pipe that chain them together and 
> could be the {{x}} operator)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7707) Create Union Pipe

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7707:
---
Description: 
pipe that executes its subpipes in sequence or in parallel, with no relation 
ship between them, and returns the union of the outputs, like a or / {{+}} 
operator (as opposed to actual Container Pipe that chain them together and 
could be the {{x}} operator)


  was:
pipe that executes its subpipes in sequence, with no relation ship between 
them, and returns the union of the outputs, like a or / {{+}} operator (as 
opposed to actual Container Pipe that chain them together and could be the 
{{x}} operator)



> Create Union Pipe
> -
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
>
> pipe that executes its subpipes in sequence or in parallel, with no relation 
> ship between them, and returns the union of the outputs, like a or / {{+}} 
> operator (as opposed to actual Container Pipe that chain them together and 
> could be the {{x}} operator)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Reopened] (SLING-7692) MockSession.revert(false) support should be clearer

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reopened SLING-7692:


Hey [~sseif...@pro-vision.de] in fact it's not entirely done :-/ at least one 
usage of refresh(false) is done, in 
org.apache.sling.testing.mock.sling.context.SlingContextImpl.tearDown

should i : 
# revert that change completely, assuming we want this either to be supported, 
or silent?
# add a catch clause in SlingContextImpl,
# remove the {{false}} parameter of the refresh?

> MockSession.revert(false) support should be clearer
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7718) Script engine should not be created for each contained or referenced path

2018-06-08 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7718:
--

 Summary: Script engine should not be created for each contained or 
referenced path
 Key: SLING-7718
 URL: https://issues.apache.org/jira/browse/SLING-7718
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


A container or a reference pipe will systematically set bindings to sub pipes. 
For that reason, it's useless to create script engine instance (and pipebinding 
object in general).
Moreover it drills down performance a lot when reference pipe or container pipe 
are used late in the pipe (i.e. are called a lot).
This ticket is about changing the API to include bindings in the constructor of 
a pipe, if null, then it can be created



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7719) Empty Container pipe should be handled

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7719.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 3.0.0

> Empty Container pipe should be handled
> --
>
> Key: SLING-7719
> URL: https://issues.apache.org/jira/browse/SLING-7719
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> corner case, but when a container pipe is empty, it should just return 
> nothing, not fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7718) Script engine should not be created for each contained or referenced path

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7718:
--

Assignee: Nicolas Peltier

> Script engine should not be created for each contained or referenced path
> -
>
> Key: SLING-7718
> URL: https://issues.apache.org/jira/browse/SLING-7718
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> A container or a reference pipe will systematically set bindings to sub 
> pipes. For that reason, it's useless to create script engine instance (and 
> pipebinding object in general).
> Moreover it drills down performance a lot when reference pipe or container 
> pipe are used late in the pipe (i.e. are called a lot).
> This ticket is about changing the API to include bindings in the constructor 
> of a pipe, if null, then it can be created



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7718) Script engine should not be created for each contained or referenced path

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7718.

   Resolution: Fixed
Fix Version/s: pipes 3.0.0

> Script engine should not be created for each contained or referenced path
> -
>
> Key: SLING-7718
> URL: https://issues.apache.org/jira/browse/SLING-7718
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> A container or a reference pipe will systematically set bindings to sub 
> pipes. For that reason, it's useless to create script engine instance (and 
> pipebinding object in general).
> Moreover it drills down performance a lot when reference pipe or container 
> pipe are used late in the pipe (i.e. are called a lot).
> This ticket is about changing the API to include bindings in the constructor 
> of a pipe, if null, then it can be created



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7719) Empty Container pipe should be handled

2018-06-08 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7719:
--

 Summary: Empty Container pipe should be handled
 Key: SLING-7719
 URL: https://issues.apache.org/jira/browse/SLING-7719
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


corner case, but when a container pipe is empty, it should just return nothing, 
not fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7707) Create Executor Pipe

2018-06-08 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7707:
---
Description: 
pipe that executes its subpipes in sequence or in parallel, with no relation 
ship between them, and returns the union of the outputs, like a or / {{+}} 
operator (as opposed to actual Container Pipe that chain them together and 
could be the {{x}} operator)

Considering subpipe1, subpipe2, ...subpipeN, we could 
- execute them in sequence (easy case),
- execute them in parallel (default configuration for performance first, with 
{{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10% 
CPU except at commit time)

one important thing to consider is the PipeBinding object should be duplicated 
and passed to the subpipe (it's ok to assume container pipe of the executor 
pipe should not have effects on its bindings). Use case for this is 
{{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
should basically call, for each locale, in parallel, "ref1","ref2","ref3" 
and"ref4", that all have in their bindings path.locale to work with



  was:
pipe that executes its subpipes in sequence or in parallel, with no relation 
ship between them, and returns the union of the outputs, like a or / {{+}} 
operator (as opposed to actual Container Pipe that chain them together and 
could be the {{x}} operator)



> Create Executor Pipe
> 
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
>
> pipe that executes its subpipes in sequence or in parallel, with no relation 
> ship between them, and returns the union of the outputs, like a or / {{+}} 
> operator (as opposed to actual Container Pipe that chain them together and 
> could be the {{x}} operator)
> Considering subpipe1, subpipe2, ...subpipeN, we could 
> - execute them in sequence (easy case),
> - execute them in parallel (default configuration for performance first, with 
> {{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10% 
> CPU except at commit time)
> one important thing to consider is the PipeBinding object should be 
> duplicated and passed to the subpipe (it's ok to assume container pipe of the 
> executor pipe should not have effects on its bindings). Use case for this is 
> {{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
> should basically call, for each locale, in parallel, "ref1","ref2","ref3" 
> and"ref4", that all have in their bindings path.locale to work with



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7715) PathPipe default autosave value should be false

2018-06-07 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7715:
--

 Summary: PathPipe default autosave value should be false
 Key: SLING-7715
 URL: https://issues.apache.org/jira/browse/SLING-7715
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


default value for autosave right now is {{true}} which leads to very bad 
default performances while they could be better, and require users to know that 
setting. 
Setting it to false by default will lead to pipe error where it will be easier 
for the user to understand why it's failing and to set the parameter to {{true}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7715) PathPipe default autosave value should be false

2018-06-07 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7715.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 3.0.0

> PathPipe default autosave value should be false
> ---
>
> Key: SLING-7715
> URL: https://issues.apache.org/jira/browse/SLING-7715
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> default value for autosave right now is {{true}} which leads to very bad 
> default performances while they could be better, and require users to know 
> that setting. 
> Setting it to false by default will lead to pipe error where it will be 
> easier for the user to understand why it's failing and to set the parameter 
> to {{true}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7692) MockSession.revert(false) support should be clearer

2018-06-14 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7692.

Resolution: Fixed

> MockSession.revert(false) support should be clearer
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4, Testing Sling Mock 2.2.20
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7729) add basic auth to AbstractInputStreamPipe

2018-06-13 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7729:
--

 Summary: add basic auth to AbstractInputStreamPipe
 Key: SLING-7729
 URL: https://issues.apache.org/jira/browse/SLING-7729
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.2
Reporter: Nicolas Peltier


being able to point to an URL with AbstractInputStreamPipe is cool, would be 
even better if we could set credentials



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7640) Package pipe

2018-06-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7640.

Resolution: Fixed

> Package pipe
> 
>
> Key: SLING-7640
> URL: https://issues.apache.org/jira/browse/SLING-7640
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> à la Authorizable pipe, both reader & writer, ability to read apache 
> filevault package filters, or write some.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7707) Create Executor Pipe

2018-06-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7707:
---
Fix Version/s: pipes 3.0.0

> Create Executor Pipe
> 
>
> Key: SLING-7707
> URL: https://issues.apache.org/jira/browse/SLING-7707
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> pipe that executes its subpipes in sequence or in parallel, with no relation 
> ship between them, and returns the union of the outputs, like a or / {{+}} 
> operator (as opposed to actual Container Pipe that chain them together and 
> could be the {{x}} operator)
> Considering subpipe1, subpipe2, ...subpipeN, we could 
> - execute them in sequence (easy case),
> - execute them in parallel (default configuration for performance first, with 
> {{parallel=true}} & {{maxThreads=5}} (on my laptop heavy thread consumes ~10% 
> CPU except at commit time)
> one important thing to consider is the PipeBinding object should be 
> duplicated and passed to the subpipe (it's ok to assume container pipe of the 
> executor pipe should not have effects on its bindings). Use case for this is 
> {{.echo("/content/mysite").children("some:Page").children("some:Page").name("locale").executor("ref1","ref2","ref3","ref4")}}
> should basically call, for each locale, in parallel, "ref1","ref2","ref3" 
> and"ref4", that all have in their bindings path.locale to work with



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7629) Regexp pipe

2018-06-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7629:
--

Assignee: Nicolas Peltier

> Regexp pipe
> ---
>
> Key: SLING-7629
> URL: https://issues.apache.org/jira/browse/SLING-7629
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> For some use case, instead of json or csv inputstream, a more unstructured 
> input like a text file, with regexp pattern (e.g. an html file) could be used 
> in a pipe



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession.revert(false) support should be clearer

2018-06-14 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512103#comment-16512103
 ] 

Nicolas Peltier commented on SLING-7692:


https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/1 :-)

> MockSession.revert(false) support should be clearer
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession should support revert(false)

2018-05-30 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495334#comment-16495334
 ] 

Nicolas Peltier commented on SLING-7692:


[~sseif...@pro-vision.de] i see...at least then, shouldn't we send an 
Unsupported operation exception when keepChanges is false?

> MockSession should support revert(false)
> 
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException

2018-05-30 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7692.

Resolution: Fixed

> MockSession.revert(false) should send UnsupportedOperationException
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException

2018-05-30 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495381#comment-16495381
 ] 

Nicolas Peltier commented on SLING-7692:


[~sseif...@pro-vision.de] done. Please note i had to remove a 
[line|https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/commit/42c3adc9638549319d3c3b7d954216909873a53d#diff-9cf1389effa2da82d9c8d62f155fcce9L264]
 from one of the existing test.



> MockSession.revert(false) should send UnsupportedOperationException
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession should support revert(false)

2018-05-30 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495341#comment-16495341
 ] 

Nicolas Peltier commented on SLING-7692:


(assuming {{this.items.clear()}} removes also content that has been loaded, 
initially, right [~sseif...@pro-vision.de] ? if not, then i'd keep it)

> MockSession should support revert(false)
> 
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7692) MockSession should support revert(false)

2018-05-30 Thread Nicolas Peltier (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495359#comment-16495359
 ] 

Nicolas Peltier commented on SLING-7692:


ok will rename this ticket, and do this instead, then, thanks!

> MockSession should support revert(false)
> 
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7694) pipe support for relative input paths

2018-05-30 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7694.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 3.0.0

> pipe support for relative input paths
> -
>
> Key: SLING-7694
> URL: https://issues.apache.org/jira/browse/SLING-7694
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 3.0.0
>
>
> it happens that several pipes in a container need to have input processed 
> depending on the upper output. 
> In other words, we should be supporting 
> {{.echo("/content").echo("fruits")}} that should be the same as 
> {{.echo("/content/fruits")}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7692) MockSession.revert(false) should send UnsupportedOperationException

2018-05-30 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7692:
---
Summary: MockSession.revert(false) should send 
UnsupportedOperationException  (was: MockSession should support revert(false))

> MockSession.revert(false) should send UnsupportedOperationException
> ---
>
> Key: SLING-7692
> URL: https://issues.apache.org/jira/browse/SLING-7692
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing JCR Mock 1.3.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Testing JCR Mock 1.3.4
>
>
> MockSession does not cancel the changes when refresh(false) is called, hence 
> resolver.revert() not working in case JCR_MOCK is used



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


<    1   2   3   4   5   6   7   8   >