[jira] [Created] (SLING-9979) Impr
Nicolas Peltier created SLING-9979: -- Summary: Impr Key: SLING-9979 URL: https://issues.apache.org/jira/browse/SLING-9979 Project: Sling Issue Type: Improvement Reporter: Nicolas Peltier -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9979) FilterPipe improvements
[ https://issues.apache.org/jira/browse/SLING-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-9979: -- Fix Version/s: Pipes 4.0.1 Affects Version/s: Pipes 4.0.0 Assignee: Nicolas Peltier Description: There are certain cases where filter pipe spits out an NPE, it should not compute patterns for every execution, we should have better coverage for certain cases Summary: FilterPipe improvements (was: Impr) > FilterPipe improvements > --- > > Key: SLING-9979 > URL: https://issues.apache.org/jira/browse/SLING-9979 > Project: Sling > Issue Type: Improvement >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > There are certain cases where filter pipe spits out an NPE, it should not > compute patterns for every execution, we should have better coverage for > certain cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9979) FilterPipe improvements
[ https://issues.apache.org/jira/browse/SLING-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9979: --- Component/s: Extensions > FilterPipe improvements > --- > > Key: SLING-9979 > URL: https://issues.apache.org/jira/browse/SLING-9979 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > There are certain cases where filter pipe spits out an NPE, it should not > compute patterns for every execution, we should have better coverage for > certain cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9979) FilterPipe improvements
[ https://issues.apache.org/jira/browse/SLING-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-9979. Resolution: Fixed > FilterPipe improvements > --- > > Key: SLING-9979 > URL: https://issues.apache.org/jira/browse/SLING-9979 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > There are certain cases where filter pipe spits out an NPE, it should not > compute patterns for every execution, we should have better coverage for > certain cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9977) add context aware configurations in pipes bindings
[ https://issues.apache.org/jira/browse/SLING-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-9977: -- Assignee: Nicolas Peltier > add context aware configurations in pipes bindings > -- > > Key: SLING-9977 > URL: https://issues.apache.org/jira/browse/SLING-9977 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > we should add a pipe binding in a similar way that in scripting, > caconfig['...'] that would help having typical application configuration set > up (application roots, components type, ...) once -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9977) add context aware configurations in pipes bindings
[
https://issues.apache.org/jira/browse/SLING-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244556#comment-17244556
]
Nicolas Peltier commented on SLING-9977:
[~sseifert] i'm about to create for this ticket more or less the same ConfigMap
you created in {{ConfigurationBindingsValueProvider}}
would you mind if i make that map a standalone (and public) class?
> add context aware configurations in pipes bindings
> --
>
> Key: SLING-9977
> URL: https://issues.apache.org/jira/browse/SLING-9977
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> we should add a pipe binding in a similar way that in scripting,
> caconfig['...'] that would help having typical application configuration set
> up (application roots, components type, ...) once
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9986) pipe scripting improvements
Nicolas Peltier created SLING-9986: -- Summary: pipe scripting improvements Key: SLING-9986 URL: https://issues.apache.org/jira/browse/SLING-9986 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.0.0 Reporter: Nicolas Peltier add some improvements to scripting, at least: * common paths to search for references, so you don't need to add full path for commonly used pipes, * add ability to add bindings, and build pipes (without executing them) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9986) pipe scripting improvements
[ https://issues.apache.org/jira/browse/SLING-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-9986. Fix Version/s: Pipes 4.1.0 Resolution: Fixed > pipe scripting improvements > --- > > Key: SLING-9986 > URL: https://issues.apache.org/jira/browse/SLING-9986 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.0 > > > add some improvements to scripting, at least: > * common paths to search for references, so you don't need to add full path > for commonly used pipes, > * add ability to add bindings, and build pipes (without executing them) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9977) add context aware configurations in pipes bindings
Nicolas Peltier created SLING-9977: -- Summary: add context aware configurations in pipes bindings Key: SLING-9977 URL: https://issues.apache.org/jira/browse/SLING-9977 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.0.0 Reporter: Nicolas Peltier we should add a pipe binding in a similar way that in scripting, caconfig['...'] that would help having typical application configuration set up (application roots, components type, ...) once -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8194) Remove HttpClient 3.x dependency
[ https://issues.apache.org/jira/browse/SLING-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-8194: --- Summary: Remove HttpClient 3.x dependency (was: Upgrade HttpClient to 4.x) > Remove HttpClient 3.x dependency > > > Key: SLING-8194 > URL: https://issues.apache.org/jira/browse/SLING-8194 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > Jackrabbit switched to HttpClient 4.x, so should Pipes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8194) Remove HttpClient 3.x dependency
[ https://issues.apache.org/jira/browse/SLING-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241656#comment-17241656 ] Nicolas Peltier commented on SLING-8194: sorry about that [~olli] thought updating the dependency would be enough. I removed it all together as it was a bit overkill anyway > Remove HttpClient 3.x dependency > > > Key: SLING-8194 > URL: https://issues.apache.org/jira/browse/SLING-8194 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > Jackrabbit switched to HttpClient 4.x, so should Pipes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8194) Upgrade HttpClient to 4.x
[ https://issues.apache.org/jira/browse/SLING-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-8194. Fix Version/s: (was: Pipes 4.0.0) Pipes 4.0.1 Resolution: Fixed > Upgrade HttpClient to 4.x > - > > Key: SLING-8194 > URL: https://issues.apache.org/jira/browse/SLING-8194 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.0.1 > > > Jackrabbit switched to HttpClient 4.x, so should Pipes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (SLING-9986) pipe scripting improvements
[ https://issues.apache.org/jira/browse/SLING-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reopened SLING-9986: Assignee: Nicolas Peltier we need to make things a bit better (cc [~hwong] ) by adding: * possibility of types (Boolean, Date, Integer, Arrays) in write & all, also need to check if patch still work, * we need some purger configured to remove "old" pipe persistence > pipe scripting improvements > --- > > Key: SLING-9986 > URL: https://issues.apache.org/jira/browse/SLING-9986 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.0 > > > add some improvements to scripting, at least: > * common paths to search for references, so you don't need to add full path > for commonly used pipes, > * add ability to add bindings, and build pipes (without executing them) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10002) command servlet improvement
[ https://issues.apache.org/jira/browse/SLING-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10002. - Fix Version/s: Pipes 4.1.0 Assignee: Nicolas Peltier Resolution: Fixed > command servlet improvement > --- > > Key: SLING-10002 > URL: https://issues.apache.org/jira/browse/SLING-10002 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.0 > > > commnand servlet should not be a concatenation of pipes outputs, but merged > into one either json or csv, depending on the extension (we should thus > remove txt extension) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10002) command servlet improvement
Nicolas Peltier created SLING-10002: --- Summary: command servlet improvement Key: SLING-10002 URL: https://issues.apache.org/jira/browse/SLING-10002 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.0.0 Reporter: Nicolas Peltier commnand servlet should not be a concatenation of pipes outputs, but merged into one either json or csv, depending on the extension (we should thus remove txt extension) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9910) minor improvements to sling pipes
Nicolas Peltier created SLING-9910: -- Summary: minor improvements to sling pipes Key: SLING-9910 URL: https://issues.apache.org/jira/browse/SLING-9910 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.0.0 Reporter: Nicolas Peltier wrapper issue for a few improvements to be made, and i didn't want to overflow Jira with * allow path pipe to create node types using JCR (without creating a sling:resourceType property), * set default build level to java 11, * fix a few sonar issues -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9910) minor improvements to sling pipes
[ https://issues.apache.org/jira/browse/SLING-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-9910. Fix Version/s: Pipes 4.0.1 Assignee: Nicolas Peltier Resolution: Fixed > minor improvements to sling pipes > - > > Key: SLING-9910 > URL: https://issues.apache.org/jira/browse/SLING-9910 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.0.1 > > > wrapper issue for a few improvements to be made, and i didn't want to > overflow Jira with > * allow path pipe to create node types using JCR (without creating a > sling:resourceType property), > * set default build level to java 11, > * fix a few sonar issues -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9979) FilterPipe improvements
[ https://issues.apache.org/jira/browse/SLING-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-9979. -- > FilterPipe improvements > --- > > Key: SLING-9979 > URL: https://issues.apache.org/jira/browse/SLING-9979 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.2 > > > There are certain cases where filter pipe spits out an NPE, it should not > compute patterns for every execution, we should have better coverage for > certain cases -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9910) minor improvements to sling pipes
[ https://issues.apache.org/jira/browse/SLING-9910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-9910. -- > minor improvements to sling pipes > - > > Key: SLING-9910 > URL: https://issues.apache.org/jira/browse/SLING-9910 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.1.2 > > > wrapper issue for a few improvements to be made, and i didn't want to > overflow Jira with > * allow path pipe to create node types using JCR (without creating a > sling:resourceType property), > * set default build level to java 11, > * fix a few sonar issues -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-10065) make command servlet tests more robust
[
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-10065.
---
> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different
> implementation of EOL in json generation, or/and in test expectation on linux
> / windows. We should have a more robust way of testing validity of the json
> response
> {Quote}i've a problem running the unit tests on windows. surefire output see
> below.
> i assume there is a problem with line endings, can you fix the test that it
> is agnostic of unix/windows line endings?
>
> stefan
>
>
> ---
> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> ---
> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<<
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
> Time elapsed: 0.39 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...:content"],"size":5}[]
> > but was:<...:content"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
> Time elapsed: 0.265 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...tent/foo"],"size":1}[]
> > but was:<...tent/foo"],"size":1}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
> Time elapsed: 0.263 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...a/carrot"],"size":5}[]
> > but was:<...a/carrot"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-9797) move pipe should accept relative paths
[
https://issues.apache.org/jira/browse/SLING-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier closed SLING-9797.
--
> move pipe should accept relative paths
> --
>
> Key: SLING-9797
> URL: https://issues.apache.org/jira/browse/SLING-9797
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> we should be able to do something like `echo /content/foo | mv bar`
> in that case the move pipe takes parent of input resource, for the moment, we
> are forced to add path `echo /content/foo | mv ${path.one}/bar` which is not
> obvious :)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-10002) command servlet improvement
[ https://issues.apache.org/jira/browse/SLING-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-10002. --- > command servlet improvement > --- > > Key: SLING-10002 > URL: https://issues.apache.org/jira/browse/SLING-10002 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.2 > > > commnand servlet should not be a concatenation of pipes outputs, but merged > into one either json or csv, depending on the extension (we should thus > remove txt extension) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9986) pipe scripting improvements
[ https://issues.apache.org/jira/browse/SLING-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-9986. -- > pipe scripting improvements > --- > > Key: SLING-9986 > URL: https://issues.apache.org/jira/browse/SLING-9986 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.2 > > > add some improvements to scripting, at least: > * common paths to search for references, so you don't need to add full path > for commonly used pipes, > * add ability to add bindings, and build pipes (without executing them) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9977) add context aware configurations in pipes bindings
[ https://issues.apache.org/jira/browse/SLING-9977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-9977. -- > add context aware configurations in pipes bindings > -- > > Key: SLING-9977 > URL: https://issues.apache.org/jira/browse/SLING-9977 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.2 > > > we should add a pipe binding in a similar way that in scripting, > caconfig['...'] that would help having typical application configuration set > up (application roots, components type, ...) once -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8194) Remove HttpClient 3.x dependency
[ https://issues.apache.org/jira/browse/SLING-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier closed SLING-8194. -- > Remove HttpClient 3.x dependency > > > Key: SLING-8194 > URL: https://issues.apache.org/jira/browse/SLING-8194 > Project: Sling > Issue Type: Improvement > Components: pipes >Reporter: Oliver Lietz >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.2 > > > Jackrabbit switched to HttpClient 4.x, so should Pipes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9986) pipe scripting improvements
[ https://issues.apache.org/jira/browse/SLING-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-9986. Resolution: Fixed > pipe scripting improvements > --- > > Key: SLING-9986 > URL: https://issues.apache.org/jira/browse/SLING-9986 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.0.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.1.0 > > > add some improvements to scripting, at least: > * common paths to search for references, so you don't need to add full path > for commonly used pipes, > * add ability to add bindings, and build pipes (without executing them) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10065) make command servlet tests more robust
Nicolas Peltier created SLING-10065:
---
Summary: make command servlet tests more robust
Key: SLING-10065
URL: https://issues.apache.org/jira/browse/SLING-10065
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Pipes 4.0.0
Reporter: Nicolas Peltier
[~sseifert] observed a build issue that is probably due to different
implementation of EOL in json generation, or/and in test expectation on linux /
windows. We should have a more robust way of testing validity of the json
response
{Quote}i've a problem running the unit tests on windows. surefire output see
below.
i assume there is a problem with line endings, can you fix the test that it is
agnostic of unix/windows line endings?
stefan
---
Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
---
Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<<
FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
Time elapsed: 0.39 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...:content"],"size":5}[]
> but was:<...:content"],"size":5}[
]
>
at
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
Time elapsed: 0.265 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...tent/foo"],"size":1}[]
> but was:<...tent/foo"],"size":1}[
]
>
at
org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
Time elapsed: 0.263 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<...a/carrot"],"size":5}[]
> but was:<...a/carrot"],"size":5}[
]
>
at
org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10065) make command servlet tests more robust
[
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10065:
Issue Type: Bug (was: Improvement)
> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Priority: Major
>
> [~sseifert] observed a build issue that is probably due to different
> implementation of EOL in json generation, or/and in test expectation on linux
> / windows. We should have a more robust way of testing validity of the json
> response
> {Quote}i've a problem running the unit tests on windows. surefire output see
> below.
> i assume there is a problem with line endings, can you fix the test that it
> is agnostic of unix/windows line endings?
>
> stefan
>
>
> ---
> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> ---
> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<<
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
> Time elapsed: 0.39 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...:content"],"size":5}[]
> > but was:<...:content"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
> Time elapsed: 0.265 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...tent/foo"],"size":1}[]
> > but was:<...tent/foo"],"size":1}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
> Time elapsed: 0.263 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...a/carrot"],"size":5}[]
> > but was:<...a/carrot"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10065) make command servlet tests more robust
[
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10065.
-
Fix Version/s: Pipes 4.1.2
Assignee: Nicolas Peltier
Resolution: Fixed
> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different
> implementation of EOL in json generation, or/and in test expectation on linux
> / windows. We should have a more robust way of testing validity of the json
> response
> {Quote}i've a problem running the unit tests on windows. surefire output see
> below.
> i assume there is a problem with line endings, can you fix the test that it
> is agnostic of unix/windows line endings?
>
> stefan
>
>
> ---
> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> ---
> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<<
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
> Time elapsed: 0.39 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...:content"],"size":5}[]
> > but was:<...:content"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
> Time elapsed: 0.265 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...tent/foo"],"size":1}[]
> > but was:<...tent/foo"],"size":1}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
> Time elapsed: 0.263 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...a/carrot"],"size":5}[]
> > but was:<...a/carrot"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10065) make command servlet tests more robust
[
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266192#comment-17266192
]
Nicolas Peltier commented on SLING-10065:
-
interesting [~bdelacretaz] ! i had implemented a quick jsonpath feature in json
pipe
([https://github.com/apache/sling-org-apache-sling-pipes/blob/master/src/main/java/org/apache/sling/pipes/internal/inputstream/JsonPipe.java#L140)]
but didn't think to use any for unit test
> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different
> implementation of EOL in json generation, or/and in test expectation on linux
> / windows. We should have a more robust way of testing validity of the json
> response
> {Quote}i've a problem running the unit tests on windows. surefire output see
> below.
> i assume there is a problem with line endings, can you fix the test that it
> is agnostic of unix/windows line endings?
>
> stefan
>
>
> ---
> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> ---
> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<<
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
> Time elapsed: 0.39 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...:content"],"size":5}[]
> > but was:<...:content"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
> Time elapsed: 0.265 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...tent/foo"],"size":1}[]
> > but was:<...tent/foo"],"size":1}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
> Time elapsed: 0.263 s <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...a/carrot"],"size":5}[]
> > but was:<...a/carrot"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9230) Servlet should not be allowed to register with invalid ResourceTypes
[ https://issues.apache.org/jira/browse/SLING-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273429#comment-17273429 ] Nicolas Peltier commented on SLING-9230: [~bdelacretaz] [~sirin] note that such resource type validation pattern would be needed elsewhere (thinking about FilterPredicate here) > Servlet should not be allowed to register with invalid ResourceTypes > > > Key: SLING-9230 > URL: https://issues.apache.org/jira/browse/SLING-9230 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Resolver 2.6.4 >Reporter: rafiya sirin >Priority: Minor > Attachments: Screen Shot 2020-03-10 at 10.12.54 PM.png, stacktrace.txt > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Servlets are allowed to register even when the resource types are specified > as > SLING_SERVLET_RESOURCE_TYPES + "=" + "[/test,/path]" > This is invalid because getOakPath for paths starting with "[" and ending > with "]" return null. This creates an unwanted scenario where > ResourceChangeListeners fail to register with a NPE. The NPE on JCR is fixed > with commit : > [https://github.com/apache/jackrabbit-oak/commit/2e37d7a507186484e13897549681bf29b17461fc] > > However we should still fix this in sling, to not accept resource types which > start with "[" and end with "]" > JCR code which returns null : > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/impl/NamePathMapperImpl.java#L91] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10419) Script errors should give more context
[ https://issues.apache.org/jira/browse/SLING-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10419: Fix Version/s: Pipes 4.2.0 > Script errors should give more context > -- > > Key: SLING-10419 > URL: https://issues.apache.org/jira/browse/SLING-10419 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > Right now, in case an exception in a script is due to the context (current > resource), there is no way to spot it but to switch to debug log. Last > resource for which exception has occured would help here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10419) Script errors should give more context
[ https://issues.apache.org/jira/browse/SLING-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10419: Summary: Script errors should give more context (was: Script errors should give context) > Script errors should give more context > -- > > Key: SLING-10419 > URL: https://issues.apache.org/jira/browse/SLING-10419 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > > Right now, in case an exception in a script is due to the context (current > resource), there is no way to spot it but to switch to debug log. Last > resource for which exception has occured would help here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10419) Script errors should give context
Nicolas Peltier created SLING-10419: --- Summary: Script errors should give context Key: SLING-10419 URL: https://issues.apache.org/jira/browse/SLING-10419 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier Right now, in case an exception in a script is due to the context (current resource), there is no way to spot it but to switch to debug log. Last resource for which exception has occured would help here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time
Nicolas Peltier created SLING-10440: --- Summary: org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time Key: SLING-10440 URL: https://issues.apache.org/jira/browse/SLING-10440 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console for example -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10251) JsonPipe should be able to loop over key/value pairs
[ https://issues.apache.org/jira/browse/SLING-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307286#comment-17307286 ] Nicolas Peltier commented on SLING-10251: - fixed in https://github.com/apache/sling-org-apache-sling-pipes/commit/5660af99a75f36915bbd5b226c459952cb972f30 > JsonPipe should be able to loop over key/value pairs > > > Key: SLING-10251 > URL: https://issues.apache.org/jira/browse/SLING-10251 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > while array loop is done, objects are always considered as a single bindings. > There should be a way (default) when an object is the value path to loop over > key & value (jsonpipe.key and jsonpipe.value bindings being fed). > There should be an additional configruation (raw=true?) to mention we want > the value as a whole json value, that also work for arrays. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10251) JsonPipe should be able to loop over key/value pairs
[ https://issues.apache.org/jira/browse/SLING-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10251. - Fix Version/s: Pipes 4.2.0 Assignee: Nicolas Peltier Resolution: Fixed > JsonPipe should be able to loop over key/value pairs > > > Key: SLING-10251 > URL: https://issues.apache.org/jira/browse/SLING-10251 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > while array loop is done, objects are always considered as a single bindings. > There should be a way (default) when an object is the value path to loop over > key & value (jsonpipe.key and jsonpipe.value bindings being fed). > There should be an additional configruation (raw=true?) to mention we want > the value as a whole json value, that also work for arrays. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10251) JsonPipe should be able to loop over key/value pairs
Nicolas Peltier created SLING-10251: --- Summary: JsonPipe should be able to loop over key/value pairs Key: SLING-10251 URL: https://issues.apache.org/jira/browse/SLING-10251 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier while array loop is done, objects are always considered as a single bindings. There should be a way (default) when an object is the value path to loop over key & value (jsonpipe.key and jsonpipe.value bindings being fed). There should be an additional configruation (raw=true?) to mention we want the value as a whole json value, that also work for arrays. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10179:
Summary: it should be made clearer that calling FilterChain.doFilter twice
must not be done (was: it should be clearer that calling FilterChain.doFilter
twice must not be done)
> it should be made clearer that calling FilterChain.doFilter twice must not be
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-10179:
---
Assignee: Nicolas Peltier
> it should be made clearer that calling FilterChain.doFilter twice must not be
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293877#comment-17293877
]
Nicolas Peltier commented on SLING-10179:
-
and the documentation is https://github.com/apache/sling-site/pull/56
> it should be made clearer that calling FilterChain.doFilter twice must not be
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done
Nicolas Peltier created SLING-10179:
---
Summary: it should be clearer that calling FilterChain.doFilter
twice must not be done
Key: SLING-10179
URL: https://issues.apache.org/jira/browse/SLING-10179
Project: Sling
Issue Type: Improvement
Components: Engine
Affects Versions: Engine 2.7.4
Reporter: Nicolas Peltier
Right now, calling FilterChain.doFilter twice will trigger an
ArrayIndexOutOfBoundException (timer array based on the number of registered
filter handles).
Such (bad) code can trigger this:
{Code}
...
filterChain.doFilter(...)
...
if (wrongAssumption()) {
filterChain.doFilter(...);
}
...
{Code}
it's not obvious for the developer from the ArrayIndexOutOfBoundException what
he did wrong and i think we should
1. either throw a servlet exception saying "Filter should not been called
twice", either log a warning with the stack trace
2. document clearly in sling filters that filter should not be called twice,
referring to both case (ArrayIndexOufOfBoundException and whatever comes out of
1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293584#comment-17293584
]
Nicolas Peltier commented on SLING-10179:
-
it is, [~cziegeler], however the issue didn't trigger any change :) will go
with your recommendation of IllegalStateException, and document things better.
> it should be clearer that calling FilterChain.doFilter twice must not be done
> -
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Priority: Minor
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-10179) it should be clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293805#comment-17293805
]
Nicolas Peltier commented on SLING-10179:
-
[~cziegeler] code part is there
https://github.com/apache/sling-org-apache-sling-engine/pull/13
> it should be clearer that calling FilterChain.doFilter twice must not be done
> -
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10179:
Fix Version/s: Engine 2.7.6
> it should be made clearer that calling FilterChain.doFilter twice must not be
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Engine 2.7.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done
[
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10179.
-
Resolution: Fixed
> it should be made clearer that calling FilterChain.doFilter twice must not be
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
> Issue Type: Improvement
> Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Engine 2.7.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an
> ArrayIndexOutOfBoundException (timer array based on the number of registered
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException
> what he did wrong and i think we should
> 1. either throw a servlet exception saying "Filter should not been called
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice,
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out
> of 1.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10745) make write pipe copy mode work with dynamic configuration
Nicolas Peltier created SLING-10745:
---
Summary: make write pipe copy mode work with dynamic configuration
Key: SLING-10745
URL: https://issues.apache.org/jira/browse/SLING-10745
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Pipes 4.1.2
Reporter: Nicolas Peltier
write @ expr="${...}" should be working (but is not for now as expression is
evaluated at configuration time).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10741) make mixinTypes working in write pipe
[
https://issues.apache.org/jira/browse/SLING-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10741:
Summary: make mixinTypes working in write pipe (was: ['one','two'] should
not be considered a script in a pipe expression)
> make mixinTypes working in write pipe
> -
>
> Key: SLING-10741
> URL: https://issues.apache.org/jira/browse/SLING-10741
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> for whatever reason ['one','two'] get transformed in ${['one','two']} as if
> it was a script which it's not. this prevents adding mixin types (when more
> than one) as values of that property can't be something random (in the
> configuration pipe)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (SLING-10741) make mixinTypes working in write pipe
[
https://issues.apache.org/jira/browse/SLING-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reopened SLING-10741:
-
Assignee: Nicolas Peltier
> make mixinTypes working in write pipe
> -
>
> Key: SLING-10741
> URL: https://issues.apache.org/jira/browse/SLING-10741
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> for whatever reason ['one','two'] get transformed in ${['one','two']} as if
> it was a script which it's not. this prevents adding mixin types (when more
> than one) as values of that property can't be something random (in the
> configuration pipe)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10741) make mixinTypes working in write pipe
[
https://issues.apache.org/jira/browse/SLING-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10741:
Description: actually current is good enough, and just does not work with
protected values, will rather add exception for mixin types, and explicitaly
make sure that works down to the writing bits (was: for whatever reason
['one','two'] get transformed in ${['one','two']} as if it was a script which
it's not. this prevents adding mixin types (when more than one) as values of
that property can't be something random (in the configuration pipe))
> make mixinTypes working in write pipe
> -
>
> Key: SLING-10741
> URL: https://issues.apache.org/jira/browse/SLING-10741
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> actually current is good enough, and just does not work with protected
> values, will rather add exception for mixin types, and explicitaly make sure
> that works down to the writing bits
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10745) make write pipe copy mode work with dynamic configuration
[
https://issues.apache.org/jira/browse/SLING-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10745.
-
Fix Version/s: Pipes 4.2.0
Resolution: Fixed
> make write pipe copy mode work with dynamic configuration
> -
>
> Key: SLING-10745
> URL: https://issues.apache.org/jira/browse/SLING-10745
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write @ expr="${...}" should be working (but is not for now as expression is
> evaluated at configuration time).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10745) make write pipe copy mode work with dynamic configuration
[
https://issues.apache.org/jira/browse/SLING-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-10745:
---
Assignee: Nicolas Peltier
> make write pipe copy mode work with dynamic configuration
> -
>
> Key: SLING-10745
> URL: https://issues.apache.org/jira/browse/SLING-10745
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> write @ expr="${...}" should be working (but is not for now as expression is
> evaluated at configuration time).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10759) jsonpipe commands should accept complex multi line json
Nicolas Peltier created SLING-10759: --- Summary: jsonpipe commands should accept complex multi line json Key: SLING-10759 URL: https://issues.apache.org/jira/browse/SLING-10759 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier token parser is for now a bit too simple on separating args on whitespaces, and it's not always handy to have the json input stream coming from outside of the script itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10759) jsonpipe commands should accept complex multi line json
[ https://issues.apache.org/jira/browse/SLING-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10759. - Fix Version/s: Pipes 4.2.0 Assignee: Nicolas Peltier Resolution: Fixed > jsonpipe commands should accept complex multi line json > > > Key: SLING-10759 > URL: https://issues.apache.org/jira/browse/SLING-10759 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > token parser is for now a bit too simple on separating args on whitespaces, > and it's not always handy to have the json input stream coming from outside > of the script itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10773) jsonpipe's valuePath should accept dynamic values
[ https://issues.apache.org/jira/browse/SLING-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10773. - Fix Version/s: Pipes 4.2.0 Assignee: Nicolas Peltier Resolution: Fixed > jsonpipe's valuePath should accept dynamic values > - > > Key: SLING-10773 > URL: https://issues.apache.org/jira/browse/SLING-10773 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > we should allow expressions in value path for accessing different bits of a > json input depending on the pipe execution context -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10773) jsonpipe's valuePath should accept dynamic values
Nicolas Peltier created SLING-10773: --- Summary: jsonpipe's valuePath should accept dynamic values Key: SLING-10773 URL: https://issues.apache.org/jira/browse/SLING-10773 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier we should allow expressions in value path for accessing different bits of a json input depending on the pipe execution context -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10741) make mixinTypes working in write pipe
[ https://issues.apache.org/jira/browse/SLING-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10741. - Resolution: Fixed > make mixinTypes working in write pipe > - > > Key: SLING-10741 > URL: https://issues.apache.org/jira/browse/SLING-10741 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > actually current is good enough, and just does not work with protected > values, will rather add exception for mixin types, and explicitaly make sure > that works down to the writing bits -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10136) Sling Repo Init: Add option to delete paths
[ https://issues.apache.org/jira/browse/SLING-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401555#comment-17401555 ] Nicolas Peltier commented on SLING-10136: - if option goes with pipes and if you need new stuff, i plan to release some new version soon, so i'm happy adding (not huge) things in. > Sling Repo Init: Add option to delete paths > --- > > Key: SLING-10136 > URL: https://issues.apache.org/jira/browse/SLING-10136 > Project: Sling > Issue Type: New Feature > Components: Repoinit >Affects Versions: Repoinit Parser 1.6.4, Repoinit JCR 1.1.30 >Reporter: Henry Kuijpers >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Given that we are able to create paths, it would also be beneficial to be > able to delete paths as well. > In our case, we're migrating a legacy setup to Sling Repo Init, where there > are some "leftover" nodes in the instances. Given that Sling Repo Init is an > "admin" way to initialize a repo, it would be very nice if delete statements > could be supported. > In our case, we would want to delete /apps/foundation, for example, because > historically there seem to have been modifications made there. > This mandates for a simple syntax like "delete path /apps/foundation" being > supported. > Another case is that we would like to cleanup /apps/cq, however, there are > some nodes that are maintained by the product (in our case AEM), such as > /apps/cq/xssprotection and also /apps/cq/core/content/nav/tools. > This mandates for a slightly more complicated syntax such as "delete path > /apps/cq (!/xssprotection,!/core/content/nav/tools,*)", however, I would be > fine with multiple delete path statements as well, for that usecase. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10741) ['one','two'] should not be considered a script in a pipe expression
Nicolas Peltier created SLING-10741:
---
Summary: ['one','two'] should not be considered a script in a pipe
expression
Key: SLING-10741
URL: https://issues.apache.org/jira/browse/SLING-10741
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Pipes 4.1.2
Reporter: Nicolas Peltier
for whatever reason ['one','two'] get transformed in ${['one','two']} as if it
was a script which it's not. this prevents adding mixin types (when more than
one) as values of that property can't be something random (in the configuration
pipe)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10741) ['one','two'] should not be considered a script in a pipe expression
[
https://issues.apache.org/jira/browse/SLING-10741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10741.
-
Fix Version/s: Pipes 4.2.0
Resolution: Fixed
> ['one','two'] should not be considered a script in a pipe expression
>
>
> Key: SLING-10741
> URL: https://issues.apache.org/jira/browse/SLING-10741
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> for whatever reason ['one','two'] get transformed in ${['one','two']} as if
> it was a script which it's not. this prevents adding mixin types (when more
> than one) as values of that property can't be something random (in the
> configuration pipe)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10809) command executor should write down what pipe command has just been executed
[ https://issues.apache.org/jira/browse/SLING-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10809: Fix Version/s: Pipes 4.2.0 > command executor should write down what pipe command has just been executed > > > Key: SLING-10809 > URL: https://issues.apache.org/jira/browse/SLING-10809 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > in the persistence of the status of the pipe, we should have the command > executed, as a summary to find it back again, may be also the result (or the > first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10809) command executor should write down what pipe command has just been executed
Nicolas Peltier created SLING-10809: --- Summary: command executor should write down what pipe command has just been executed Key: SLING-10809 URL: https://issues.apache.org/jira/browse/SLING-10809 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier in the persistence of the status of the pipe, we should have the command executed, as a summary to find it back again, may be also the result (or the first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10809) command executor should write down what pipe command has just been executed
[ https://issues.apache.org/jira/browse/SLING-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10809: --- Assignee: Nicolas Peltier > command executor should write down what pipe command has just been executed > > > Key: SLING-10809 > URL: https://issues.apache.org/jira/browse/SLING-10809 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > in the persistence of the status of the pipe, we should have the command > executed, as a summary to find it back again, may be also the result (or the > first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10816) left tokens of pipe commands should parse expression too
Nicolas Peltier created SLING-10816:
---
Summary: left tokens of pipe commands should parse expression too
Key: SLING-10816
URL: https://issues.apache.org/jira/browse/SLING-10816
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Pipes 4.1.2
Reporter: Nicolas Peltier
write ${some.expr}=foo is not possible from commands while the pipe itself
supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10809) command executor should write down what pipe command has just been executed
[ https://issues.apache.org/jira/browse/SLING-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10809. - Resolution: Fixed > command executor should write down what pipe command has just been executed > > > Key: SLING-10809 > URL: https://issues.apache.org/jira/browse/SLING-10809 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > in the persistence of the status of the pipe, we should have the command > executed, as a summary to find it back again, may be also the result (or the > first thousand chars) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10817) NBSP should be accepted around pipe character
[ https://issues.apache.org/jira/browse/SLING-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10817. - Fix Version/s: Pipes 4.2.0 Resolution: Fixed > NBSP should be accepted around pipe character > - > > Key: SLING-10817 > URL: https://issues.apache.org/jira/browse/SLING-10817 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > writing quickly pipe commands with Alt GR (or Cmd for macbooks) generally > ends up with $ blah |rm > that will look for a pipe whose key is rm and fail -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10816) left tokens of pipe commands should parse expression too
[
https://issues.apache.org/jira/browse/SLING-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10816.
-
Resolution: Fixed
> left tokens of pipe commands should parse expression too
>
>
> Key: SLING-10816
> URL: https://issues.apache.org/jira/browse/SLING-10816
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write ${some.expr}=foo is not possible from commands while the pipe itself
> supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10816) left tokens of pipe commands should parse expression too
[
https://issues.apache.org/jira/browse/SLING-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10816:
Fix Version/s: Pipes 4.2.0
> left tokens of pipe commands should parse expression too
>
>
> Key: SLING-10816
> URL: https://issues.apache.org/jira/browse/SLING-10816
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write ${some.expr}=foo is not possible from commands while the pipe itself
> supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10816) left tokens of pipe commands should parse expression too
[
https://issues.apache.org/jira/browse/SLING-10816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier reassigned SLING-10816:
---
Assignee: Nicolas Peltier
> left tokens of pipe commands should parse expression too
>
>
> Key: SLING-10816
> URL: https://issues.apache.org/jira/browse/SLING-10816
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Pipes 4.1.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.2.0
>
>
> write ${some.expr}=foo is not possible from commands while the pipe itself
> supports it
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10419) Script errors should give more context
[ https://issues.apache.org/jira/browse/SLING-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10419. - Assignee: Nicolas Peltier Resolution: Fixed > Script errors should give more context > -- > > Key: SLING-10419 > URL: https://issues.apache.org/jira/browse/SLING-10419 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.2.0 > > > Right now, in case an exception in a script is due to the context (current > resource), there is no way to spot it but to switch to debug log. Last > resource for which exception has occured would help here -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10817) NBSP should be accepted around pipe character
[ https://issues.apache.org/jira/browse/SLING-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10817: --- Assignee: Nicolas Peltier > NBSP should be accepted around pipe character > - > > Key: SLING-10817 > URL: https://issues.apache.org/jira/browse/SLING-10817 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > writing quickly pipe commands with Alt GR (or Cmd for macbooks) generally > ends up with $ blah |rm > that will look for a pipe whose key is rm and fail -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10817) NBSP should be accepted around pipe character
Nicolas Peltier created SLING-10817: --- Summary: NBSP should be accepted around pipe character Key: SLING-10817 URL: https://issues.apache.org/jira/browse/SLING-10817 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Pipes 4.1.2 Reporter: Nicolas Peltier writing quickly pipe commands with Alt GR (or Cmd for macbooks) generally ends up with $ blah |rm that will look for a pipe whose key is rm and fail -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9517) allow simpler way to add pipes bindings
[
https://issues.apache.org/jira/browse/SLING-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-9517.
Fix Version/s: Pipes 4.3.0
Assignee: Nicolas Peltier
Resolution: Won't Fix
> allow simpler way to add pipes bindings
> ---
>
> Key: SLING-9517
> URL: https://issues.apache.org/jira/browse/SLING-9517
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> execution bindings tend to be more & more used, and having to add bindings
> all the time is cumbersome, this ticket is for having possibility in case
> e.g. we have a root binding to be able to add root=/content as a parameter,
> not binding=\{'root':'/content'}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10440) org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to time
[ https://issues.apache.org/jira/browse/SLING-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10440. - Fix Version/s: Pipes 4.3.0 Resolution: Duplicate > org.apache.sling.pipes.it.PipeModelIT.testListComponent fails from time to > time > --- > > Key: SLING-10440 > URL: https://issues.apache.org/jira/browse/SLING-10440 > Project: Sling > Issue Type: Bug > Components: Extensions >Affects Versions: Pipes 4.1.2 >Reporter: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > see > https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-pipes/job/master/74/console > for example -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9712) Move pipe should support relative path as expression
[
https://issues.apache.org/jira/browse/SLING-9712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-9712:
---
Affects Version/s: pipes
> Move pipe should support relative path as expression
>
>
> Key: SLING-9712
> URL: https://issues.apache.org/jira/browse/SLING-9712
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: Pipes 3.1.0, pipes
>Reporter: Honwai Wong
>Priority: Major
>
> The Move pipe should support relative paths as argument from the expression.
> Currently, an absolute path needs to be provided which potentially requires
> constructing the full path using ${path}/foo for example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10849. - Assignee: Nicolas Peltier Resolution: Fixed added a dependency on plumber servlet that should guarantee readiness of the servlet before the request is done (was observing responses that were default sling servlet's) > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7250) allow non persisted configurations for pipe
[ https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7250: --- Component/s: pipes > allow non persisted configurations for pipe > --- > > Key: SLING-7250 > URL: https://issues.apache.org/jira/browse/SLING-7250 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 1.1.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > > for some usage of the pipe builder, it might be useful not to persist pipes > before executing them -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9523) package pipe should not pass bad init
[ https://issues.apache.org/jira/browse/SLING-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-9523: --- Component/s: pipes > package pipe should not pass bad init > - > > Key: SLING-9523 > URL: https://issues.apache.org/jira/browse/SLING-9523 > Project: Sling > Issue Type: Bug > Components: Extensions, pipes >Affects Versions: Pipes 3.1.0 >Reporter: Nicolas Peltier >Priority: Major > > When something is badly configured with package pipe: > * no path provided, > * already existing package in another folder provided > this results in NPE at the end of referrer call execution, while we do have > the error clearly stated that would be much clearer to output -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10869: Issue Type: Improvement (was: Task) > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Priority: Major > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
Nicolas Peltier created SLING-10869: --- Summary: ability to declare (multiline) bindings in pipe scripts Key: SLING-10869 URL: https://issues.apache.org/jira/browse/SLING-10869 Project: Sling Issue Type: Task Components: pipes Affects Versions: Pipes 4.2.0 Reporter: Nicolas Peltier we should be able for sake of ease of use to add multiline bindings (csv or json mostly) to the text scripts we can reuse in a pipe declared in the same script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10869) ability to declare (multiline) bindings in pipe scripts
[ https://issues.apache.org/jira/browse/SLING-10869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10869. - Fix Version/s: Pipes 4.3.0 Assignee: Nicolas Peltier Resolution: Fixed > ability to declare (multiline) bindings in pipe scripts > --- > > Key: SLING-10869 > URL: https://issues.apache.org/jira/browse/SLING-10869 > Project: Sling > Issue Type: Improvement > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Major > Fix For: Pipes 4.3.0 > > > we should be able for sake of ease of use to add multiline bindings (csv or > json mostly) to the text scripts we can reuse in a pipe declared in the same > script -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10856: Fix Version/s: Pipes 4.3.0 > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10856: --- Assignee: Nicolas Peltier > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10856) Update to sling parent 41
Nicolas Peltier created SLING-10856: --- Summary: Update to sling parent 41 Key: SLING-10856 URL: https://issues.apache.org/jira/browse/SLING-10856 Project: Sling Issue Type: Task Components: pipes Affects Versions: Pipes 4.2.0 Reporter: Nicolas Peltier -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10856) Update to sling parent 41
[ https://issues.apache.org/jira/browse/SLING-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10856. - Resolution: Fixed > Update to sling parent 41 > - > > Key: SLING-10856 > URL: https://issues.apache.org/jira/browse/SLING-10856 > Project: Sling > Issue Type: Task > Components: pipes >Affects Versions: Pipes 4.2.0 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10849) Sling Pipes IT Test Fail
[
https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424524#comment-17424524
]
Nicolas Peltier commented on SLING-10849:
-
reproduced it once, looks like an intermittent paxexam osgi context issue.
This time
{Code}
---
Test set: org.apache.sling.pipes.it.PlumberServletIT
---
Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 20.672 s <<<
FAILURE! - in org.apache.sling.pipes.it.PlumberServletIT
org.apache.sling.pipes.it.PlumberServletIT.testListComponentJson Time elapsed:
2.139 s <<< FAILURE!
java.lang.AssertionError: there should be 2 elements expected:<2> but was:<0>
at
org.apache.sling.pipes.it.PlumberServletIT.testListComponentJson(PlumberServletIT.java:59)
{Code}
> Sling Pipes IT Test Fail
>
>
> Key: SLING-10849
> URL: https://issues.apache.org/jira/browse/SLING-10849
> Project: Sling
> Issue Type: Bug
>Reporter: Ben Zahler
>Priority: Major
> Fix For: Pipes 4.3.0
>
>
> Steps to Reproduce:
> # check out the Sling Pipes source code, master branch
> # execute "mvn clean install"
> Build fails because of IT Tests:
> [ERROR] Errors:
> [ERROR] PipeBuilderIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exa...
> [ERROR] PipeModelIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exam
> [ERROR] PlumberServletIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax
> [ERROR] PlumberTestIT » TestContainer
> [link:classpath:META-INF/links/org.ops4j.pax.exa...
> Note: "mvn clean test" command passes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier resolved SLING-10846.
-
Assignee: Nicolas Peltier
Resolution: Fixed
Hey [~lukianet], pls have a look at
https://github.com/apache/sling-org-apache-sling-pipes/commit/de3179f618476c40de8b832b1165b31364384759
and check if it's ok with you
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10847: --- Assignee: Nicolas Peltier > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-10848: --- Assignee: Nicolas Peltier > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10848. - Resolution: Fixed thanks [~benzahler] and Sonja! > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > Time Spent: 1h > Remaining Estimate: 0h > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-10847. - Resolution: Fixed thanks [~benzahler] and Sonja! > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Assignee: Nicolas Peltier >Priority: Minor > Fix For: Pipes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10847) RegexPipe: Allow Patterns from Bindings
[ https://issues.apache.org/jira/browse/SLING-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10847: Fix Version/s: PIpes 4.3.0 > RegexPipe: Allow Patterns from Bindings > --- > > Key: SLING-10847 > URL: https://issues.apache.org/jira/browse/SLING-10847 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Priority: Minor > Fix For: PIpes 4.3.0 > > > The RegexPipe has a property "pattern". Currently this can only be passed > into the pipe as a fixed string. > I would be helpful to allow the pattern to be read from existing bindings in > the execution scope, so the pattern can be passed from a previous pipe into > the RegexPipe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10848) URLs in RegexPipe: Add option to process as String
[ https://issues.apache.org/jira/browse/SLING-10848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10848: Fix Version/s: Pipes 4.3.0 > URLs in RegexPipe: Add option to process as String > -- > > Key: SLING-10848 > URL: https://issues.apache.org/jira/browse/SLING-10848 > Project: Sling > Issue Type: New Feature > Components: pipes >Reporter: Ben Zahler >Priority: Minor > Fix For: Pipes 4.3.0 > > > If the input(expression) for a RegexPipe is a url (starts with "http"), an > HTTP request to that URL is executed and the response from the HTTP is used > as the input for the RegexPipe. > We have a scenario where we would like to apply a regex to the URL as-is (as > a String). > I would likle to have an option to enable processing URLs as a string on > RegexPipes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423184#comment-17423184
]
Nicolas Peltier commented on SLING-10846:
-
i think we should keep jcr:lastModifiedBy to be user name, i like though the
tracking of pipe used for that modification. May be in another property.
I wonder also if we should not need an opt out for that last property
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Component/s: (was: Extensions)
pipes
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: pipes
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Component/s: Extensions
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-10849) Sling Pipes IT Test Fail
[ https://issues.apache.org/jira/browse/SLING-10849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-10849: Fix Version/s: Pipes 4.3.0 > Sling Pipes IT Test Fail > > > Key: SLING-10849 > URL: https://issues.apache.org/jira/browse/SLING-10849 > Project: Sling > Issue Type: Bug >Reporter: Ben Zahler >Priority: Major > Fix For: Pipes 4.3.0 > > > Steps to Reproduce: > # check out the Sling Pipes source code, master branch > # execute "mvn clean install" > Build fails because of IT Tests: > [ERROR] Errors: > [ERROR] PipeBuilderIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > [ERROR] PipeModelIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exam > [ERROR] PlumberServletIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax > [ERROR] PlumberTestIT » TestContainer > [link:classpath:META-INF/links/org.ops4j.pax.exa... > Note: "mvn clean test" command passes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-10846) Sling Pipes to write metadata on modified resources
[
https://issues.apache.org/jira/browse/SLING-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Peltier updated SLING-10846:
Fix Version/s: Pipes 4.3.0
> Sling Pipes to write metadata on modified resources
> ---
>
> Key: SLING-10846
> URL: https://issues.apache.org/jira/browse/SLING-10846
> Project: Sling
> Issue Type: Improvement
>Reporter: Mariia Lukianets
>Priority: Minor
> Fix For: Pipes 4.3.0
>
>
> h4. Background
> Sling Pipes modify content without leaving a trace in the repository.
> Developers should have the ability to mark resources modified by the Sling
> Pipe. While modifying the resource, the 'Write' Sling pipe could also set
> metadata info indicating the time of modification and the author of the
> change.
> *Example*: pipe 'enable-foo' sets the property foo=true on nodeA.
> without metadata:
> nodeA
> foo=true
> with metadata:
> nodeA
> foo = true
> jcr:lastModified = 2021-08-09T11:06:56.753+02:00
> jcr:lastModifiedBy = sling-pipe-enable-foo
> h4.
> h4. Suggestion
> To add a 'metadata' flag to content modification pipes. When set to true, the
> pipe will set 2 properties on each modified resource:
> * 'jcr:lastModified' - current server's DateTime.
> * 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name}'
> By default, the metadata flag is set to false and will do nothing.
> Q1. should we make 'jcr:lastModifiedBy' - 'sling-pipe-${pipe_name} on behalf
> of ${user}'?
> Q2. what other pipes to adapt
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-11041) CsvPipe: InputStream closed before Iterator is finished
[
https://issues.apache.org/jira/browse/SLING-11041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469227#comment-17469227
]
Nicolas Peltier commented on SLING-11041:
-
[~luckyluke80] we could also move the IS closing to the "after" hook.
> CsvPipe: InputStream closed before Iterator is finished
> ---
>
> Key: SLING-11041
> URL: https://issues.apache.org/jira/browse/SLING-11041
> Project: Sling
> Issue Type: Bug
> Components: pipes
>Affects Versions: Pipes 4.3.0
>Reporter: Lukas Kummer
>Priority: Major
>
> When using the
> [CsvPipe|https://sling.apache.org/documentation/bundles/sling-pipes/readers.html#csv-pipe-csv-expr-1]
> and using a remote source for the expr such as:
> {code:java}
> csv
> https://raw.githubusercontent.com/apache/sling-org-apache-sling-pipes/5660af99a75f36915bbd5b226c459952cb972f30/src/test/resources/standardTest.csv
> | echo ${item.apple}
> {code}
> an Exception will be thrown, that `next()` cannot be called because the
> stream is closed. The reason is, that the AbstractInputStreamPipe is [closing
> the InputStream
> quietly|https://github.com/apache/sling-org-apache-sling-pipes/blob/5660af99a75f36915bbd5b226c459952cb972f30/src/main/java/org/apache/sling/pipes/AbstractInputStreamPipe.java#L118]
> before the CsvIterator has finished it's task.
> One solution could be to delegate the task of closing the InputStream to the
> inherited classes of the Abstract Class (CsvPipe, JsonPipe, RegexPipe).
> Another solution could be to create an AbstractIterator. This iterator could
> also read in the InputStream to a defined size (to limit the used memory)
> into a String. This String can then be used again to create a stream.
> This problem mainly affects CsvPipe and RegexPipe for remote connections. It
> does not affect the JsonPipe because the JsonPipe is reading in the full
> String from the InputStream.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SLING-7729) add basic auth to AbstractInputStreamPipe
[ https://issues.apache.org/jira/browse/SLING-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-7729: --- Component/s: pipes > add basic auth to AbstractInputStreamPipe > - > > Key: SLING-7729 > URL: https://issues.apache.org/jira/browse/SLING-7729 > Project: Sling > Issue Type: Improvement > Components: Extensions, pipes >Affects Versions: Pipes 2.0.2 >Reporter: Nicolas Peltier >Priority: Major > > being able to point to an URL with AbstractInputStreamPipe is cool, would be > even better if we could set credentials -- This message was sent by Atlassian Jira (v8.20.1#820001)
