[jira] [Assigned] (SLING-3236) Unable to change node primary type once created
[ https://issues.apache.org/jira/browse/SLING-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3236: -- Assignee: Robert Munteanu Unable to change node primary type once created --- Key: SLING-3236 URL: https://issues.apache.org/jira/browse/SLING-3236 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Consider the following scenario in a Sling content module: - folder is created in the project - folder is synced and created in the repo with a nt:folder primary type - a .content.xml file is added and the primary type set to sling:Folder At this point the the primary type is not updated in the repository and additional metadata is not updated. Originally reported by [~dsuess] -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3550) Inspect bundles for deployment for well-known errors
Robert Munteanu created SLING-3550: -- Summary: Inspect bundles for deployment for well-known errors Key: SLING-3550 URL: https://issues.apache.org/jira/browse/SLING-3550 Project: Sling Issue Type: New Feature Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.2 We should validate that the bundle's output directory contains at least * a META-INF/MANIFEST.MF file * DS descriptors if the Service-Component header is present This should cover almost all of the troubles hit when bundle deployment does not work as expected -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3551) Content sync does not propagate mixin types
Robert Munteanu created SLING-3551:
--
Summary: Content sync does not propagate mixin types
Key: SLING-3551
URL: https://issues.apache.org/jira/browse/SLING-3551
Project: Sling
Issue Type: Bug
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Assume that we have a full coverage aggregate as follows:
{code}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:sling=http://sling.apache.org/jcr/sling/1.0;
xmlns:vlt=http://www.day.com/jcr/vault/1.0;
xmlns:jcr=http://www.jcp.org/jcr/1.0;
jcr:mixinTypes=[mix:language]
jcr:primaryType=nt:folder
jcr:language=en
message
jcr:primaryType=sling:MessageEntry
sling:key=message
sling:value=Message
/message
error
jcr:primaryType=sling:MessageEntry
sling:key=error
sling:value=Error
/error
warning
jcr:primaryType=sling:MessageEntry
sling:key=warning
sling:value=Warning
/warning
/jcr:root
{code}
When synced to the repo this will fail with the following message
{quote}!MESSAGE Failed publishing JcrResult[ success:false, exception:
org.apache.sling.ide.transport.RepositoryException -
javax.jcr.nodetype.ConstraintViolationException: no matching property
definition found for {http://www.jcp.org/jcr/1.0}language]{quote}
The reason is that the jcr:mixinTypes property is protected, and therefore
skipped. We need to handle this explicitly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-2635) [Tooling] Logging framework for Slingclipse
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-2635. Resolution: Fixed [Tooling] Logging framework for Slingclipse --- Key: SLING-2635 URL: https://issues.apache.org/jira/browse/SLING-2635 Project: Sling Issue Type: Improvement Components: IDE Reporter: Antonio Sanso Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: SLING-2635.diff We need a Logging framework for Slingclipse. I see two options at the moment: - using a log framework as SLF4J logger or other similar - using the embedded Eclipse logging framework -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3236) Unable to change node primary type once created
[ https://issues.apache.org/jira/browse/SLING-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993913#comment-13993913 ] Robert Munteanu commented on SLING-3236: * http://svn.apache.org/viewvc?view=revisionrevision=1593616 fix Poller timing out too fast * http://svn.apache.org/viewvc?view=revisionrevision=1593617 poller now propagates the last caught throwable in all situations * http://svn.apache.org/viewvc?view=revisionrevision=1593618 update the node's primary type if necessary ( + IT ) * http://svn.apache.org/viewvc?view=revisionrevision=1593619 use a common location in the repository for all methods of the ContentDeploymentTest Unable to change node primary type once created --- Key: SLING-3236 URL: https://issues.apache.org/jira/browse/SLING-3236 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Consider the following scenario in a Sling content module: - folder is created in the project - folder is synced and created in the repo with a nt:folder primary type - a .content.xml file is added and the primary type set to sling:Folder At this point the the primary type is not updated in the repository and additional metadata is not updated. Originally reported by [~dsuess] -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-2651) Manually trigger sync on files/directories
[
https://issues.apache.org/jira/browse/SLING-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998105#comment-13998105
]
Robert Munteanu commented on SLING-2651:
The Export wizard incorrectly tries to sync some .content.xml files as proper
resources. I probably missed porting some logic from the
SlingLaunchpadBehaviour . The reported error is
{code}[May 15, 2014 12:44:00 AM EEST] AddOrUpdateNodeCommand -
/apps/sling/servlet/default/acl.html.esp : JcrResult[ success:false, exception:
org.apache.sling.ide.transport.RepositoryException -
java.io.FileNotFoundException:
/home/ADOBENET/rmuntean/w/runtime-sling-ide-tooling/content/jcr_root/apps/sling/servlet/default/acl.html.esp.dir
(Is a directory)] (23 ms)
org.apache.sling.ide.transport.RepositoryException:
java.io.FileNotFoundException:
/home/ADOBENET/rmuntean/w/runtime-sling-ide-tooling/content/jcr_root/apps/sling/servlet/default/acl.html.esp.dir
(Is a directory)
at org.apache.sling.ide.impl.vlt.JcrResult.failure(JcrResult.java:33)
at org.apache.sling.ide.impl.vlt.JcrCommand.execute(JcrCommand.java:64)
at
org.apache.sling.ide.transport.TracingCommand.execute(TracingCommand.java:43)
at
org.apache.sling.ide.eclipse.ui.internal.ExportWizard$1$2.visit(ExportWizard.java:88)
at
org.eclipse.core.internal.resources.Resource$2.visit(Resource.java:126)
at
org.eclipse.core.internal.resources.Resource$1.visitElement(Resource.java:85)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:82)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at
org.eclipse.core.internal.watson.ElementTreeIterator.doIteration(ElementTreeIterator.java:86)
at
org.eclipse.core.internal.watson.ElementTreeIterator.iterate(ElementTreeIterator.java:127)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:95)
at org.eclipse.core.internal.resources.Resource.accept(Resource.java:52)
at
org.eclipse.core.internal.resources.Resource.accept(Resource.java:124)
at
org.eclipse.core.internal.resources.Resource.accept(Resource.java:108)
at
org.apache.sling.ide.eclipse.ui.internal.ExportWizard$1.run(ExportWizard.java:80)
at
org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Caused by: java.io.FileNotFoundException:
/home/ADOBENET/rmuntean/w/runtime-sling-ide-tooling/content/jcr_root/apps/sling/servlet/default/acl.html.esp.dir
(Is a directory)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.init(FileInputStream.java:146)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.updateFileLikeNodeTypes(AddOrUpdateNodeCommand.java:411)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.updateNode(AddOrUpdateNodeCommand.java:226)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.update(AddOrUpdateNodeCommand.java:98)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:81)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:1)
at org.apache.sling.ide.impl.vlt.JcrCommand.execute(JcrCommand.java:54)
... 17 more
{code}
Manually trigger sync on files/directories
--
Key: SLING-2651
URL: https://issues.apache.org/jira/browse/SLING-2651
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Antonio Sanso
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
We should be able to manually publish a subtree of content, as opposed to the
sync happening in the background. One use case is where the auto-sync is
disabled and the user only wants to publish the changes manually.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3553) Run FindBugs (and fix accordingly) on Sling Replication code
[ https://issues.apache.org/jira/browse/SLING-3553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996209#comment-13996209 ] Robert Munteanu commented on SLING-3553: See also INFRA-6539, where I tried to get our Sonar job running on the ASF Sonar instance. Run FindBugs (and fix accordingly) on Sling Replication code Key: SLING-3553 URL: https://issues.apache.org/jira/browse/SLING-3553 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Tommaso Teofili Assignee: Tommaso Teofili Priority: Trivial Labels: replication Sling Replication code has grown over time and I'd like to a) fix current problems as reported by FindBugs b) add a reporting entry to the pom.xml in order to be continuously able to check eventual problems. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3122) Incorrect filtering for full coverage nodes
[ https://issues.apache.org/jira/browse/SLING-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3122. Resolution: Fixed * http://svn.apache.org/viewvc?view=revisionrevision=1594242 - ProjectAdapter now rejects empty input streams * http://svn.apache.org/viewvc?view=revisionrevision=1594243 - add RepositoryAccessor.creatNode * http://svn.apache.org/viewvc?view=revisionrevision=1594244 - take the real repository path into account when filtering Incorrect filtering for full coverage nodes --- Key: SLING-3122 URL: https://issues.apache.org/jira/browse/SLING-3122 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 With the following filter ?xml version=1.0 encoding=UTF-8? workspaceFilter version=1.0 filter root=/content/slingDemo/ filter root=/apps/slingDemo/ filter root=/var/full-coverage/ /workspaceFilter changes to /var/full-coverage.xml not synced, were that is file corresponds to a node with full coverage present at /var/full-coverage -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3236) Unable to change node primary type once created
[ https://issues.apache.org/jira/browse/SLING-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993913#comment-13993913 ] Robert Munteanu edited comment on SLING-3236 at 5/9/14 9:02 PM: * http://svn.apache.org/viewvc?view=revisionrevision=1593616 fix Poller timing out too fast * http://svn.apache.org/viewvc?view=revisionrevision=1593617 poller now propagates the last caught throwable in all situations * http://svn.apache.org/viewvc?view=revisionrevision=1593618 update the node's primary type if necessary ( + IT ) * http://svn.apache.org/viewvc?view=revisionrevision=1593619 use a common location in the repository for all methods of the ContentDeploymentTest was (Author: rombert): * http://svn.apache.org/viewvc?view=revisionrevision=1593616 fix Poller timing out too fast * http://svn.apache.org/viewvc?view=revisionrevision=1593617 poller now propagates the last caught throwable in all situations * http://svn.apache.org/viewvc?view=revisionrevision=1593618 update the node's primary type if necessary ( + IT ) * http://svn.apache.org/viewvc?view=revisionrevision=1593619 use a common location in the repository for all methods of the ContentDeploymentTest Unable to change node primary type once created --- Key: SLING-3236 URL: https://issues.apache.org/jira/browse/SLING-3236 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Consider the following scenario in a Sling content module: - folder is created in the project - folder is synced and created in the repo with a nt:folder primary type - a .content.xml file is added and the primary type set to sling:Folder At this point the the primary type is not updated in the repository and additional metadata is not updated. Originally reported by [~dsuess] -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-2666) Resource transport layer - checking out resources fails if the DefaultGetServlet does not serve the content
[ https://issues.apache.org/jira/browse/SLING-2666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-2666: -- Assignee: (was: Robert Munteanu) Resource transport layer - checking out resources fails if the DefaultGetServlet does not serve the content --- Key: SLING-2666 URL: https://issues.apache.org/jira/browse/SLING-2666 Project: Sling Issue Type: Bug Components: IDE Reporter: Antonio Sanso Priority: Minor Fix For: Sling Eclipse IDE 1.0.2 see discussion at [0] [0] http://sling.markmail.org/message/rsmysnx6ombk4u4s -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3551) Content sync does not propagate mixin types
[
https://issues.apache.org/jira/browse/SLING-3551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3551.
Resolution: Fixed
Content sync does not propagate mixin types
---
Key: SLING-3551
URL: https://issues.apache.org/jira/browse/SLING-3551
Project: Sling
Issue Type: Bug
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Assume that we have a full coverage aggregate as follows:
{code}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:sling=http://sling.apache.org/jcr/sling/1.0;
xmlns:vlt=http://www.day.com/jcr/vault/1.0;
xmlns:jcr=http://www.jcp.org/jcr/1.0;
jcr:mixinTypes=[mix:language]
jcr:primaryType=nt:folder
jcr:language=en
message
jcr:primaryType=sling:MessageEntry
sling:key=message
sling:value=Message
/message
error
jcr:primaryType=sling:MessageEntry
sling:key=error
sling:value=Error
/error
warning
jcr:primaryType=sling:MessageEntry
sling:key=warning
sling:value=Warning
/warning
/jcr:root
{code}
When synced to the repo this will fail with the following message
{quote}!MESSAGE Failed publishing JcrResult[ success:false, exception:
org.apache.sling.ide.transport.RepositoryException -
javax.jcr.nodetype.ConstraintViolationException: no matching property
definition found for {http://www.jcp.org/jcr/1.0}language]{quote}
The reason is that the jcr:mixinTypes property is protected, and therefore
skipped. We need to handle this explicitly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
[
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998841#comment-13998841
]
Robert Munteanu commented on SLING-3567:
That code hasn't changed in some time, so I'm not sure what triggered this
problem. Just to be on the safe side, what SVN revision did you build the
project from?
Cannot add null entries, when creating a new bundle and adding it to an
existing server
---
Key: SLING-3567
URL: https://issues.apache.org/jira/browse/SLING-3567
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
With the most recent version of Sling IDE Tooling I get the following
exception when adding a new Sling bundle project and adding it to an existing
server:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
at
org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
at
[jira] [Resolved] (SLING-3566) Properties from extended file aggregates are not synchronized
[
https://issues.apache.org/jira/browse/SLING-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3566.
Resolution: Fixed
As it turns out, this worked but I wrote the tests incorrectly. Nevertheless,
we have one more automated test for the sync process.
* http://svn.apache.org/viewvc?view=revisionrevision=1594912 - added tracing
to the impl-vlt plugin
* http://svn.apache.org/viewvc?view=revisionrevision=1594913 - added a
PropertyMatcher
- http://svn.apache.org/viewvc?view=revisionrevision=1594914 - added test to
validate the scenario of this bug
Properties from extended file aggregates are not synchronized
-
Key: SLING-3566
URL: https://issues.apache.org/jira/browse/SLING-3566
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Assume the following directory structure
{code}
.
├── ace.html.esp
├── ace.html.esp.dir
│ ├── .content.xml
{code}
where .content.xml contains
{code}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:jcr=http://www.jcp.org/jcr/1.0;
xmlns:nt=http://www.jcp.org/jcr/nt/1.0;
jcr:primaryType=nt:file
jcr:content
jcr:lastModifiedBy=admin
jcr:mimeType=text/javascript
jcr:primaryType=nt:resource/
/jcr:root
{code}
Changes to the jcr:mimeType are not registered, since we don't descend down
the jcr:content node when updating file-like nodes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3564) it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: Invalid thread access
[
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3564:
---
Summary: it tests in tooling/ide/eclipse-test fail on MacOS X with
SWTException: Invalid thread access (was: it tests in tooling/ide/eclipse-test
fail (for me) with SWTException: Invalid thread access)
it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException:
Invalid thread access
-
Key: SLING-3564
URL: https://issues.apache.org/jira/browse/SLING-3564
Project: Sling
Issue Type: Bug
Components: IDE
Environment: mac os x, 10.7.5, java version 1.6.0_65
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3564-1.diff
When I run 'mvn clean install' in tooling/ide I get a failure in
tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in
eclipse-test):
{code}
***WARNING: Display must be created on main thread due to Cocoa restrictions.
{code}
and the corresponding
tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
{code}
org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:4397)
at org.eclipse.swt.SWT.error(SWT.java:4312)
at org.eclipse.swt.SWT.error(SWT.java:4283)
at org.eclipse.swt.widgets.Display.error(Display.java:1076)
at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
at org.eclipse.swt.widgets.Display.create(Display.java:816)
at org.eclipse.swt.graphics.Device.init(Device.java:130)
at org.eclipse.swt.widgets.Display.init(Display.java:707)
at org.eclipse.swt.widgets.Display.init(Display.java:698)
at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
at
org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
at
org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3520) Consolidate archetype plugin versions in a parent pom
[ https://issues.apache.org/jira/browse/SLING-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998582#comment-13998582 ] Robert Munteanu commented on SLING-3520: Archetypes now use the released parent pom - http://svn.apache.org/viewvc?view=revisionrevision=1594818 Consolidate archetype plugin versions in a parent pom - Key: SLING-3520 URL: https://issues.apache.org/jira/browse/SLING-3520 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Archetype Parent Version 1 Attachments: SLING-3520-1.patch, SLING-3520-2.patch Currently all plugin versions used in generated archetypes are maintained in each pom. This makes it difficult to update the used versions, and many archetypes now have outdated plugin versions. To make maintenance easier, we should create an archetype parent which centralises these settings. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3165) Cannot remove Bundle or Content Package Module from Server
[ https://issues.apache.org/jira/browse/SLING-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3165: -- Assignee: Robert Munteanu Cannot remove Bundle or Content Package Module from Server -- Key: SLING-3165 URL: https://issues.apache.org/jira/browse/SLING-3165 Project: Sling Issue Type: Bug Components: IDE Reporter: Justin Edelson Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 From the Servers view, right clicking on a module (bundle or content package) includes a Remove option which opens a confirmation dialog, but this doesn't seem to do anything. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3566) Properties from extended file aggregates are not synchronized
Robert Munteanu created SLING-3566:
--
Summary: Properties from extended file aggregates are not
synchronized
Key: SLING-3566
URL: https://issues.apache.org/jira/browse/SLING-3566
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Assume the following directory structure
{code}
.
├── ace.html.esp
├── ace.html.esp.dir
│ ├── .content.xml
{code}
where .content.xml contains
{code}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:jcr=http://www.jcp.org/jcr/1.0;
xmlns:nt=http://www.jcp.org/jcr/nt/1.0;
jcr:primaryType=nt:file
jcr:content
jcr:lastModifiedBy=admin
jcr:mimeType=text/javascript
jcr:primaryType=nt:resource/
/jcr:root
{code}
Changes to the jcr:mimeType are not registered, since we don't descend down the
jcr:content node when updating file-like nodes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
[
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998860#comment-13998860
]
Robert Munteanu edited comment on SLING-3567 at 5/15/14 3:49 PM:
-
I've committed a potential fix in
http://svn.apache.org/viewvc?view=revisionrevision=1594956, can you check if
this solves the problem for you?
was (Author: rombert):
I've committed a potential fix in
http://svn.apache.org/viewvc?view=revisionrevision=r1594956, can you check if
this solves the problem for you?
Cannot add null entries, when creating a new bundle and adding it to an
existing server
---
Key: SLING-3567
URL: https://issues.apache.org/jira/browse/SLING-3567
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
With the most recent version of Sling IDE Tooling I get the following
exception when adding a new Sling bundle project and adding it to an existing
server:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at
[jira] [Assigned] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
[
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-3567:
--
Assignee: Robert Munteanu
Cannot add null entries, when creating a new bundle and adding it to an
existing server
---
Key: SLING-3567
URL: https://issues.apache.org/jira/browse/SLING-3567
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
With the most recent version of Sling IDE Tooling I get the following
exception when adding a new Sling bundle project and adding it to an existing
server:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
at
org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
at
org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
at
[jira] [Resolved] (SLING-3559) Never run project launches when publishing
[ https://issues.apache.org/jira/browse/SLING-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3559. Resolution: Fixed Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1595033 Never run project launches when publishing -- Key: SLING-3559 URL: https://issues.apache.org/jira/browse/SLING-3559 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 The SlingLaunchpadBehaviour still runs project launches if they exist. I don't think that's needed anymore, as the content sync code should be good enough, and launches are reserved for other tasks. As such, we should remove that code. [~egli] - is there anything that I missed? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time
[
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999758#comment-13999758
]
Robert Munteanu commented on SLING-3081:
{quote}The new-project-wizard will also start the server of course and
up-till-now was assuming the publish would automatically start. That we can
still trigger explicitly from the wizard though, so no issue there.{quote}
Sounds good
Do not re-publish modules when starting the launchpad for the first time
Key: SLING-3081
URL: https://issues.apache.org/jira/browse/SLING-3081
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.2
This results in unnecessary publishing activity. The right way is to provide
a manual action to sync a sub-tree to ( or the whole module ) to the
Launchpad.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-2651) Manually trigger sync on files/directories
[ https://issues.apache.org/jira/browse/SLING-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998242#comment-13998242 ] Robert Munteanu commented on SLING-2651: * http://svn.apache.org/viewvc?view=revisionrevision=r1594750 - allow import from arbitray paths Manually trigger sync on files/directories -- Key: SLING-2651 URL: https://issues.apache.org/jira/browse/SLING-2651 Project: Sling Issue Type: Improvement Components: IDE Reporter: Antonio Sanso Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should be able to manually publish a subtree of content, as opposed to the sync happening in the background. One use case is where the auto-sync is disabled and the user only wants to publish the changes manually. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3165) Cannot remove Bundle or Content Package Module from Server
[ https://issues.apache.org/jira/browse/SLING-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3165. Resolution: Fixed Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1594935 Cannot remove Bundle or Content Package Module from Server -- Key: SLING-3165 URL: https://issues.apache.org/jira/browse/SLING-3165 Project: Sling Issue Type: Bug Components: IDE Reporter: Justin Edelson Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 From the Servers view, right clicking on a module (bundle or content package) includes a Remove option which opens a confirmation dialog, but this doesn't seem to do anything. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore files
[ https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3161. Resolution: Fixed I've added .vltignore logic, but just for importing. Let's see if we need something else. * http://svn.apache.org/viewvc?view=revisionrevision=1595203 added EclipseResourceMatchers * http://svn.apache.org/viewvc?view=revisionrevision=1595205 added RepositoryAccessor.createFile * http://svn.apache.org/viewvc?view=revisionrevision=1595207 added ContentImportTest.importFilesAndFolders * http://svn.apache.org/viewvc?view=revisionrevision=1595208 added ContentImportTest.importFilesAndFoldersRespectsVltFilters * http://svn.apache.org/viewvc?view=revisionrevision=1595209 add an IgnoredResources abstraction in the api project. * http://svn.apache.org/viewvc?view=revisionrevision=1595210 respect found .vltignore files found when importing. * http://svn.apache.org/viewvc?view=revisionrevision=1595211 take into account .vltignore files which are present under the content sync root but not under the import root. SlingIDE Import Content wizard should respect .vltignore files -- Key: SLING-3161 URL: https://issues.apache.org/jira/browse/SLING-3161 Project: Sling Issue Type: Bug Components: IDE Reporter: Justin Edelson Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Given in repository: /apps/foo/install /apps/foo/install/.vltignore = *.jar /apps/foo/install/foo.jar Then running import content should not copy foo.jar into the local working copy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3569) Fix test suite on Windows
[ https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1350#comment-1350 ] Robert Munteanu commented on SLING-3569: It seems that on Windows the Sling launchpad does not start, see [^BundleDeploymentTest-windows-error.txt]. Fix test suite on Windows - Key: SLING-3569 URL: https://issues.apache.org/jira/browse/SLING-3569 Project: Sling Issue Type: Test Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: BundleDeploymentTest-windows-error.txt Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt ones fail. For the eclipse-test ones, it seems that no connection is made to the launchpad. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1376#comment-1376 ] Robert Munteanu commented on SLING-3174: [~egli] - what do you think is still missing here? A wizard for creating a content project? A wizard for creating a plain ( non-Maven ) bundle project? [Tooling] add 'new simple content/bundle project' wizards - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3569) Fix test suite on Windows
[ https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3569. Resolution: Fixed The issues were most about PermGen size, JVM ergonomics are different on Windows. All tests now pass * http://svn.apache.org/viewvc?view=revisionrevision=1595254 fix VltSerializationManagerTest when running on Windows * http://svn.apache.org/viewvc?view=revisionrevision=1595263 ensure that the test Eclipse instance has enough PermGen * http://svn.apache.org/viewvc?view=revisionrevision=1595264 added a README.md file which explains the PermGen requirements Fix test suite on Windows - Key: SLING-3569 URL: https://issues.apache.org/jira/browse/SLING-3569 Project: Sling Issue Type: Test Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: BundleDeploymentTest-windows-error.txt Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt ones fail. For the eclipse-test ones, it seems that no connection is made to the launchpad. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3564) it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: Invalid thread access
[
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999216#comment-13999216
]
Robert Munteanu edited comment on SLING-3564 at 5/15/14 9:00 PM:
-
So this particular issue is fixed - commited in
http://svn.apache.org/viewvc?view=revisionrevision=1595036 . Please open a new
issue about the BundleDeploymentTest. A couple of thoughts
- you can inspect the error log of the sling launchpad
tooling/ide/eclipse-test/target/sling/_/logs ; perhaps there are some error
logged in there ; or perhaps the tooling bundle was not installed during the
test
- you can try increasing the timeout in the Poller class, although I don't
think it's a timing issue - 5 seconds are more than enough
- you can try running the test as a plug-in test from within Eclipse ; it tries
to find a Sling launchpad on port 8080
- perhaps you have an older tooling support bundle installed? You can try
bumping the dependency to 1.0.1-SNAPSHOT ( 1.0.0 vote is still underway ) and
see what that does
was (Author: rombert):
So this particular issue is fixed - commited in
http://svn.apache.org/viewvc?view=revisionrevision=1595036 . Please open a new
issue about the BundleDeploymentTest. A couple of thoughts
- you can inspect the error log of the sling launchpad
tooling/ide/eclipse-test/target/sling/_/logs ; perhaps there are some error
logged in there ; or perhaps the tooling bundle was not installed during the
test
-you can try increasing the timeout in the Poller class, although I don't
think it's a timing issue - 5 seconds are more than enough
- you can try running the test as a plug-in test from within Eclipse ; it
tries to find a Sling launchpad on port 8080
it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException:
Invalid thread access
-
Key: SLING-3564
URL: https://issues.apache.org/jira/browse/SLING-3564
Project: Sling
Issue Type: Bug
Components: IDE
Environment: mac os x, 10.7.5, java version 1.6.0_65
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3564-1.diff
When I run 'mvn clean install' in tooling/ide I get a failure in
tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in
eclipse-test):
{code}
***WARNING: Display must be created on main thread due to Cocoa restrictions.
{code}
and the corresponding
tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
{code}
org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:4397)
at org.eclipse.swt.SWT.error(SWT.java:4312)
at org.eclipse.swt.SWT.error(SWT.java:4283)
at org.eclipse.swt.widgets.Display.error(Display.java:1076)
at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
at org.eclipse.swt.widgets.Display.create(Display.java:816)
at org.eclipse.swt.graphics.Device.init(Device.java:130)
at org.eclipse.swt.widgets.Display.init(Display.java:707)
at org.eclipse.swt.widgets.Display.init(Display.java:698)
at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
at
org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
at
org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
[jira] [Updated] (SLING-3569) Fix test suite on Windows
[ https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3569: --- Attachment: BundleDeploymentTest-windows-error.txt Fix test suite on Windows - Key: SLING-3569 URL: https://issues.apache.org/jira/browse/SLING-3569 Project: Sling Issue Type: Test Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: BundleDeploymentTest-windows-error.txt Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt ones fail. For the eclipse-test ones, it seems that no connection is made to the launchpad. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3569) Fix test suite on Windows
[ https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3569: -- Assignee: Robert Munteanu Fix test suite on Windows - Key: SLING-3569 URL: https://issues.apache.org/jira/browse/SLING-3569 Project: Sling Issue Type: Test Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt ones fail. For the eclipse-test ones, it seems that no connection is made to the launchpad. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3569) Fix test suite on Windows
Robert Munteanu created SLING-3569: -- Summary: Fix test suite on Windows Key: SLING-3569 URL: https://issues.apache.org/jira/browse/SLING-3569 Project: Sling Issue Type: Test Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt ones fail. For the eclipse-test ones, it seems that no connection is made to the launchpad. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3115) Deleting files and folders does not work on Windows
[ https://issues.apache.org/jira/browse/SLING-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3115: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.2) Sling Eclipse IDE 1.0.0 Deleting files and folders does not work on Windows --- Key: SLING-3115 URL: https://issues.apache.org/jira/browse/SLING-3115 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 [September 25, 2013 12:07:23 PM EEST] AddOrUpdateNodeCommand - /var/my-folder : JcrResult[ success:true] (78 ms) [September 25, 2013 12:07:23 PM EEST] AddOrUpdateNodeCommand - /var/my-folder/some-file.txt : JcrResult[ success:true] (110 ms) [September 25, 2013 12:07:34 PM EEST] DeleteNodeCommand - /var/my-folder : JcrResult[ success:true] (78 ms) [September 25, 2013 12:07:34 PM EEST] DeleteNodeCommand - /var\my-folder/some-file.txt : JcrResult[ success:true] (47 ms) -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3564) it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid thread access
[
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998629#comment-13998629
]
Robert Munteanu commented on SLING-3564:
Can you try the attached diff and see if it fixes the build for you? In the
tooling/ide directory, apply it with patch -p3 SLING-3564-1.diff
it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid
thread access
---
Key: SLING-3564
URL: https://issues.apache.org/jira/browse/SLING-3564
Project: Sling
Issue Type: Bug
Components: IDE
Environment: mac os x, 10.7.5, java version 1.6.0_65
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3564-1.diff
When I run 'mvn clean install' in tooling/ide I get a failure in
tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in
eclipse-test):
{code}
***WARNING: Display must be created on main thread due to Cocoa restrictions.
{code}
and the corresponding
tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
{code}
org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:4397)
at org.eclipse.swt.SWT.error(SWT.java:4312)
at org.eclipse.swt.SWT.error(SWT.java:4283)
at org.eclipse.swt.widgets.Display.error(Display.java:1076)
at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
at org.eclipse.swt.widgets.Display.create(Display.java:816)
at org.eclipse.swt.graphics.Device.init(Device.java:130)
at org.eclipse.swt.widgets.Display.init(Display.java:707)
at org.eclipse.swt.widgets.Display.init(Display.java:698)
at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
at
org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
at
org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository
[
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999752#comment-13999752
]
Robert Munteanu commented on SLING-3571:
[~egli] I'm starting to get lots of test failures in the eclipse-test module.
Can you please look into this?
{code}Failed tests:
changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest):
Unexpected IStatus when starting server
deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest):
Unexpected IStatus when starting server
deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected
IStatus when starting server
reorderNodesFromNestedFullCoverageAggregate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
Unexpected IStatus when starting server
deployNestedFullCoverageAggregate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
Unexpected IStatus when starting server
deployNestedFullCoverageAggregateAtFilterRoot(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
Unexpected IStatus when starting server
deleteNodeFromNestedFullCoverageAggreate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
Unexpected IStatus when starting server
deployBundleOnServer(org.apache.sling.ide.test.impl.BundleDeploymentTest):
Unexpected IStatus when starting server
Tests run: 13, Failures: 8, Errors: 0, Skipped: 0
{code}
It seems that the server is no longer able to start
{code}
deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest) Time elapsed:
0.36 sec FAILURE!
java.lang.AssertionError: Unexpected IStatus when starting server
Expected: is OK
but: was Status ERROR: org.apache.sling.ide.eclipse-core code=0
java.lang.NullPointerException
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at
org.apache.sling.ide.test.impl.helpers.SlingWstServer.waitForServerToStart(SlingWstServer.java:124)
at
org.apache.sling.ide.test.impl.helpers.SlingWstServer.waitForServerToStart(SlingWstServer.java:105)
at
org.apache.sling.ide.test.impl.ContentDeploymentTest.deployFile(ContentDeploymentTest.java:80)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
at
[jira] [Created] (SLING-3573) Local resources which are no longer present in the repository are not deleted when importing
Robert Munteanu created SLING-3573:
--
Summary: Local resources which are no longer present in the
repository are not deleted when importing
Key: SLING-3573
URL: https://issues.apache.org/jira/browse/SLING-3573
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.2
Consider the following scenario
Local workspace
{code}
.
├── item
│ └── html.jsp
└── list
├── html.jsp
└── json.jsp
{code}
Repository
{code}
.
├── item
│ └── html.jsp
└── list
└── html.jsp
{code}
When importing content from the repository, list/json.jsp is not deleted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository
[
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999761#comment-13999761
]
Robert Munteanu commented on SLING-3571:
The following seems the fix the problem for me, can you double-check?
I think you might be using Oak-specific properties, which are not present in
Jackrabbit 2.x .
{code}
diff --git
a/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
b/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
index a7b589d..468eaa0 100644
---
a/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
+++
b/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
@@ -161,28 +161,32 @@ public class VltNodeTypeFactory {
// load mandatory
String[] mandatoryProperties = (String[])
child.getProperties().get(rep:mandatoryProperties);
-for (int i = 0; i mandatoryProperties.length; i++) {
-String aMandatoryProperty = mandatoryProperties[i];
-VltPropertyDefinition vpd = pds.get(aMandatoryProperty);
-if (vpd==null) {
-vpd = new VltPropertyDefinition();
-vpd.setName(aMandatoryProperty);
-pds.put(aMandatoryProperty, vpd);
+if (mandatoryProperties != null) {
+for (int i = 0; i mandatoryProperties.length; i++) {
+String aMandatoryProperty = mandatoryProperties[i];
+VltPropertyDefinition vpd = pds.get(aMandatoryProperty);
+if (vpd == null) {
+vpd = new VltPropertyDefinition();
+vpd.setName(aMandatoryProperty);
+pds.put(aMandatoryProperty, vpd);
+}
+vpd.setMandatory(true);
}
-vpd.setMandatory(true);
}
// load protected
String[] protectedProperties = (String[])
child.getProperties().get(rep:protectedProperties);
-for (int i = 0; i protectedProperties.length; i++) {
-String aProtectedProperties = protectedProperties[i];
-VltPropertyDefinition vpd = pds.get(aProtectedProperties);
-if (vpd==null) {
-vpd = new VltPropertyDefinition();
-vpd.setName(aProtectedProperties);
-pds.put(aProtectedProperties, vpd);
+if (protectedProperties != null) {
+for (int i = 0; i protectedProperties.length; i++) {
+String aProtectedProperties = protectedProperties[i];
+VltPropertyDefinition vpd = pds.get(aProtectedProperties);
+if (vpd == null) {
+vpd = new VltPropertyDefinition();
+vpd.setName(aProtectedProperties);
+pds.put(aProtectedProperties, vpd);
+}
+vpd.setProtected(true);
}
-vpd.setProtected(true);
}
nt.setDeclaredPropertyDefinitions(pds.values().toArray(new
VltPropertyDefinition[pds.size()]));
{code}
Introduce NodeTypeRegistry, attached to Repository
--
Key: SLING-3571
URL: https://issues.apache.org/jira/browse/SLING-3571
Project: Sling
Issue Type: Task
Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
Fix For: Sling Eclipse IDE 1.0.0
We need more node type support in the IDE to support proper content
manipulation checks and displaying properties with more details.
To do this, we introduce a NodeTypeRegistry that is attached to the
Repository.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999695#comment-13999695
]
Robert Munteanu commented on SLING-3570:
[~egli] - you're probably more familiar with this area of the code, does this
ring any bells?
Assertion failed when trying to create new Sling Bundle project
---
Key: SLING-3570
URL: https://issues.apache.org/jira/browse/SLING-3570
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Fix For: Sling Eclipse IDE 1.0.0
When I try to create a new Sling Bundle project with the wizard I get the
following exception:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
!MESSAGE assertion failed:
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: assertion failed:
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
at
org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
at
org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
at
org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at
org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
at org.eclipse.core.internal.resources.Project.build(Project.java:114)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
at
org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
{code}
I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-2985) [Tooling] show content of .content.xml in project explorer
[
https://issues.apache.org/jira/browse/SLING-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998588#comment-13998588
]
Robert Munteanu commented on SLING-2985:
[~egli] - I get a compilation error, probably related to your latest changes,
can you please double-check?
{code}[ERROR] Failed to execute goal
org.eclipse.tycho:tycho-compiler-plugin:0.20.0:compile (default-compile) on
project org.apache.sling.ide.eclipse-ui: Compilation failure: Compilation
failure:
[ERROR]
/home/ADOBENET/rmuntean/w/workspace/sling/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/actions/JcrNewNodeAction.java:[60]
[ERROR] node.createChild(id.getValue());
[ERROR] ^^^
[ERROR] The method createChild(String, String) in the type JcrNode is not
applicable for the arguments (String)
[ERROR] 1 problem (1 error)
[ERROR] - [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn goals -rf :org.apache.sling.ide.eclipse-ui
{code}
[Tooling] show content of .content.xml in project explorer
--
Key: SLING-2985
URL: https://issues.apache.org/jira/browse/SLING-2985
Project: Sling
Issue Type: New Feature
Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
Fix For: Sling Eclipse IDE 1.0.0
Irrespective of the chosen serialization the content of .content.xml should
be shown in the tree structure of the project explorer. This can be achieved
using a Navigator Content Extension (NCE) (which is part of the Common
Navigator Framework (CNF) of eclipse).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server
[
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3567.
Resolution: Fixed
Thanks for confirming, marked as fixed.
Cannot add null entries, when creating a new bundle and adding it to an
existing server
---
Key: SLING-3567
URL: https://issues.apache.org/jira/browse/SLING-3567
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
With the most recent version of Sling IDE Tooling I get the following
exception when adding a new Sling bundle project and adding it to an existing
server:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
at
org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
at
org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
at
[jira] [Resolved] (SLING-2651) Manually trigger sync on files/directories
[ https://issues.apache.org/jira/browse/SLING-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-2651. Resolution: Fixed Fixed: - http://svn.apache.org/viewvc?view=revisionrevision=1594890 - move more filter-related logic to ProjectUtil - http://svn.apache.org/viewvc?view=revisionrevision=1594892 - ExportWizardPage - display information about the filter that will be used - http://svn.apache.org/viewvc?view=revisionrevision=1594893 - fix tracing arguments in ResourceChangeCommandFactory - http://svn.apache.org/viewvc?view=revisionrevision=1594894 - skip serialization directories ( $nodename.dir ) - http://svn.apache.org/viewvc?view=revisionrevision=159489 - update key binding for export action Manually trigger sync on files/directories -- Key: SLING-2651 URL: https://issues.apache.org/jira/browse/SLING-2651 Project: Sling Issue Type: Improvement Components: IDE Reporter: Antonio Sanso Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 We should be able to manually publish a subtree of content, as opposed to the sync happening in the background. One use case is where the auto-sync is disabled and the user only wants to publish the changes manually. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3559) Never run project launches when publishing
[ https://issues.apache.org/jira/browse/SLING-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999192#comment-13999192 ] Robert Munteanu commented on SLING-3559: The new project wizard simply requests a full publish of the server - not sure if that's not too heavyweight right now, but it works. https://github.com/apache/sling/blob/c6b87d8043efde46dad6cb360df738b821da206c/tooling/ide/eclipse-m2e-ui/src/org/apache/sling/ide/eclipse/ui/wizards/np/AbstractNewSlingApplicationWizard.java#L277 Never run project launches when publishing -- Key: SLING-3559 URL: https://issues.apache.org/jira/browse/SLING-3559 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 The SlingLaunchpadBehaviour still runs project launches if they exist. I don't think that's needed anymore, as the content sync code should be good enough, and launches are reserved for other tasks. As such, we should remove that code. [~egli] - is there anything that I missed? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3568) Allow importing content from arbitrary locations
Robert Munteanu created SLING-3568: -- Summary: Allow importing content from arbitrary locations Key: SLING-3568 URL: https://issues.apache.org/jira/browse/SLING-3568 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 The current import wizard only processes the whole project. This is problematic for large projects where import would take a lot of time. Also, at times a developer makes a small change in the repository and wants to sync it back to the workspace. To support these scenarios we need to allow importing content from arbitrary locations under the content sync root. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore files
[ https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999760#comment-13999760 ] Robert Munteanu commented on SLING-3161: The rules for parsing .vltignore files are found in the [Ignore#addIgnored|https://github.com/apache/jackrabbit-filevault/blob/9981fdca2630bc08b921752f41475e0027615da4/vault-vlt/src/main/java/org/apache/jackrabbit/vault/vlt/meta/Ignored.java#L122]. SlingIDE Import Content wizard should respect .vltignore files -- Key: SLING-3161 URL: https://issues.apache.org/jira/browse/SLING-3161 Project: Sling Issue Type: Bug Components: IDE Reporter: Justin Edelson Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Given in repository: /apps/foo/install /apps/foo/install/.vltignore = *.jar /apps/foo/install/foo.jar Then running import content should not copy foo.jar into the local working copy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3564) it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid thread access
[
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3564:
---
Attachment: SLING-3564-1.diff
it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid
thread access
---
Key: SLING-3564
URL: https://issues.apache.org/jira/browse/SLING-3564
Project: Sling
Issue Type: Bug
Components: IDE
Environment: mac os x, 10.7.5, java version 1.6.0_65
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3564-1.diff
When I run 'mvn clean install' in tooling/ide I get a failure in
tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in
eclipse-test):
{code}
***WARNING: Display must be created on main thread due to Cocoa restrictions.
{code}
and the corresponding
tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
{code}
org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:4397)
at org.eclipse.swt.SWT.error(SWT.java:4312)
at org.eclipse.swt.SWT.error(SWT.java:4283)
at org.eclipse.swt.widgets.Display.error(Display.java:1076)
at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
at org.eclipse.swt.widgets.Display.create(Display.java:816)
at org.eclipse.swt.graphics.Device.init(Device.java:130)
at org.eclipse.swt.widgets.Display.init(Display.java:707)
at org.eclipse.swt.widgets.Display.init(Display.java:698)
at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
at
org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
at
org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
at
org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore filess
[ https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3161: -- Assignee: Robert Munteanu SlingIDE Import Content wizard should respect .vltignore filess --- Key: SLING-3161 URL: https://issues.apache.org/jira/browse/SLING-3161 Project: Sling Issue Type: Bug Components: IDE Reporter: Justin Edelson Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Given in repository: /apps/foo/install /apps/foo/install/.vltignore = *.jar /apps/foo/install/foo.jar Then running import content should not copy foo.jar into the local working copy. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time
[
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999759#comment-13999759
]
Robert Munteanu commented on SLING-3081:
{quote}The new-project-wizard will also start the server of course and
up-till-now was assuming the publish would automatically start. That we can
still trigger explicitly from the wizard though, so no issue there.{quote}
Sounds good
Do not re-publish modules when starting the launchpad for the first time
Key: SLING-3081
URL: https://issues.apache.org/jira/browse/SLING-3081
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.2
This results in unnecessary publishing activity. The right way is to provide
a manual action to sync a sub-tree to ( or the whole module ) to the
Launchpad.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3568) Allow importing content from arbitrary locations
[ https://issues.apache.org/jira/browse/SLING-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3568. Resolution: Fixed - http://svn.apache.org/viewvc?view=revisionrevision=1595166 - add ProjectUtil.isInsideContentSyncRoot - http://svn.apache.org/viewvc?view=revisionrevision=1595167 - update ContentResourceTester with canBeImported property - http://svn.apache.org/viewvc?view=revisionrevision=1595168 - allow the ImportWizard to select arbitrary locations for importing. Allow importing content from arbitrary locations Key: SLING-3568 URL: https://issues.apache.org/jira/browse/SLING-3568 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 The current import wizard only processes the whole project. This is problematic for large projects where import would take a lot of time. Also, at times a developer makes a small change in the repository and wants to sync it back to the workspace. To support these scenarios we need to allow importing content from arbitrary locations under the content sync root. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3124) SetupServerWizardPage should not hardcode username/password to admin/admin
[ https://issues.apache.org/jira/browse/SLING-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3124: -- Assignee: Robert Munteanu SetupServerWizardPage should not hardcode username/password to admin/admin -- Key: SLING-3124 URL: https://issues.apache.org/jira/browse/SLING-3124 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3124) SetupServerWizardPage should not hardcode username/password to admin/admin
[ https://issues.apache.org/jira/browse/SLING-3124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3124. Resolution: Fixed * http://svn.apache.org/viewvc?view=revisionrevision=1596137 minor cleanups * http://svn.apache.org/viewvc?view=revisionrevision=1596138 implementation SetupServerWizardPage should not hardcode username/password to admin/admin -- Key: SLING-3124 URL: https://issues.apache.org/jira/browse/SLING-3124 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14002978#comment-14002978 ] Robert Munteanu commented on SLING-3174: I see your point. For this simple bundle project we must minimally have: * a MANIFEST.MF * dependencies to a couple of jars - org.apache.sling.api and javax.servlet * an OSGi component, probably configured with a XML DS descriptor I have done this for the [BundleDeploymentTest|https://github.com/apache/sling/blob/c6b87d8043efde46dad6cb360df738b821da206c/tooling/ide/eclipse-test/src/org/apache/sling/ide/test/impl/BundleDeploymentTest.java#L75], and therefore know what to do. I see a couple of problems with this approach though: * We should not use the DS annotations, because we can't enable a builder which will generate the XML descriptors * We do not have access to the Maven repository for dependencies since the simple archetypes must be Maven-free My proposal would then be to stick to the Maven-driven process for creating bundle projects, and only add a wizard for simple content projects for 1.0.0 . We can always revisit later, but I don't think this is critical for the 1.0.0 release. [~egli] - how does that sound? [Tooling] add 'new simple content/bundle project' wizards - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu reassigned SLING-3570:
--
Assignee: Robert Munteanu
Assertion failed when trying to create new Sling Bundle project
---
Key: SLING-3570
URL: https://issues.apache.org/jira/browse/SLING-3570
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
When I try to create a new Sling Bundle project with the wizard I get the
following exception:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
!MESSAGE assertion failed:
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: assertion failed:
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
at
org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
at
org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
at
org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at
org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
at org.eclipse.core.internal.resources.Project.build(Project.java:114)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
at
org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
{code}
I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3570) Assertion failed when trying to create new Sling Bundle project
[
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3570.
Resolution: Fixed
Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1596228 . I was
unable to reproduce this particular issue, but the operations should be
properly serialized and hopefully even faster. In my tests everything works,
please reopen if there are still problems.
Assertion failed when trying to create new Sling Bundle project
---
Key: SLING-3570
URL: https://issues.apache.org/jira/browse/SLING-3570
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
When I try to create a new Sling Bundle project with the wizard I get the
following exception:
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
!MESSAGE assertion failed:
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: assertion failed:
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
at
org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
at
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
at
org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
at
org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at
org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
at org.eclipse.core.internal.resources.Project.build(Project.java:114)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
at
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
at
org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
at
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
{code}
I tested with SVN revision 1595036.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3581: -- Assignee: (was: Robert Munteanu) Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3581: --- Fix Version/s: (was: Sling Eclipse IDE 1.0.0) Sling Eclipse IDE 1.0.2 Requires changes in the tooling support bundle - Moving to 1.0.2 Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.2 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[
https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003172#comment-14003172
]
Robert Munteanu commented on SLING-3583:
[~egli] - can you please attach an archive of the content structure? It's much
faster than trying to re-create it myself
children of folder, containing files besides .content.xml, will get deleted
on content-sync
---
Key: SLING-3583
URL: https://issues.apache.org/jira/browse/SLING-3583
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
In slingclipse, when content is synched to a launchpad-server, children of
certain folders are immediately deleted after creation.
Details:
* consider a sling-content project which contains e.g the following
structure (node names of children describe their primary type)
{code}
someparent
├── osgiconfig
├── ntfolder
├── ntunstructured
│ └── childofntunstructured
└── slingfolder
└── childofslingfolder
{code}
* The SlingLaunchpadBehavior.publishContentModule, which is in charge of
updating the launchpad with changes in the eclipse-filesystem, goes through
the list of files (Let's assume an initial publish for simplicity reason).
* It so happens, that the order of iteration is in such a way, that the
someparent/.content.xml is handled last - after the other children have
properly been synched with the server.
* Upon handling of someparent/.content.xml,
SlingLaunchpadBehavior.addFileCommand is executed, and in there,
serializationManager.readSerializationData() (or more precisely in
VltSerializationManager.readSerializationData()) returns the *parent of the
.content.xml file*, namely the 'someparent' node.
* With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims
that the someparent(ex ./.content.xml) has no children, hence deletes all
existing ones from the server.
[~rombert], assigning this to you as you're more familiar with the code in
that area. I'm uncertain if the real bug is in the readSerializationData or
in the AddOrUpdateNodeCommand..
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (SLING-3581) Removing a bundle project from the server does not uninstall the bundle
[ https://issues.apache.org/jira/browse/SLING-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3581: -- Assignee: Robert Munteanu Removing a bundle project from the server does not uninstall the bundle --- Key: SLING-3581 URL: https://issues.apache.org/jira/browse/SLING-3581 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 After deploying a bundle, remove it from the server and then inspect the logs or the bundle list from the web console. The bundle is still there. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[
https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003244#comment-14003244
]
Robert Munteanu commented on SLING-3583:
That's perfect, thanks.
children of folder, containing files besides .content.xml, will get deleted
on content-sync
---
Key: SLING-3583
URL: https://issues.apache.org/jira/browse/SLING-3583
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Attachments: bugproject.zip
In slingclipse, when content is synched to a launchpad-server, children of
certain folders are immediately deleted after creation.
Details:
* consider a sling-content project which contains e.g the following
structure (node names of children describe their primary type)
{code}
someparent
├── osgiconfig
├── ntfolder
├── ntunstructured
│ └── childofntunstructured
└── slingfolder
└── childofslingfolder
{code}
* The SlingLaunchpadBehavior.publishContentModule, which is in charge of
updating the launchpad with changes in the eclipse-filesystem, goes through
the list of files (Let's assume an initial publish for simplicity reason).
* It so happens, that the order of iteration is in such a way, that the
someparent/.content.xml is handled last - after the other children have
properly been synched with the server.
* Upon handling of someparent/.content.xml,
SlingLaunchpadBehavior.addFileCommand is executed, and in there,
serializationManager.readSerializationData() (or more precisely in
VltSerializationManager.readSerializationData()) returns the *parent of the
.content.xml file*, namely the 'someparent' node.
* With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims
that the someparent(ex ./.content.xml) has no children, hence deletes all
existing ones from the server.
[~rombert], assigning this to you as you're more familiar with the code in
that area. I'm uncertain if the real bug is in the readSerializationData or
in the AddOrUpdateNodeCommand..
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3583) children of folder, containing files besides .content.xml, will get deleted on content-sync
[
https://issues.apache.org/jira/browse/SLING-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3583.
Resolution: Fixed
This should now be fixed, your example project works fine for me.
* http://svn.apache.org/viewvc?view=revisionrevision=1596257 - simplify usage
of ProjectAdapter.createOrUpdateFile
* http://svn.apache.org/viewvc?view=revisionrevision=1596258 - added tracing
to the node deletion code
* http://svn.apache.org/viewvc?view=revisionrevision=1596259 - fixed bug +
added regression test
children of folder, containing files besides .content.xml, will get deleted
on content-sync
---
Key: SLING-3583
URL: https://issues.apache.org/jira/browse/SLING-3583
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Attachments: bugproject.zip
In slingclipse, when content is synched to a launchpad-server, children of
certain folders are immediately deleted after creation.
Details:
* consider a sling-content project which contains e.g the following
structure (node names of children describe their primary type)
{code}
someparent
├── osgiconfig
├── ntfolder
├── ntunstructured
│ └── childofntunstructured
└── slingfolder
└── childofslingfolder
{code}
* The SlingLaunchpadBehavior.publishContentModule, which is in charge of
updating the launchpad with changes in the eclipse-filesystem, goes through
the list of files (Let's assume an initial publish for simplicity reason).
* It so happens, that the order of iteration is in such a way, that the
someparent/.content.xml is handled last - after the other children have
properly been synched with the server.
* Upon handling of someparent/.content.xml,
SlingLaunchpadBehavior.addFileCommand is executed, and in there,
serializationManager.readSerializationData() (or more precisely in
VltSerializationManager.readSerializationData()) returns the *parent of the
.content.xml file*, namely the 'someparent' node.
* With that, in turn, the AddOrUpdateNodeCommand.processDeletedNodes() claims
that the someparent(ex ./.content.xml) has no children, hence deletes all
existing ones from the server.
[~rombert], assigning this to you as you're more familiar with the code in
that area. I'm uncertain if the real bug is in the readSerializationData or
in the AddOrUpdateNodeCommand..
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3585) Wizard for creating a new simple OSGi bundle
Robert Munteanu created SLING-3585: -- Summary: Wizard for creating a new simple OSGi bundle Key: SLING-3585 URL: https://issues.apache.org/jira/browse/SLING-3585 Project: Sling Issue Type: New Feature Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.2 (Created as a spin-off from SLING-3174). We should support a simple bundle project which does not require Maven for execution. Open questions * how do we resolve the needed jars in order to add them to the classpath? * what sort of content do we add to the project? A service using DS annotations is out since we don't have the proper builder installed to generate the XML descriptors -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Description: We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. (was: We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse.) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include a new wizards which creates a simple content projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although this wizard would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[ https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3174: --- Summary: Add new simple project content wizard (was: [Tooling] add 'new simple content/bundle project' wizards) Add new simple project content wizard - Key: SLING-3174 URL: https://issues.apache.org/jira/browse/SLING-3174 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 We should include 'new' wizards which create simple content/bundle projects. The project would simply create a faceted project with the according facet set and set any additional type specific properties (eg with content it would create a jcr_root directory). Although these two wizards would do very trivial tasks, IMO this will help users kickstart projects and get into the mindset of slingclipse. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003344#comment-14003344
]
Robert Munteanu commented on SLING-3174:
{quote}is this really needed for the bare minimum?{quote}
We can of course discuss this. But I think we need to create a project that
when deployed does something useful, and one example is an OSGi service.
Perhaps we can register a service using the classic OSGi approach, but I don't
like the idea of promoting a very verbose approach.
{quote} Let's do a 'new simple content wizard' for now, and look at an 'even
simpler (than sling's archetypes/bundle) new bundle wizard' later. wdyt?{quote}
Agreed. Created SLING-3585.
[Tooling] add 'new simple content/bundle project' wizards
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Fix For: Sling Eclipse IDE 1.0.0
We should include 'new' wizards which create simple content/bundle projects.
The project would simply create a faceted project with the according facet
set and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although these two wizards would do very
trivial tasks, IMO this will help users kickstart projects and get into the
mindset of slingclipse.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3174:
---
Description:
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set and
set any additional type specific properties (eg with content it would create a
jcr_root directory). Although this wizard would do very trivial tasks, IMO this
will help users kickstart projects and get into the mindset of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
was:We should include a new wizards which creates a simple content projects.
The project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial tasks,
IMO this will help users kickstart projects and get into the mindset of
slingclipse.
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Fix For: Sling Eclipse IDE 1.0.0
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3174:
---
Assignee: Robert Munteanu
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003372#comment-14003372
]
Robert Munteanu commented on SLING-3174:
I'm going to need to move some functionality out of the eclipse-m2e-ui plugin,
notably the
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard
class to make it reusable for this task.
That class will move to eclipse-ui, with the Maven-specific functionality
remaining in eclipse-m2e-ui as an AbstractNewMavenBasedSlingApplicationWizard (
or a better name , if someone suggests one )
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003409#comment-14003409
]
Robert Munteanu commented on SLING-3174:
Reusable code moved to eclipse-ui in
http://svn.apache.org/viewvc?view=revisionrevision=1596282 .
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003431#comment-14003431
]
Robert Munteanu commented on SLING-3174:
Added a skeletal implementation in
http://svn.apache.org/viewvc?view=revisionrevision=1596287 .
Pending:
- create more content ( see TODO in code )
- decide how we can test this ( SWT bot? )
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3587) Publish not triggered by WST on folder creation
[ https://issues.apache.org/jira/browse/SLING-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003436#comment-14003436 ] Robert Munteanu commented on SLING-3587: Yup, see this as well. I think that if we want to force this behaviour, we can introduce a new Builder for content projects which uses the triggerIncrementalBuild facility you just added whenever just a folder is created. Publish not triggered by WST on folder creation --- Key: SLING-3587 URL: https://issues.apache.org/jira/browse/SLING-3587 Project: Sling Issue Type: Improvement Components: IDE Reporter: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 When you create a folder in a directory that is hooked up to a (WST)server, the corresponding publish mechanism doesn't get triggered. The core issue seems to be a WST-bug IMHO: the org.eclipse.wst.server.core.internal.ResourceManager.getPublishRequiredServers's IResourceDeltaVisitor.visit() only returns true if anything related to an IFile has changed. If a folder has changed, it will navigate down to that folder, but won't necessarily find anything changed below there and thus ignore the change. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[
https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003850#comment-14003850
]
Robert Munteanu commented on SLING-3589:
[~egli] - yes, the simple content project wizard ( SLING-3174 ) will create a
filter.xml file. However, it's safer to guard against filter.xml missing,
there's no guarantee that it exists.
[~kwin] - I've created a placeholder for the filter docs at
https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide#SlingIDEtoolingUserGuide-Filteringtopics-includingfilter.xmldefinition
, to make sure it's not forgotten.
Creating new nodes within a new Sling Content Project leads to NPE
--
Key: SLING-3589
URL: https://issues.apache.org/jira/browse/SLING-3589
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Konrad Windszus
{code}
!ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
at
org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
at
org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
at
org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
I just created a new Sling Content Project with the Wizard and tried to add a
new node via right click on jcr_root/apps/example/item - New - New JCR Node.
The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[
https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14003853#comment-14003853
]
Robert Munteanu commented on SLING-3589:
[~egli] - if you already handle missing filter.xml files, can this be closed?
Creating new nodes within a new Sling Content Project leads to NPE
--
Key: SLING-3589
URL: https://issues.apache.org/jira/browse/SLING-3589
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Konrad Windszus
Fix For: Sling Eclipse IDE 1.0.0
{code}
!ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
at
org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
at
org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
at
org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
I just created a new Sling Content Project with the Wizard and tried to add a
new node via right click on jcr_root/apps/example/item - New - New JCR Node.
The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3589) Creating new nodes within a new Sling Content Project leads to NPE
[
https://issues.apache.org/jira/browse/SLING-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3589:
---
Fix Version/s: Sling Eclipse IDE 1.0.0
Creating new nodes within a new Sling Content Project leads to NPE
--
Key: SLING-3589
URL: https://issues.apache.org/jira/browse/SLING-3589
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Konrad Windszus
Fix For: Sling Eclipse IDE 1.0.0
{code}
!ENTRY org.eclipse.ui 4 0 2014-05-20 18:14:28.830
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
at
org.apache.sling.ide.eclipse.ui.nav.model.JcrNode.canCreateChild(JcrNode.java:938)
at
org.apache.sling.ide.eclipse.ui.actions.JcrNewNodeAction.run(JcrNewNodeAction.java:49)
at
org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at
org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
at
org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at
org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}
I just created a new Sling Content Project with the Wizard and tried to add a
new node via right click on jcr_root/apps/example/item - New - New JCR Node.
The project is connected to a running server. I tested with SVN rev. 1596303
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004517#comment-14004517
]
Robert Munteanu commented on SLING-3174:
I've started working on a simple SwtBot test, see attached
[^SLING-3174-swtbot.diff] . This doesn't work for me so I'm going to postpone
the effort, see an analysis at
https://stackoverflow.com/questions/23778686/swtbot-hangs-at-click .
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3174-swtbot.diff
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3174:
---
Attachment: SLING-3174-swtbot.diff
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3174-swtbot.diff
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3174) Add new simple project content wizard
[
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-3174.
Resolution: Fixed
- http://svn.apache.org/viewvc?view=revisionrevision=1596515 updated the
wizard to include a minimal set of files ( vlt config files, resource,
rendering script )
- http://svn.apache.org/viewvc?view=revisionrevision=1596516 remove 'New' from
project wizard labels
Add new simple project content wizard
-
Key: SLING-3174
URL: https://issues.apache.org/jira/browse/SLING-3174
Project: Sling
Issue Type: Improvement
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Attachments: SLING-3174-swtbot.diff
We should include a new wizards which creates a simple content projects. The
project would simply create a faceted project with the according facet set
and set any additional type specific properties (eg with content it would
create a jcr_root directory). Although this wizard would do very trivial
tasks, IMO this will help users kickstart projects and get into the mindset
of slingclipse.
The initial content should be something like
{code}
.
├── jcr_root
│ ├── content
│ └─ example
└── META-INF
└── vault
├── config.xml
├── filter.xml
└── settings.xml
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3136) Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based
[ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3136: --- Assignee: Robert Munteanu Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based --- Key: SLING-3136 URL: https://issues.apache.org/jira/browse/SLING-3136 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 There are a couple of issues with the way the current configuration actions are done: - it is only enabled for Maven projects ; this does not apply to all projects and is confusing - for the Content Package action, it only enables itself for projects of type 'content-package' . This should not be checked against since this packaging does not exist from a Sling point of view - for the Content package action, it assumes that the content sync root is src/main/content/jcr_root, even though it may not exist. Instead, I propose the following: 1. Use only the WST facets definition to decide if we can convert a project to a facet ; I guess for now we can simply disallow projects from having both facets ( content + bundle ) 2. Do not make Maven a hard requirement 3. Use the following heuristic to detect the content sync root: - look for the following ( can be made configurable later ) directories - jcr_root - src/main/content/jcr_root Whenever such a project is found, make it the default jcr_root directory. If none is found, ask the user for input. More specific actions can be done as part of the m2e configurator for content packages tracked under SLING-3100 . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3136) Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based
[ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3136. Resolution: Fixed - http://svn.apache.org/viewvc?view=revisionrevision=1596528 detect potential content projects by looking for a directory containing both jcr_root and META-INF/vault/filter.xml - http://svn.apache.org/viewvc?view=revisionrevision=1596529 use the standard naming of 'Sling Content Project' and 'Sling Bundle Project' for the convert actions - http://svn.apache.org/viewvc?view=revisionrevision=1596530 ConvertToBundleAction now considers all Java projects as candidates Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based --- Key: SLING-3136 URL: https://issues.apache.org/jira/browse/SLING-3136 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 There are a couple of issues with the way the current configuration actions are done: - it is only enabled for Maven projects ; this does not apply to all projects and is confusing - for the Content Package action, it only enables itself for projects of type 'content-package' . This should not be checked against since this packaging does not exist from a Sling point of view - for the Content package action, it assumes that the content sync root is src/main/content/jcr_root, even though it may not exist. Instead, I propose the following: 1. Use only the WST facets definition to decide if we can convert a project to a facet ; I guess for now we can simply disallow projects from having both facets ( content + bundle ) 2. Do not make Maven a hard requirement 3. Use the following heuristic to detect the content sync root: - look for the following ( can be made configurable later ) directories - jcr_root - src/main/content/jcr_root Whenever such a project is found, make it the default jcr_root directory. If none is found, ask the user for input. More specific actions can be done as part of the m2e configurator for content packages tracked under SLING-3100 . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3136) Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based
[ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004553#comment-14004553 ] Robert Munteanu commented on SLING-3136: The main reason is that not having a filter.xml is a bad idea, especially for large projects/repositories as we get a lot of traffic between Eclipse and the repository. Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based --- Key: SLING-3136 URL: https://issues.apache.org/jira/browse/SLING-3136 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 There are a couple of issues with the way the current configuration actions are done: - it is only enabled for Maven projects ; this does not apply to all projects and is confusing - for the Content Package action, it only enables itself for projects of type 'content-package' . This should not be checked against since this packaging does not exist from a Sling point of view - for the Content package action, it assumes that the content sync root is src/main/content/jcr_root, even though it may not exist. Instead, I propose the following: 1. Use only the WST facets definition to decide if we can convert a project to a facet ; I guess for now we can simply disallow projects from having both facets ( content + bundle ) 2. Do not make Maven a hard requirement 3. Use the following heuristic to detect the content sync root: - look for the following ( can be made configurable later ) directories - jcr_root - src/main/content/jcr_root Whenever such a project is found, make it the default jcr_root directory. If none is found, ask the user for input. More specific actions can be done as part of the m2e configurator for content packages tracked under SLING-3100 . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Comment Edited] (SLING-3136) Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based
[ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004553#comment-14004553 ] Robert Munteanu edited comment on SLING-3136 at 5/21/14 10:27 AM: -- The main reason is that not having a filter.xml is a bad idea, especially for large projects/repositories as we get a lot of traffic between Eclipse and the repository. And also an arbitrary jcr_root directory may be present, not necessarily the one we're looking for. But a jcr_root alongside META-INF/vault/filter.xml is a definite sign of a content project. was (Author: rombert): The main reason is that not having a filter.xml is a bad idea, especially for large projects/repositories as we get a lot of traffic between Eclipse and the repository. Configure - Convert to Bundle/Content Package project should not assume the project is Maven-based --- Key: SLING-3136 URL: https://issues.apache.org/jira/browse/SLING-3136 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 There are a couple of issues with the way the current configuration actions are done: - it is only enabled for Maven projects ; this does not apply to all projects and is confusing - for the Content Package action, it only enables itself for projects of type 'content-package' . This should not be checked against since this packaging does not exist from a Sling point of view - for the Content package action, it assumes that the content sync root is src/main/content/jcr_root, even though it may not exist. Instead, I propose the following: 1. Use only the WST facets definition to decide if we can convert a project to a facet ; I guess for now we can simply disallow projects from having both facets ( content + bundle ) 2. Do not make Maven a hard requirement 3. Use the following heuristic to detect the content sync root: - look for the following ( can be made configurable later ) directories - jcr_root - src/main/content/jcr_root Whenever such a project is found, make it the default jcr_root directory. If none is found, ask the user for input. More specific actions can be done as part of the m2e configurator for content packages tracked under SLING-3100 . -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3590) Exception when processing reordering of content nodes for partial coverage aggregates
Robert Munteanu created SLING-3590:
--
Summary: Exception when processing reordering of content nodes for
partial coverage aggregates
Key: SLING-3590
URL: https://issues.apache.org/jira/browse/SLING-3590
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.0
Assume the following filesystem structure
{code}
.
├── apps
│ └── example
│ └── item
│ └── html.jsp
└── content
└── example (nt:unstructured)
├── .content.xml
└── nested (nt:unstructured)
└── .content.xml
{code}
When modifying the properties of /content/example ( in
/content/example/.content.xml ) a NoSuchElementException is thrown
{code}
java.util.NoSuchElementException
at java.util.ArrayList$Itr.next(ArrayList.java:834)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.reorderChildNodes(AddOrUpdateNodeCommand.java:174)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.update(AddOrUpdateNodeCommand.java:119)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:80)
at
org.apache.sling.ide.impl.vlt.AddOrUpdateNodeCommand.execute0(AddOrUpdateNodeCommand.java:1)
at org.apache.sling.ide.impl.vlt.JcrCommand.execute(JcrCommand.java:54)
at
org.apache.sling.ide.transport.TracingCommand.execute(TracingCommand.java:43)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.execute(SlingLaunchpadBehaviour.java:356)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishContentModule(SlingLaunchpadBehaviour.java:322)
at
org.apache.sling.ide.eclipse.core.internal.SlingLaunchpadBehaviour.publishModule(SlingLaunchpadBehaviour.java:174)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModule(ServerBehaviourDelegate.java:1091)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publishModules(ServerBehaviourDelegate.java:1183)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:987)
at
org.eclipse.wst.server.core.model.ServerBehaviourDelegate.publish(ServerBehaviourDelegate.java:774)
at
org.eclipse.wst.server.core.internal.Server.publishImpl(Server.java:3154)
at
org.eclipse.wst.server.core.internal.Server$PublishJob.run(Server.java:345)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3591) Unable to delete all nodes of a full coverage aggregate
[ https://issues.apache.org/jira/browse/SLING-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004607#comment-14004607 ] Robert Munteanu commented on SLING-3591: Added failing, ignored test in http://svn.apache.org/viewvc?view=revisionrevision=1596549 Unable to delete all nodes of a full coverage aggregate --- Key: SLING-3591 URL: https://issues.apache.org/jira/browse/SLING-3591 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.2 With the fix for SLING-3590 it is no longer possible to delete all nodes of a full coverage aggregate. Pushing to 1.0.2 since - it is not an usual scenario - it requires some changes to the Sling IDE Resource API, which I'd like to defer for now. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Issue Comment Deleted] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time
[
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-3081:
---
Comment: was deleted
(was: {quote}The new-project-wizard will also start the server of course and
up-till-now was assuming the publish would automatically start. That we can
still trigger explicitly from the wizard though, so no issue there.{quote}
Sounds good)
Do not re-publish modules when starting the launchpad for the first time
Key: SLING-3081
URL: https://issues.apache.org/jira/browse/SLING-3081
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.2
This results in unnecessary publishing activity. The right way is to provide
a manual action to sync a sub-tree to ( or the whole module ) to the
Launchpad.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3592) Remove embedded bundle archetype in favour of released version
Robert Munteanu created SLING-3592: -- Summary: Remove embedded bundle archetype in favour of released version Key: SLING-3592 URL: https://issues.apache.org/jira/browse/SLING-3592 Project: Sling Issue Type: Task Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 The vote for the sling-bundle-archetype 1.0.2 is complete, and we should: * remove the embedded archetype we package * allow usage of versions = 1.0.2 in our wizard I think we can safely assume that the user has access to Maven Central, usage of the archetype won't work otherwise. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3593) Add resource type decorator for jcr nodes
Robert Munteanu created SLING-3593: -- Summary: Add resource type decorator for jcr nodes Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3593) Add resource type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004630#comment-14004630 ] Robert Munteanu commented on SLING-3593: [~egli] - this is how the decorator would look like. Thanks for the nice JcrNode implementation BTW, makes this very easy. Do you think it's worth including? Add resource type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3593) Add resource type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3593: --- Attachment: screenshot.png Add resource type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3594) Update icon for non-file/folder nodes
Robert Munteanu created SLING-3594: -- Summary: Update icon for non-file/folder nodes Key: SLING-3594 URL: https://issues.apache.org/jira/browse/SLING-3594 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 I think that the current icon could use a little improvements - crisper, and possibly use colours which are more usually found in Eclipse. Since I'm no icon designer, I reused an icon from the org.eclipse.debug plugin. IMHO it looks a bit better, but I'm putting this up for discussion, to get more eyes on the problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3594) Update icon for non-file/folder nodes
[ https://issues.apache.org/jira/browse/SLING-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004639#comment-14004639 ] Robert Munteanu commented on SLING-3594: Added screenshot of the new icon. [~egli] - what do you think about this change? BTW, you can see a listing of the current Eclipse icons, also available in a nice SVG format at https://code.google.com/p/eclipse-svg-icons/ . Update icon for non-file/folder nodes - Key: SLING-3594 URL: https://issues.apache.org/jira/browse/SLING-3594 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think that the current icon could use a little improvements - crisper, and possibly use colours which are more usually found in Eclipse. Since I'm no icon designer, I reused an icon from the org.eclipse.debug plugin. IMHO it looks a bit better, but I'm putting this up for discussion, to get more eyes on the problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3594) Update icon for non-file/folder nodes
[ https://issues.apache.org/jira/browse/SLING-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3594: --- Attachment: screenshot.png Update icon for non-file/folder nodes - Key: SLING-3594 URL: https://issues.apache.org/jira/browse/SLING-3594 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think that the current icon could use a little improvements - crisper, and possibly use colours which are more usually found in Eclipse. Since I'm no icon designer, I reused an icon from the org.eclipse.debug plugin. IMHO it looks a bit better, but I'm putting this up for discussion, to get more eyes on the problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3593) Add node type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3593: --- Summary: Add node type decorator for jcr nodes (was: Add resource type decorator for jcr nodes) Add node type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot-2.png, screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3593) Add node type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3593: --- Attachment: screenshot-2.png Add node type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot-2.png, screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3593) Add node type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004649#comment-14004649 ] Robert Munteanu commented on SLING-3593: Added a second screenshot, with the node type in brackets. Add node type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot-2.png, screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (SLING-3594) Update icon for non-file/folder nodes
[ https://issues.apache.org/jira/browse/SLING-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-3594: -- Assignee: Robert Munteanu Update icon for non-file/folder nodes - Key: SLING-3594 URL: https://issues.apache.org/jira/browse/SLING-3594 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think that the current icon could use a little improvements - crisper, and possibly use colours which are more usually found in Eclipse. Since I'm no icon designer, I reused an icon from the org.eclipse.debug plugin. IMHO it looks a bit better, but I'm putting this up for discussion, to get more eyes on the problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3595) Sling wizard icons are too large
Robert Munteanu created SLING-3595: -- Summary: Sling wizard icons are too large Key: SLING-3595 URL: https://issues.apache.org/jira/browse/SLING-3595 Project: Sling Issue Type: Bug Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 The sling logo takes up too much space, we should resize it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3595) Sling wizard icons are too large
[ https://issues.apache.org/jira/browse/SLING-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3595: --- Attachment: sling-wizard-vs-m2e-wizard.png Sling wizard icons are too large Key: SLING-3595 URL: https://issues.apache.org/jira/browse/SLING-3595 Project: Sling Issue Type: Bug Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 Attachments: sling-wizard-vs-m2e-wizard.png The sling logo takes up too much space, we should resize it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3596) Content navigator icon is jagged
[ https://issues.apache.org/jira/browse/SLING-3596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3596: --- Attachment: screenshot.png Content navigator icon is jagged Key: SLING-3596 URL: https://issues.apache.org/jira/browse/SLING-3596 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png The jcr_root directory is marked with a sling icon, but it's jagged due to rescaling. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3596) Content navigator icon is jagged
Robert Munteanu created SLING-3596: -- Summary: Content navigator icon is jagged Key: SLING-3596 URL: https://issues.apache.org/jira/browse/SLING-3596 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png The jcr_root directory is marked with a sling icon, but it's jagged due to rescaling. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3597) Sling server and module icons are jagged due to downscaling
Robert Munteanu created SLING-3597: -- Summary: Sling server and module icons are jagged due to downscaling Key: SLING-3597 URL: https://issues.apache.org/jira/browse/SLING-3597 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (SLING-3598) Sling launchpad is does not have an icon
[ https://issues.apache.org/jira/browse/SLING-3598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-3598: --- Attachment: screenshot.png Sling launchpad is does not have an icon Key: SLING-3598 URL: https://issues.apache.org/jira/browse/SLING-3598 Project: Sling Issue Type: Bug Components: IDE Reporter: Robert Munteanu Priority: Minor Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3593) Add node type decorator for jcr nodes
[ https://issues.apache.org/jira/browse/SLING-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004713#comment-14004713 ] Robert Munteanu commented on SLING-3593: I slightly prefer the second one, so I'm going to go with that. There's no conflict with other decorators AFAICT since we are working on the nav model you provided, not on filesystem resources. Add node type decorator for jcr nodes - Key: SLING-3593 URL: https://issues.apache.org/jira/browse/SLING-3593 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot-2.png, screenshot.png I think it would be good to see the primary node type when browsing the synced content. I've done a simple basic implementation of this, submitting for visual review. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SLING-3594) Update icon for non-file/folder nodes
[ https://issues.apache.org/jira/browse/SLING-3594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3594. Resolution: Fixed Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1596583 . Update icon for non-file/folder nodes - Key: SLING-3594 URL: https://issues.apache.org/jira/browse/SLING-3594 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.0 Attachments: screenshot.png I think that the current icon could use a little improvements - crisper, and possibly use colours which are more usually found in Eclipse. Since I'm no icon designer, I reused an icon from the org.eclipse.debug plugin. IMHO it looks a bit better, but I'm putting this up for discussion, to get more eyes on the problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
