[jira] [Updated] (SLING-9780) Log service missing after switching to the feature model

2020-10-01 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9780:
---
Summary: Log service missing after switching to the feature model  (was: 
Log webconsole page does not work after switching to the feature model)

> Log service missing after switching to the feature model
> 
>
> Key: SLING-9780
> URL: https://issues.apache.org/jira/browse/SLING-9780
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Java 11 and 13 on MacOS
>Reporter: Hans-Peter Stoerr
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
> Attachments: LogserviceNotRunning.png, Starter11-HasLogService.png, 
> Starter12-NoLogService.png
>
>
> In the current Sling Starter 12 snapshot the OSGI Log Service does not work 
> properly. This has the effect that in the console at OSGI / Log Service 
> [http://localhost:8080/system/console/logs] there is only the display "Log 
> Service is not installed/running." and messages from OSGI (such as errors in 
> activation methods) are inconveniently logged to stdout instead of the 
> configured logfiles like error.log, which gave me some headache until I 
> noticed that. :)  Both the console plugin and the logging to error.log do 
> work properly in version 11.
> This is in spite of the bundle org.apache.sling.commons.logservice being 
> active. I tried downgrading it from the currently included 1.1.0 to 1.0.6, 
> which works in the version 11 of the Sling Starter, but this doesn't help. So 
> I guess it's some kind of configuration problem.
> Thanks so much for your amazing work!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9780) Log service missing after switching to the feature model

2020-10-01 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9780.

Resolution: Fixed

Fixed with [sling-org-apache-sling-starter commit 
8e5075d|https://github.com/apache/sling-org-apache-sling-starter/commit/8e5075d].

[~hanspeterstoerr] - can you please check?

> Log service missing after switching to the feature model
> 
>
> Key: SLING-9780
> URL: https://issues.apache.org/jira/browse/SLING-9780
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Java 11 and 13 on MacOS
>Reporter: Hans-Peter Stoerr
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
> Attachments: LogserviceNotRunning.png, Starter11-HasLogService.png, 
> Starter12-NoLogService.png
>
>
> In the current Sling Starter 12 snapshot the OSGI Log Service does not work 
> properly. This has the effect that in the console at OSGI / Log Service 
> [http://localhost:8080/system/console/logs] there is only the display "Log 
> Service is not installed/running." and messages from OSGI (such as errors in 
> activation methods) are inconveniently logged to stdout instead of the 
> configured logfiles like error.log, which gave me some headache until I 
> noticed that. :)  Both the console plugin and the logging to error.log do 
> work properly in version 11.
> This is in spite of the bundle org.apache.sling.commons.logservice being 
> active. I tried downgrading it from the currently included 1.1.0 to 1.0.6, 
> which works in the version 11 of the Sling Starter, but this doesn't help. So 
> I guess it's some kind of configuration problem.
> Thanks so much for your amazing work!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9782:
--

 Summary: Occasional failure in loading vanity paths due to 
UnsupportedOperationException
 Key: SLING-9782
 URL: https://issues.apache.org/jira/browse/SLING-9782
 Project: Sling
  Issue Type: Bug
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Resource Resolver 1.7.2


I sometimes see this kind of error on startup

{noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS NOT 
NULL, path=*, property=[sling:vanityPath=[is not null]]); consider creating an 
index or changing the query
15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
activate: Cannot access repository, failed setting up Mapping Support
java.lang.UnsupportedOperationException: null
at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
at 
org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
at 
org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
at 
org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
at 
org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
at 
org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
at 
org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:907)
 [org.apache.felix.scr:2.1.20]
at 
org.apache.felix.scr.impl.manager.AbstractComponentManager$3.register(AbstractComponentManager.java:893)
 [org.apache.felix.scr:2.1.20]
at 
org.apache.felix.scr.impl.manager.Regi

[jira] [Commented] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205537#comment-17205537
 ] 

Robert Munteanu commented on SLING-9782:


[~cziegeler] - according to the stack trace 1.7.0 . 

> Occasional failure in loading vanity paths due to 
> UnsupportedOperationException
> ---
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 

[jira] [Commented] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205539#comment-17205539
 ] 

Robert Munteanu commented on SLING-9782:


Looking at the stack trace, the put that fails is is on {{resolveMapsMap}}. 
That field is initialised as a {{Collections.singletonMap}} ( has been for at 
least 4 years ) and then swapped with a ConcurrentHashMap in {{doInit}}. Since 
{{doInit}} is called from the constructor ( and must be the same thread ) the 
only mode of failure that I see is the resolver or factory being null and 
{{doInit}} not completed successfully.

This can only happen when either {{resolver}} or {{factory}} are null. Since 
the {{CommonResourceResolverFactoryImpl}} initialises the {{MapEntries}} with 
_this_ as the argument for _factory_ and the resolver is created via 
{{factory.getServiceResourceResolver}}, I am not yet sure why this can fail.

Of course, I can replace the singleton map with a regular concurrent hashmap, 
but I think this will be hiding the problem instead of fixing the root cause.

> Occasional failure in loading vanity paths due to 
> UnsupportedOperationException
> ---
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> or

[jira] [Commented] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205541#comment-17205541
 ] 

Robert Munteanu commented on SLING-9782:


Hm, perhaps an exception is thrown is {{loadAliase}} and the resolve maps are 
not properly populated since. I'll try and obtain logs around it.

> Occasional failure in loading vanity paths due to 
> UnsupportedOperationException
> ---
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:483

[jira] [Commented] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205548#comment-17205548
 ] 

Robert Munteanu commented on SLING-9782:


That seems to be the case, loading aliases fails with

{noformat}15.09.2020 13:24:00.539 *WARN* [Apache Sling Repository Startup 
Thread #1] org.apache.jackrabbit.oak.query.FilterIterators The query read or 
traversed more than 10 nodes.
org.apache.jackrabbit.oak.query.RuntimeNodeTraversalException: The query read 
or traversed more than 10 nodes. To avoid affecting other tasks, processing 
was stopped.
at 
org.apache.jackrabbit.oak.query.FilterIterators.checkReadLimit(FilterIterators.java:70)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor.fetchNext(Cursors.java:341)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor.next(Cursors.java:320)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.query.ast.SelectorImpl.nextInternal(SelectorImpl.java:520)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.query.ast.SelectorImpl.next(SelectorImpl.java:508) 
[org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.fetchNext(QueryImpl.java:876)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.hasNext(QueryImpl.java:903)
 [org.apache.jackrabbit.oak-core:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$4.fetch(QueryResultImpl.java:186)
 [org.apache.jackrabbit.oak-jcr:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$4.(QueryResultImpl.java:181)
 [org.apache.jackrabbit.oak-jcr:1.33.0.R1880830]
at 
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl.getNodes(QueryResultImpl.java:174)
 [org.apache.jackrabbit.oak-jcr:1.33.0.R1880830]
at 
org.apache.sling.jcr.resource.internal.helper.jcr.BasicQueryLanguageProvider.findResources(BasicQueryLanguageProvider.java:83)
 [org.apache.sling.jcr.resource:3.0.22]
at 
org.apache.sling.resourceresolver.impl.providers.stateful.AuthenticatedResourceProvider.findResources(AuthenticatedResourceProvider.java:260)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl.findResources(ResourceResolverControl.java:459)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverImpl.findResources(ResourceResolverImpl.java:549)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadAliases(MapEntries.java:1025)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.doInit(MapEntries.java:197)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:160)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
 [org.apache.sling.resourceresolver:1.7.0]
at 
org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943

[jira] [Updated] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-01 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9782:
---
Component/s: ResourceResolver

> Occasional failure in loading vanity paths due to 
> UnsupportedOperationException
> ---
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
> 

[jira] [Commented] (SLING-9780) Log service missing after switching to the feature model

2020-10-01 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205587#comment-17205587
 ] 

Robert Munteanu commented on SLING-9780:


Great, thanks for confirming.

> Log service missing after switching to the feature model
> 
>
> Key: SLING-9780
> URL: https://issues.apache.org/jira/browse/SLING-9780
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Java 11 and 13 on MacOS
>Reporter: Hans-Peter Stoerr
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
> Attachments: LogserviceNotRunning.png, Starter11-HasLogService.png, 
> Starter12-NoLogService.png
>
>
> In the current Sling Starter 12 snapshot the OSGI Log Service does not work 
> properly. This has the effect that in the console at OSGI / Log Service 
> [http://localhost:8080/system/console/logs] there is only the display "Log 
> Service is not installed/running." and messages from OSGI (such as errors in 
> activation methods) are inconveniently logged to stdout instead of the 
> configured logfiles like error.log, which gave me some headache until I 
> noticed that. :)  Both the console plugin and the logging to error.log do 
> work properly in version 11.
> This is in spite of the bundle org.apache.sling.commons.logservice being 
> active. I tried downgrading it from the currently included 1.1.0 to 1.0.6, 
> which works in the version 11 of the Sling Starter, but this doesn't help. So 
> I guess it's some kind of configuration problem.
> Thanks so much for your amazing work!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9637) Re-enable Smoke IT, but only keep the repository available check

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9637:
--

Assignee: Robert Munteanu

> Re-enable Smoke IT, but only keep the repository available check
> 
>
> Key: SLING-9637
> URL: https://issues.apache.org/jira/browse/SLING-9637
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> The 'all bundles started' check is superfluous now that we have the feature 
> model analysers. However, it would be good to verify that the repository 
> successfully start up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9637) Re-enable Smoke IT, but only keep the repository available check

2020-10-02 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206152#comment-17206152
 ] 

Robert Munteanu commented on SLING-9637:


With https://github.com/apache/sling-org-apache-sling-starter/pull/14 I've 
re-enabled both tests. Since we already take the performance hit of waiting for 
the Starter to be available, it makes sense to run an additional quick check.

I expect the analysers to have very high fidelity, but perhaps there are some 
cases that slip.

> Re-enable Smoke IT, but only keep the repository available check
> 
>
> Key: SLING-9637
> URL: https://issues.apache.org/jira/browse/SLING-9637
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The 'all bundles started' check is superfluous now that we have the feature 
> model analysers. However, it would be good to verify that the repository 
> successfully start up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9637) Re-enable Smoke IT, but only keep the repository available check

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9637.

Resolution: Fixed

> Re-enable Smoke IT, but only keep the repository available check
> 
>
> Key: SLING-9637
> URL: https://issues.apache.org/jira/browse/SLING-9637
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The 'all bundles started' check is superfluous now that we have the feature 
> model analysers. However, it would be good to verify that the repository 
> successfully start up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9639) Deprecate no longer used launchpad testing projects

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9639:
--

Assignee: Robert Munteanu

> Deprecate no longer used launchpad testing projects
> ---
>
> Key: SLING-9639
> URL: https://issues.apache.org/jira/browse/SLING-9639
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> We can deprecated the following two projects:
> - launchpad-testing-bundles - now the launchpad-testing project has its own 
> feature model
> - launchpad-testing-war - wars are no longer supported



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9786) Use pre-authentication for system users

2020-10-02 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9786:
--

 Summary: Use pre-authentication for system users
 Key: SLING-9786
 URL: https://issues.apache.org/jira/browse/SLING-9786
 Project: Sling
  Issue Type: Improvement
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12


Oak [pre-authenticated 
login|https://jackrabbit.apache.org/oak/docs/security/authentication/preauthentication.html]
 without repository involvement presents a number of advantages:

- it is faster since the repository is not involved
- allows mapping a single principal to the repositories of multiple service 
users, making ACLs easier to define in a fine-grained manner

We should therefore switch the starter to the pre-auth setup for service users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9746) Add Scripting FreeMarker

2020-10-02 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206200#comment-17206200
 ] 

Robert Munteanu commented on SLING-9746:


[~olli] - I see the following error entries in the Starter log now

{noformat}02.10.2020 15:56:45.071 *ERROR* [FelixStartLevel] 
freemarker.configuration DefaultObjectWrapper.incompatibleImprovements was set 
to the object returned by Configuration.getVersion(). That defeats the purpose 
of inc
ompatibleImprovements, and makes upgrading FreeMarker a potentially breaking 
change. Also, this probably won't be allowed starting from 2.4.0. Instead, set 
incompatibleImprovements to the highest concrete version t
hat's known to be compatible with your application.
02.10.2020 15:56:45.072 *ERROR* [FelixStartLevel] freemarker.configuration 
Configuration.incompatibleImprovements was set to the object returned by 
Configuration.getVersion(). That defeats the purpose of 
incompatibleImprovements, and makes upgrading FreeMarker a potentially breaking 
change. Also, this probably won't be allowed starting from 2.4.0. Instead, set 
incompatibleImprovements to the highest concrete version that's known to be 
compatible with your application.{noformat}

It would be good to not have them in the released starter.

> Add Scripting FreeMarker
> 
>
> Key: SLING-9746
> URL: https://issues.apache.org/jira/browse/SLING-9746
> Project: Sling
>  Issue Type: New Feature
>  Components: Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Starter 12
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9786) Use pre-authentication for system users

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9786.

Resolution: Fixed

Fixed with https://github.com/apache/sling-org-apache-sling-starter/pull/15

> Use pre-authentication for system users
> ---
>
> Key: SLING-9786
> URL: https://issues.apache.org/jira/browse/SLING-9786
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Oak [pre-authenticated 
> login|https://jackrabbit.apache.org/oak/docs/security/authentication/preauthentication.html]
>  without repository involvement presents a number of advantages:
> - it is faster since the repository is not involved
> - allows mapping a single principal to the repositories of multiple service 
> users, making ACLs easier to define in a fine-grained manner
> We should therefore switch the starter to the pre-auth setup for service 
> users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9786) Use pre-authentication for system users

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9786:
---
Labels: Sling-12-ReleaseNotes  (was: )

> Use pre-authentication for system users
> ---
>
> Key: SLING-9786
> URL: https://issues.apache.org/jira/browse/SLING-9786
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Starter 12
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Oak [pre-authenticated 
> login|https://jackrabbit.apache.org/oak/docs/security/authentication/preauthentication.html]
>  without repository involvement presents a number of advantages:
> - it is faster since the repository is not involved
> - allows mapping a single principal to the repositories of multiple service 
> users, making ACLs easier to define in a fine-grained manner
> We should therefore switch the starter to the pre-auth setup for service 
> users.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9638) Update Starter Docker image to be based on the feature model

2020-10-02 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9638:
--

Assignee: Robert Munteanu

> Update Starter Docker image to be based on the feature model
> 
>
> Key: SLING-9638
> URL: https://issues.apache.org/jira/browse/SLING-9638
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9818) Move repoinit statements out of feature files

2020-10-13 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9818:
--

 Summary: Move repoinit statements out of feature files
 Key: SLING-9818
 URL: https://issues.apache.org/jira/browse/SLING-9818
 Project: Sling
  Issue Type: Improvement
  Components: Starter
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Starter 12


With SLING-9725 we can now store the repoinit declarations outside the feature 
model, which is IMO much more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-9782) Occasional failure in loading vanity paths due to UnsupportedOperationException

2020-10-13 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9782:
--

Assignee: (was: Robert Munteanu)

> Occasional failure in loading vanity paths due to 
> UnsupportedOperationException
> ---
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 
> org.apache.fe

[jira] [Updated] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-13 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9782:
---
Summary: Failure in loading vanity paths due to query limit being reached  
(was: Occasional failure in loading vanity paths due to 
UnsupportedOperationException)

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.ap

[jira] [Resolved] (SLING-9818) Move repoinit statements out of feature files

2020-10-13 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9818.

Resolution: Fixed

Fixed with [sling-org-apache-sling-starter commit 
6df89a0|https://github.com/apache/sling-org-apache-sling-starter/commit/6df89a0]


> Move repoinit statements out of feature files
> -
>
> Key: SLING-9818
> URL: https://issues.apache.org/jira/browse/SLING-9818
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
>
> With SLING-9725 we can now store the repoinit declarations outside the 
> feature model, which is IMO much more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9818) Move repoinit statements out of feature files

2020-10-13 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213062#comment-17213062
 ] 

Robert Munteanu commented on SLING-9818:


Missing copyright headers added with [sling-org-apache-sling-starter commit 
ccc945d|https://github.com/apache/sling-org-apache-sling-starter/commit/ccc945d].

> Move repoinit statements out of feature files
> -
>
> Key: SLING-9818
> URL: https://issues.apache.org/jira/browse/SLING-9818
> Project: Sling
>  Issue Type: Improvement
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Starter 12
>
>
> With SLING-9725 we can now store the repoinit declarations outside the 
> feature model, which is IMO much more readable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-13 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213133#comment-17213133
 ] 

Robert Munteanu commented on SLING-9782:


[~angela] - in the scenario where I saw this there should be a Lucene index for 
{{sling:alias}}.My (admittedly incomplete) understanding is that a query like 
{{SELECT sling:alias FROM nt:base WHERE sling:alias IS NOT NULL}} will read all 
sling:alias nodes and if the number of such nodes is greater than the 
QueryEngineSettings/LimitReads value then it will fail, irrespective of indexes.

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> or

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213718#comment-17213718
 ] 

Robert Munteanu commented on SLING-9782:


[~cziegeler] - my understanding is that the current exception is because of the 
query problem. Or do you see something else here?

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:48

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213819#comment-17213819
 ] 

Robert Munteanu commented on SLING-9782:


[~cziegeler] - I see what you mean now. Well, there is a catch block in 
{{doInit}} that seems to indicate that initialisation should proceed despite 
any errors. It's easy for me to remove that, do you think it's safe to do so?

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(Ev

[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213921#comment-17213921
 ] 

Robert Munteanu commented on SLING-9782:


I think error log + continue with disabled optimisation is a good compromise 
here, especially since we'll be logging a stack trace and those tend to grab 
people's attention.

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.f

[jira] [Commented] (SLING-9826) jcr:uuid index not updated on move

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214022#comment-17214022
 ] 

Robert Munteanu commented on SLING-9826:


Thanks for the report. In SLING-9825 we see a potentially related bug report 
that was fixed by downgrading org.apache.sling:org.apache.sling.jcr.oak.server 
to 1.2.4. Can you try that and see if it fixes your problem?

> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
>  Issue Type: Bug
>  Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Major
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling 
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes 
> that are mix:referenceable by their jcr:uuid after they have been moved in 
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException, 
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh 
> of the /oak:index/uuid, the node is found again - until it is moved again. 
> The query problem is also easy to replicate by creating a mix:referenceable 
> node in the browser, moving it and trying to query it with 
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not 
> possible to reproduce this with the oak-jcr tests. I could also not reproduce 
> it with a unit test in org-apache-sling-jcr-resource, only when using the 
> Sling Starter 12. [This comment on my Oak 
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
>  suggests that there might be some misconfiguration in Sling.
> Thank you very much!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9825) Bundle Content Install Fails in Composite Store Seeding

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214023#comment-17214023
 ] 

Robert Munteanu commented on SLING-9825:


I did see some issues in my composite demo for the adaptTo conference and 
rolled back to oak.server 1.2.6 . Does that work for you or do you have to use 
1.2.4?

> Bundle Content Install Fails in Composite Store Seeding
> ---
>
> Key: SLING-9825
> URL: https://issues.apache.org/jira/browse/SLING-9825
> Project: Sling
>  Issue Type: Bug
>  Components: Oak
>Affects Versions: JCR Oak Server 1.2.8
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
>
> When running with JCR Oak Server 1.2.8, installing Bundle Content fails with 
> exceptions complaining about UUID conflicts, for example:
> {{08.10.2020 23:02:19.406 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load 
> initial content for bundle org.apache.sling.cms.ui : OakConstraint0030: 
> Uniqueness constraint violated property [jcr:uuid] having value 
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6: 
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content
> javax.jcr.nodetype.ConstraintViolationException: OakConstraint0030: 
> Uniqueness constraint violated property [jcr:uuid] having value 
> 5f5e23b5-e45b-4c8f-ac2f-fc725e3c14b6: 
> /libs/sling-cms/components/cms/blank/blank.jsp/jcr:content}}
> Reverting to 1.2.4 resolves the issue. I suspect the issue may be due to the 
> following commit, but I need to do more analysis: 
> https://github.com/apache/sling-org-apache-sling-jcr-oak-server/commit/77c571f03362f1d7b4ec33842c09ef23c85759ed



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9826) jcr:uuid index not updated on move

2020-10-14 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214024#comment-17214024
 ] 

Robert Munteanu commented on SLING-9826:


Oh, and it would be good to test with 1.2.6 as well if you have the time.

> jcr:uuid index not updated on move
> --
>
> Key: SLING-9826
> URL: https://issues.apache.org/jira/browse/SLING-9826
> Project: Sling
>  Issue Type: Bug
>  Components: JCR, Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Major
>
> When changing from Sling Starter 11 to the (almost) latest version of Sling 
> Starter 12-SNAPSHOT I get the problem that it is not possible to find nodes 
> that are mix:referenceable by their jcr:uuid after they have been moved in 
> the JCR tree: Session.getNodeByIdentifier throws an ItemNotFoundException, 
> and a query /jcr:root//*[@jcr:uuid='${uuid}'] does not find the node.
> I tested it with the following code (Node and Session being from javax.jcr.*):
> {code:java}
> Node parent = session.getNode(PATH);
> String name = "child" + System.currentTimeMillis();
> Node child = parent.addNode(name, "sling:Folder");
> child.addMixin("mix:referenceable");
> session.save();
> String id = child.getIdentifier();
> // session.getNodeByIdentifier(id); // OK, works as expected here.
> session.move(child.getPath(), PATH2 + "/" + name);
> session.save();
> session.getNodeByIdentifier(id); // often throws ItemNotFoundException!
> {code}
> PATH and PATH2 denote two preexisting writeable nodes. If I force a refresh 
> of the /oak:index/uuid, the node is found again - until it is moved again. 
> The query problem is also easy to replicate by creating a mix:referenceable 
> node in the browser, moving it and trying to query it with 
> /jcr:root//*[@jcr:uuid='${uuid}'] .
> I initially reported the bug to the Jackrabbit OAK project, but it is not 
> possible to reproduce this with the oak-jcr tests. I could also not reproduce 
> it with a unit test in org-apache-sling-jcr-resource, only when using the 
> Sling Starter 12. [This comment on my Oak 
> bugreport|https://issues.apache.org/jira/browse/OAK-9253?focusedCommentId=17213939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17213939]
>  suggests that there might be some misconfiguration in Sling.
> Thank you very much!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9821) Error message points to non-existing method

2020-10-15 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9821:
---
Fix Version/s: JCR Base 3.1.8

> Error message points to non-existing method
> ---
>
> Key: SLING-9821
> URL: https://issues.apache.org/jira/browse/SLING-9821
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Reporter: Angela Schreiber
>Priority: Trivial
> Fix For: JCR Base 3.1.8
>
>
> https://github.com/apache/sling-org-apache-sling-jcr-base/blame/master/src/main/java/org/apache/sling/jcr/base/AbstractSlingRepositoryManager.java#L573
> logs the following error:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stopRepository()", e);
> {code}
> but there no method {{stopRepository()}}. the method that is called is 
> {{stop()}}.
> so, the right log output should read instead:
> {code}
> log.error("start: Uncaught Throwable trying to access Repository, calling 
> stop()", e);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12

2020-10-15 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214543#comment-17214543
 ] 

Robert Munteanu commented on SLING-9824:


[~kpauls], [~davidb] - any thoughts on this?

> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
>
> We are having some trouble running our application on [the current Sling 
> Starter 12 
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
>  since we are using ehache 3, which uses sun.misc.Unsafe internally. This 
> works with Sling Starter 11, but since Sling Starter changed to the feature 
> launcher, this class seems to have disappeared from the classpath: the class 
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError: 
> sun/misc/Unsafe
> I tried to add command line arguments
>  --add-modules=jdk.unsupported
>  and
>  --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
>  to the launcher command line, as I've seen that suggested on the net for 
> similar problems, but it didn't help.
>  In fact, this doesn't seem to be the problem: even without those flags the 
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports: 
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
>  <%
>  Class clazz = sun.misc.Unsafe.class;
>  %>
>  In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on 
> an x86_64 Linux.
>  This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add 
>  {{-D org.osgi.framework.system.packages.extra=sun.misc}}
>  to the command line, which was thankfully suggested [in the mailing 
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does 
> work. But I feel it is not a particularily clean solution. It also does 
> something else than what happens on Sling Starter 11 : now the sun.misc 
> package is listed in the exports list of the felix framework bundle 
>  [http://localhost:9090/system/console/bundles/0] . Not sure whether this is 
> good or bad.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-9722) AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked multiple times

2020-10-15 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-9722.
--

> AbstractSlingRepositoryManager.stop throws NullPointerExceptions if invoked 
> multiple times
> --
>
> Key: SLING-9722
> URL: https://issues.apache.org/jira/browse/SLING-9722
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 3.1.4
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: JCR Base 3.1.6
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> The stop method has a check for the currentThread
> {code:java}
> if ( startupThread != Thread.currentThread() ) {
> waitForStartupThreadToComplete();
> startupThread = null;
> }
> {code}
> On the first invocation, the {{startupThread}} is not null, the if block is 
> entered and the field is then set to null. On subsequent invocations, the 
> condition will also be true, since {{startupThread == null}}, which will 
> cause an NPE in the {{waitForStartupThreadToComplete}} method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9639) Deprecate no longer used launchpad testing projects

2020-10-15 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9639.

Resolution: Fixed

Done with 
- [sling-org-apache-sling-launchpad-test-bundles commit 
710c8e4|https://github.com/apache/sling-org-apache-sling-launchpad-test-bundles/commit/710c8e4]
- [sling-org-apache-sling-launchpad-testing-war commit 
2592e23|https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/commit/2592e23]
- [sling-org-apache-sling-launchpad-testing-war commit 
68e9af6|https://github.com/apache/sling-org-apache-sling-launchpad-testing-war/commit/68e9af6]


> Deprecate no longer used launchpad testing projects
> ---
>
> Key: SLING-9639
> URL: https://issues.apache.org/jira/browse/SLING-9639
> Project: Sling
>  Issue Type: Sub-task
>  Components: Launchpad, Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> We can deprecated the following two projects:
> - launchpad-testing-bundles - now the launchpad-testing project has its own 
> feature model
> - launchpad-testing-war - wars are no longer supported



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9782) Failure in loading vanity paths due to query limit being reached

2020-10-19 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216509#comment-17216509
 ] 

Robert Munteanu commented on SLING-9782:


[~cziegeler] - LGTM, with a minor naming nitpick.

> Failure in loading vanity paths due to query limit being reached
> 
>
> Key: SLING-9782
> URL: https://issues.apache.org/jira/browse/SLING-9782
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.7.0
>Reporter: Robert Munteanu
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: Resource Resolver 1.7.2
>
>
> I sometimes see this kind of error on startup
> {noformat}15.09.2020 13:24:02.582 *WARN* [Apache Sling Repository Startup 
> Thread #1] org.apache.jackrabbit.oak.plugins.index.Cursors$TraversingCursor 
> Traversed 79000 nodes with filter Filter(query=SELECT sling:vanityPath, 
> sling:redirect, sling:redirectStatus FROM nt:base WHERE sling:vanityPath IS 
> NOT NULL, path=*, property=[sling:vanityPath=[is not null]]); consider 
> creating an index or changing the query
> 15.09.2020 13:24:02.617 *ERROR* [Apache Sling Repository Startup Thread #1] 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl 
> activate: Cannot access repository, failed setting up Mapping Support
> java.lang.UnsupportedOperationException: null
>   at java.base/java.util.AbstractMap.put(AbstractMap.java:209)
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.addEntry(MapEntries.java:1007)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPath(MapEntries.java:1212)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.loadVanityPaths(MapEntries.java:1138)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.initializeVanityPaths(MapEntries.java:253)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.mapping.MapEntries.(MapEntries.java:175)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.CommonResourceResolverFactoryImpl.activate(CommonResourceResolverFactoryImpl.java:325)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.registerFactory(ResourceResolverFactoryActivator.java:496)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.checkFactoryPreconditions(ResourceResolverFactoryActivator.java:560)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator.access$100(ResourceResolverFactoryActivator.java:73)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator$1.providerAdded(ResourceResolverFactoryActivator.java:394)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.register(ResourceProviderTracker.java:217)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker.access$200(ResourceProviderTracker.java:59)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:130)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.apache.sling.resourceresolver.impl.providers.ResourceProviderTracker$1.addingService(ResourceProviderTracker.java:106)
>  [org.apache.sling.resourceresolver:1.7.0]
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework

[jira] [Created] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

2020-10-19 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9838:
--

 Summary: Jenkins builds fail: ERROR: Could not find the JDK 
installation: JDK 1.8 (latest)
 Key: SLING-9838
 URL: https://issues.apache.org/jira/browse/SLING-9838
 Project: Sling
  Issue Type: Bug
  Components: Build and Source Control
Reporter: Robert Munteanu
Assignee: Robert Munteanu


With INFRA-20858 the names of the tools have changed and we need to update, 
otherwise all builds will keep failing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

2020-10-19 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9838:
---
Description: With INFRA-20858 the names of the tools have changed and we 
need to update, otherwise all builds will keep failing. A more detailed 
description and a discussion is at 
https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
 ..  (was: With INFRA-20858 the names of the tools have changed and we need to 
update, otherwise all builds will keep failing.)

> Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 
> (latest)
> -
>
> Key: SLING-9838
> URL: https://issues.apache.org/jira/browse/SLING-9838
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
>
> With INFRA-20858 the names of the tools have changed and we need to update, 
> otherwise all builds will keep failing. A more detailed description and a 
> discussion is at 
> https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
>  ..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9838) Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 (latest)

2020-10-19 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9838.

Resolution: Fixed

Fixed with [sling-tooling-jenkins commit 
85f35e1|https://github.com/apache/sling-tooling-jenkins/commit/85f35e1].

> Jenkins builds fail: ERROR: Could not find the JDK installation: JDK 1.8 
> (latest)
> -
>
> Key: SLING-9838
> URL: https://issues.apache.org/jira/browse/SLING-9838
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
>
> With INFRA-20858 the names of the tools have changed and we need to update, 
> otherwise all builds will keep failing. A more detailed description and a 
> discussion is at 
> https://lists.apache.org/thread.html/rb4c2834b9874b9f4a74c528de9055958483d2bc6e62c3464bc5c053f%40%3Cbuilds.apache.org%3E
>  ..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9839) Jenkins: Sonarcloud analysis with Java 11

2020-10-19 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216515#comment-17216515
 ] 

Robert Munteanu commented on SLING-9839:


Yes, we need to adapt somehow to these changes. One thing to keep in mind is 
that not all modules will build on Java 11 (but I don't have numbers ATM).

> Jenkins: Sonarcloud analysis with Java 11
> -
>
> Key: SLING-9839
> URL: https://issues.apache.org/jira/browse/SLING-9839
> Project: Sling
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> As SonarSource is stopping support for Java 8 analysis 
> (https://sonarcloud.io/documentation/appendices/move-analysis-java-11/), we 
> should switch to matrix builds with Jenkins with Java 8 and 11 builds in 
> parallel 
> (https://www.jenkins.io/blog/2019/12/02/matrix-building-with-scripted-pipeline/
>  ).
> The Java 8 build should be deployed to Apache Snapshots (for backwards 
> compatibility reasons). The Java 11 build should be used for coverage 
> analysis and sonar execution..



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9850) Clarify null return values for ResourceResolver.map(...)

2020-10-23 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219639#comment-17219639
 ] 

Robert Munteanu commented on SLING-9850:


[~kwin] - I agree, both should be {{@Nullable}} by looking at the code. That 
being said, I'm not sure how we can not have at least one mapping, looking at 
https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L125-L143
 .

> Clarify null return values for ResourceResolver.map(...)
> 
>
> Key: SLING-9850
> URL: https://issues.apache.org/jira/browse/SLING-9850
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.23.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the two signatures of {{map}} differ by their null return 
> annotation:
> - 
> https://github.com/apache/sling-org-apache-sling-api/blob/3e9cf187eff999235ee161e0543f1d8a68c4285c/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L294
>  (must not return null)
> and
> - 
> https://github.com/apache/sling-org-apache-sling-api/blob/3e9cf187eff999235ee161e0543f1d8a68c4285c/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L332
>  (may return null)
> The implementation of both may return null though in fact, IIU
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L40,
>  
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L420
>  and 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L75
>  correctly.
> The javadoc for both methods should be clarified with regards to when to 
> expect a null value and most probably the null annotations need to be fixed 
> as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9850) Clarify null return values for ResourceResolver.map(...)

2020-10-28 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222100#comment-17222100
 ] 

Robert Munteanu commented on SLING-9850:


That would work for me, given that we add an assertion somewhere verifying that 
we don't actually return a null value through some edge case.

> Clarify null return values for ResourceResolver.map(...)
> 
>
> Key: SLING-9850
> URL: https://issues.apache.org/jira/browse/SLING-9850
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.23.0
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently the two signatures of {{map}} differ by their null return 
> annotation:
> - 
> https://github.com/apache/sling-org-apache-sling-api/blob/3e9cf187eff999235ee161e0543f1d8a68c4285c/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L294
>  (must not return null)
> and
> - 
> https://github.com/apache/sling-org-apache-sling-api/blob/3e9cf187eff999235ee161e0543f1d8a68c4285c/src/main/java/org/apache/sling/api/resource/ResourceResolver.java#L332
>  (may return null)
> The implementation of both may return null though in fact, IIU
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L40,
>  
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java#L420
>  and 
> https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/657055bcb31059dc7b71cde55941fb2050cbaddb/src/main/java/org/apache/sling/resourceresolver/impl/mapping/ResourceMapperImpl.java#L75
>  correctly.
> The javadoc for both methods should be clarified with regards to when to 
> expect a null value and most probably the null annotations need to be fixed 
> as well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9877) Schema related errors are not captured and returned as a GraphQL error response

2020-11-05 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9877:
---
Summary: Schema related errors are not captured and returned as a GraphQL 
error response  (was: Schema related errors are not captured and returned as a 
GrpahQL error response)

> Schema related errors are not captured and returned as a GraphQL error 
> response
> ---
>
> Key: SLING-9877
> URL: https://issues.apache.org/jira/browse/SLING-9877
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Affects Versions: GraphQL Core 0.0.6
>Reporter: Jabran Asghar
>Assignee: Bertrand Delacretaz
>Priority: Major
> Fix For: GraphQL Core 0.0.8
>
>
> *Problem:*
>  GraphQL query execution problems are captured by SLING-9847 and SLING-9870, 
> but errors which may occur due to schema being not valid (for any reason), 
> are still not captured. In such cases, a non standard error response is sent 
> back to client.
> *Proposed solution:*
>  Capture the errors, and format it according to GraphQL error response 
> specification [0]. Utilize "extensions" JSON property to capture any 
> additional meaningful information.
> PR: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/14
>  
> [0] [http://spec.graphql.org/June2018/#sec-Errors]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9535) Improve performance of sling:alias Query when Optimize alias resolution is activated

2020-11-06 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227399#comment-17227399
 ] 

Robert Munteanu commented on SLING-9535:


[~akanksha88] - thanks for the PR! I made a first review, it would be good if 
someone else could look as well.

> Improve performance of sling:alias Query when Optimize alias resolution is 
> activated
> 
>
> Key: SLING-9535
> URL: https://issues.apache.org/jira/browse/SLING-9535
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Leonardo Derks
>Priority: Major
> Attachments: image-2020-06-19-18-29-24-335.png, 
> image-2020-06-19-18-33-21-657.png
>
>
> Improve performance of sling:alias Query when Optimize alias resolution is 
> activated in the Resource Resolver Factory:
> !image-2020-06-19-18-29-24-335.png!
> By checking the logs at startup this query is executed:
> {noformat}
> (query=SELECT sling:alias FROM nt:base WHERE sling:alias IS NOT NULL, path=*, 
> property=[sling:alias=[is not null]]){noformat}
> *The part that will be good to improve is that the query is not executed for 
> path=*, instead a predefined set of locations is used.*
> (Something similar as it is for the Vanity Paths will be nice):
> !image-2020-06-19-18-33-21-657.png!
> Then if none fo these are configured then the query is executed with path=*.
>  
> In our project several versions are created per page and it turns out that 
> the sling:alias found under _/jcr:system/jcr:versionStorage_ are also 
> including in the query exceeding the 1 limit mentioned in the warning 
> message of the property:
> _This might have an impact on the startup time and on the alias update time 
> if the number of aliases is huge (over 1)_
>  
> We might have a different approach to solve our issue but did not want to 
> leave this topic in the air. Might be also a good improvement for others.
>  
> Thanks
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9882) Add more information about the project in the README

2020-11-06 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-9882:
--

 Summary: Add more information about the project in the README
 Key: SLING-9882
 URL: https://issues.apache.org/jira/browse/SLING-9882
 Project: Sling
  Issue Type: Task
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
 Fix For: Content Package Archetype 1.0.2


[~reusr1] points out that we could use some more documentation in 
sling-content-package-archetype, see for example 
https://github.com/apache/sling-project-archetype/blob/master/README.md .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9692) Add support for principal-based access control entries

2020-11-12 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230483#comment-17230483
 ] 

Robert Munteanu commented on SLING-9692:


Those are good points, thanks for taking the time to list them [~angela]

> Add support for principal-based access control entries
> --
>
> Key: SLING-9692
> URL: https://issues.apache.org/jira/browse/SLING-9692
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.1.2
>
>
> When passed a content package that contains principal-based access control 
> entries, the converter ignores them. It should instead generate the proper 
> repoinit statements.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9901) JcrSystemUserValidatorTest contains not tests for system users

2020-11-12 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230750#comment-17230750
 ] 

Robert Munteanu commented on SLING-9901:


[~angela] - I suspect the answer here is to use the Sling mocks with the 
{{JCR_OAK}} backend. I am not aware of a Oak-enabled class similar to 
{{RepositoryTestBase}}.

> JcrSystemUserValidatorTest contains not tests for system users
> --
>
> Key: SLING-9901
> URL: https://issues.apache.org/jira/browse/SLING-9901
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Angela Schreiber
>Priority: Minor
>
> _org.apache.sling.jcr.resource_ comes with a {{JcrSystemUserValidator}} that 
> adds validation to service-user-mapping and if enable prevents regular users 
> or groups from being mapped.
> however, {{JcrSystemUserValidatorTest}} doesn't contain a single test case 
> verifying if the validation is actually successful for system users (or that 
> disabled system users would not be valid).
> i suspect that this is due to the fact that 
> {{org.apache.sling.commons.testing.jcr.RepositoryTestBase}} creates a 
> Jackrabbit repository and has never been adjusted to allow for an Oak 
> repository to be used as test repository. In other words: an attempt to 
> create a system user will fail.
> [~rombert], is there an alternative to the {{RepositoryTestBase}} that would 
> operate on a Oak repository?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9901) JcrSystemUserValidatorTest contains not tests for system users

2020-11-13 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231371#comment-17231371
 ] 

Robert Munteanu commented on SLING-9901:


[~angela] - yes, there is a bit of investment needed for the setup with Sling 
Mocks, especially in terms of classpath.

> JcrSystemUserValidatorTest contains not tests for system users
> --
>
> Key: SLING-9901
> URL: https://issues.apache.org/jira/browse/SLING-9901
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Angela Schreiber
>Priority: Minor
>
> _org.apache.sling.jcr.resource_ comes with a {{JcrSystemUserValidator}} that 
> adds validation to service-user-mapping and if enable prevents regular users 
> or groups from being mapped.
> however, {{JcrSystemUserValidatorTest}} doesn't contain a single test case 
> verifying if the validation is actually successful for system users (or that 
> disabled system users would not be valid).
> i suspect that this is due to the fact that 
> {{org.apache.sling.commons.testing.jcr.RepositoryTestBase}} creates a 
> Jackrabbit repository and has never been adjusted to allow for an Oak 
> repository to be used as test repository. In other words: an attempt to 
> create a system user will fail.
> [~rombert], is there an alternative to the {{RepositoryTestBase}} that would 
> operate on a Oak repository?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-5652) Publishing content fails if intermediate nodes are not present in the repository

2016-04-12 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5652:
--

Assignee: Robert Munteanu

> Publishing content fails if intermediate nodes are not present in the 
> repository
> 
>
> Key: SLING-5652
> URL: https://issues.apache.org/jira/browse/SLING-5652
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Graham
>Assignee: Robert Munteanu
> Attachments: sling5652.zip
>
>
> I'm seeing the issue https://issues.apache.org/jira/browse/SLING-3586 with 
> Sling Eclipse IDE 1.1.0
> The error is
> Failed exporting: JcrResult[ success:false, exception: 
> org.apache.sling.ide.transport.RepositoryException - 
> javax.jcr.RepositoryException: No parent found at 
> /content/sling5652/en/thankyou/jcr:content/image/file ; it's needed to create 
> node at /content/sling5652/en/thankyou/jcr:content/image/file/jcr:content] 
> Is it possible that this has creeped back in?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5652) Publishing content fails if intermediate nodes are not present in the repository

2016-04-12 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237285#comment-15237285
 ] 

Robert Munteanu commented on SLING-5652:


Thanks for the sample project. However, this 'works for me'. Here's what I've 
done

# Imported the SLING5652 project in my Eclipse workspace
# Started a new AEM server ( since the project references the {{cq}} namespace )
# Added the module to the server

Export was successful. Another attempt

# Deleted /content/sling5652 using CRXDE Lite
# Right-clicked the project in the Project Explorer
# Selected AEM -> Export to Server
# Clicked Finish

This was also successful. Do you have other steps to reproduce? If this works 
for you, can you please:

# let me know your JVM version + OS
# upload debug + trace logs as per 
https://sling.apache.org/documentation/development/ide-tooling.html#gathering-debug-information
 


> Publishing content fails if intermediate nodes are not present in the 
> repository
> 
>
> Key: SLING-5652
> URL: https://issues.apache.org/jira/browse/SLING-5652
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Graham
>Assignee: Robert Munteanu
> Attachments: sling5652.zip
>
>
> I'm seeing the issue https://issues.apache.org/jira/browse/SLING-3586 with 
> Sling Eclipse IDE 1.1.0
> The error is
> Failed exporting: JcrResult[ success:false, exception: 
> org.apache.sling.ide.transport.RepositoryException - 
> javax.jcr.RepositoryException: No parent found at 
> /content/sling5652/en/thankyou/jcr:content/image/file ; it's needed to create 
> node at /content/sling5652/en/thankyou/jcr:content/image/file/jcr:content] 
> Is it possible that this has creeped back in?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5146) Add JSONObject/JSONArray support to JSONWriter

2016-04-21 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5146:
---
Fix Version/s: Commons JSON 2.0.18

> Add JSONObject/JSONArray support to JSONWriter
> --
>
> Key: SLING-5146
> URL: https://issues.apache.org/jira/browse/SLING-5146
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Damien Antipa
>Priority: Minor
> Fix For: Commons JSON 2.0.18
>
>
> JSONWriter should be able to accept JSONObject and JSONArray as parameter to 
> generate their output
> PR: https://github.com/apache/sling/pull/106



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5146) Add JSONObject/JSONArray support to JSONWriter

2016-04-25 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5146:
--

Assignee: Robert Munteanu

> Add JSONObject/JSONArray support to JSONWriter
> --
>
> Key: SLING-5146
> URL: https://issues.apache.org/jira/browse/SLING-5146
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Damien Antipa
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons JSON 2.0.18
>
>
> JSONWriter should be able to accept JSONObject and JSONArray as parameter to 
> generate their output
> PR: https://github.com/apache/sling/pull/106



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5146) Add JSONObject/JSONArray support to JSONWriter

2016-04-25 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5146.

Resolution: Fixed

Applied, thanks [~dantipa]!

> Add JSONObject/JSONArray support to JSONWriter
> --
>
> Key: SLING-5146
> URL: https://issues.apache.org/jira/browse/SLING-5146
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Damien Antipa
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons JSON 2.0.18
>
>
> JSONWriter should be able to accept JSONObject and JSONArray as parameter to 
> generate their output
> PR: https://github.com/apache/sling/pull/106



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5652) Publishing content fails if intermediate nodes are not present in the repository

2016-04-25 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256227#comment-15256227
 ] 

Robert Munteanu commented on SLING-5652:


The console logs don't offer much extra information - it seems that indeed an 
intermediate folder is skipped.

Can you please upload the debug + trace logs as per 
https://sling.apache.org/documentation/development/ide-tooling.html#gathering-debug-information
 ? Note that these are different from the console logs and will typically 
reside on the filesystem.

> Publishing content fails if intermediate nodes are not present in the 
> repository
> 
>
> Key: SLING-5652
> URL: https://issues.apache.org/jira/browse/SLING-5652
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.1.0
>Reporter: Graham
>Assignee: Robert Munteanu
> Attachments: SLING-5652-aem-access-logs.txt, 
> SLING-5652-aem-console-logs.txt, sling5652.zip
>
>
> I'm seeing the issue https://issues.apache.org/jira/browse/SLING-3586 with 
> Sling Eclipse IDE 1.1.0
> The error is
> Failed exporting: JcrResult[ success:false, exception: 
> org.apache.sling.ide.transport.RepositoryException - 
> javax.jcr.RepositoryException: No parent found at 
> /content/sling5652/en/thankyou/jcr:content/image/file ; it's needed to create 
> node at /content/sling5652/en/thankyou/jcr:content/image/file/jcr:content] 
> Is it possible that this has creeped back in?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5662) Maven license report extracted URLs are 404

2016-05-04 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270281#comment-15270281
 ] 

Robert Munteanu commented on SLING-5662:


The plug-in pages don't make it immediately obvious, but do you know how the 
plug-in checks for the license URL? The Sling projects ( and I assume Felix and 
Jackrabbit as well ) inherit the license settings from the Apache parent pom ( 
see 
http://svn.apache.org/viewvc/maven/pom/tags/apache-17/pom.xml?view=markup#l45 
for the license block ).

Running {{mvn help:effective-pom}} does show a correct license POM block for 
{{org.apache.sling.api}}

{code:xml}
  

  Apache License, Version 2.0
  http://www.apache.org/licenses/LICENSE-2.0.txt
  repo

  

{code}

> Maven license report extracted URLs are 404
> ---
>
> Key: SLING-5662
> URL: https://issues.apache.org/jira/browse/SLING-5662
> Project: Sling
>  Issue Type: Bug
>  Components: Distribution
>Reporter: Bruce Edge
>Priority: Trivial
>
> The maven license plugin that extracts licenses from 3rd party components:
>   org.codehaus.mojo
>   license-maven-plugin
>   1.8
> The extracted URLs for all of the sling components all 404.
>  (The Apache Software License, Version 2.0) Apache Sling API 
> (org.apache.sling:org.apache.sling.api:2.4.2 - 
> http://sling.apache.org/org.apache.sling.api)
>  (The Apache Software License, Version 2.0) Apache Sling Commons OSGi 
> support (org.apache.sling:org.apache.sling.commons.osgi:2.2.2 - 
> http://sling.apache.org/org.apache.sling.commons.osgi)
>  (The Apache Software License, Version 2.0) Apache Sling Event Support 
> (org.apache.sling:org.apache.sling.event:3.3.0 - 
> http://sling.apache.org/org.apache.sling.event)
>  (The Apache Software License, Version 2.0) Apache Sling Wrapper Bundle 
> for the JCR API (org.apache.sling:org.apache.sling.jcr.jcr-wrapper:2.0.0 - 
> http://sling.apache.org/org.apache.sling.jcr.jcr-wrapper)
>  (The Apache Software License, Version 2.0) Apache Sling Query 
> (org.apache.sling:org.apache.sling.query:3.0.0 - 
> http://sling.apache.org/org.apache.sling.query)
>  (The Apache Software License, Version 2.0) Apache Sling Default POST 
> Servlets (org.apache.sling:org.apache.sling.servlets.post:2.3.6 - 
> http://sling.apache.org/org.apache.sling.servlets.post)
> The same is true for all of the felix & jackrabbit components. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5449) Content repository initialization language

2016-05-25 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300819#comment-15300819
 ] 

Robert Munteanu commented on SLING-5449:


Are there any plans to add support for creating regular users and groups, and 
maybe defining group memberships?

> Content repository initialization language
> --
>
> Key: SLING-5449
> URL: https://issues.apache.org/jira/browse/SLING-5449
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-5449-launchpad-testing.patch
>
>
> Discussions on our dev list and with my colleagues around SLING-5355 (the ACL 
> definition language) show that we need to initialize a number of things when 
> starting on a new or existing content repository:
> * Create the "base tree", paths like /libs, /apps, /var that many modules use 
> and sometimes compete to create.
> * Create service users
> * Set ACLs on the base tree for those service users
> * And maybe setup some JCR-specific things like node types and custom 
> privileges, that other content repositories would ignore.
> I'll create a more general module than what I created for SLING-5355 (which 
> hasn't been released) to cover those things, and put it under 
> {{commons/repoinit}} as it shouldn't have any dependencies on Sling. We might 
> donate it to Jackrabbit once it matures but for now my goal is to implement 
> the whole cycle inside Sling as it's the primary customer of that.
> The JCR-specific APIs should only use a JCR Session as a handle to the 
> content repository, to keep this independent of Sling and allow it to be used 
> in other contexts like tests.
> _Edit: changed the path from {{commons/jcrinit}} to {{commons/repoinit}}, 
> even if some parts are specific to JCR the repoinit language will be mostly 
> generic_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-06 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5763:
---
Affects Version/s: (was: Maven JSPC Plugin 2.0.8)
   Scripting JSP 2.1.8

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.1.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.

[jira] [Updated] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-06 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5763:
---
Component/s: (was: Maven Plugins and Archetypes)
 Scripting

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.1.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(La

[jira] [Commented] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-06 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316282#comment-15316282
 ] 

Robert Munteanu commented on SLING-5763:


What version of the {{org.apache.sling.scripting.jsp}} bundle do you use?

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.1.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus

[jira] [Commented] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-06 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15316465#comment-15316465
 ] 

Robert Munteanu commented on SLING-5763:


Hm, that version is pretty old. Could you quickly try the latest 9-SNAPSHOT 
version of the Sling Launchpad and see if that fixes your problem? Looking at 
the commit log for the `scripting.jsp` bundle I can spot at least SLING-3405 
and SLING-3724 as related to your problem.

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.1.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl

[jira] [Updated] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-07 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5763:
---
Component/s: (was: Scripting)
 Maven Plugins and Archetypes

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.0.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classworlds.launcher.Lau

[jira] [Updated] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-07 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5763:
---
Affects Version/s: (was: Scripting JSP 2.1.8)
   Maven JSPC Plugin 2.0.8

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.0.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> org.codehaus.plexus.classwo

[jira] [Commented] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-07 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318461#comment-15318461
 ] 

Robert Munteanu commented on SLING-5763:


Ah, sorry, I completely misread your report. I though this was happening at 
runtime and mistook the component as 'it happened on a project generated using 
the Maven archetype'.

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.1.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorIm

[jira] [Commented] (SLING-5763) ClassFormatException when using java 8 lambda expressions

2016-06-07 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318467#comment-15318467
 ] 

Robert Munteanu commented on SLING-5763:


It seems that there have been some API changes between version 2.0 and 2.1 of 
the `org.apache.sling.scripting.jsp` bundle, namely in how the wrapper classes 
from `org.apache.sling.scripting.jsp.jasper` are configured and used.

So a straight upgrade does not work and I am not sure after a first glance how 
to update the code.

Would you be interested in supplying a patch? To get started, just upgrade the 
dependency to `org.apache.sling.scripting.jsp` in the 
`maven-jspc-plugin/pom.xml` file and see what does not compile :-)

> ClassFormatException when using java 8 lambda expressions
> -
>
> Key: SLING-5763
> URL: https://issues.apache.org/jira/browse/SLING-5763
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.0.8
>Reporter: Andrey Bardashevsky
>
> When i try to jsp:useBean with Java 8 lambda expression jspc plugin throws 
> following exception:
> {code}
> org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException
>   at 
> org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader.(ClassFileReader.java:329)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:204)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler$1.findType(JDTCompiler.java:176)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.LookupEnvironment.askForType(LookupEnvironment.java:123)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.PackageBinding.getTypeOrPackage(PackageBinding.java:178)
>   at 
> org.eclipse.jdt.internal.compiler.lookup.Scope.getPackage(Scope.java:2046)
>   at 
> org.eclipse.jdt.internal.compiler.ast.QualifiedTypeReference.getTypeBinding(QualifiedTypeReference.java:69)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeReference.resolveType(TypeReference.java:130)
>   at 
> org.eclipse.jdt.internal.compiler.ast.LocalDeclaration.resolve(LocalDeclaration.java:138)
>   at 
> org.eclipse.jdt.internal.compiler.ast.Block.resolveUsing(Block.java:115)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TryStatement.resolve(TryStatement.java:751)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolveStatements(AbstractMethodDeclaration.java:432)
>   at 
> org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.resolveStatements(MethodDeclaration.java:190)
>   at 
> org.eclipse.jdt.internal.compiler.ast.AbstractMethodDeclaration.resolve(AbstractMethodDeclaration.java:403)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1047)
>   at 
> org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.resolve(TypeDeclaration.java:1094)
>   at 
> org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.resolve(CompilationUnitDeclaration.java:353)
>   at org.eclipse.jdt.internal.compiler.Compiler.process(Compiler.java:596)
>   at org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:411)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:410)
>   at 
> org.apache.sling.scripting.jsp.jasper.compiler.Compiler.compile(Compiler.java:313)
>   at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:367)
>   at 
> org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:321)
>   at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:240)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> 

[jira] [Commented] (SLING-5768) Introduce rep:slingResourceTypes as extension to Oak permission system

2016-06-09 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322459#comment-15322459
 ] 

Robert Munteanu commented on SLING-5768:


Looks good! I added a couple of comments on the Github PR, but I think it's a 
great idead.

> Introduce rep:slingResourceTypes as extension to Oak permission system
> --
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   rep:slingResourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> See github PR for a first simple implementation (adding a bundle 
> org.apache.sling.sling-oak-restrictions to contributions, not sure if this is 
> the best spot). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (SLING-5768) Introduce rep:slingResourceTypes as extension to Oak permission system

2016-06-09 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322459#comment-15322459
 ] 

Robert Munteanu edited comment on SLING-5768 at 6/9/16 1:05 PM:


Looks good! I added a couple of comments on the Github PR, but I think it's a 
great idea.


was (Author: rombert):
Looks good! I added a couple of comments on the Github PR, but I think it's a 
great idead.

> Introduce rep:slingResourceTypes as extension to Oak permission system
> --
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   rep:slingResourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> See github PR for a first simple implementation (adding a bundle 
> org.apache.sling.sling-oak-restrictions to contributions, not sure if this is 
> the best spot). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5520) Update Oak to 1.4

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324329#comment-15324329
 ] 

Robert Munteanu commented on SLING-5520:


[~olli] - any more changes to be done here? I'd like to update to 1.5.3 ( 
separate task ) to see if we can stop embedding {{oak-jcr}}

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5776) Update to Oak 1.5.3

2016-06-10 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5776:
--

 Summary: Update to Oak 1.5.3
 Key: SLING-5776
 URL: https://issues.apache.org/jira/browse/SLING-5776
 Project: Sling
  Issue Type: Bug
  Components: JCR, Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: JCR Oak Server 1.0.2






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5776) Update to Oak 1.5.3

2016-06-10 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5776.

Resolution: Fixed

Fixed in [r1747690|https://svn.apache.org/r1747690]:

- bundles/jcr/oak-server
- bundles/jcr/it-jackrabbit-oak
- launchpad/builder
- contrib/launchpad/karaf/org.apache.sling.launchpad.karaf-features

[~olli] - if I missed something related to the Karaf features, please let me 
know. I followed your previous commits

> Update to Oak 1.5.3
> ---
>
> Key: SLING-5776
> URL: https://issues.apache.org/jira/browse/SLING-5776
> Project: Sling
>  Issue Type: Bug
>  Components: JCR, Launchpad, Oak
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: JCR Oak Server 1.0.2
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5511) Adjust Oak package imports

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324350#comment-15324350
 ] 

Robert Munteanu commented on SLING-5511:


[~olli] - is there anything left to be done here?

> Adjust Oak package imports
> --
>
> Key: SLING-5511
> URL: https://issues.apache.org/jira/browse/SLING-5511
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Affects Versions: JCR Oak Server 1.0.0
>Reporter: Oliver Lietz
> Fix For: JCR Oak Server 1.0.2
>
>
> With OAK-3842 lots of package exports were removed. We have to adjust in 
> Sling accordingly when using Oak >= {{1.3.15}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5777) Stop embedding oak-jcr in the o.a.s.jcr.oak.server bundle

2016-06-10 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5777:
--

 Summary: Stop embedding oak-jcr in the o.a.s.jcr.oak.server bundle
 Key: SLING-5777
 URL: https://issues.apache.org/jira/browse/SLING-5777
 Project: Sling
  Issue Type: Bug
  Components: Oak
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: JCR Oak Server 1.0.2


We should no longer embed the oak-jcr bundle, as it makes upgrading new Oak 
version harder, since we need to update both the oak-server bundle and the 
launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5520) Update Oak to 1.4

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324375#comment-15324375
 ] 

Robert Munteanu commented on SLING-5520:


{quote}There is still use of deprecated Oak API in OakSlingRepositoryManager 
but it can be postponed.{/quote}

Is that the {{withAsync()}} call? I replaced it for SLING-5776.

{quote}AFAIK next stable Oak (1.6) will be released in 2017. I prefer upgrading 
to Oak 1.4.3 and releasing org.apache.sling.jcr.oak.server 1.0.2 first (and 
branch), so we can release launchpads without having to use unstable Oak 
1.5.{/quote}

Well, we already went with unstable Oak releases so far and no one complained 
:-) The reason for updating to an unstable version is SLING-5777, which makes 
it really simple for users of the launchpad to upgrade Oak without having to 
rebuild .

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5520) Update Oak to 1.4

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324466#comment-15324466
 ] 

Robert Munteanu commented on SLING-5520:


I am not sure about that, but I can try later :-) and file a bug if it still 
does not work.

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (SLING-5520) Update Oak to 1.4

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324375#comment-15324375
 ] 

Robert Munteanu edited comment on SLING-5520 at 6/10/16 1:44 PM:
-

{quote}There is still use of deprecated Oak API in OakSlingRepositoryManager 
but it can be postponed.{quote}

Is that the {{withAsync()}} call? I replaced it for SLING-5776.

{quote}AFAIK next stable Oak (1.6) will be released in 2017. I prefer upgrading 
to Oak 1.4.3 and releasing org.apache.sling.jcr.oak.server 1.0.2 first (and 
branch), so we can release launchpads without having to use unstable Oak 
1.5.{quote}

Well, we already went with unstable Oak releases so far and no one complained 
:-) The reason for updating to an unstable version is SLING-5777, which makes 
it really simple for users of the launchpad to upgrade Oak without having to 
rebuild .


was (Author: rombert):
{quote}There is still use of deprecated Oak API in OakSlingRepositoryManager 
but it can be postponed.{/quote}

Is that the {{withAsync()}} call? I replaced it for SLING-5776.

{quote}AFAIK next stable Oak (1.6) will be released in 2017. I prefer upgrading 
to Oak 1.4.3 and releasing org.apache.sling.jcr.oak.server 1.0.2 first (and 
branch), so we can release launchpads without having to use unstable Oak 
1.5.{/quote}

Well, we already went with unstable Oak releases so far and no one complained 
:-) The reason for updating to an unstable version is SLING-5777, which makes 
it really simple for users of the launchpad to upgrade Oak without having to 
rebuild .

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5777) Stop embedding oak-jcr in the o.a.s.jcr.oak.server bundle

2016-06-10 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5777.

Resolution: Fixed

Fixed in [r1747710|https://svn.apache.org/r1747710]

[~olli] - I updated the Karaf feature as well, but some tests failed for me ( 
not sure when they started failing )

{noformat}  SlingLaunchpadOakTarIT.testAnonymousHasReadAccess » ClassNotFound 
de.flapdoodl...
  SlingLaunchpadOakTarIT.testAnonymousLoginA » ClassNotFound 
de.flapdoodle.embed...
  SlingLaunchpadOakTarIT.testAnonymousLoginB » ClassNotFound 
de.flapdoodle.embed...
  SlingLaunchpadOakTarIT.testCreateRetrieveNode » ClassNotFound 
de.flapdoodle.em...
  SlingLaunchpadOakTarIT.testCreateRetrieveSlingFolder » ClassNotFound 
de.flapdo...
  SlingLaunchpadOakTarIT.testExplicitAdminLogin » ClassNotFound 
de.flapdoodle.em...
  SlingLaunchpadOakTarIT.testLoginAdministrative » ClassNotFound 
de.flapdoodle.e...
  SlingLaunchpadOakTarIT.testMultiValueInputStream » ClassNotFound 
de.flapdoodle...
  SlingLaunchpadOakTarIT.testNodetypeObservation » ClassNotFound 
de.flapdoodle.e...
  SlingLaunchpadOakTarIT.testRepositoryPresent » ClassNotFound 
de.flapdoodle.emb...
  SlingLaunchpadOakTarIT.testSingleValueInputStream » ClassNotFound 
de.flapdoodl...
  SlingLaunchpadOakTarIT.testSlingRepository » ClassNotFound 
de.flapdoodle.embed...
  SlingLaunchpadOakTarIT.testSqlQuery » ClassNotFound 
de.flapdoodle.embed.mongo
  SlingLaunchpadOakTarIT.testVarSlingExists » ClassNotFound 
de.flapdoodle.embed
  SlingLaunchpadOakTarIT.testWrongLogin » ClassNotFound 
de.flapdoodle.embed.mong...
  SlingLaunchpadOakTarIT.testXpathQueryWithMixin » ClassNotFound 
de.flapdoodle.e...
{noformat}

They don't seem related to my changes though but feel free to reopen and point 
out what I missed.

> Stop embedding oak-jcr in the o.a.s.jcr.oak.server bundle
> -
>
> Key: SLING-5777
> URL: https://issues.apache.org/jira/browse/SLING-5777
> Project: Sling
>  Issue Type: Bug
>  Components: Oak
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: JCR Oak Server 1.0.2
>
>
> We should no longer embed the oak-jcr bundle, as it makes upgrading new Oak 
> version harder, since we need to update both the oak-server bundle and the 
> launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5520) Update Oak to 1.4

2016-06-10 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324499#comment-15324499
 ] 

Robert Munteanu commented on SLING-5520:


[~olli] - the Repository is still reconfigured/restarted when I move the 
oak-server bundle to startLevel 15:

{noformat}
$ grep -e 'OakSlingRepositoryManager stop' sling/logs/error.log 
10.06.2016 17:00:28.745 *INFO* [CM Event Dispatcher (Fire ConfigurationEvent: 
pid=org.apache.jackrabbit.oak.security.authentication.AuthenticationConfigurationImpl)]
 org.apache.sling.oak.server.OakSlingRepositoryManager stop: Repository still 
running, forcing shutdown
10.06.2016 17:00:29.693 *INFO* [CM Event Dispatcher (Fire ConfigurationEvent: 
pid=org.apache.jackrabbit.oak.security.user.UserConfigurationImpl)] 
org.apache.sling.oak.server.OakSlingRepositoryManager stop: Repository still 
running, forcing shutdown
10.06.2016 17:00:30.467 *INFO* [CM Event Dispatcher (Fire ConfigurationEvent: 
pid=org.apache.jackrabbit.oak.spi.security.user.action.DefaultAuthorizableActionProvider)]
 org.apache.sling.oak.server.OakSlingRepositoryManager stop: Repository still 
running, forcing shutdown
{noformat}

Do you consider this a bug in Sling? Just trying to make sure I capture the 
right information in the bug report.

> Update Oak to 1.4
> -
>
> Key: SLING-5520
> URL: https://issues.apache.org/jira/browse/SLING-5520
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Launchpad, Oak
>Reporter: Oliver Lietz
> Fix For: Launchpad Karaf Features 0.2.0, JCR Oak Server 1.0.2, 
> Launchpad Builder 9
>
>
> Doing update in several more steps until Oak {{1.4}} is released due to major 
> changes, one of them being OAK-3842 (removed package exports, tracked in 
> SLING-5511).
> First updating to Oak {{1.3.14}} (latest pre OAK-3842 release) and then to 
> Oak {{1.3.15}}.
> Features deprecated for Oak {{1.4}} should be removed from 
> {{org.apache.sling.jcr.oak.server}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5778) o.a.s.repoinit.oak-jcr does not start due to missing org.apache.sling.provisioning.model package

2016-06-10 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5778:
--

 Summary: o.a.s.repoinit.oak-jcr does not start due to missing 
org.apache.sling.provisioning.model package
 Key: SLING-5778
 URL: https://issues.apache.org/jira/browse/SLING-5778
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Launchpad Builder 9


{noformat}10.06.2016 17:59:25.220 *INFO* [OsgiInstallerImpl] 
org.apache.sling.installer.core.impl.tasks.BundleStartTask Could not start 
bundle org.apache.sling.repoinit.oak-jcr [129]. Reason: {}. Will retry.
org.osgi.framework.BundleException: Unable to resolve 
org.apache.sling.repoinit.oak-jcr [129](R 129.0): missing requirement 
[org.apache.sling.repoinit.oak-jcr [129](R 129.0)] osgi.wiring.package; 
(&(osgi.wiring.package=org.apache.sling.provisioning.model)(version>=1.5.0)(!(version>=2.0.0)))
 Unresolved requirements: [[org.apache.sling.repoinit.oak-jcr [129](R 129.0)] 
osgi.wiring.package; 
(&(osgi.wiring.package=org.apache.sling.provisioning.model)(version>=1.5.0)(!(version>=2.0.0)))]
at 
org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4111)
at org.apache.felix.framework.Felix.startBundle(Felix.java:2117)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984)
at 
org.apache.sling.installer.core.impl.tasks.BundleStartTask.execute(BundleStartTask.java:93)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:847)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:689)
at 
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:265)
at java.lang.Thread.run(Thread.java:745){noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5778) o.a.s.repoinit.oak-jcr does not start due to missing org.apache.sling.provisioning.model package

2016-06-10 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5778.

Resolution: Fixed

Fixed in [r1747733|https://svn.apache.org/r1747733]

> o.a.s.repoinit.oak-jcr does not start due to missing 
> org.apache.sling.provisioning.model package
> 
>
> Key: SLING-5778
> URL: https://issues.apache.org/jira/browse/SLING-5778
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Launchpad Builder 9
>
>
> {noformat}10.06.2016 17:59:25.220 *INFO* [OsgiInstallerImpl] 
> org.apache.sling.installer.core.impl.tasks.BundleStartTask Could not start 
> bundle org.apache.sling.repoinit.oak-jcr [129]. Reason: {}. Will retry.
> org.osgi.framework.BundleException: Unable to resolve 
> org.apache.sling.repoinit.oak-jcr [129](R 129.0): missing requirement 
> [org.apache.sling.repoinit.oak-jcr [129](R 129.0)] osgi.wiring.package; 
> (&(osgi.wiring.package=org.apache.sling.provisioning.model)(version>=1.5.0)(!(version>=2.0.0)))
>  Unresolved requirements: [[org.apache.sling.repoinit.oak-jcr [129](R 129.0)] 
> osgi.wiring.package; 
> (&(osgi.wiring.package=org.apache.sling.provisioning.model)(version>=1.5.0)(!(version>=2.0.0)))]
> at 
> org.apache.felix.framework.Felix.resolveBundleRevision(Felix.java:4111)
> at org.apache.felix.framework.Felix.startBundle(Felix.java:2117)
> at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:998)
> at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:984)
> at 
> org.apache.sling.installer.core.impl.tasks.BundleStartTask.execute(BundleStartTask.java:93)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:847)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:689)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:265)
> at java.lang.Thread.run(Thread.java:745){noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5779) LuceneIndexProviderService is sometimes not configured

2016-06-10 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5779:
---
Attachment: stdout.log.gz
error.log.gz

> LuceneIndexProviderService is sometimes not configured
> --
>
> Key: SLING-5779
> URL: https://issues.apache.org/jira/browse/SLING-5779
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
> Fix For: Launchpad Builder 9
>
> Attachments: error.log.gz, stdout.log.gz
>
>
> (Setting version to Launchpad for now until we find out the root cause).
> From time to time I see the launchpad failing to start properly. The first 
> error that is visible is {noformat}10.06.2016 18:18:48.826 *ERROR* 
> [OsgiInstallerImpl] org.apache.jackrabbit.oak-lucene 
> [org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService(31)]
>  The activate method has thrown an exception (java.lang.NullPointerException: 
> Index directory cannot be determined as neither index directory path 
> [localIndexDir] nor repository home [repository.home] defined)
> java.lang.NullPointerException: Index directory cannot be determined as 
> neither index directory path [localIndexDir] nor repository home 
> [repository.home] defined
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:236){noformat}
> That's weird since the provisioning model holds all the configurations and 
> the relevant bundles are present in the {{:boot}} feature → Start Level 1.
> My launchpad jar was built from r1747733 ( but of course SNAPSHOT 
> dependencies mean that someone else building the launchpad will not get the 
> same exact output ).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5779) LuceneIndexProviderService sometimes is not configured

2016-06-10 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5779:
--

 Summary: LuceneIndexProviderService sometimes is not configured
 Key: SLING-5779
 URL: https://issues.apache.org/jira/browse/SLING-5779
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
Reporter: Robert Munteanu
 Fix For: Launchpad Builder 9
 Attachments: error.log.gz, stdout.log.gz

(Setting version to Launchpad for now until we find out the root cause).

>From time to time I see the launchpad failing to start properly. The first 
>error that is visible is {noformat}10.06.2016 18:18:48.826 *ERROR* 
>[OsgiInstallerImpl] org.apache.jackrabbit.oak-lucene 
>[org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService(31)]
> The activate method has thrown an exception (java.lang.NullPointerException: 
>Index directory cannot be determined as neither index directory path 
>[localIndexDir] nor repository home [repository.home] defined)
java.lang.NullPointerException: Index directory cannot be determined as neither 
index directory path [localIndexDir] nor repository home [repository.home] 
defined
at 
com.google.common.base.Preconditions.checkNotNull(Preconditions.java:236){noformat}

That's weird since the provisioning model holds all the configurations and the 
relevant bundles are present in the {{:boot}} feature → Start Level 1.

My launchpad jar was built from r1747733 ( but of course SNAPSHOT dependencies 
mean that someone else building the launchpad will not get the same exact 
output ).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5779) LuceneIndexProviderService is sometimes not configured

2016-06-10 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5779:
---
Summary: LuceneIndexProviderService is sometimes not configured  (was: 
LuceneIndexProviderService sometimes is not configured)

> LuceneIndexProviderService is sometimes not configured
> --
>
> Key: SLING-5779
> URL: https://issues.apache.org/jira/browse/SLING-5779
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
> Fix For: Launchpad Builder 9
>
> Attachments: error.log.gz, stdout.log.gz
>
>
> (Setting version to Launchpad for now until we find out the root cause).
> From time to time I see the launchpad failing to start properly. The first 
> error that is visible is {noformat}10.06.2016 18:18:48.826 *ERROR* 
> [OsgiInstallerImpl] org.apache.jackrabbit.oak-lucene 
> [org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService(31)]
>  The activate method has thrown an exception (java.lang.NullPointerException: 
> Index directory cannot be determined as neither index directory path 
> [localIndexDir] nor repository home [repository.home] defined)
> java.lang.NullPointerException: Index directory cannot be determined as 
> neither index directory path [localIndexDir] nor repository home 
> [repository.home] defined
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:236){noformat}
> That's weird since the provisioning model holds all the configurations and 
> the relevant bundles are present in the {{:boot}} feature → Start Level 1.
> My launchpad jar was built from r1747733 ( but of course SNAPSHOT 
> dependencies mean that someone else building the launchpad will not get the 
> same exact output ).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5779) LuceneIndexProviderService is sometimes not configured

2016-06-14 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329038#comment-15329038
 ] 

Robert Munteanu commented on SLING-5779:


I think there's also an argument to be made about reducing the number of 
needless component reconfigurations. While there should be no harm in 
deactivating/activating a component during startup, it does tend to:

- slow down startup, due to components being reconfigured and possibly 
triggering a chain of other components being reconfigured
- make debugging harder, due to more events being triggered and TBH is was 
counter-intuitive to me that the component was reconfigured this early in the 
process

> LuceneIndexProviderService is sometimes not configured
> --
>
> Key: SLING-5779
> URL: https://issues.apache.org/jira/browse/SLING-5779
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Reporter: Robert Munteanu
> Fix For: Launchpad Builder 9
>
> Attachments: error.log.gz, stdout.log.gz
>
>
> (Setting version to Launchpad for now until we find out the root cause).
> From time to time I see the launchpad failing to start properly. The first 
> error that is visible is {noformat}10.06.2016 18:18:48.826 *ERROR* 
> [OsgiInstallerImpl] org.apache.jackrabbit.oak-lucene 
> [org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService(31)]
>  The activate method has thrown an exception (java.lang.NullPointerException: 
> Index directory cannot be determined as neither index directory path 
> [localIndexDir] nor repository home [repository.home] defined)
> java.lang.NullPointerException: Index directory cannot be determined as 
> neither index directory path [localIndexDir] nor repository home 
> [repository.home] defined
> at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:236){noformat}
> That's weird since the provisioning model holds all the configurations and 
> the relevant bundles are present in the {{:boot}} feature → Start Level 1.
> My launchpad jar was built from r1747733 ( but of course SNAPSHOT 
> dependencies mean that someone else building the launchpad will not get the 
> same exact output ).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5768) Introduce sling:resourceTypes as extension to Oak permission system

2016-07-08 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5768:
---
Assignee: Robert Munteanu

> Introduce sling:resourceTypes as extension to Oak permission system
> ---
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>Assignee: Robert Munteanu
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> Additionally to strict resource type matching it shall be possible to 
> automatically match a resource with a given resource type including all 
> children. Also, not all content nodes have a resource type, therefore it 
> should be possible to match against a child node by appending \@path to the 
> resource type: 
> {code}
> - /content/myprj 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypesWithChildren (String[]) = 
> [myproj/resourcetype1@jcr:content]
> {code}
> To achieve this any path match attempt traverses the parents and checks for a 
> match (but only up to the base path, /content/myprj in this example). For AEM 
> use cases, this can match a whole page structure (e.g. something like 
> /content/myprj/path/to/newsoverview, the whole news section can be easily 
> matched by having a distinct news overview template). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5768) Introduce sling:resourceTypes as extension to Oak permission system

2016-07-08 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5768:
---
Fix Version/s: Oak Restrictions 1.0.0

> Introduce sling:resourceTypes as extension to Oak permission system
> ---
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>Assignee: Robert Munteanu
> Fix For: Oak Restrictions 1.0.0
>
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> Additionally to strict resource type matching it shall be possible to 
> automatically match a resource with a given resource type including all 
> children. Also, not all content nodes have a resource type, therefore it 
> should be possible to match against a child node by appending \@path to the 
> resource type: 
> {code}
> - /content/myprj 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypesWithChildren (String[]) = 
> [myproj/resourcetype1@jcr:content]
> {code}
> To achieve this any path match attempt traverses the parents and checks for a 
> match (but only up to the base path, /content/myprj in this example). For AEM 
> use cases, this can match a whole page structure (e.g. something like 
> /content/myprj/path/to/newsoverview, the whole news section can be easily 
> matched by having a distinct news overview template). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5768) Introduce sling:resourceTypes as extension to Oak permission system

2016-07-08 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367561#comment-15367561
 ] 

Robert Munteanu commented on SLING-5768:


Patch applied in [r1751881|https://svn.apache.org/r1751881], thanks a lot for 
the contribution! I've also added the project to the contrib reactor in 
[r1751882|https://svn.apache.org/r1751882].

It would be great if you could add an usage example to the documentation.

> Introduce sling:resourceTypes as extension to Oak permission system
> ---
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>Assignee: Robert Munteanu
> Fix For: Oak Restrictions 1.0.0
>
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> Additionally to strict resource type matching it shall be possible to 
> automatically match a resource with a given resource type including all 
> children. Also, not all content nodes have a resource type, therefore it 
> should be possible to match against a child node by appending \@path to the 
> resource type: 
> {code}
> - /content/myprj 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypesWithChildren (String[]) = 
> [myproj/resourcetype1@jcr:content]
> {code}
> To achieve this any path match attempt traverses the parents and checks for a 
> match (but only up to the base path, /content/myprj in this example). For AEM 
> use cases, this can match a whole page structure (e.g. something like 
> /content/myprj/path/to/newsoverview, the whole news section can be easily 
> matched by having a distinct news overview template). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5768) Introduce sling:resourceTypes as extension to Oak permission system

2016-07-08 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5768.

Resolution: Fixed

> Introduce sling:resourceTypes as extension to Oak permission system
> ---
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>Assignee: Robert Munteanu
> Fix For: Oak Restrictions 1.0.0
>
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> Additionally to strict resource type matching it shall be possible to 
> automatically match a resource with a given resource type including all 
> children. Also, not all content nodes have a resource type, therefore it 
> should be possible to match against a child node by appending \@path to the 
> resource type: 
> {code}
> - /content/myprj 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypesWithChildren (String[]) = 
> [myproj/resourcetype1@jcr:content]
> {code}
> To achieve this any path match attempt traverses the parents and checks for a 
> match (but only up to the base path, /content/myprj in this example). For AEM 
> use cases, this can match a whole page structure (e.g. something like 
> /content/myprj/path/to/newsoverview, the whole news section can be easily 
> matched by having a distinct news overview template). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5768) Introduce sling:resourceTypes as extension to Oak permission system

2016-07-12 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372782#comment-15372782
 ] 

Robert Munteanu commented on SLING-5768:


{quote}I don't think the name is perfect either, I could just not think of a 
better name. You suggested sling:resourceTypesInAncestry at some point (this 
would actually be more in line with the algorithm that traverses the parents), 
but when writing the rule, I think it feels more natural to think about a node 
with a resource type and match all the children along with it. Robert Munteanu, 
as a third opinion, what do you think?{quote}

As a third opinion :-) , if I read the description correctly, isn't this more 
of a {{sling:parentResourceTypes}} ?

{quote}Regarding the documentation: Where exactly is the source of pages like 
https://sling.apache.org/documentation/bundles/sling-health-check-tool.html? I 
suggest adding a new page for the sling restrictions (as it is its own module). 
{quote}

A new page sounds good to me.

The source is in SVN at https://svn.apache.org/repos/asf/sling/site. File 
format is markdown, take a look at other pages for examples.

> Introduce sling:resourceTypes as extension to Oak permission system
> ---
>
> Key: SLING-5768
> URL: https://issues.apache.org/jira/browse/SLING-5768
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Georg Henzler
>Assignee: Robert Munteanu
> Fix For: Oak Restrictions 1.0.0
>
>
> Oak allows to extend its permissions management by using custom restrictions 
> \[1], also the standard oak restrictions are based on this and are 
> implemented in a fairly straight-forward way \[2] (example is for 
> rep:ntNames). 
> It would be nice to have sling level restrictions using sling properties in 
> general. This issue is about introducing a restriction on resource types - 
> the following should be possible:
> {code}
> - /content/mynode 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypes (String[]) = 
> [myproj/resourcetype1,myproj/resourcetype2]
> {code}
> The example would only grant "rep:write" for the resource types 
> myproj/resourcetype1 and myproj/resourcetype2 in path /content/mynode, other 
> resources under path /content/mynode would not have "rep:write" permissions. 
> Additionally to strict resource type matching it shall be possible to 
> automatically match a resource with a given resource type including all 
> children. Also, not all content nodes have a resource type, therefore it 
> should be possible to match against a child node by appending \@path to the 
> resource type: 
> {code}
> - /content/myprj 
>- rep:policy (rep:ACL)
>  - allow (rep:GrantACE)
>+ principalName (String) = "myAuthorizable"
>+ rep:privileges (Name[]) = "rep:write"
>- rep:restrictions (rep:Restrictions)
>   +   sling:resourceTypesWithChildren (String[]) = 
> [myproj/resourcetype1@jcr:content]
> {code}
> To achieve this any path match attempt traverses the parents and checks for a 
> match (but only up to the base path, /content/myprj in this example). For AEM 
> use cases, this can match a whole page structure (e.g. something like 
> /content/myprj/path/to/newsoverview, the whole news section can be easily 
> matched by having a distinct news overview template). 
> \[1]
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html#Pluggability
> \[2]
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/NodeTypePattern.java#L50)
> https://github.com/apache/jackrabbit-oak/blob/cea167f5bf70d818d58b1ffcc6bc65b3c0f9a5a4/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/restriction/RestrictionProviderImpl.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5836) RepoInit ITs fail - 5 bundles stuck in installed state

2016-07-12 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5836:
--

 Summary: RepoInit ITs fail - 5 bundles stuck in installed state
 Key: SLING-5836
 URL: https://issues.apache.org/jira/browse/SLING-5836
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Robert Munteanu
 Attachments: error.log

The repoinit ITs fail on Jenkins ( sling-trunk-1.7 and sling-trunk-1.8 ) and 
locally as well.

5 bundles fail to start due to missing exported packages ( see full log 
attached ).

[~bdelacretaz] FYI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5836) RepoInit ITs fail - 5 bundles stuck in installed state

2016-07-12 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5836:
---
Attachment: error.log

> RepoInit ITs fail - 5 bundles stuck in installed state
> --
>
> Key: SLING-5836
> URL: https://issues.apache.org/jira/browse/SLING-5836
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Robert Munteanu
>  Labels: sling-IT
> Attachments: error.log
>
>
> The repoinit ITs fail on Jenkins ( sling-trunk-1.7 and sling-trunk-1.8 ) and 
> locally as well.
> 5 bundles fail to start due to missing exported packages ( see full log 
> attached ).
> [~bdelacretaz] FYI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5836) RepoInit ITs fail - 5 bundles stuck in installed state

2016-07-12 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5836:
---
Attachment: repoinit-5-bundles-installed.png

> RepoInit ITs fail - 5 bundles stuck in installed state
> --
>
> Key: SLING-5836
> URL: https://issues.apache.org/jira/browse/SLING-5836
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Robert Munteanu
>  Labels: sling-IT
> Attachments: error.log, repoinit-5-bundles-installed.png
>
>
> The repoinit ITs fail on Jenkins ( sling-trunk-1.7 and sling-trunk-1.8 ) and 
> locally as well.
> 5 bundles fail to start due to missing exported packages ( see full log 
> attached ).
> [~bdelacretaz] FYI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5836) RepoInit ITs fail - 5 bundles stuck in installed state

2016-07-12 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372878#comment-15372878
 ] 

Robert Munteanu commented on SLING-5836:


These are not the default Launchpad ITs, but a set of separate ITs living under 
{{bundles/extensions/repoinit/it}}

> RepoInit ITs fail - 5 bundles stuck in installed state
> --
>
> Key: SLING-5836
> URL: https://issues.apache.org/jira/browse/SLING-5836
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Robert Munteanu
>  Labels: sling-IT
> Attachments: error.log, repoinit-5-bundles-installed.png
>
>
> The repoinit ITs fail on Jenkins ( sling-trunk-1.7 and sling-trunk-1.8 ) and 
> locally as well.
> 5 bundles fail to start due to missing exported packages ( see full log 
> attached ).
> [~bdelacretaz] FYI



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

2016-07-18 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5862:
--

 Summary: Remove maven-antrun-plugin executions related to memory 
checks
 Key: SLING-5862
 URL: https://issues.apache.org/jira/browse/SLING-5862
 Project: Sling
  Issue Type: Improvement
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Parent 27


WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
antrun executions which output warnings related to the memory needed to build 
Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381970#comment-15381970
 ] 

Robert Munteanu commented on SLING-5862:


Fixed in [r1753187|https://svn.apache.org/r1753187]

> Remove maven-antrun-plugin executions related to memory checks
> --
>
> Key: SLING-5862
> URL: https://issues.apache.org/jira/browse/SLING-5862
> Project: Sling
>  Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 27
>
>
> WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
> antrun executions which output warnings related to the memory needed to build 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5862) Remove maven-antrun-plugin executions related to memory checks

2016-07-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5862.

Resolution: Fixed

> Remove maven-antrun-plugin executions related to memory checks
> --
>
> Key: SLING-5862
> URL: https://issues.apache.org/jira/browse/SLING-5862
> Project: Sling
>  Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 27
>
>
> WIth SLING-5860 we now require Maven 3.3.9. This means that we can remove the 
> antrun executions which output warnings related to the memory needed to build 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5860) Require maven version 3.3.9

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382074#comment-15382074
 ] 

Robert Munteanu commented on SLING-5860:


Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (SLING-5860) Require maven version 3.3.9

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382074#comment-15382074
 ] 

Robert Munteanu edited comment on SLING-5860 at 7/18/16 10:52 AM:
--

Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

Or alternatively don't upgrade to the latest parent until this is solved.


was (Author: rombert):
Just noticed that this is not available on builds.apache.org - INFRA-12296 . 
Can we downgrade the requirement to 3.3.3 until this gets resolved?

> Require maven version 3.3.9
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5860) Require maven version 3.3.3

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382102#comment-15382102
 ] 

Robert Munteanu commented on SLING-5860:


Apparently 3.3.9 is available on Jenkins, but only as 'latest', not as a fixed 
version.

We can switch back to 3.3.9, and stick with whatever 'latest' means, at the 
risk of being upgraded without knowing to the next Maven version. I would 
prefer the safe route however, and live with 3.3.3 for now.

> Require maven version 3.3.3
> ---
>
> Key: SLING-5860
> URL: https://issues.apache.org/jira/browse/SLING-5860
> Project: Sling
>  Issue Type: Improvement
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Parent 27
>
>
> According to http://maven.apache.org/download.cgi
> Maven 3.3.9 is the recommended version for all users. We should require it in 
> the parent pom



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382145#comment-15382145
 ] 

Robert Munteanu commented on SLING-920:
---

As "Maven 3 (latest)" caused a failure on Jenkins slave H11, I've switched to 
"maven-3.3.9" which INFRA just added ( see INFRA-12296 ).

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-920) Sling Jenkins setup

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382202#comment-15382202
 ] 

Robert Munteanu commented on SLING-920:
---

Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6 }} , which according to 
INFRA are guaranteed to be properly configured in terms of Maven versions.

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (SLING-920) Sling Jenkins setup

2016-07-18 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15382202#comment-15382202
 ] 

Robert Munteanu edited comment on SLING-920 at 7/18/16 12:29 PM:
-

Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6}} , which according to INFRA 
are guaranteed to be properly configured in terms of Maven versions.


was (Author: rombert):
Updated trunk 7 and 8 builds to only use 
{{ubuntu-1||ubuntu-2||ubuntu-4||ubuntu-5||ubuntu-6 }} , which according to 
INFRA are guaranteed to be properly configured in terms of Maven versions.

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Jenkins setup at 
> https://builds.apache.org/view/S-Z/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5863) Make the sightly-maven-plugin m2e compatible

2016-07-18 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-5863:
--

 Summary: Make the sightly-maven-plugin m2e compatible
 Key: SLING-5863
 URL: https://issues.apache.org/jira/browse/SLING-5863
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sightly Maven Plugin 1.0.0


Maven plug-ins can easily be made compatible with m2e for transparent 
integration with Eclipse.

We should add this to the sightly-maven-plugin and make the compilation results 
available in Eclipse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


<    3   4   5   6   7   8   9   10   11   12   >