[Bug 3943] New: Problem in "all_from_addrs"
http://bugzilla.spamassassin.org/show_bug.cgi?id=3943
Summary: Problem in "all_from_addrs"
Product: Spamassassin
Version: 3.0.0
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Rules (Eval Tests)
AssignedTo: dev@spamassassin.apache.org
ReportedBy: [EMAIL PROTECTED]
In Row 1034 of the Module "Mail::SpamAssassin::EvalTests" there is this:
@addrs = grep { defined($_) && length($_) > 0 } map { tr/././s; $_; }
($self->get('From:addr'), # std
$self->get('Envelope-Sender:addr'),# qmail: new-inject(1)
$self->get('Resent-Sender:addr'), # procmailrc manpage
$self->get('X-Envelope-From:addr'),# procmailrc manpage
$self->get('EnvelopeFrom:addr')); # SMTP envelope
Now I have the Problem that in some of my mails there are many "X-Envelope-From"
headers. The "get"-function concat all the adresses and in @addrs there is a
value like "[EMAIL PROTECTED] [EMAIL PROTECTED] [EMAIL PROTECTED]".
If you add the following line after the first line "@addrs = ..."
map { split( /\s+/, $_ ) }
the concatted get-value will be split and the following code will cleanup the
equal adresses!
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
[Bug 3942] Small Bug in EvalTests::_check_recipients()
http://bugzilla.spamassassin.org/show_bug.cgi?id=3942
[EMAIL PROTECTED] changed:
What|Removed |Added
Severity|normal |trivial
Summary|Small Bug in EvalTests |Small Bug in
||EvalTests::_check_recipients
||()
Target Milestone|Future |3.0.2
--- Additional Comments From [EMAIL PROTECTED] 2004-10-30 10:01 ---
The problem description in the ticket isn't very informative, so here's the
issue:
# ToCc: pseudo-header works best, but sometimes Bcc: is better
for ('ToCc', 'Bcc') {
my $to = $self->get($_);# get recipients
$to =~ s/\(.*?\)//g;# strip out the (comments)
@inputs = ($to =~ m/([EMAIL PROTECTED](?:[\w.-]+\.)+\w+)/g);
last if scalar(@inputs) >= TOCC_SIMILAR_COUNT;
}
The problem is that the @inputs array from ToCC will be overwritten by the
array from Bcc (which is
typically empty) if there aren't enough values from ToCC.
It's not clear whether or not this is the desired behavior -- should ToCC and
Bcc be merged together if
ToCC alone isn't enough, or should Bcc override ToCC (current behavior)?
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
[Bug 3942] New: Small Bug in EvalTests
http://bugzilla.spamassassin.org/show_bug.cgi?id=3942 Summary: Small Bug in EvalTests Product: Spamassassin Version: 3.0.0 Platform: All OS/Version: other Status: NEW Severity: normal Priority: P5 Component: Rules (Eval Tests) AssignedTo: dev@spamassassin.apache.org ReportedBy: [EMAIL PROTECTED] In "Mail/SpamAssassin/EvalTests.pm" row 135 @inputs = ($to =~ m/([EMAIL PROTECTED](?:[\w.-]+\.)+\w+)/g); should be push( @inputs, ($to =~ m/([EMAIL PROTECTED](?:[\w.-]+\.)+\w+)/g) ); I think? Cause the next foreach run overwrite the old value??? Is this correct, or did I don't understand the function??? --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 3924] URIDNSBL plugin crashes with certain messages
http://bugzilla.spamassassin.org/show_bug.cgi?id=3924 --- Additional Comments From [EMAIL PROTECTED] 2004-10-30 04:40 --- I confirmed the bug in the latest ActivePerl 5.8.4 and reported it to them in http://bugs.activestate.com/show_bug.cgi?id=34726 --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 3924] URIDNSBL plugin crashes with certain messages
http://bugzilla.spamassassin.org/show_bug.cgi?id=3924 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2004-10-30 03:08 --- I created a test case that bypasses Net::DNS to use only IO::Socket and IO::Select to cause the crash. That makes it an ActivePerl bug, which I am reporting to them. The limit seems to be 343 UDP sockets created and then called with can_send(0.0). The ip addresses do not seem to matter. I'm resolving this as WONTFIX because there doesn't seem to be anything left to do with it in SpamAssassin. --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-30 03:02 --- Sorry for not noticing thatthe make test faiolure was not the resuolt of the patch. Tested the new patch in trunk and 3.0.2 branch. +1 for the new patch --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3941] [review] Spamcop now limits reports to 2 day old mail
http://bugzilla.spamassassin.org/show_bug.cgi?id=3941 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Spamcop now limits reports |[review] Spamcop now limits |to 2 day old mail |reports to 2 day old mail --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 3941] Spamcop now limits reports to 2 day old mail
http://bugzilla.spamassassin.org/show_bug.cgi?id=3941 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 21:44 --- Created an attachment (id=2499) --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2499&action=view) suggested patch --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #2494 is|0 |1 obsolete|| Attachment #2497 is|0 |1 obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 20:36 --- Created an attachment (id=2498) --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2498&action=view) new version, applies cleanly --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 20:35 --- Subject: Re: [review] URIDNSBL plugin does not honor config option to limit URLs. On Fri, Oct 29, 2004 at 07:34:25PM -0700, [EMAIL PROTECTED] wrote: > OK, -1 on the patches. Umm... No disrespect intended, but the patches as posted don't include that call (which is a new plugin hack I've been putting in the plugins for 3.1 so error handling occurs correctly). The patches as posted in the ticket pass "make test", although the first one doesn't apply cleanly for some reason. I'll post a new version which goes against the current stable branch. I found the 3.1 "make test" failures right as I was reading your post, btw... That'll be fixed shortly. :) --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 19:34 --- OK, -1 on the patches. It calls handle_parser_error which is not defined in URIDNSBL.pm It is used and defined redundantly in HashCash.pm and razor2.pm It looks like the sub should be defined just once, in Plugin.pm, if it is going to be used without change in so many plugins. I'll leave it for you, Theo, if you agree, since you are doing these patches. --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 19:25 --- Correction -- I forgot that I had not run make test since applying and trying out the patch. This is from nmake test under Win32: t\basic_lintplugin: eval failed: Can't locate object method "han dle_parser_error" via package "Mail::SpamAssassin::Plugin::URIDNSBL" at ..\lib/M ail/SpamAssassin/Plugin/URIDNSBL.pm line 275. config: failed to parse line, skipping: uridnsbl_timeout2 lint: 1 issues detected. please rerun with debug enabled for more information. I retract that +1 until I see what is going on. --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 19:21 --- +1 on the combined two patches. > I have a feeling that's the best we can do though [For the record, I'll point out the typos I made in comment #18 where I should have been referring to bug 3924] I agree. With this fix I think we should close bug 3924 as WONTFIX, perhaps documenting somewhere what to set uridnsbl_max_domains to when running under Win32. It would be nice if I or someone else who plays with Windows can figure out a workaround for Net::DNS or a fix for IO::Sockets or IO::Select running under Win32, but that's a separate issue. I will submit the test case I came up with to the Net::DNS bug list, to get it documented there. --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 18:52 --- Subject: Re: [review] URIDNSBL plugin does not honor config option to limit URLs. On Fri, Oct 29, 2004 at 06:30:31PM -0700, [EMAIL PROTECTED] wrote: > That's a workaround for bug 2924, not a fix. I have a feeling that's the best we can do though. The bug isn't in SpamAssasssin, and all we could ever really do is lower the number of sockets we use -- but that's still just a workaround. --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
[Bug 3930] [review] URIDNSBL plugin does not honor config option to limit URLs.
http://bugzilla.spamassassin.org/show_bug.cgi?id=3930 --- Additional Comments From [EMAIL PROTECTED] 2004-10-29 18:30 --- The patch seems to work as expected. As per the analysis in bug 2924, if I set uridnsbl_max_domains to 60 the test case there runs, and to 80 it crashes. In other words, running under Win32 it has to be set to less than approximately 350 divided by the total number of urirhssub and urirhsbl entries in user_prefs. That's a workaround for bug 2924, not a fix. --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is.
