[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-11-09 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-11-09 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-11-08 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-11-07 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-11-01 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-17 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060
Bug 8060 depends on bug 7735, which changed state.

Bug 7735 Summary: Meta rules need to handle missing/unrun dependencies
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

Henrik Krohns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from Henrik Krohns  ---
Committed with few extra additions to basic_meta2.t tests:

Sendingtrunk/lib/Mail/SpamAssassin/Conf/Parser.pm
Sendingtrunk/lib/Mail/SpamAssassin/Conf.pm
Sendingtrunk/lib/Mail/SpamAssassin/Plugin/Check.pm
Sendingtrunk/t/basic_meta2.t
Transmitting file data done
Committing transaction...
Committed revision 1904529.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

Kevin A. McGrail  changed:

   What|Removed |Added

 CC||kmcgr...@apache.org

--- Comment #6 from Kevin A. McGrail  ---
+1 from me as well

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

Bill Cole  changed:

   What|Removed |Added

 CC||billc...@apache.org

--- Comment #5 from Bill Cole  ---
+1 to commit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

--- Comment #4 from Henrik Krohns  ---
More I think about it, more it seems to make sense.

meta FOO 0
meta FOO 1

Those should not differ in the way they effect any metas. It's just a
difference of rule hitting or not.

So +1 for my original patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

--- Comment #3 from Henrik Krohns  ---
On the other hand, maybe this is an advantage, so user can choose which way to
disable a rule?

# Disable rule, consider rule unrun, don't let any meta depending on it be run
score DISABLED_RULE 0

# Disable rule, consider result not hitting, let any meta depending on it be
run
meta DISABLED_RULE 0 --

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

Henrik Krohns  changed:

   What|Removed |Added

 Depends on||7735


Referenced Bugs:

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7735
[Bug 7735] Meta rules need to handle missing/unrun dependencies
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

--- Comment #2 from Henrik Krohns  ---
The patch might affect the common "meta DISABLED_RULE 0" usage, which
previously I think was considered an "unrun" rule, now it is considered run
rule that did not hit.

Which now differs from other common way of "score DISABLED_RULE 0", which still
makes rule "unrun".

I think both should have identical results, but should be allow metas depending
on them to fully evaluate or not?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8060] [review] Fix meta handling for metas without dependencies

2022-10-11 Thread bugzilla-daemon
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8060

Henrik Krohns  changed:

   What|Removed |Added

Summary|Fix meta handling for metas |[review] Fix meta handling
   |without dependencies|for metas without
   ||dependencies
   Target Milestone|Undefined   |4.0.0

-- 
You are receiving this mail because:
You are the assignee for the bug.