Re: Proposal of closing some PRs and maybe some PRs abandoned by its author

2016-05-06 Thread Sean Owen 
Skimmed these as a one-off exercise, and I suggest ...

Leave open for now

7739 mgrover
10701 nraychaudhuri
9920 jliwork
9936 Lewuathe
10052 dereksabryfb
10125 kevinyu98
10466 hhbyyh
10995 tedyu
10887 blbradley
11005 huaxingao
11129 AtkinsChang
11610 iyounus
11729 mbaddar1
11980 koertkuipers
12075 zhuoliu
10572 navis
10945 dmarcous

Close

9354 jacek-lewandowski
9451 vidma
10507 JerryLead
10486 wilson8
10460 huaxingao
10967 kevinyu98
10681 nikit-os
11766 s4weng
9907 Lewuathe
10209 nongli
10379 yanakad
10403 naveenminchu
10842 rajeshbalamohan
11036 mbautin

On Fri, May 6, 2016 at 4:45 PM, Hyukjin Kwon  wrote:
> Hi all,
>
>
> This was similar with the proposal of closing PRs before I asked.
>
> I think the PRs suggested to be closed below are closable but not very sure
> of PRs apparently abandoned by its author at least for a month.
>
> I remember the discussion about auto-closing PR before. So, I included the
> PRs as below anyway.
>
> I looked though the open every PR at this time and could make a list as
> below:
>
>
> 1. Suggested to be closed.
>
>
> https://github.com/apache/spark/pull/7739  <- not sure
>
> https://github.com/apache/spark/pull/9354
>
> https://github.com/apache/spark/pull/9451
>
> https://github.com/apache/spark/pull/10507
>
> https://github.com/apache/spark/pull/10486
>
> https://github.com/apache/spark/pull/10460
>
> https://github.com/apache/spark/pull/10967
>
> https://github.com/apache/spark/pull/10945
>
> https://github.com/apache/spark/pull/10701
>
> https://github.com/apache/spark/pull/10681
>
> https://github.com/apache/spark/pull/11766
>
>
>
> 2. Author not answering at least for a month.
>
>
> https://github.com/apache/spark/pull/9907
>
> https://github.com/apache/spark/pull/9920
>
> https://github.com/apache/spark/pull/9936
>
> https://github.com/apache/spark/pull/10052
>
> https://github.com/apache/spark/pull/10125
>
> https://github.com/apache/spark/pull/10209
>
> https://github.com/apache/spark/pull/10572 <- not sure
>
> https://github.com/apache/spark/pull/10326
>
> https://github.com/apache/spark/pull/10379
>
> https://github.com/apache/spark/pull/10403
>
> https://github.com/apache/spark/pull/10466
>
> https://github.com/apache/spark/pull/10572 <- not sure
>
> https://github.com/apache/spark/pull/10995
>
> https://github.com/apache/spark/pull/10887
>
> https://github.com/apache/spark/pull/10842
>
> https://github.com/apache/spark/pull/11005
>
> https://github.com/apache/spark/pull/11036
>
> https://github.com/apache/spark/pull/11129
>
> https://github.com/apache/spark/pull/11610
>
> https://github.com/apache/spark/pull/11729
>
> https://github.com/apache/spark/pull/11980
>
> https://github.com/apache/spark/pull/12075
>
>
> Thanks.
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
For additional commands, e-mail: dev-h...@spark.apache.org

Re: Proposal of closing some PRs and maybe some PRs abandoned by its author

2016-05-06 Thread Nicholas Chammas 
Alex has built tooling for this btw:
https://github.com/databricks/spark-pr-dashboard/pull/71

On Fri, May 6, 2016 at 12:15 PM Ted Yu  wrote:

> PR #10572 was listed twice.
>
> In the future, is it possible to include the contributor's handle beside
> the PR number so that people can easily recognize their own PR ?
>
> Thanks
>
> On Fri, May 6, 2016 at 8:45 AM, Hyukjin Kwon  wrote:
>
>> Hi all,
>>
>>
>> This was similar with the proposal of closing PRs before I asked.
>>
>> I think the PRs suggested to be closed below are closable but not very
>> sure of PRs apparently abandoned by its author at least for a month.
>>
>> I remember the discussion about auto-closing PR before. So, I included
>> the PRs as below anyway.
>>
>> I looked though the open every PR at this time and could make a list as
>> below:
>>
>>
>> 1. Suggested to be closed.
>>
>>
>> https://github.com/apache/spark/pull/7739  <- not sure
>>
>> https://github.com/apache/spark/pull/9354
>>
>> https://github.com/apache/spark/pull/9451
>>
>> https://github.com/apache/spark/pull/10507
>>
>> https://github.com/apache/spark/pull/10486
>>
>> https://github.com/apache/spark/pull/10460
>>
>> https://github.com/apache/spark/pull/10967
>>
>> https://github.com/apache/spark/pull/10945
>>
>> https://github.com/apache/spark/pull/10701
>>
>> https://github.com/apache/spark/pull/10681
>>
>> https://github.com/apache/spark/pull/11766
>>
>>
>>
>> 2. Author not answering at least for a month.
>>
>>
>> https://github.com/apache/spark/pull/9907
>>
>> https://github.com/apache/spark/pull/9920
>>
>> https://github.com/apache/spark/pull/9936
>>
>> https://github.com/apache/spark/pull/10052
>>
>> https://github.com/apache/spark/pull/10125
>>
>> https://github.com/apache/spark/pull/10209
>>
>> https://github.com/apache/spark/pull/10572 <- not sure
>>
>> https://github.com/apache/spark/pull/10326
>>
>> https://github.com/apache/spark/pull/10379
>>
>> https://github.com/apache/spark/pull/10403
>>
>> https://github.com/apache/spark/pull/10466
>>
>> https://github.com/apache/spark/pull/10572 <- not sure
>>
>> https://github.com/apache/spark/pull/10995
>>
>> https://github.com/apache/spark/pull/10887
>>
>> https://github.com/apache/spark/pull/10842
>>
>> https://github.com/apache/spark/pull/11005
>>
>> https://github.com/apache/spark/pull/11036
>>
>> https://github.com/apache/spark/pull/11129
>>
>> https://github.com/apache/spark/pull/11610
>>
>> https://github.com/apache/spark/pull/11729
>>
>> https://github.com/apache/spark/pull/11980
>>
>> https://github.com/apache/spark/pull/12075
>>
>>
>> Thanks.
>>
>>
>>
>

Re: Proposal of closing some PRs and maybe some PRs abandoned by its author

2016-05-06 Thread Ted Yu 
PR #10572 was listed twice.

In the future, is it possible to include the contributor's handle beside
the PR number so that people can easily recognize their own PR ?

Thanks

On Fri, May 6, 2016 at 8:45 AM, Hyukjin Kwon  wrote:

> Hi all,
>
>
> This was similar with the proposal of closing PRs before I asked.
>
> I think the PRs suggested to be closed below are closable but not very
> sure of PRs apparently abandoned by its author at least for a month.
>
> I remember the discussion about auto-closing PR before. So, I included the
> PRs as below anyway.
>
> I looked though the open every PR at this time and could make a list as
> below:
>
>
> 1. Suggested to be closed.
>
>
> https://github.com/apache/spark/pull/7739  <- not sure
>
> https://github.com/apache/spark/pull/9354
>
> https://github.com/apache/spark/pull/9451
>
> https://github.com/apache/spark/pull/10507
>
> https://github.com/apache/spark/pull/10486
>
> https://github.com/apache/spark/pull/10460
>
> https://github.com/apache/spark/pull/10967
>
> https://github.com/apache/spark/pull/10945
>
> https://github.com/apache/spark/pull/10701
>
> https://github.com/apache/spark/pull/10681
>
> https://github.com/apache/spark/pull/11766
>
>
>
> 2. Author not answering at least for a month.
>
>
> https://github.com/apache/spark/pull/9907
>
> https://github.com/apache/spark/pull/9920
>
> https://github.com/apache/spark/pull/9936
>
> https://github.com/apache/spark/pull/10052
>
> https://github.com/apache/spark/pull/10125
>
> https://github.com/apache/spark/pull/10209
>
> https://github.com/apache/spark/pull/10572 <- not sure
>
> https://github.com/apache/spark/pull/10326
>
> https://github.com/apache/spark/pull/10379
>
> https://github.com/apache/spark/pull/10403
>
> https://github.com/apache/spark/pull/10466
>
> https://github.com/apache/spark/pull/10572 <- not sure
>
> https://github.com/apache/spark/pull/10995
>
> https://github.com/apache/spark/pull/10887
>
> https://github.com/apache/spark/pull/10842
>
> https://github.com/apache/spark/pull/11005
>
> https://github.com/apache/spark/pull/11036
>
> https://github.com/apache/spark/pull/11129
>
> https://github.com/apache/spark/pull/11610
>
> https://github.com/apache/spark/pull/11729
>
> https://github.com/apache/spark/pull/11980
>
> https://github.com/apache/spark/pull/12075
>
>
> Thanks.
>
>
>

Proposal of closing some PRs and maybe some PRs abandoned by its author

2016-05-06 Thread Hyukjin Kwon 
Hi all,


This was similar with the proposal of closing PRs before I asked.

I think the PRs suggested to be closed below are closable but not very sure
of PRs apparently abandoned by its author at least for a month.

I remember the discussion about auto-closing PR before. So, I included the
PRs as below anyway.

I looked though the open every PR at this time and could make a list as
below:


1. Suggested to be closed.


https://github.com/apache/spark/pull/7739  <- not sure

https://github.com/apache/spark/pull/9354

https://github.com/apache/spark/pull/9451

https://github.com/apache/spark/pull/10507

https://github.com/apache/spark/pull/10486

https://github.com/apache/spark/pull/10460

https://github.com/apache/spark/pull/10967

https://github.com/apache/spark/pull/10945

https://github.com/apache/spark/pull/10701

https://github.com/apache/spark/pull/10681

https://github.com/apache/spark/pull/11766



2. Author not answering at least for a month.


https://github.com/apache/spark/pull/9907

https://github.com/apache/spark/pull/9920

https://github.com/apache/spark/pull/9936

https://github.com/apache/spark/pull/10052

https://github.com/apache/spark/pull/10125

https://github.com/apache/spark/pull/10209

https://github.com/apache/spark/pull/10572 <- not sure

https://github.com/apache/spark/pull/10326

https://github.com/apache/spark/pull/10379

https://github.com/apache/spark/pull/10403

https://github.com/apache/spark/pull/10466

https://github.com/apache/spark/pull/10572 <- not sure

https://github.com/apache/spark/pull/10995

https://github.com/apache/spark/pull/10887

https://github.com/apache/spark/pull/10842

https://github.com/apache/spark/pull/11005

https://github.com/apache/spark/pull/11036

https://github.com/apache/spark/pull/11129

https://github.com/apache/spark/pull/11610

https://github.com/apache/spark/pull/11729

https://github.com/apache/spark/pull/11980

https://github.com/apache/spark/pull/12075


Thanks.

TaskSchedulerImpl#initialize - why is rootPool initialized here not while TaskSchedulerImpl is created?

2016-05-06 Thread Jacek Laskowski 
Hi,

While reviewing TaskSchedulerImpl I've noticed that rootPool is
created and initialized in TaskSchedulerImpl#initialize [1], but seems
legit to do it as part of TaskSchedulerImpl's instantiation.

What is the reason for creating and initializing rootPool late in
TaskSchedulerImpl's lifecycle?

[1] 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala#L131-L142

Pozdrawiam,
Jacek Laskowski

https://medium.com/@jaceklaskowski/
Mastering Apache Spark http://bit.ly/mastering-apache-spark
Follow me at https://twitter.com/jaceklaskowski

-
To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
For additional commands, e-mail: dev-h...@spark.apache.org