GraphX doc: triangleCount() requirement overstatement?

2015-01-18 Thread Michael Malak 
According to:
https://spark.apache.org/docs/1.2.0/graphx-programming-guide.html#triangle-counting
 

Note that TriangleCount requires the edges to be in canonical orientation 
(srcId  dstId)

But isn't this overstating the requirement? Isn't the requirement really that 
IF there are duplicate edges between two vertices, THEN those edges must all be 
in the same direction (in order for the groupEdges() at the beginning of 
triangleCount() to produce the intermediate results that triangleCount() 
expects)?

If so, should I enter a JIRA ticket to clarify the documentation?

Or is it the case that https://issues.apache.org/jira/browse/SPARK-3650 will 
make it into Spark 1.3 anyway?

-
To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
For additional commands, e-mail: dev-h...@spark.apache.org

Re: GraphX doc: triangleCount() requirement overstatement?

2015-01-18 Thread Reynold Xin 
We will merge https://issues.apache.org/jira/browse/SPARK-3650  for 1.3.
Thanks for reminding!


On Sun, Jan 18, 2015 at 8:34 PM, Michael Malak 
michaelma...@yahoo.com.invalid wrote:

 According to:

 https://spark.apache.org/docs/1.2.0/graphx-programming-guide.html#triangle-counting

 Note that TriangleCount requires the edges to be in canonical orientation
 (srcId  dstId)

 But isn't this overstating the requirement? Isn't the requirement really
 that IF there are duplicate edges between two vertices, THEN those edges
 must all be in the same direction (in order for the groupEdges() at the
 beginning of triangleCount() to produce the intermediate results that
 triangleCount() expects)?

 If so, should I enter a JIRA ticket to clarify the documentation?

 Or is it the case that https://issues.apache.org/jira/browse/SPARK-3650
 will make it into Spark 1.3 anyway?

 -
 To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org
 For additional commands, e-mail: dev-h...@spark.apache.org