Re: SparkConf constructor now private
Is the SparkConf effectively a singleton? Could there be a Utils method to return a clone of the SparkConf? Cheers On Tue, 15 Mar 2016 at 16:49 Marcelo Vanzinwrote: > Oh, my bad. I think I left that from a previous part of the patch and > forgot to revert it. Will fix. > > On Tue, Mar 15, 2016 at 7:37 AM, Koert Kuipers wrote: > > in this commit > > > > 8301fadd8d269da11e72870b7a889596e3337839 > > Author: Marcelo Vanzin > > Date: Mon Mar 14 14:27:33 2016 -0700 > > [SPARK-13626][CORE] Avoid duplicate config deprecation warnings. > > > > the following change was made > > > > -class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging { > > +class SparkConf private[spark] (loadDefaults: Boolean) extends Cloneable > > with Logging { > > > > i use the constructor new SparkConf(false) to build a SparkConf for our > > in-house unit tests (where i do not want system properties to change > meddle > > with things). > > > > is this API change on purpose? > > > > -- > Marcelo > > - > To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org > For additional commands, e-mail: dev-h...@spark.apache.org > >
Re: SparkConf constructor now private
Oh, my bad. I think I left that from a previous part of the patch and forgot to revert it. Will fix. On Tue, Mar 15, 2016 at 7:37 AM, Koert Kuiperswrote: > in this commit > > 8301fadd8d269da11e72870b7a889596e3337839 > Author: Marcelo Vanzin > Date: Mon Mar 14 14:27:33 2016 -0700 > [SPARK-13626][CORE] Avoid duplicate config deprecation warnings. > > the following change was made > > -class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging { > +class SparkConf private[spark] (loadDefaults: Boolean) extends Cloneable > with Logging { > > i use the constructor new SparkConf(false) to build a SparkConf for our > in-house unit tests (where i do not want system properties to change meddle > with things). > > is this API change on purpose? -- Marcelo - To unsubscribe, e-mail: dev-unsubscr...@spark.apache.org For additional commands, e-mail: dev-h...@spark.apache.org
SparkConf constructor now private
in this commit 8301fadd8d269da11e72870b7a889596e3337839 Author: Marcelo VanzinDate: Mon Mar 14 14:27:33 2016 -0700 [SPARK-13626][CORE] Avoid duplicate config deprecation warnings. the following change was made -class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging { +class SparkConf private[spark] (loadDefaults: Boolean) extends Cloneable with Logging { i use the constructor new SparkConf(false) to build a SparkConf for our in-house unit tests (where i do not want system properties to change meddle with things). is this API change on purpose?