thank you for reviewing our patches

2014-09-26 Thread Nicholas Chammas
I recently came across this mailing list post by Linus Torvalds
https://lkml.org/lkml/2004/12/20/255 about the value of reviewing even
“trivial” patches. The following passages stood out to me:

I think that much more important than the patch is the fact that people get
used to the notion that they can change the kernel

…

So please don’t stop. Yes, those trivial patches *are* a bother. Damn, they
are *horrible*. But at the same time, the devil is in the detail, and they
are needed in the long run. Both the patches themselves, and the people
that grew up on them.

Spark is the first (and currently only) open source project I contribute
regularly to. My first several PRs against the project, as simple as they
were, were definitely patches that I “grew up on”.

I appreciate the time and effort all the reviewers I’ve interacted with
have taken to work with me on my PRs, even when they are “trivial”. And I’m
sure that as I continue to contribute to this project there will be many
more patches that I will “grow up on”.

Thank you Patrick, Reynold, Josh, Davies, Michael, and everyone else who’s
taken time to review one of my patches. I appreciate it!

Nick
​


Re: thank you for reviewing our patches

2014-09-26 Thread Reynold Xin
Keep the patches coming :)


On Fri, Sep 26, 2014 at 1:50 PM, Nicholas Chammas 
nicholas.cham...@gmail.com wrote:

 I recently came across this mailing list post by Linus Torvalds
 https://lkml.org/lkml/2004/12/20/255 about the value of reviewing even
 “trivial” patches. The following passages stood out to me:

 I think that much more important than the patch is the fact that people get
 used to the notion that they can change the kernel

 …

 So please don’t stop. Yes, those trivial patches *are* a bother. Damn, they
 are *horrible*. But at the same time, the devil is in the detail, and they
 are needed in the long run. Both the patches themselves, and the people
 that grew up on them.

 Spark is the first (and currently only) open source project I contribute
 regularly to. My first several PRs against the project, as simple as they
 were, were definitely patches that I “grew up on”.

 I appreciate the time and effort all the reviewers I’ve interacted with
 have taken to work with me on my PRs, even when they are “trivial”. And I’m
 sure that as I continue to contribute to this project there will be many
 more patches that I will “grow up on”.

 Thank you Patrick, Reynold, Josh, Davies, Michael, and everyone else who’s
 taken time to review one of my patches. I appreciate it!

 Nick
 ​