[jira] [Commented] (SQOOP-1281) Support of glob paths during export

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945235#comment-14945235
 ] 

ASF subversion and git services commented on SQOOP-1281:


Commit 02e36db2b8deee01ae08a493369097b6812a164e in sqoop's branch 
refs/heads/trunk from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=02e36db ]

SQOOP-1281: Support of glob paths during export

(Clément MAHTIEU via Jarek Jarcec Cecho)


> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (SQOOP-1281) Support of glob paths during export

[Jarek Jarcec Cecho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Jarcec Cecho reassigned SQOOP-1281:
-

Assignee: Clément MATHIEU

> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
>Assignee: Clément MATHIEU
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 38372: Support of glob paths during export

[Jarek Cecho]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38372/#review101649
---

Ship it!


Ship It!

- Jarek Cecho


On Oct. 3, 2015, 3 p.m., Clément MATHIEU wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38372/
> ---
> 
> (Updated Oct. 3, 2015, 3 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1281
> https://issues.apache.org/jira/browse/SQOOP-1281
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> The only thing required to add support of glob paths is to update 
> ExportJobBase.getFileType.
> 
> Current code fails with an exception when globbing is used. The patch add 
> support of glob paths while preserving the original logic:
> 
>  - Returns the type of the first file
>  - Fails if no file can be found
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/mapreduce/ExportJobBase.java f9fa7f3 
>   src/test/com/cloudera/sqoop/TestAvroExport.java 663828c 
> 
> Diff: https://reviews.apache.org/r/38372/diff/
> 
> 
> Testing
> ---
> 
> It has been tested & used with Sqoop 1.4.5 on top of a CDH 4.7, 5.3 & 5.4 (we 
> have jobs taking glob paths as input parameter)
> 
> I quickly crawled the test suite to see how I could unit test this change but 
> failed to find a trivial implementation. I believe that I have to fiddle with 
> getTablePath / TestExport but I'm not sure where it will take me. Any advice 
> is welcome.
> 
> 
> Thanks,
> 
> Clément MATHIEU
> 
>

[jira] [Commented] (SQOOP-2490) Sqoop2: Add extra jars to job

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946179#comment-14946179
 ] 

ASF subversion and git services commented on SQOOP-2490:


Commit d3fbe102acf7360252ba47e5fd0c3f297bdd9404 in sqoop's branch 
refs/heads/sqoop2 from [~jarcec]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=d3fbe10 ]

SQOOP-2490: Sqoop2: Add extra jars to job

(Abraham Fine via Jarek Jarcec Cecho)


> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2490) Sqoop2: Add extra jars to job

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946206#comment-14946206
 ] 

Hudson commented on SQOOP-2490:
---

SUCCESS: Integrated in Sqoop2 #915 (See 
[https://builds.apache.org/job/Sqoop2/915/])
SQOOP-2490: Sqoop2: Add extra jars to job (jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=d3fbe102acf7360252ba47e5fd0c3f297bdd9404])
* dist/src/main/server/conf/sqoop.properties
* test/src/test/resources/TestConnector/TestToInitializer.java
* core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
* core/src/main/resources/driver-config.properties
* test/src/test/resources/TestConnector/TestConnector.java
* test/src/test/resources/TestConnector/TestToJobConfiguration.java
* test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java
* core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
* core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java
* test/src/test/resources/TestConnector/TestToDestroyer.java
* test/src/test/resources/TestConnector/TestLoader.java
* test/src/test/resources/TestConnector/TestDependency.java
* core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
* test/src/test/resources/TestConnector/sqoopconnector.properties
* test/src/test/resources/TestConnector/TestLinkConfiguration.java
* core/src/main/java/org/apache/sqoop/driver/JobManager.java
* test/src/test/resources/classpath-tests-suite.xml
* core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
* core/src/test/java/org/apache/sqoop/driver/TestJobConfiguration.java
* test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java


> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2604) Sqoop2: Add "run" mode to sqoop2-server script

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945508#comment-14945508
 ] 

Sqoop QA bot commented on SQOOP-2604:
-

Testing file 
[SQOOP-2604.patch|https://issues.apache.org/jira/secure/attachment/12765201/SQOOP-2604.patch]
 against branch sqoop2 took 0:57:59.740515.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1760/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1760/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1760/console].

This message is automatically generated.

> Sqoop2: Add "run" mode to sqoop2-server script
> --
>
> Key: SQOOP-2604
> URL: https://issues.apache.org/jira/browse/SQOOP-2604
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2604.patch
>
>
> Before we migrated to Jetty, in Tomcat world one had ability to run 
> {{catalina.sh}} script directly with argument {{run}} that would start the 
> Tomcat instance in the foreground rather then in the background as is done 
> with the {{start}} argument. The {{run}} method is super useful for 
> packaging, so I would like to add it to our {{sqoop.sh}} script now as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2605) Sqoop2: Allow to override location of configuration directory

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945557#comment-14945557
 ] 

Sqoop QA bot commented on SQOOP-2605:
-

Testing file 
[SQOOP-2605.patch|https://issues.apache.org/jira/secure/attachment/12765207/SQOOP-2605.patch]
 against branch sqoop2 took 0:53:51.151257.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1761/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1761/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1761/console].

This message is automatically generated.

> Sqoop2: Allow to override location of configuration directory
> -
>
> Key: SQOOP-2605
> URL: https://issues.apache.org/jira/browse/SQOOP-2605
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2605.patch
>
>
> I'm working on packaging scripts for Sqoop 2 and I've noticed that we've 
> hardcoded location of configuration directory. I would like to make it 
> configurable, so that the packaging scripts can move the location directory 
> somewhere else (for example to {{/etc/sqoop2/}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SQOOP-2605) Sqoop2: Allow to override location of configuration directory

[Jarek Jarcec Cecho (JIRA)]

Jarek Jarcec Cecho created SQOOP-2605:
-

 Summary: Sqoop2: Allow to override location of configuration 
directory
 Key: SQOOP-2605
 URL: https://issues.apache.org/jira/browse/SQOOP-2605
 Project: Sqoop
  Issue Type: Bug
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
 Fix For: 1.99.7


I'm working on packaging scripts for Sqoop 2 and I've noticed that we've 
hardcoded location of configuration directory. I would like to make it 
configurable, so that the packaging scripts can move the location directory 
somewhere else (for example to {{/etc/sqoop2/}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2605) Sqoop2: Allow to override location of configuration directory

[Jarek Jarcec Cecho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Jarcec Cecho updated SQOOP-2605:
--
Attachment: SQOOP-2605.patch

Attaching simple patch, so skipping review board.

> Sqoop2: Allow to override location of configuration directory
> -
>
> Key: SQOOP-2605
> URL: https://issues.apache.org/jira/browse/SQOOP-2605
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2605.patch
>
>
> I'm working on packaging scripts for Sqoop 2 and I've noticed that we've 
> hardcoded location of configuration directory. I would like to make it 
> configurable, so that the packaging scripts can move the location directory 
> somewhere else (for example to {{/etc/sqoop2/}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2604) Sqoop2: Add "run" mode to sqoop2-server script

[Jarek Jarcec Cecho (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945523#comment-14945523
 ] 

Jarek Jarcec Cecho commented on SQOOP-2604:
---

Absence of test is expected in packaging only change.

> Sqoop2: Add "run" mode to sqoop2-server script
> --
>
> Key: SQOOP-2604
> URL: https://issues.apache.org/jira/browse/SQOOP-2604
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2604.patch
>
>
> Before we migrated to Jetty, in Tomcat world one had ability to run 
> {{catalina.sh}} script directly with argument {{run}} that would start the 
> Tomcat instance in the foreground rather then in the background as is done 
> with the {{start}} argument. The {{run}} method is super useful for 
> packaging, so I would like to add it to our {{sqoop.sh}} script now as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2603) Sqoop2: Packaging script should make executables to be executable by default for everyone

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944548#comment-14944548
 ] 

Hudson commented on SQOOP-2603:
---

SUCCESS: Integrated in Sqoop2 #914 (See 
[https://builds.apache.org/job/Sqoop2/914/])
SQOOP-2603: Sqoop2: Packaging script should make executables to be (kathleen: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=26ae15c20040c883e3c52d49cca770ffdad9b1ac])
* dist/pom.xml


> Sqoop2: Packaging script should make executables to be executable by default 
> for everyone
> -
>
> Key: SQOOP-2603
> URL: https://issues.apache.org/jira/browse/SQOOP-2603
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2603.patch
>
>
> Currently only the owner have the executable bit which is a bit odd. The 
> files should be executable by everyone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: (was: SQOOP-2490.patch)

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: (was: SQOOP-2490.patch)

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: (was: SQOOP-2490.patch)

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: SQOOP-2490.patch

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: SQOOP-2490.patch

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39030: SQOOP-2490

[Abraham Fine]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39030/
---

(Updated Oct. 6, 2015, 7:48 p.m.)


Review request for Sqoop.


Bugs: SQOOP-2490
https://issues.apache.org/jira/browse/SQOOP-2490


Repository: sqoop-sqoop2


Description
---

Sqoop2: Add extra jars to job


Diffs (updated)
-

  core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java d7fe27b 
  core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 52e432d 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java ebb7efd 
  core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java 
PRE-CREATION 
  
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 
bf1328a 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java f9649f2 
  dist/pom.xml ff18487 
  dist/src/main/server/conf/sqoop.properties fe8bcce 
  test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 
7440025 
  test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java 
PRE-CREATION 
  test/src/test/resources/TestConnector/TestConnector.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestDependency.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestLinkConfiguration.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestLoader.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToDestroyer.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToInitializer.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToJobConfiguration.java 
PRE-CREATION 
  test/src/test/resources/TestConnector/sqoopconnector.properties PRE-CREATION 
  test/src/test/resources/classpath-tests-suite.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/39030/diff/


Testing
---

yes


Thanks,

Abraham Fine

[jira] [Commented] (SQOOP-2490) Sqoop2: Add extra jars to job

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945905#comment-14945905
 ] 

Sqoop QA bot commented on SQOOP-2490:
-

Testing file 
[SQOOP-2490.patch|https://issues.apache.org/jira/secure/attachment/12765234/SQOOP-2490.patch]
 against branch sqoop2 took 0:54:51.243296.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1762/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1762/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1762/console].

This message is automatically generated.

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Sqoop developer meetup

[Abraham Fine]

5 PM PDT would work for me.

I can't wait to meet everyone!

Abe

On Mon, Oct 5, 2015 at 8:31 AM, Jarek Jarcec Cecho 
wrote:

> I’ve dropped a ball on this discuss a bit, so my apologies for that.
>
> Since we’re distributed over the globe, I’m expecting to have difficulties
> to find an hour that will work for everyone. Hence let’s firstly talk about
> that and then we’ll find appropriate day :) Would let say 5 p.m. PDT be
> acceptable (that should be 8 a.m. in China) for everyone?
>
> Jarcec
>
> > On Sep 17, 2015, at 10:13 PM, Venkat Ranganathan <
> vranganat...@hortonworks.com> wrote:
> >
> > +1 from me too!
> >
> > Thanks
> >
> > Venkat
> >
> > 
> > From: Ma, Junjie 
> > Sent: Thursday, September 17, 2015 6:28 PM
> > To: dev@sqoop.apache.org
> > Subject: RE: Sqoop developer meetup
> >
> > Great, this can help me know the community better.
> >
> > Best regards,
> >
> > Colin Ma(Ma Jun Jie)
> >
> > -Original Message-
> > From: Fu, Dian [mailto:dian...@intel.com]
> > Sent: Friday, September 18, 2015 9:02 AM
> > To: dev@sqoop.apache.org
> > Subject: RE: Sqoop developer meetup
> >
> > +1. It would be a good chance to know other persons also working on
> Sqoop.
> >
> > Thanks,
> > Dian
> >
> > -Original Message-
> > From: Abraham Elmahrek [mailto:a...@cloudera.com]
> > Sent: Friday, September 18, 2015 4:58 AM
> > To: dev@sqoop.apache.org
> > Subject: Re: Sqoop developer meetup
> >
> > Sounds good to me as well :).
> >
> > On Thu, Sep 17, 2015 at 10:38 AM SenthilBharani Bogana Vijay <
> bvsent...@gmail.com> wrote:
> >
> >> Sounds very good. I am newbie to the group, it will be useful for
> >> several of the newbies like me to meet other developers and understand
> >> the community better.
> >> Thanks
> >> Senthil
> >>
> >> On Wed, Sep 16, 2015 at 2:07 PM, Jarek Jarcec Cecho
> >> 
> >> wrote:
> >>
> >>> Fellow sqoopers (sqoop developers),
> >>> myself and Venkat proposed Sqoop contributor (developer) meetup
> >>> early
> >> this
> >>> year [1]. We had one meeting so far and I was thinking about doing
> >> another
> >>> one and I’m wondering what is the community feeling about that?
> >>>
> >>> I know that it will be hard to get everyone in person as we have
> >>> quite active team in China, but perhaps we can get local people in
> >>> bay area and teleconference the rest? My main goal is to primarily
> >>> connect developers
> >> in
> >>> person/over the phone and socialize then to discuss any serious topics.
> >> But
> >>> if you have anything worth discussing in person, do let me know!
> >>>
> >>> Jarcec
> >>>
> >>> Links:
> >>> 1: http://markmail.org/message/dgqpp6warbofnjp3
> >>>
> >>>
> >>>
> >>
>
>

Re: Sqoop developer meetup

[Mengwei Ding]

I would like to join as well. Haven't sync up with you guys for a while. :)
5:00pm PDT sounds good to me.

Mengwei

On Tue, Oct 6, 2015 at 2:21 PM, Abraham Fine  wrote:

> 5 PM PDT would work for me.
>
> I can't wait to meet everyone!
>
> Abe
>
> On Mon, Oct 5, 2015 at 8:31 AM, Jarek Jarcec Cecho 
> wrote:
>
> > I’ve dropped a ball on this discuss a bit, so my apologies for that.
> >
> > Since we’re distributed over the globe, I’m expecting to have
> difficulties
> > to find an hour that will work for everyone. Hence let’s firstly talk
> about
> > that and then we’ll find appropriate day :) Would let say 5 p.m. PDT be
> > acceptable (that should be 8 a.m. in China) for everyone?
> >
> > Jarcec
> >
> > > On Sep 17, 2015, at 10:13 PM, Venkat Ranganathan <
> > vranganat...@hortonworks.com> wrote:
> > >
> > > +1 from me too!
> > >
> > > Thanks
> > >
> > > Venkat
> > >
> > > 
> > > From: Ma, Junjie 
> > > Sent: Thursday, September 17, 2015 6:28 PM
> > > To: dev@sqoop.apache.org
> > > Subject: RE: Sqoop developer meetup
> > >
> > > Great, this can help me know the community better.
> > >
> > > Best regards,
> > >
> > > Colin Ma(Ma Jun Jie)
> > >
> > > -Original Message-
> > > From: Fu, Dian [mailto:dian...@intel.com]
> > > Sent: Friday, September 18, 2015 9:02 AM
> > > To: dev@sqoop.apache.org
> > > Subject: RE: Sqoop developer meetup
> > >
> > > +1. It would be a good chance to know other persons also working on
> > Sqoop.
> > >
> > > Thanks,
> > > Dian
> > >
> > > -Original Message-
> > > From: Abraham Elmahrek [mailto:a...@cloudera.com]
> > > Sent: Friday, September 18, 2015 4:58 AM
> > > To: dev@sqoop.apache.org
> > > Subject: Re: Sqoop developer meetup
> > >
> > > Sounds good to me as well :).
> > >
> > > On Thu, Sep 17, 2015 at 10:38 AM SenthilBharani Bogana Vijay <
> > bvsent...@gmail.com> wrote:
> > >
> > >> Sounds very good. I am newbie to the group, it will be useful for
> > >> several of the newbies like me to meet other developers and understand
> > >> the community better.
> > >> Thanks
> > >> Senthil
> > >>
> > >> On Wed, Sep 16, 2015 at 2:07 PM, Jarek Jarcec Cecho
> > >> 
> > >> wrote:
> > >>
> > >>> Fellow sqoopers (sqoop developers),
> > >>> myself and Venkat proposed Sqoop contributor (developer) meetup
> > >>> early
> > >> this
> > >>> year [1]. We had one meeting so far and I was thinking about doing
> > >> another
> > >>> one and I’m wondering what is the community feeling about that?
> > >>>
> > >>> I know that it will be hard to get everyone in person as we have
> > >>> quite active team in China, but perhaps we can get local people in
> > >>> bay area and teleconference the rest? My main goal is to primarily
> > >>> connect developers
> > >> in
> > >>> person/over the phone and socialize then to discuss any serious
> topics.
> > >> But
> > >>> if you have anything worth discussing in person, do let me know!
> > >>>
> > >>> Jarcec
> > >>>
> > >>> Links:
> > >>> 1: http://markmail.org/message/dgqpp6warbofnjp3
> > >>>
> > >>>
> > >>>
> > >>
> >
> >
>

[jira] [Assigned] (SQOOP-1442) Sqoop2: Validations: Serialize validations over the wire for client transfer

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine reassigned SQOOP-1442:
---

Assignee: Abraham Fine  (was: Jarek Jarcec Cecho)

> Sqoop2: Validations: Serialize validations over the wire for client transfer
> 
>
> Key: SQOOP-1442
> URL: https://issues.apache.org/jira/browse/SQOOP-1442
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Abraham Fine
> Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39030: SQOOP-2490

[Jarek Cecho]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39030/#review101702
---


Few comments:


core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java (line 87)


Nit: Might I suggest to rename this variable to 
org.apache.sqoop.classpath.job or something. So that it's in the same "prefix" 
as the property CLASSPATH.



core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java (lines 280 - 
310)


I somehow feel that the job of parsing the configuration property shouldn't 
be here but rather in the JobManager class.

The SqoopConfiguration is a general class that in general doesn't know 
about semantics of underlaying properties (there are few exceptions though) and 
the semantics is given in the code that is actually using the configuration 
propertly. Good example of that is the property 
org.apache.sqoop.classpath.extra that also contains extra classpath entires, 
but yet we're not parsing them in this class.



core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java (lines 
26 - 30)


You will need to create entries in driver-config.properties: 


https://github.com/apache/sqoop/blob/sqoop2/core/src/main/resources/driver-config.properties

Might I suggest to port this tescase to Driver as well?


https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnector.java

The test case would uncover this missing piece.



core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java (line 
28)


Super nit: Please put space between the "//" and "A"



dist/pom.xml (line 194)


This change doesn't seem to be relevant to this patch, so let's nuke it?


Jarcec

- Jarek Cecho


On Oct. 6, 2015, 7:48 p.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39030/
> ---
> 
> (Updated Oct. 6, 2015, 7:48 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2490
> https://issues.apache.org/jira/browse/SQOOP-2490
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> Sqoop2: Add extra jars to job
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 
> d7fe27b 
>   core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 52e432d 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ebb7efd 
>   core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
>  bf1328a 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java f9649f2 
>   dist/pom.xml ff18487 
>   dist/src/main/server/conf/sqoop.properties fe8bcce 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 
> 7440025 
>   
> test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/TestConnector.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestDependency.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestLinkConfiguration.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/TestLoader.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToDestroyer.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToInitializer.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToJobConfiguration.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/sqoopconnector.properties 
> PRE-CREATION 
>   test/src/test/resources/classpath-tests-suite.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39030/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

[jira] [Commented] (SQOOP-2605) Sqoop2: Allow to override location of configuration directory

[Jarek Jarcec Cecho (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945568#comment-14945568
 ] 

Jarek Jarcec Cecho commented on SQOOP-2605:
---

Absence of tests is expected from packaging only change.

> Sqoop2: Allow to override location of configuration directory
> -
>
> Key: SQOOP-2605
> URL: https://issues.apache.org/jira/browse/SQOOP-2605
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2605.patch
>
>
> I'm working on packaging scripts for Sqoop 2 and I've noticed that we've 
> hardcoded location of configuration directory. I would like to make it 
> configurable, so that the packaging scripts can move the location directory 
> somewhere else (for example to {{/etc/sqoop2/}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2490) Sqoop2: Add extra jars to job

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946148#comment-14946148
 ] 

Sqoop QA bot commented on SQOOP-2490:
-

Testing file 
[SQOOP-2490.patch|https://issues.apache.org/jira/secure/attachment/12765294/SQOOP-2490.patch]
 against branch sqoop2 took 0:55:36.435461.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1436 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1764/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1764/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 89 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1764/console].

This message is automatically generated.

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39030: SQOOP-2490

[Abraham Fine]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39030/
---

(Updated Oct. 7, 2015, 12:05 a.m.)


Review request for Sqoop.


Bugs: SQOOP-2490
https://issues.apache.org/jira/browse/SQOOP-2490


Repository: sqoop-sqoop2


Description
---

Sqoop2: Add extra jars to job


Diffs (updated)
-

  core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java d7fe27b 
  core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 52e432d 
  core/src/main/java/org/apache/sqoop/driver/JobManager.java ebb7efd 
  core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java 
PRE-CREATION 
  
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java 
bf1328a 
  core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java f9649f2 
  core/src/main/resources/driver-config.properties e005775 
  core/src/test/java/org/apache/sqoop/driver/TestJobConfiguration.java 
PRE-CREATION 
  dist/src/main/server/conf/sqoop.properties fe8bcce 
  test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 
7440025 
  test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java 
PRE-CREATION 
  test/src/test/resources/TestConnector/TestConnector.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestDependency.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestLinkConfiguration.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestLoader.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToDestroyer.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToInitializer.java PRE-CREATION 
  test/src/test/resources/TestConnector/TestToJobConfiguration.java 
PRE-CREATION 
  test/src/test/resources/TestConnector/sqoopconnector.properties PRE-CREATION 
  test/src/test/resources/classpath-tests-suite.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/39030/diff/


Testing
---

yes


Thanks,

Abraham Fine

[jira] [Updated] (SQOOP-2490) Sqoop2: Add extra jars to job

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine updated SQOOP-2490:

Attachment: SQOOP-2490.patch

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 39030: SQOOP-2490

[Jarek Cecho]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39030/#review101728
---

Ship it!


+1 as long as precommit hook passes

- Jarek Cecho


On Oct. 7, 2015, 12:05 a.m., Abraham Fine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39030/
> ---
> 
> (Updated Oct. 7, 2015, 12:05 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2490
> https://issues.apache.org/jira/browse/SQOOP-2490
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> ---
> 
> Sqoop2: Add extra jars to job
> 
> 
> Diffs
> -
> 
>   core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 
> d7fe27b 
>   core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 52e432d 
>   core/src/main/java/org/apache/sqoop/driver/JobManager.java ebb7efd 
>   core/src/main/java/org/apache/sqoop/driver/configuration/JarConfig.java 
> PRE-CREATION 
>   
> core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
>  bf1328a 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java f9649f2 
>   core/src/main/resources/driver-config.properties e005775 
>   core/src/test/java/org/apache/sqoop/driver/TestJobConfiguration.java 
> PRE-CREATION 
>   dist/src/main/server/conf/sqoop.properties fe8bcce 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 
> 7440025 
>   
> test/src/test/java/org/apache/sqoop/integration/classpath/ClasspathTest.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/TestConnector.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestDependency.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestLinkConfiguration.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/TestLoader.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToDestroyer.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToInitializer.java PRE-CREATION 
>   test/src/test/resources/TestConnector/TestToJobConfiguration.java 
> PRE-CREATION 
>   test/src/test/resources/TestConnector/sqoopconnector.properties 
> PRE-CREATION 
>   test/src/test/resources/classpath-tests-suite.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39030/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Abraham Fine
> 
>

[jira] [Created] (SQOOP-2606) Sqoop2: Do not reconfigure log4j if there are no log4j properties inside sqoop.properties file

[Jarek Jarcec Cecho (JIRA)]

Jarek Jarcec Cecho created SQOOP-2606:
-

 Summary: Sqoop2: Do not reconfigure log4j if there are no log4j 
properties inside sqoop.properties file
 Key: SQOOP-2606
 URL: https://issues.apache.org/jira/browse/SQOOP-2606
 Project: Sqoop
  Issue Type: Bug
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
 Fix For: 1.99.7


Current 
[SqoopConfiguration|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java#L283]
 implementation will assume that log4 is *always* configured inside 
{{sqoop.properties}} file and if this is not the case, then it will reconfigure 
log4j with "nothing". I like the ability to specify log4j properties inside the 
configuration file - that is very handy, however they are valid use cases when 
one would supply the log4j configuration using "usual" means and hence we 
should not re-configure log4j if there is no configuration inside the 
{{sqoop.properties}} file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2606) Sqoop2: Do not reconfigure log4j if there are no log4j properties inside sqoop.properties file

[Jarek Jarcec Cecho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Jarcec Cecho updated SQOOP-2606:
--
Attachment: SQOOP-2606.patch

Attaching simple patch, so skipping review board.

> Sqoop2: Do not reconfigure log4j if there are no log4j properties inside 
> sqoop.properties file
> --
>
> Key: SQOOP-2606
> URL: https://issues.apache.org/jira/browse/SQOOP-2606
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2606.patch
>
>
> Current 
> [SqoopConfiguration|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java#L283]
>  implementation will assume that log4 is *always* configured inside 
> {{sqoop.properties}} file and if this is not the case, then it will 
> reconfigure log4j with "nothing". I like the ability to specify log4j 
> properties inside the configuration file - that is very handy, however they 
> are valid use cases when one would supply the log4j configuration using 
> "usual" means and hence we should not re-configure log4j if there is no 
> configuration inside the {{sqoop.properties}} file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2606) Sqoop2: Do not reconfigure log4j if there are no log4j properties inside sqoop.properties file

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946016#comment-14946016
 ] 

Sqoop QA bot commented on SQOOP-2606:
-

Testing file 
[SQOOP-2606.patch|https://issues.apache.org/jira/secure/attachment/12765281/SQOOP-2606.patch]
 against branch sqoop2 took 0:02:49.890222.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:red}ERROR:{color} Patch does not add/modify any test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:red}ERROR:{color} Some of unit tests failed 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/test_unit.txt],
 executed 0 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/artifact/patch-process/test_integration.txt],
 executed 146 tests)
* Test {{TestSuite}}



Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1763/console].

This message is automatically generated.

> Sqoop2: Do not reconfigure log4j if there are no log4j properties inside 
> sqoop.properties file
> --
>
> Key: SQOOP-2606
> URL: https://issues.apache.org/jira/browse/SQOOP-2606
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2606.patch
>
>
> Current 
> [SqoopConfiguration|https://github.com/apache/sqoop/blob/sqoop2/core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java#L283]
>  implementation will assume that log4 is *always* configured inside 
> {{sqoop.properties}} file and if this is not the case, then it will 
> reconfigure log4j with "nothing". I like the ability to specify log4j 
> properties inside the configuration file - that is very handy, however they 
> are valid use cases when one would supply the log4j configuration using 
> "usual" means and hence we should not re-configure log4j if there is no 
> configuration inside the {{sqoop.properties}} file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-1281) Support of glob paths during export

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945314#comment-14945314
 ] 

Hudson commented on SQOOP-1281:
---

FAILURE: Integrated in Sqoop-hadoop200 #1026 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1026/])
SQOOP-1281: Support of glob paths during export (jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=02e36db2b8deee01ae08a493369097b6812a164e])
* src/test/com/cloudera/sqoop/TestAvroExport.java
* src/java/org/apache/sqoop/mapreduce/ExportJobBase.java


> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
>Assignee: Clément MATHIEU
> Fix For: 1.4.7
>
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-2490) Sqoop2: Add extra jars to job

[Sqoop QA bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945387#comment-14945387
 ] 

Sqoop QA bot commented on SQOOP-2490:
-

Testing file 
[SQOOP-2490.patch|https://issues.apache.org/jira/secure/attachment/12765117/SQOOP-2490.patch]
 against branch sqoop2 took 0:54:16.027781.

{color:red}Overall:{color} -1 due to an error(s), see details below:

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1434 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1759/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1759/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1759/artifact/patch-process/test_integration.txt],
 executed 82 tests)
* Test {{org.apache.sqoop.integration.server.ShowJobInOrderTest}}
* Test {{org.apache.sqoop.integration.server.InformalObjectNameTest}}
* Test {{org.apache.sqoop.integration.connector.hdfs.S3Test}}
* Test {{org.apache.sqoop.integration.server.ClasspathTest}}
* Test {{new-integration-tests}}
* Test 
{{org.apache.sqoop.integration.server.SubmissionWithDisabledModelObjectsTest}}



Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1759/console].

This message is automatically generated.

> Sqoop2: Add extra jars to job
> -
>
> Key: SQOOP-2490
> URL: https://issues.apache.org/jira/browse/SQOOP-2490
> Project: Sqoop
>  Issue Type: Improvement
>  Components: sqoop2-framework
>Affects Versions: 1.99.7
>Reporter: Abraham Elmahrek
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2490.patch, SQOOP-2490.patch
>
>
> It would be nice to have a configuration in sqoop.properties to add extra 
> jars to the job just in the event a connector is buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-1281) Support of glob paths during export

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945330#comment-14945330
 ] 

Hudson commented on SQOOP-1281:
---

FAILURE: Integrated in Sqoop-hadoop23 #1222 (See 
[https://builds.apache.org/job/Sqoop-hadoop23/1222/])
SQOOP-1281: Support of glob paths during export (jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=02e36db2b8deee01ae08a493369097b6812a164e])
* src/test/com/cloudera/sqoop/TestAvroExport.java
* src/java/org/apache/sqoop/mapreduce/ExportJobBase.java


> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
>Assignee: Clément MATHIEU
> Fix For: 1.4.7
>
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SQOOP-2604) Sqoop2: Add "run" mode to sqoop2-server script

[Jarek Jarcec Cecho (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jarek Jarcec Cecho updated SQOOP-2604:
--
Attachment: SQOOP-2604.patch

> Sqoop2: Add "run" mode to sqoop2-server script
> --
>
> Key: SQOOP-2604
> URL: https://issues.apache.org/jira/browse/SQOOP-2604
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Jarek Jarcec Cecho
>Assignee: Jarek Jarcec Cecho
> Fix For: 1.99.7
>
> Attachments: SQOOP-2604.patch
>
>
> Before we migrated to Jetty, in Tomcat world one had ability to run 
> {{catalina.sh}} script directly with argument {{run}} that would start the 
> Tomcat instance in the foreground rather then in the background as is done 
> with the {{start}} argument. The {{run}} method is super useful for 
> packaging, so I would like to add it to our {{sqoop.sh}} script now as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SQOOP-2604) Sqoop2: Add "run" mode to sqoop2-server script

[Jarek Jarcec Cecho (JIRA)]

Jarek Jarcec Cecho created SQOOP-2604:
-

 Summary: Sqoop2: Add "run" mode to sqoop2-server script
 Key: SQOOP-2604
 URL: https://issues.apache.org/jira/browse/SQOOP-2604
 Project: Sqoop
  Issue Type: Bug
Reporter: Jarek Jarcec Cecho
Assignee: Jarek Jarcec Cecho
 Fix For: 1.99.7


Before we migrated to Jetty, in Tomcat world one had ability to run 
{{catalina.sh}} script directly with argument {{run}} that would start the 
Tomcat instance in the foreground rather then in the background as is done with 
the {{start}} argument. The {{run}} method is super useful for packaging, so I 
would like to add it to our {{sqoop.sh}} script now as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-1281) Support of glob paths during export

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945310#comment-14945310
 ] 

Hudson commented on SQOOP-1281:
---

FAILURE: Integrated in Sqoop-hadoop20 #1019 (See 
[https://builds.apache.org/job/Sqoop-hadoop20/1019/])
SQOOP-1281: Support of glob paths during export (jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=02e36db2b8deee01ae08a493369097b6812a164e])
* src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* src/test/com/cloudera/sqoop/TestAvroExport.java


> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
>Assignee: Clément MATHIEU
> Fix For: 1.4.7
>
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SQOOP-1281) Support of glob paths during export

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945320#comment-14945320
 ] 

Hudson commented on SQOOP-1281:
---

FAILURE: Integrated in Sqoop-hadoop100 #986 (See 
[https://builds.apache.org/job/Sqoop-hadoop100/986/])
SQOOP-1281: Support of glob paths during export (jarcec: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=02e36db2b8deee01ae08a493369097b6812a164e])
* src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* src/test/com/cloudera/sqoop/TestAvroExport.java


> Support of glob paths during export 
> 
>
> Key: SQOOP-1281
> URL: https://issues.apache.org/jira/browse/SQOOP-1281
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.3
>Reporter: Viji
>Assignee: Clément MATHIEU
> Fix For: 1.4.7
>
> Attachments: 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export-2.patch, 
> 0001-SQOOP-1281-Support-of-glob-paths-during-export.patch
>
>
> The current Export mechanism in Sqoop does not support globs in its input 
> directory parameter. As a result, it considers wildcards as a path component 
> and upon the logical failure of its lookup, it assumes the input format is 
> unknown, and proceeds with using a Text based processor instead of the actual 
> type (such as avro).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)