Re: Review Request 65884: SqoopJobDataPublisher is invoked before Hive/HCat imports succeed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65884/#review198530 --- Patch #1 changes the following: - moves the reporting after Hive import - creats isolated classloader for Hive import, since Hive was polluting its classloader that caused trouble in Atlas' SqoopHook - changes PublishJobData#publishJobData to accept class name as its first argument instead of unnecessary Configuration object - daniel voros On March 2, 2018, 3:39 p.m., daniel voros wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65884/ > --- > > (Updated March 2, 2018, 3:39 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-3291 > https://issues.apache.org/jira/browse/SQOOP-3291 > > > Repository: sqoop-trunk > > > Description > --- > > Job data is published to listeners (defined via sqoop.job.data.publish.class) > in case of Hive and HCat imports. Currently this happens before the Hive > import completes, so it gets reported even if Hive import fails. > > > Diffs > - > > src/java/org/apache/sqoop/hive/HiveImport.java c272911 > src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 6529bd2 > src/java/org/apache/sqoop/mapreduce/ImportJobBase.java fb5d054 > src/java/org/apache/sqoop/mapreduce/PublishJobData.java fc18188 > src/java/org/apache/sqoop/tool/ImportTool.java e992005 > src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java b3579ac > src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java a5f85a0 > > > Diff: https://reviews.apache.org/r/65884/diff/1/ > > > Testing > --- > > - created unit test > - tested on a cluster with Atlas SqoopHook in place > > > Thanks, > > daniel voros > >
[jira] [Commented] (SQOOP-3291) SqoopJobDataPublisher is invoked before Hive/HCat imports succeed
[ https://issues.apache.org/jira/browse/SQOOP-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383703#comment-16383703 ] Daniel Voros commented on SQOOP-3291: - Attached review request link. > SqoopJobDataPublisher is invoked before Hive/HCat imports succeed > - > > Key: SQOOP-3291 > URL: https://issues.apache.org/jira/browse/SQOOP-3291 > Project: Sqoop > Issue Type: Bug > Components: hive-integration >Affects Versions: 1.4.7 >Reporter: Daniel Voros >Assignee: Daniel Voros >Priority: Major > Fix For: 1.5.0 > > > Job data is published to listeners (defined via sqoop.job.data.publish.class) > in case of Hive and HCat imports. Currently this happens before the Hive > import completes, so it gets reported even if Hive import fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Review Request 65884: SqoopJobDataPublisher is invoked before Hive/HCat imports succeed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65884/ --- Review request for Sqoop. Bugs: SQOOP-3291 https://issues.apache.org/jira/browse/SQOOP-3291 Repository: sqoop-trunk Description --- Job data is published to listeners (defined via sqoop.job.data.publish.class) in case of Hive and HCat imports. Currently this happens before the Hive import completes, so it gets reported even if Hive import fails. Diffs - src/java/org/apache/sqoop/hive/HiveImport.java c272911 src/java/org/apache/sqoop/mapreduce/ExportJobBase.java 6529bd2 src/java/org/apache/sqoop/mapreduce/ImportJobBase.java fb5d054 src/java/org/apache/sqoop/mapreduce/PublishJobData.java fc18188 src/java/org/apache/sqoop/tool/ImportTool.java e992005 src/test/org/apache/sqoop/TestSqoopJobDataPublisher.java b3579ac src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java a5f85a0 Diff: https://reviews.apache.org/r/65884/diff/1/ Testing --- - created unit test - tested on a cluster with Atlas SqoopHook in place Thanks, daniel voros
[jira] [Created] (SQOOP-3291) SqoopJobDataPublisher is invoked before Hive/HCat imports succeed
Daniel Voros created SQOOP-3291: --- Summary: SqoopJobDataPublisher is invoked before Hive/HCat imports succeed Key: SQOOP-3291 URL: https://issues.apache.org/jira/browse/SQOOP-3291 Project: Sqoop Issue Type: Bug Components: hive-integration Affects Versions: 1.4.7 Reporter: Daniel Voros Assignee: Daniel Voros Fix For: 1.5.0 Job data is published to listeners (defined via sqoop.job.data.publish.class) in case of Hive and HCat imports. Currently this happens before the Hive import completes, so it gets reported even if Hive import fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
