[jira] [Created] (SQOOP-3354) Document SQOOP-912: --hive-database parameter

2018-07-25 Thread Greg Liebowitz (JIRA) 
Greg Liebowitz created SQOOP-3354:
-

 Summary: Document SQOOP-912: --hive-database parameter
 Key: SQOOP-3354
 URL: https://issues.apache.org/jira/browse/SQOOP-3354
 Project: Sqoop
  Issue Type: Improvement
  Components: docs
Affects Versions: 1.4.7
Reporter: Greg Liebowitz


Sqoop documentation needed to be updated to include usage instructions on 
`--hive-database` parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SQOOP-3352) Bump java target version to 1.8

2018-07-25 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/SQOOP-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555831#comment-16555831
 ] 

Hudson commented on SQOOP-3352:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1189 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1189/])
SQOOP-3352: Bump java target version to 1.8 (vasas: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=eefb7a0f3e28956fc51346b91f8a9337c5be9aca])
* (edit) src/docs/man/sqoop.txt
* (edit) build.gradle
* (edit) README.txt
* (edit) build.xml
* (edit) COMPILING.txt
* (edit) gradle.properties


> Bump java target version to 1.8
> ---
>
> Key: SQOOP-3352
> URL: https://issues.apache.org/jira/browse/SQOOP-3352
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Assignee: Boglarka Egyed
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3352.patch, SQOOP-3352.patch, SQOOP-3352.patch
>
>
> We should move to Java 8 as a minimum requirement.
> Java 7 is EOL'ed for more than 3 years now: 
> [http://www.oracle.com/technetwork/java/eol-135779.html]
> Many Apache projects are adopting Java 8 as a minimum requirement, for 
> instance:
>  * Hadoop 3: HADOOP-11858
>  * Hbase 2: HBASE-15624
>  * Flume 1.8: FLUME-2945
> This change affects the Ant and the Gradle build too.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3350) Fix tests which use warehouse-dir as target-dir

2018-07-25 Thread Szabolcs Vasas (JIRA) 


 [ 
https://issues.apache.org/jira/browse/SQOOP-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3350:
--
Attachment: SQOOP-3350.patch

> Fix tests which use warehouse-dir as target-dir
> ---
>
> Key: SQOOP-3350
> URL: https://issues.apache.org/jira/browse/SQOOP-3350
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3350.patch
>
>
> Some Sqoop tests use the value of the 
> org.apache.sqoop.testutil.BaseSqoopTestCase#getWarehouseDir as target-dir:
> {code:java}
> args.add("--target-dir");
> args.add(getWarehouseDir());
> {code}
> This leads to an error when the warehouse directory exists which can happen 
> if a previous test does not clean up properly.
> The issue was found when executing the tests with Gradle since it probably 
> executes the tests in a different order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 68045: Fix tests which use warehouse-dir as target-dir

2018-07-25 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68045/
---

Review request for Sqoop.


Bugs: SQOOP-3350
https://issues.apache.org/jira/browse/SQOOP-3350


Repository: sqoop-trunk


Description
---

See JIRA description


Diffs
-

  src/test/org/apache/sqoop/TestFreeFormQueryImport.java 2df4352a0 
  src/test/org/apache/sqoop/manager/mysql/MySqlColumnEscapeImportTest.java 
734499e58 
  src/test/org/apache/sqoop/manager/oracle/OracleColumnEscapeImportTest.java 
d4146dcbe 
  src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java 
4dde3d62f 
  
src/test/org/apache/sqoop/manager/oracle/OracleSpecialCharacterTableImportTest.java
 453ad8218 
  src/test/org/apache/sqoop/manager/oracle/OracleSplitterTest.java 33b7d7452 


Diff: https://reviews.apache.org/r/68045/diff/1/


Testing
---

Executed unit and third party tests.
Having SQOOP-3353 committed all tests should pass with Gradle too.


Thanks,

Szabolcs Vasas

Review Request 68038: Sqoop should not check incremental constraints for HBase imports

2018-07-25 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68038/
---

Review request for Sqoop.


Bugs: SQOOP-3353
https://issues.apache.org/jira/browse/SQOOP-3353


Repository: sqoop-trunk


Description
---

See the corresponding JIRA for the description of the bug.


Diffs
-

  src/java/org/apache/sqoop/tool/ImportTool.java ccded652c 
  src/test/org/apache/sqoop/TestIncrementalImport.java 1ab98021a 
  src/test/org/apache/sqoop/tool/TestImportTool.java 3bdc5c654 


Diff: https://reviews.apache.org/r/68038/diff/1/


Testing
---

Executed test and third party tests using ant.
Gradle test is still unstable because of 
https://issues.apache.org/jira/browse/SQOOP-3350


Thanks,

Szabolcs Vasas

[jira] [Updated] (SQOOP-3353) Sqoop should not check incremental constraints for HBase imports

2018-07-25 Thread Szabolcs Vasas (JIRA) 


 [ 
https://issues.apache.org/jira/browse/SQOOP-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas updated SQOOP-3353:
--
Attachment: SQOOP-3353.patch

> Sqoop should not check incremental constraints for HBase imports
> 
>
> Key: SQOOP-3353
> URL: https://issues.apache.org/jira/browse/SQOOP-3353
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
> Attachments: SQOOP-3353.patch
>
>
> ImportTool#initIncrementalConstraints method is invoked for every import in 
> Sqoop and it can throw the following error even for HBase imports:
> {code:java}
> --merge-key or --append is required when using --incremental lastmodified and 
> the output directory exists.{code}
> The task is to fix the validation not to throw an exception when importing 
> into an HBase table since in that case it does not matter if the table 
> directory exists on HDFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Fero Szabo via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206442
---


Ship it!




Ship It!

- Fero Szabo


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

[jira] [Commented] (SQOOP-3352) Bump java target version to 1.8

2018-07-25 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/SQOOP-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555804#comment-16555804
 ] 

ASF subversion and git services commented on SQOOP-3352:


Commit eefb7a0f3e28956fc51346b91f8a9337c5be9aca in sqoop's branch 
refs/heads/trunk from [~vasas]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=eefb7a0 ]

SQOOP-3352: Bump java target version to 1.8

(Boglarka Egyed via Szabolcs Vasas)


> Bump java target version to 1.8
> ---
>
> Key: SQOOP-3352
> URL: https://issues.apache.org/jira/browse/SQOOP-3352
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Assignee: Boglarka Egyed
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3352.patch, SQOOP-3352.patch, SQOOP-3352.patch
>
>
> We should move to Java 8 as a minimum requirement.
> Java 7 is EOL'ed for more than 3 years now: 
> [http://www.oracle.com/technetwork/java/eol-135779.html]
> Many Apache projects are adopting Java 8 as a minimum requirement, for 
> instance:
>  * Hadoop 3: HADOOP-11858
>  * Hbase 2: HBASE-15624
>  * Flume 1.8: FLUME-2945
> This change affects the Ant and the Gradle build too.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/
---

(Updated July 25, 2018, 9:43 a.m.)


Review request for Sqoop, Fero Szabo and Szabolcs Vasas.


Changes
---

Bumped required Ant version in document


Bugs: SQOOP-3352
https://issues.apache.org/jira/browse/SQOOP-3352


Repository: sqoop-trunk


Description
---

* Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
* Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
* Updated documentation


Diffs (updated)
-

  COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
  README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
  build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
  build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
  gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
  src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 


Diff: https://reviews.apache.org/r/68032/diff/3/

Changes: https://reviews.apache.org/r/68032/diff/2-3/


Testing
---

Successfully ran with ant:
ant
ant clean compile
ant clean package
ant clean test
ant cobertura -Dcobertura.home=/path/to/cobertura
ant clean test -Dthirdparty= ...
ant checkstyle
ant mvn-install
ant docs
ant eclipse

Succesfully ran with gradle:
./gradlew clean
./gradlew package
./gradlew test
./gradlew jacocoTestReport
./gradlew -Dsqoop.thirdparty.lib.dir= 
thirdPartyTest
./gradlew checkStyleMain
./gradlew compileJava
./gradlew publishToMavenLocal


Thanks,

Boglarka Egyed

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Szabolcs Vasas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206441
---


Ship it!




Ship It!

- Szabolcs Vasas


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

[jira] [Updated] (SQOOP-3352) Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed (JIRA) 


 [ 
https://issues.apache.org/jira/browse/SQOOP-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boglarka Egyed updated SQOOP-3352:
--
Attachment: SQOOP-3352.patch

> Bump java target version to 1.8
> ---
>
> Key: SQOOP-3352
> URL: https://issues.apache.org/jira/browse/SQOOP-3352
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Assignee: Boglarka Egyed
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3352.patch, SQOOP-3352.patch, SQOOP-3352.patch
>
>
> We should move to Java 8 as a minimum requirement.
> Java 7 is EOL'ed for more than 3 years now: 
> [http://www.oracle.com/technetwork/java/eol-135779.html]
> Many Apache projects are adopting Java 8 as a minimum requirement, for 
> instance:
>  * Hadoop 3: HADOOP-11858
>  * Hbase 2: HBASE-15624
>  * Flume 1.8: FLUME-2945
> This change affects the Ant and the Gradle build too.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68032: SQOOP-3352: Bump java target version to 1.8

2018-07-25 Thread Boglarka Egyed 


> On July 24, 2018, 4:12 p.m., Szabolcs Vasas wrote:
> > COMPILING.txt
> > Line 30 (original), 30 (patched)
> > 
> >
> > I have just realized that Ant 1.7.1 probably does not support Java 8, 
> > so this number should be bumped too.

You are totally right, I have corrected it. Thanks!


- Boglarka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68032/#review206392
---


On July 25, 2018, 9:43 a.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68032/
> ---
> 
> (Updated July 25, 2018, 9:43 a.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3352
> https://issues.apache.org/jira/browse/SQOOP-3352
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Bumped targetJavaVersion and sourceJavaVersion to 1.8 in build.xml
> * Bumped javaSourceCompatibilityVersion to 1.8 in gradle.properties
> * Updated documentation
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   README.txt b8f0a7a2c7d760c72f9811435b36c23cde354b15 
>   build.gradle 8b8b55575ab05187eec0b8ca6b6da17e0a318d72 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   gradle.properties a571e6cb26ddd3d687f3b3a2a69615a5e1fc71d5 
>   src/docs/man/sqoop.txt 7977e13091af184f6b1d10028aa827e033c9452a 
> 
> 
> Diff: https://reviews.apache.org/r/68032/diff/3/
> 
> 
> Testing
> ---
> 
> Successfully ran with ant:
> ant
> ant clean compile
> ant clean package
> ant clean test
> ant cobertura -Dcobertura.home=/path/to/cobertura
> ant clean test -Dthirdparty= ...
> ant checkstyle
> ant mvn-install
> ant docs
> ant eclipse
> 
> Succesfully ran with gradle:
> ./gradlew clean
> ./gradlew package
> ./gradlew test
> ./gradlew jacocoTestReport
> ./gradlew -Dsqoop.thirdparty.lib.dir= 
> thirdPartyTest
> ./gradlew checkStyleMain
> ./gradlew compileJava
> ./gradlew publishToMavenLocal
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

[jira] [Created] (SQOOP-3353) Sqoop should not check incremental constraints for HBase imports

2018-07-25 Thread Szabolcs Vasas (JIRA) 
Szabolcs Vasas created SQOOP-3353:
-

 Summary: Sqoop should not check incremental constraints for HBase 
imports
 Key: SQOOP-3353
 URL: https://issues.apache.org/jira/browse/SQOOP-3353
 Project: Sqoop
  Issue Type: Bug
Affects Versions: 1.4.7
Reporter: Szabolcs Vasas


ImportTool#initIncrementalConstraints method is invoked for every import in 
Sqoop and it can throw the following error even for HBase imports:
{code:java}
--merge-key or --append is required when using --incremental lastmodified and 
the output directory exists.{code}

The task is to fix the validation not to throw an exception when importing into 
an HBase table since in that case it does not matter if the table directory 
exists on HDFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

***UNCHECKED*** [jira] [Assigned] (SQOOP-3353) Sqoop should not check incremental constraints for HBase imports

2018-07-25 Thread Szabolcs Vasas (JIRA) 


 [ 
https://issues.apache.org/jira/browse/SQOOP-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3353:
-

Assignee: Szabolcs Vasas

> Sqoop should not check incremental constraints for HBase imports
> 
>
> Key: SQOOP-3353
> URL: https://issues.apache.org/jira/browse/SQOOP-3353
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Szabolcs Vasas
>Assignee: Szabolcs Vasas
>Priority: Major
>
> ImportTool#initIncrementalConstraints method is invoked for every import in 
> Sqoop and it can throw the following error even for HBase imports:
> {code:java}
> --merge-key or --append is required when using --incremental lastmodified and 
> the output directory exists.{code}
> The task is to fix the validation not to throw an exception when importing 
> into an HBase table since in that case it does not matter if the table 
> directory exists on HDFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)