Re: Review Request 68278: Add LOG message for git hash

[Nguyen Truong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

(Updated Aug. 9, 2018, 8 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs (updated)
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/3/

Changes: https://reviews.apache.org/r/68278/diff/2-3/


Testing
---


Thanks,

Nguyen Truong

Re: Review Request 68278: Add LOG message for git hash

[Nguyen Truong]

> On Aug. 9, 2018, 2:02 p.m., Szabolcs Vasas wrote:
> > src/java/org/apache/sqoop/Sqoop.java
> > Lines 95 (patched)
> > 
> >
> > I have just realized that VERSION and GIT_HASH are static final members 
> > of SqoopVersion so the best practice is to access them via class reference:
> > SqoopVersion.VERSION
> > SqoopVersion.GIT_HASH

Hi Szabolcs,

Yes, you're right. I will fix it. Thank you for the suggestion.

Best,
Nguyen


- Nguyen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207030
---


On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

[jira] [Commented] (SQOOP-3357) Change MainframeImportTool to refer to MainframeManager class directly

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575016#comment-16575016
 ] 

Hudson commented on SQOOP-3357:
---

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1193 (See 
[https://builds.apache.org/job/Sqoop-hadoop200/1193/])
SQOOP-3357: Change MainframeImportTool to refer to MainframeManager (vasas: 
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=c3d916ab20ca02c9d6b85bb51d6c31eb31aaff88])
* (edit) src/java/org/apache/sqoop/tool/MainframeImportTool.java
* (edit) src/test/org/apache/sqoop/manager/TestMainframeManager.java


> Change MainframeImportTool to refer to MainframeManager class directly
> --
>
> Key: SQOOP-3357
> URL: https://issues.apache.org/jira/browse/SQOOP-3357
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3357.patch
>
>
> Currently MainframeImportTool refers to the MainframeManager with a string 
> which can create a problem in refactoring. It would be beneficial to change 
> the string to a MainframeManager class reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SQOOP-3357) Change MainframeImportTool to refer to MainframeManager class directly

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574987#comment-16574987
 ] 

ASF subversion and git services commented on SQOOP-3357:


Commit c3d916ab20ca02c9d6b85bb51d6c31eb31aaff88 in sqoop's branch 
refs/heads/trunk from [~vasas]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=c3d916a ]

SQOOP-3357: Change MainframeImportTool to refer to MainframeManager class 
directly

(Nguyen Truong via Szabolcs Vasas)


> Change MainframeImportTool to refer to MainframeManager class directly
> --
>
> Key: SQOOP-3357
> URL: https://issues.apache.org/jira/browse/SQOOP-3357
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3357.patch
>
>
> Currently MainframeImportTool refers to the MainframeManager with a string 
> which can create a problem in refactoring. It would be beneficial to change 
> the string to a MainframeManager class reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68254: Change MainframeImportTool to refer to MainframeManager class directly

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207038
---


Ship it!




Ship It!

- Szabolcs Vasas


On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> ---
> 
> (Updated Aug. 7, 2018, 9:33 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> MainframeImportTool used to refer to the MainframeManager with a string. I 
> changed the string to a MainframeManager class reference.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
>   src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88 
> 
> 
> Diff: https://reviews.apache.org/r/68254/diff/1/
> 
> 
> Testing
> ---
> 
> I ran ant test and did not add any more test case because my change was 
> already covered.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68024: SQOOP-3348: Add hadoop-aws dependency and S3 credential generator logic for tests

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68024/#review207036
---




COMPILING.txt
Lines 311 (patched)


Based on 
org.apache.sqoop.testutil.DefaultS3CredentialGenerator#generateS3Credentials I 
think it only works with " ".



COMPILING.txt
Lines 316 (patched)


Can you please add the test command for gradle as well?



src/test/org/apache/sqoop/s3/TestS3AvroImport.java
Lines 54 (patched)


When the generator command is not specified this method throws an exception.
This does not cause an issue in case of Ant, the tests will be green but it 
the Gradle build will fail. Can you please fix it?



src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java
Lines 59 (patched)


The constructor

org.apache.hadoop.io.SequenceFile.Reader#Reader(org.apache.hadoop.fs.FileSystem,
 org.apache.hadoop.fs.Path, org.apache.hadoop.conf.Configuration) is deprecated 
so please use 
org.apache.hadoop.io.SequenceFile.Reader#Reader(org.apache.hadoop.conf.Configuration,
 org.apache.hadoop.io.SequenceFile.Reader.Option...) instead.


- Szabolcs Vasas


On July 23, 2018, 4:07 p.m., Boglarka Egyed wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68024/
> ---
> 
> (Updated July 23, 2018, 4:07 p.m.)
> 
> 
> Review request for Sqoop, Fero Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3348
> https://issues.apache.org/jira/browse/SQOOP-3348
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> * Added hadoop-aws dependency
> * Added an Amazon S3 credential generator logic to enable automated testing
> * Added s3.bucket.url and s3.generator.command properties for testing purposes
> * Added first S3 import test cases for text, Avro and Sequence file formats
> * Extended COMPILING.txt with Amazon S3 test running guide
> 
> 
> Diffs
> -
> 
>   COMPILING.txt 9abf0b211b24de65b53351ece170b09e4851938b 
>   build.xml 0ae729bce035f6f1afef78702a3d888bb6c5a9ff 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   src/test/org/apache/sqoop/s3/TestS3AvroImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3SequenceFileImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/s3/TestS3TextImport.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/DefaultS3CredentialGenerator.java 
> PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/S3CredentialGenerator.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/S3TestUtils.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/SequenceFileTestUtils.java PRE-CREATION 
>   src/test/org/apache/sqoop/testutil/TextFileTestUtils.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/68024/diff/1/
> 
> 
> Testing
> ---
> 
> Added new S3 import test cases with text, Avro and Sequence file formats.
> 
> ant clean test -Ds3.bucket.url= 
> -Ds3.generator.command=
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>

Re: Review Request 68254: Change MainframeImportTool to refer to MainframeManager class directly

[Boglarka Egyed]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207035
---


Ship it!




Thanks for this fix Nguyen!

- Boglarka Egyed


On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> ---
> 
> (Updated Aug. 7, 2018, 9:33 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> MainframeImportTool used to refer to the MainframeManager with a string. I 
> changed the string to a MainframeManager class reference.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
>   src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88 
> 
> 
> Diff: https://reviews.apache.org/r/68254/diff/1/
> 
> 
> Testing
> ---
> 
> I ran ant test and did not add any more test case because my change was 
> already covered.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68278: Add LOG message for git hash

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207030
---



Hi Nguyen,

Thank you for submitting this patch, it is a nice little improvement for 
debugging.
I have left a minor comment, please take a look.

Szabolcs


src/java/org/apache/sqoop/Sqoop.java
Lines 95 (patched)


I have just realized that VERSION and GIT_HASH are static final members of 
SqoopVersion so the best practice is to access them via class reference:
SqoopVersion.VERSION
SqoopVersion.GIT_HASH


- Szabolcs Vasas


On Aug. 9, 2018, 1:53 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

[Szabolcs Vasas]

> On Aug. 9, 2018, 12:39 p.m., Denes Arvay wrote:
> > build.gradle
> > Lines 83 (patched)
> > 
> >
> > Guava is missing from the ant/ivy version, doesn't it cause any issues, 
> > doesn't it result in different guava version in ant/ivy?

This line just enforces Guava 14.0.1 in Gradle, Ant keeps 14.0.1 by default so 
it does not need any enforcement (and I haven't really found any nice way to do 
it in Ant).


- Szabolcs


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207021
---


On Aug. 9, 2018, 11:49 a.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 11:49 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Re: Review Request 68278: Add LOG message for git hash

[Nguyen Truong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

(Updated Aug. 9, 2018, 1:53 p.m.)


Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs (updated)
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/2/

Changes: https://reviews.apache.org/r/68278/diff/1-2/


Testing
---


Thanks,

Nguyen Truong

Re: Review Request 68278: Add LOG message for git hash

[Fero Szabo via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/#review207025
---




src/java/org/apache/sqoop/Sqoop.java
Lines 95 (patched)


You could extract SqoopVersion into a local variable and reuse it.


- Fero Szabo


On Aug. 9, 2018, 1:32 p.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68278/
> ---
> 
> (Updated Aug. 9, 2018, 1:32 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3359
> https://issues.apache.org/jira/browse/SQOOP-3359
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> I added a log message for the git hash of the running Sqoop in the debug 
> level.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/Sqoop.java 
> 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 
> 
> 
> Diff: https://reviews.apache.org/r/68278/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Re: Review Request 68254: Change MainframeImportTool to refer to MainframeManager class directly

[Fero Szabo via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68254/#review207024
---


Ship it!




Ship It!

- Fero Szabo


On Aug. 7, 2018, 9:33 a.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68254/
> ---
> 
> (Updated Aug. 7, 2018, 9:33 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3357
> https://issues.apache.org/jira/browse/SQOOP-3357
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> MainframeImportTool used to refer to the MainframeManager with a string. I 
> changed the string to a MainframeManager class reference.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d 
>   src/test/org/apache/sqoop/manager/TestMainframeManager.java 97e48e88 
> 
> 
> Diff: https://reviews.apache.org/r/68254/diff/1/
> 
> 
> Testing
> ---
> 
> I ran ant test and did not add any more test case because my change was 
> already covered.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

Review Request 68278: Add LOG message for git hash

[Nguyen Truong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68278/
---

Review request for Sqoop.


Bugs: SQOOP-3359
https://issues.apache.org/jira/browse/SQOOP-3359


Repository: sqoop-trunk


Description
---

I added a log message for the git hash of the running Sqoop in the debug level.


Diffs
-

  src/java/org/apache/sqoop/Sqoop.java 08ff82ca22cb2fcdffeb29661951d091a70c5bb9 


Diff: https://reviews.apache.org/r/68278/diff/1/


Testing
---


Thanks,

Nguyen Truong

Re: Review Request 68277: Fix hive-exec dependency issues in Gradle

[Denes Arvay via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/#review207021
---




build.gradle
Lines 83 (patched)


Guava is missing from the ant/ivy version, doesn't it cause any issues, 
doesn't it result in different guava version in ant/ivy?


- Denes Arvay


On Aug. 9, 2018, 1:49 p.m., Szabolcs Vasas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68277/
> ---
> 
> (Updated Aug. 9, 2018, 1:49 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3360
> https://issues.apache.org/jira/browse/SQOOP-3360
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.
> 
> 
> Diffs
> -
> 
>   build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
>   gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
>   ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
>   ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 
> 
> 
> Diff: https://reviews.apache.org/r/68277/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit and third party tests with both Ant and Gradle.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>

Review Request 68277: Fix hive-exec dependency issues in Gradle

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68277/
---

Review request for Sqoop.


Bugs: SQOOP-3360
https://issues.apache.org/jira/browse/SQOOP-3360


Repository: sqoop-trunk


Description
---

It turned out during making SQOOP-3345 work with Gradle that there are issues 
with the dependency handling which cause problems with Gradle. Root cause of 
the problem seems to be the hive-exec dependency which also contains its own 
dependencies pulling in incorrect libs and versions runtime. This has to be 
cleaned up via better dependency management.


Diffs
-

  build.gradle e2c4479d35cbf97c51de0d6a9c5192284d934dc9 
  gradle.properties 2d6c259ff267b74410247d574af28c35d62a72e1 
  ivy.xml 796ef70ae38f254169587ce7d3401646f4a80a3a 
  ivy/libraries.properties d679b125f0e2a4f3c3c25c83a2640c3e713e6079 


Diff: https://reviews.apache.org/r/68277/diff/1/


Testing
---

Ran unit and third party tests with both Ant and Gradle.


Thanks,

Szabolcs Vasas

[jira] [Resolved] (SQOOP-3351) Add hadoop-aws dependency in Gradle

[Boglarka Egyed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boglarka Egyed resolved SQOOP-3351.
---
   Resolution: Duplicate
Fix Version/s: no-release

This is included in SQOOP-3345.

> Add hadoop-aws dependency in Gradle
> ---
>
> Key: SQOOP-3351
> URL: https://issues.apache.org/jira/browse/SQOOP-3351
> Project: Sqoop
>  Issue Type: Sub-task
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Assignee: Boglarka Egyed
>Priority: Major
> Fix For: no-release
>
>
> S3 use cases should work with Gradle too that has been added in SQOOP-3052.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3360) Fix hive-exec dependency issues in Gradle

[Boglarka Egyed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boglarka Egyed updated SQOOP-3360:
--
Summary: Fix hive-exec dependency issues in Gradle  (was: Fix dependency 
issues in Gradle)

> Fix hive-exec dependency issues in Gradle
> -
>
> Key: SQOOP-3360
> URL: https://issues.apache.org/jira/browse/SQOOP-3360
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Priority: Major
>
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SQOOP-3360) Fix hive-exec dependency issues in Gradle

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3360:
-

Assignee: Szabolcs Vasas

> Fix hive-exec dependency issues in Gradle
> -
>
> Key: SQOOP-3360
> URL: https://issues.apache.org/jira/browse/SQOOP-3360
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Assignee: Szabolcs Vasas
>Priority: Major
>
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SQOOP-3360) Fix dependency issues in Gradle

[Boglarka Egyed (JIRA)]

Boglarka Egyed created SQOOP-3360:
-

 Summary: Fix dependency issues in Gradle
 Key: SQOOP-3360
 URL: https://issues.apache.org/jira/browse/SQOOP-3360
 Project: Sqoop
  Issue Type: Bug
Reporter: Boglarka Egyed


It turned out during making SQOOP-3345 work with Gradle that there are issues 
with the dependency handling which cause problems with Gradle. Root cause of 
the problem seems to be the hive-exec dependency which also contains its own 
dependencies pulling in incorrect libs and versions runtime. This has to be 
cleaned up via better dependency management.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3360) Fix dependency issues in Gradle

[Boglarka Egyed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Boglarka Egyed updated SQOOP-3360:
--
Affects Version/s: 1.4.7

> Fix dependency issues in Gradle
> ---
>
> Key: SQOOP-3360
> URL: https://issues.apache.org/jira/browse/SQOOP-3360
> Project: Sqoop
>  Issue Type: Bug
>Affects Versions: 1.4.7
>Reporter: Boglarka Egyed
>Priority: Major
>
> It turned out during making SQOOP-3345 work with Gradle that there are issues 
> with the dependency handling which cause problems with Gradle. Root cause of 
> the problem seems to be the hive-exec dependency which also contains its own 
> dependencies pulling in incorrect libs and versions runtime. This has to be 
> cleaned up via better dependency management.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SQOOP-2331) Snappy Compression Support in Sqoop-HCatalog

[Fero Szabo (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574718#comment-16574718
 ] 

Fero Szabo edited comment on SQOOP-2331 at 8/9/18 11:36 AM:


Hi [~standon],

Sure can do. I've compile errors, though.
{noformat}
    [javac] 
/Users/ferencszabo/workspace/sqoop/src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java:85:
 error: package com.cloudera.sqoop.io does not exist{noformat}
This package got changed to _org.apache.sqoop.io_, so you'll have to modify the 
import to the new package.

Also, can you please update the review on ReviewBoard please (upload the latest 
diff)? We can continue the code related discussion there.

Thanks,

Fero


was (Author: fero):
Hi [~standon],

Sure can do. I've compile errors, though.
{noformat}
    [javac] 
/Users/ferencszabo/workspace/sqoop/src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java:85:
 error: package com.cloudera.sqoop.io does not exist{noformat}
This package got change to _org.apache.sqoop.io_, so you'll have to modify the 
import to the new package.


Also, can you please update the review on ReviewBoard please? We can continue 
the code related discussion there.

Thanks,

Fero

> Snappy Compression Support in Sqoop-HCatalog
> 
>
> Key: SQOOP-2331
> URL: https://issues.apache.org/jira/browse/SQOOP-2331
> Project: Sqoop
>  Issue Type: New Feature
>Affects Versions: 1.4.7
>Reporter: Atul Gupta
>Assignee: Shashank
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: SQOOP-2331_0.patch, SQOOP-2331_1.patch, 
> SQOOP-2331_2.patch, SQOOP-2331_2.patch
>
>
> Current Apache Sqoop 1.4.7 does not compress in gzip format with 
>  --compress option while using with --hcatalog-table option. It also does not 
> support option --compression-codec snappy with --hcatalog-table option. it 
> would be nice if we add both the options in the Sqoop future releases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SQOOP-2331) Snappy Compression Support in Sqoop-HCatalog

[Fero Szabo (JIRA)]

[ 
https://issues.apache.org/jira/browse/SQOOP-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574718#comment-16574718
 ] 

Fero Szabo commented on SQOOP-2331:
---

Hi [~standon],

Sure can do. I've compile errors, though.
{noformat}
    [javac] 
/Users/ferencszabo/workspace/sqoop/src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java:85:
 error: package com.cloudera.sqoop.io does not exist{noformat}
This package got change to _org.apache.sqoop.io_, so you'll have to modify the 
import to the new package.


Also, can you please update the review on ReviewBoard please? We can continue 
the code related discussion there.

Thanks,

Fero

> Snappy Compression Support in Sqoop-HCatalog
> 
>
> Key: SQOOP-2331
> URL: https://issues.apache.org/jira/browse/SQOOP-2331
> Project: Sqoop
>  Issue Type: New Feature
>Affects Versions: 1.4.7
>Reporter: Atul Gupta
>Assignee: Shashank
>Priority: Major
> Fix For: 1.5.0
>
> Attachments: SQOOP-2331_0.patch, SQOOP-2331_1.patch, 
> SQOOP-2331_2.patch, SQOOP-2331_2.patch
>
>
> Current Apache Sqoop 1.4.7 does not compress in gzip format with 
>  --compress option while using with --hcatalog-table option. It also does not 
> support option --compression-codec snappy with --hcatalog-table option. it 
> would be nice if we add both the options in the Sqoop future releases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3359) Add LOG message for Git hash

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong updated SQOOP-3359:
-
Summary: Add LOG message for Git hash  (was: Add LOG for Git hash)

> Add LOG message for Git hash
> 
>
> Key: SQOOP-3359
> URL: https://issues.apache.org/jira/browse/SQOOP-3359
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Minor
>
> Besides the version, it would be nice to also know the git hash of the 
> running Sqoop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3359) Add LOG message for git hash

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong updated SQOOP-3359:
-
Summary: Add LOG message for git hash  (was: Add LOG message for Git hash)

> Add LOG message for git hash
> 
>
> Key: SQOOP-3359
> URL: https://issues.apache.org/jira/browse/SQOOP-3359
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Minor
>
> Besides the version, it would be nice to also know the git hash of the 
> running Sqoop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SQOOP-3359) Add LOG for Git hash

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong reassigned SQOOP-3359:


Assignee: Nguyen Truong

> Add LOG for Git hash
> 
>
> Key: SQOOP-3359
> URL: https://issues.apache.org/jira/browse/SQOOP-3359
> Project: Sqoop
>  Issue Type: Improvement
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Minor
>
> Besides the version, it would be nice to also know the git hash of the 
> running Sqoop.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SQOOP-3357) Change MainframeImportTool to refer to MainframeManager class directly

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong reassigned SQOOP-3357:


Assignee: Nguyen Truong

> Change MainframeImportTool to refer to MainframeManager class directly
> --
>
> Key: SQOOP-3357
> URL: https://issues.apache.org/jira/browse/SQOOP-3357
> Project: Sqoop
>  Issue Type: Improvement
>Affects Versions: 1.4.7
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: SQOOP-3357.patch
>
>
> Currently MainframeImportTool refers to the MainframeManager with a string 
> which can create a problem in refactoring. It would be beneficial to change 
> the string to a MainframeManager class reference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)