[jira] [Assigned] (SQOOP-3104) Create test categories instead of test suites and naming conventions

[Szabolcs Vasas (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Szabolcs Vasas reassigned SQOOP-3104:
-

Assignee: Nguyen Truong

> Create test categories instead of test suites and naming conventions
> 
>
> Key: SQOOP-3104
> URL: https://issues.apache.org/jira/browse/SQOOP-3104
> Project: Sqoop
>  Issue Type: Sub-task
>Reporter: Anna Szonyi
>Assignee: Nguyen Truong
>Priority: Major
>
> We are currently unsing test naming conventions to differentiate between 
> ManualTests, Unit tests and 3rd party tests.
> Instead of this, we should use junit4 categories, so it's clear by looking at 
> a test where it fits. This would also remove the reliance on the test class 
> name.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 68316: Debug toString() methods of OraOopOracleDataChunk

[Szabolcs Vasas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/#review207153
---



Hi Nguyen,

Thank you for submitting this patch, this was a nasty little bug...

Please see my comments below.


src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java
Line 161 (original), 161 (patched)


It is true that your changes are covered with third party test cases but I 
think it would be great if you could add a few unit test cases to this method.
In your tests you could initialize a OraOopDBInputSplit object with a few 
OraOopOracleDataChunk object and check if the getDebugDetails works as expected.



src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java
Lines 24 (patched)


This seems to be an unnecessary whitespace change, please remove it.



src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java
Lines 94 (patched)


I think we should log the id field as well which is inherited from the 
superclass.



src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java
Lines 96 (patched)


nit: since you already have a StringBuilder object you could write:
result.append("\n\t\t oracleDataObjectId = ").append(oracleDataObjectId);
to avoid extra String object creation.



src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java
Lines 78 (patched)


I think we should log the id field as well which is inherited from the 
superclass.


- Szabolcs Vasas


On Aug. 13, 2018, 9:14 a.m., Nguyen Truong wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68316/
> ---
> 
> (Updated Aug. 13, 2018, 9:14 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3362
> https://issues.apache.org/jira/browse/SQOOP-3362
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> The method was currently returning the hash of data chunk object. I 
> implemented the toString() methods inside the subclasses of 
> OraOopOracleDataChunk.
> 
> 
> Diffs
> -
> 
>   src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java 
> eb67fd2e4 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 
> 20b39eea0 
>   
> src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java 
> 59889b82b 
> 
> 
> Diff: https://reviews.apache.org/r/68316/diff/2/
> 
> 
> Testing
> ---
> 
> No test case is added because the change has already covered.
> 
> 
> Thanks,
> 
> Nguyen Truong
> 
>

[jira] [Created] (SQOOP-3363) Test incremental import with S3

[Boglarka Egyed (JIRA)]

Boglarka Egyed created SQOOP-3363:
-

 Summary: Test incremental import with S3
 Key: SQOOP-3363
 URL: https://issues.apache.org/jira/browse/SQOOP-3363
 Project: Sqoop
  Issue Type: Sub-task
Affects Versions: 1.4.7
Reporter: Boglarka Egyed
Assignee: Boglarka Egyed






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 62492: SQOOP-3224: Mainframe FTP transfer should have an option to use binary mode for transfer

[Chris Teoh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
---

(Updated Aug. 13, 2018, 8:52 p.m.)


Review request for Sqoop.


Changes
---

Updated based on feedback.


Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224


Repository: sqoop-trunk


Description
---

Added --as-binaryfile and --buffersize to support FTP transfer mode switching.


Diffs (updated)
-

  build.xml 084823cf 
  src/docs/user/import-mainframe.txt abeb7cde 
  src/java/org/apache/sqoop/SqoopOptions.java f97dbfdf 
  src/java/org/apache/sqoop/mapreduce/ByteKeyOutputFormat.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 349ca8d8 
  src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 
  
src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java
 PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java 
ea54b07f 
  
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java
 PRE-CREATION 
  
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java 
PRE-CREATION 
  
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java
 1f78384b 
  
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java 
0b7b5b85 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 
8ef30d38 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9dcbdd59 
  src/java/org/apache/sqoop/tool/ImportTool.java 478f1748 
  src/java/org/apache/sqoop/tool/MainframeImportTool.java cdd9d6d0 
  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb 
  src/test/org/apache/sqoop/manager/mainframe/MainframeManagerImportTest.java 
041dfb78 
  src/test/org/apache/sqoop/manager/mainframe/MainframeTestUtil.java f28ff36c 
  
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java
 PRE-CREATION 
  
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java
 3547294f 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetPath.java 
9b277b2a 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeImportJob.java 
be62efd0 
  src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34 
  src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 


Diff: https://reviews.apache.org/r/62492/diff/20/

Changes: https://reviews.apache.org/r/62492/diff/19-20/


Testing
---

Unit tests.

Functional testing on mainframe.


Thanks,

Chris Teoh

Re: Review Request 68316: Debug toString() methods of OraOopOracleDataChunk

[Nguyen Truong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/
---

(Updated Aug. 13, 2018, 9:14 a.m.)


Review request for Sqoop.


Bugs: SQOOP-3362
https://issues.apache.org/jira/browse/SQOOP-3362


Repository: sqoop-trunk


Description
---

The method was currently returning the hash of data chunk object. I implemented 
the toString() methods inside the subclasses of OraOopOracleDataChunk.


Diffs (updated)
-

  src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 948bdbb73 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java eb67fd2e4 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 
20b39eea0 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java 
59889b82b 


Diff: https://reviews.apache.org/r/68316/diff/2/

Changes: https://reviews.apache.org/r/68316/diff/1-2/


Testing
---

No test case is added because the change has already covered.


Thanks,

Nguyen Truong

Review Request 68316: Debug toString() methods of OraOopOracleDataChunk

[Nguyen Truong]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68316/
---

Review request for Sqoop.


Bugs: SQOOP-3362
https://issues.apache.org/jira/browse/SQOOP-3362


Repository: sqoop-trunk


Description
---

The method was currently returning the hash of data chunk object. I implemented 
the toString() methods inside the subclasses of OraOopOracleDataChunk.


Diffs
-

  src/java/org/apache/sqoop/manager/oracle/OraOopDBInputSplit.java 
948bdbb73c7455dc3b1c2dddb6fa55fb74eead97 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunk.java 
eb67fd2e425cdf20f822eb506a87e3b1b46de3b7 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkExtent.java 
20b39eea0c553e50d79502bd601b736feee793e6 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleDataChunkPartition.java 
59889b82b4d166098f3de40cb1e95a39bcc74bd7 


Diff: https://reviews.apache.org/r/68316/diff/1/


Testing
---

No test case is added because the change has already covered.


Thanks,

Nguyen Truong

[jira] [Updated] (SQOOP-3362) Debug toString() methods of OraOopOracleDataChunk

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong updated SQOOP-3362:
-
Description: The method is currently returning the hash of data chunk 
object. It would be nice to show the information of the class's variables.

> Debug toString() methods of OraOopOracleDataChunk
> -
>
> Key: SQOOP-3362
> URL: https://issues.apache.org/jira/browse/SQOOP-3362
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Major
>
> The method is currently returning the hash of data chunk object. It would be 
> nice to show the information of the class's variables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SQOOP-3362) Debug toString() methods of OraOopOracleDataChunk

[Nguyen Truong (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SQOOP-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nguyen Truong updated SQOOP-3362:
-
Summary: Debug toString() methods of OraOopOracleDataChunk  (was: Debug 
toString methods of OraOopOracleDataChunk)

> Debug toString() methods of OraOopOracleDataChunk
> -
>
> Key: SQOOP-3362
> URL: https://issues.apache.org/jira/browse/SQOOP-3362
> Project: Sqoop
>  Issue Type: Bug
>Reporter: Nguyen Truong
>Assignee: Nguyen Truong
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SQOOP-3362) Debug toString methods of OraOopOracleDataChunk

[Nguyen Truong (JIRA)]

Nguyen Truong created SQOOP-3362:


 Summary: Debug toString methods of OraOopOracleDataChunk
 Key: SQOOP-3362
 URL: https://issues.apache.org/jira/browse/SQOOP-3362
 Project: Sqoop
  Issue Type: Bug
Reporter: Nguyen Truong
Assignee: Nguyen Truong






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)