[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[
https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070744#comment-15070744
]
Jarek Jarcec Cecho commented on SQOOP-2726:
---
Thanks for chiming in [~colin_mjj]. Agreed that we're expecting the SQL Mode
set to {{ANSI_QUOTES}} for Repository, but I believe that we're not expecting
it for the JDBC Connector. Whereas user can use it, they can also use the
[Dialect
configuration|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/SqlDialect.java]
which I'm assuming will be a bit preferred. As the providers are more used for
the JDBC Connector testing then for the repository, it seems natural to test
without it.
> Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
>
>
> Key: SQOOP-2726
> URL: https://issues.apache.org/jira/browse/SQOOP-2726
> Project: Sqoop
> Issue Type: Bug
>Affects Versions: 1.99.6
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2726.patch
>
>
> Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This
> should be removed to better reflect real world usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070519#comment-15070519 ] Colin Ma commented on SQOOP-2726: - [~abrahamfine], [~jarcec], I just notice this ticket, to use Mysql for Sqoop's repository, it must be sql_mode='ANSI_QUOTES'. Setting it in MySQLProvider will be convenient for integrattion test and also reflect the same usage as the real world for Sqoop. > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Affects Versions: 1.99.6 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057671#comment-15057671 ] Hudson commented on SQOOP-2726: --- SUCCESS: Integrated in Sqoop2 #969 (See [https://builds.apache.org/job/Sqoop2/969/]) SQOOP-2726: Sqoop2: Integration Tests: Do not use ansi_quotes mode for (jarcec: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git=commit=d35efd3c3a229f01afb9ac5982c8bed65c977e18]) * common-test/src/main/java/org/apache/sqoop/common/test/db/MySQLProvider.java > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Affects Versions: 1.99.6 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057593#comment-15057593 ] Jarek Jarcec Cecho commented on SQOOP-2726: --- +1 > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Affects Versions: 1.99.6 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057596#comment-15057596 ] ASF subversion and git services commented on SQOOP-2726: Commit d35efd3c3a229f01afb9ac5982c8bed65c977e18 in sqoop's branch refs/heads/sqoop2 from [~jarcec] [ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=d35efd3 ] SQOOP-2726: Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL (Abraham Fine via Jarek Jarcec Cecho) > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Affects Versions: 1.99.6 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[
https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057248#comment-15057248
]
Sqoop QA bot commented on SQOOP-2726:
-
Testing file
[SQOOP-2726.patch|https://issues.apache.org/jira/secure/attachment/12777641/SQOOP-2726.patch]
against branch sqoop2 took 1:05:00.153872.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1638 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1997/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1997/artifact/patch-process/findbugs_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 145 tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1997/console].
This message is automatically generated.
> Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
>
>
> Key: SQOOP-2726
> URL: https://issues.apache.org/jira/browse/SQOOP-2726
> Project: Sqoop
> Issue Type: Bug
>Affects Versions: 1.99.6
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2726.patch
>
>
> Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This
> should be removed to better reflect real world usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050605#comment-15050605 ] Jarek Jarcec Cecho commented on SQOOP-2726: --- Looks good to me, I'll commit it once SQOOP-2727 get's in. > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Affects Versions: 1.99.6 >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[
https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048414#comment-15048414
]
Jarek Jarcec Cecho commented on SQOOP-2726:
---
Setting {{fixVersion}} to allow precommit hook to run. Please do make sure that
either {{affectVersion}} or {{fixVersion}} is filled [~abrahamfine], otherwise
the precommit hook will refuse to run (and spam JIRAs not targeting the
specific release branch on which it won't work).
> Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
>
>
> Key: SQOOP-2726
> URL: https://issues.apache.org/jira/browse/SQOOP-2726
> Project: Sqoop
> Issue Type: Bug
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2726.patch
>
>
> Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This
> should be removed to better reflect real world usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[
https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048530#comment-15048530
]
Sqoop QA bot commented on SQOOP-2726:
-
Testing file
[SQOOP-2726.patch|https://issues.apache.org/jira/secure/attachment/12776417/SQOOP-2726.patch]
against branch sqoop2 took 0:56:16.716841.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1640 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1971/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1971/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1971/artifact/patch-process/test_integration.txt],
executed 75 tests)
* Test {{integration-tests}}
* Test {{org.apache.sqoop.integration.connector.hive.FromRDBMSToKiteHiveTest}}
* Test {{org.apache.sqoop.integration.connector.hdfs.S3Test}}
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1971/console].
This message is automatically generated.
> Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
>
>
> Key: SQOOP-2726
> URL: https://issues.apache.org/jira/browse/SQOOP-2726
> Project: Sqoop
> Issue Type: Bug
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2726.patch
>
>
> Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This
> should be removed to better reflect real world usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[
https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048706#comment-15048706
]
Sqoop QA bot commented on SQOOP-2726:
-
Testing file
[SQOOP-2726.patch|https://issues.apache.org/jira/secure/attachment/12776417/SQOOP-2726.patch]
against branch sqoop2 took 0:46:41.906132.
{color:red}Overall:{color} -1 due to an error(s), see details below:
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:red}ERROR:{color} Some of unit tests failed
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1972/artifact/patch-process/test_unit.txt],
executed 1445 tests)
* Test {{org.apache.sqoop.connector.kafka.TestKafkaLoader}}
{color:green}SUCCESS:{color} Test coverage did not decreased
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1972/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} No new findbugs warnings
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1972/artifact/patch-process/findbugs_report.txt])
{color:red}ERROR:{color} Some of integration tests failed
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1972/artifact/patch-process/test_integration.txt],
executed 132 tests)
* Test {{org.apache.sqoop.integration.connector.kafka.FromRDBMSToKafkaTest}}
* Test {{org.apache.sqoop.connector.kafka.TestKafkaLoader}}
* Test {{org.apache.sqoop.integration.connector.kafka.FromHDFSToKafkaTest}}
* Test
{{org.apache.sqoop.integration.connector.jdbc.generic.IncrementalReadTest}}
* Test {{org.apache.sqoop.integration.connector.jdbc.generic.PartitionerTest}}
* Test
{{org.apache.sqoop.integration.connector.jdbc.generic.FromRDBMSToHDFSTest}}
* Test
{{org.apache.sqoop.integration.connector.jdbc.generic.FromHDFSToRDBMSTest}}
* Test {{integration-tests}}
* Test {{org.apache.sqoop.integration.connector.jdbc.generic.AllTypesTest}}
* Test {{org.apache.sqoop.integration.connector.hdfs.S3Test}}
* Test
{{org.apache.sqoop.integration.connector.jdbc.generic.TableStagedRDBMSTest}}
* Test {{org.apache.sqoop.integration.connector.kite.FromRDBMSToKiteTest}}
* Test {{org.apache.sqoop.integration.connector.hive.FromRDBMSToKiteHiveTest}}
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1972/console].
This message is automatically generated.
> Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
>
>
> Key: SQOOP-2726
> URL: https://issues.apache.org/jira/browse/SQOOP-2726
> Project: Sqoop
> Issue Type: Bug
>Reporter: Abraham Fine
>Assignee: Abraham Fine
> Fix For: 1.99.7
>
> Attachments: SQOOP-2726.patch
>
>
> Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This
> should be removed to better reflect real world usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SQOOP-2726) Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL
[ https://issues.apache.org/jira/browse/SQOOP-2726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049745#comment-15049745 ] Abraham Fine commented on SQOOP-2726: - this is dependent on SQOOP-2725 > Sqoop2: Integration Tests: Do not use ansi_quotes mode for MySQL > > > Key: SQOOP-2726 > URL: https://issues.apache.org/jira/browse/SQOOP-2726 > Project: Sqoop > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 1.99.7 > > Attachments: SQOOP-2726.patch > > > Currently we are using sql_mode='ANSI_QUOTES' in the MySQL provider. This > should be removed to better reflect real world usage. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
