[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882143#comment-15882143
]
Hudson commented on SQOOP-3135:
---
FAILURE: Integrated in Jenkins build Sqoop-hadoop23 #1292 (See
[https://builds.apache.org/job/Sqoop-hadoop23/1292/])
SQOOP-3135: Improve error message of Sqoop in case of missing password (maugli:
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=0bb039a002f1b6bc7ccea1370689ecd04830a0cf])
* (edit) src/java/org/apache/sqoop/tool/JobTool.java
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882133#comment-15882133
]
Hudson commented on SQOOP-3135:
---
FAILURE: Integrated in Jenkins build Sqoop-hadoop20 #1091 (See
[https://builds.apache.org/job/Sqoop-hadoop20/1091/])
SQOOP-3135: Improve error message of Sqoop in case of missing password (maugli:
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=0bb039a002f1b6bc7ccea1370689ecd04830a0cf])
* (edit) src/java/org/apache/sqoop/tool/JobTool.java
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882118#comment-15882118
]
Hudson commented on SQOOP-3135:
---
FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1096 (See
[https://builds.apache.org/job/Sqoop-hadoop200/1096/])
SQOOP-3135: Improve error message of Sqoop in case of missing password (maugli:
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=0bb039a002f1b6bc7ccea1370689ecd04830a0cf])
* (edit) src/java/org/apache/sqoop/tool/JobTool.java
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882098#comment-15882098
]
Hudson commented on SQOOP-3135:
---
FAILURE: Integrated in Jenkins build Sqoop-hadoop100 #1055 (See
[https://builds.apache.org/job/Sqoop-hadoop100/1055/])
SQOOP-3135: Improve error message of Sqoop in case of missing password (maugli:
[https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=0bb039a002f1b6bc7ccea1370689ecd04830a0cf])
* (edit) src/java/org/apache/sqoop/tool/JobTool.java
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882086#comment-15882086
]
Attila Szabo commented on SQOOP-3135:
-
Hey [~ericlin],
Many thanks for your contribution!
[~maugli]
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882084#comment-15882084
]
ASF subversion and git services commented on SQOOP-3135:
Commit 0bb039a002f1b6bc7ccea1370689ecd04830a0cf in sqoop's branch
refs/heads/trunk from [~maugli]
[ https://git-wip-us.apache.org/repos/asf?p=sqoop.git;h=0bb039a ]
SQOOP-3135: Improve error message of Sqoop in case of missing password
by adding the related ParseException stack trace
(Eric Lin via Attila Szabo)
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.2.patch, SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868912#comment-15868912
]
Eric Lin commented on SQOOP-3135:
-
Review requested: https://reviews.apache.org/r/56737/
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SQOOP-3135) Not enough error message for debugging when parameters missing
[
https://issues.apache.org/jira/browse/SQOOP-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868904#comment-15868904
]
Eric Lin commented on SQOOP-3135:
-
Provided patch so that the same command will print out the following:
{code}
16/12/21 05:57:29 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
16/12/21 05:57:29 ERROR tool.JobTool: Error parsing arguments to the
job-specific tool: org.apache.commons.cli.MissingArgumentException: Missing
argument for option: password
16/12/21 05:57:29 ERROR tool.JobTool: See 'sqoop help ' for usage.
{code}
which tells us exactly that password option was missing.
> Not enough error message for debugging when parameters missing
> --
>
> Key: SQOOP-3135
> URL: https://issues.apache.org/jira/browse/SQOOP-3135
> Project: Sqoop
> Issue Type: Improvement
>Affects Versions: 1.4.6
>Reporter: Eric Lin
>Assignee: Eric Lin
> Attachments: SQOOP-3135.patch
>
>
> Run the following sqoop command:
> {code}
> sqoop job --create test -- import --connect jdbc:mysql://localhost/test
> --username root --password $pass --target-dir /tmp/test10 -m 1 --driver
> com.mysql.jdbc.Driver --table test
> {code}
> Due to $pass is not set, command will fail with the following error:
> {code}
> 16/12/21 05:48:32 INFO sqoop.Sqoop: Running Sqoop version: 1.4.7-SNAPSHOT
> 16/12/21 05:48:33 ERROR tool.JobTool: Error parsing arguments to the
> job-specific tool.
> 16/12/21 05:48:33 ERROR tool.JobTool: See 'sqoop help ' for usage.
> {code}
> This is not informative, by checking the code in JobTool class:
> {code}
> // Now feed the arguments into the tool itself.
> try {
> childOptions = childTool.parseArguments(parseableChildArgv,
> null, childOptions, false);
> childTool.appendArgs(extraChildArgv);
> childTool.validateOptions(childOptions);
> } catch (ParseException pe) {
> LOG.error("Error parsing arguments to the job-specific tool.");
> LOG.error("See 'sqoop help ' for usage.");
> return 1;
> } catch (SqoopOptions.InvalidOptionsException e) {
> System.err.println(e.getMessage());
> return 1;
> }
> {code}
> The ParseException pe's message has been dropped, we should print out the
> message in the exception so that more meaningful message will be printed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
