Re: Review Request 41452: SQOOP-2747 Allow customizing test username and password for Oracle tests

2015-12-16 Thread Venkat Ranganathan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41452/#review110894
---

Ship it!


Ship It!

- Venkat Ranganathan


On Dec. 16, 2015, 9:09 a.m., Jarek Cecho wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41452/
> ---
> 
> (Updated Dec. 16, 2015, 9:09 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2747
> https://issues.apache.org/jira/browse/SQOOP-2747
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> ---
> 
> Added new properties to override credentials as suggested on JIRA.
> 
> 
> Diffs
> -
> 
>   build.xml 148cc6d 
>   src/test/com/cloudera/sqoop/manager/OracleUtils.java d9e31b8 
> 
> Diff: https://reviews.apache.org/r/41452/diff/
> 
> 
> Testing
> ---
> 
> I've tried them while investigating SQOOP-2745.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>



Review Request 41452: SQOOP-2747 Allow customizing test username and password for Oracle tests

2015-12-16 Thread Jarek Cecho

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41452/
---

Review request for Sqoop.


Bugs: SQOOP-2747
https://issues.apache.org/jira/browse/SQOOP-2747


Repository: sqoop-trunk


Description
---

Added new properties to override credentials as suggested on JIRA.


Diffs
-

  build.xml 148cc6d 
  src/test/com/cloudera/sqoop/manager/OracleUtils.java d9e31b8 

Diff: https://reviews.apache.org/r/41452/diff/


Testing
---

I've tried them while investigating SQOOP-2745.


Thanks,

Jarek Cecho